kevin/linux
1
Fork 0
Code

spmi: rename spmi device lookup helper

Browse Source 
Rename the SPMI device helper which is used to lookup a device from its
OF node as spmi_find_device_by_of_node() so that it reflects the
implementation and matches how other helpers like this are named.

This will specifically make it more clear that this is a lookup function
which returns a reference counted structure.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Acked-by: Stephen Boyd <sboyd@kernel.org>
Link: https://lore.kernel.org/r/20231003152927.15000-6-johan+linaro@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Johan Hovold 2023-10-03 17:29:27 +02:00 committed by Lee Jones
parent ade7941a47
commit 272f99edab
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/mfd/qcom-spmi-pmic.c
View File

@ -116,7 +116,7 @@ static struct spmi_device *qcom_pmic_get_base_usid(struct spmi_device *sdev, str
} }
if (pmic_addr == function_parent_usid - (ctx->num_usids - 1)) { if (pmic_addr == function_parent_usid - (ctx->num_usids - 1)) {
sdev = spmi_device_from_of(child); sdev = spmi_find_device_by_of_node(child);
if (!sdev) { if (!sdev) {
/* /*
* If the base USID for this PMIC hasn't been * If the base USID for this PMIC hasn't been

6
drivers/spmi/spmi.c
View File

@ -388,7 +388,7 @@ static struct bus_type spmi_bus_type = {
}; };
/** /**
* spmi_device_from_of() - get the associated SPMI device from a device node * spmi_find_device_by_of_node() - look up an SPMI device from a device node
* *
* @np: device node * @np: device node
* *
@ -397,7 +397,7 @@ static struct bus_type spmi_bus_type = {
* *
* Returns the struct spmi_device associated with a device node or NULL. * Returns the struct spmi_device associated with a device node or NULL.
*/ */
struct spmi_device *spmi_device_from_of(struct device_node *np) struct spmi_device *spmi_find_device_by_of_node(struct device_node *np)
{ {
struct device *dev = bus_find_device_by_of_node(&spmi_bus_type, np); struct device *dev = bus_find_device_by_of_node(&spmi_bus_type, np);
@ -405,7 +405,7 @@ struct spmi_device *spmi_device_from_of(struct device_node *np)
return to_spmi_device(dev); return to_spmi_device(dev);
return NULL; return NULL;
} }
EXPORT_SYMBOL_GPL(spmi_device_from_of); EXPORT_SYMBOL_GPL(spmi_find_device_by_of_node);
/** /**
* spmi_device_alloc() - Allocate a new SPMI device * spmi_device_alloc() - Allocate a new SPMI device

2
include/linux/spmi.h
View File

@ -166,7 +166,7 @@ static inline void spmi_driver_unregister(struct spmi_driver *sdrv)
struct device_node; struct device_node;
struct spmi_device *spmi_device_from_of(struct device_node *np); struct spmi_device *spmi_find_device_by_of_node(struct device_node *np);
int spmi_register_read(struct spmi_device *sdev, u8 addr, u8 *buf); int spmi_register_read(struct spmi_device *sdev, u8 addr, u8 *buf);
int spmi_ext_register_read(struct spmi_device *sdev, u8 addr, u8 *buf, int spmi_ext_register_read(struct spmi_device *sdev, u8 addr, u8 *buf,
size_t len); size_t len);