kevin/linux
1
Fork 0
Code

befs: Convert befs_symlink_read_folio() to use folio_end_read()

Browse Source 
This is slightly more efficient than separate calls to
folio_mark_uptodate() and folio_unlock(), and it's easier to read.
Get rid of the call to folio_set_error() as nobody will check this flag.

Cc: Luis de Bethencourt <luisbg@kernel.org>
Cc: Salah Triki <salah.triki@gmail.com>
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Link: https://lore.kernel.org/r/20240530202110.2653630-2-willy@infradead.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Matthew Wilcox (Oracle) 2024-05-30 21:20:53 +01:00 committed by Christian Brauner
parent 1613e604df
commit 263cf57804
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
fs/befs/linuxvfs.c
View File

@ -475,6 +475,7 @@ static int befs_symlink_read_folio(struct file *unused, struct folio *folio)
befs_data_stream *data = &befs_ino->i_data.ds; befs_data_stream *data = &befs_ino->i_data.ds;
befs_off_t len = data->size; befs_off_t len = data->size;
char *link = folio_address(folio); char *link = folio_address(folio);
int err = -EIO;
if (len == 0 || len > PAGE_SIZE) { if (len == 0 || len > PAGE_SIZE) {
befs_error(sb, "Long symlink with illegal length"); befs_error(sb, "Long symlink with illegal length");
@ -487,13 +488,10 @@ static int befs_symlink_read_folio(struct file *unused, struct folio *folio)
goto fail; goto fail;
} }
link[len - 1] = '\0'; link[len - 1] = '\0';
folio_mark_uptodate(folio); err = 0;
folio_unlock(folio);
return 0;
fail: fail:
folio_set_error(folio); folio_end_read(folio, err == 0);
folio_unlock(folio); return err;
return -EIO;
} }
/* /*