kevin/linux
1
Fork 0
Code

9p: Use length of data written to the server in preference to error

Browse Source 
In v9fs_upload_to_server(), we pass the error to netfslib to terminate the
subreq rather than the amount of data written - even if we did actually
write something.

Further, we assume that the write is always entirely done if successful -
but it might have been partially complete - as returned by
p9_client_write(), but we ignore that.

Fix this by indicating the amount written by preference and only returning
the error if we didn't write anything.

(We might want to return both in future if both are available as this
might be useful as to whether we retry or not.)

Suggested-by: Dominique Martinet <asmadeus@codewreck.org>
Link: https://lore.kernel.org/r/ZZULNQAZ0n0WQv7p@codewreck.org/
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Dominique Martinet <asmadeus@codewreck.org>
cc: Eric Van Hensbergen <ericvh@kernel.org>
cc: Latchesar Ionkov <lucho@ionkov.net>
cc: Christian Schoenebeck <linux_oss@crudebyte.com>
cc: v9fs@lists.linux.dev
cc: linux-cachefs@redhat.com
cc: linux-fsdevel@vger.kernel.org
This commit is contained in:
David Howells 2024-01-03 14:30:48 +00:00
parent 6c2c1e0009
commit 252cf7b2ea
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
fs/9p/vfs_addr.c
View File

@ -29,12 +29,11 @@
static void v9fs_upload_to_server(struct netfs_io_subrequest *subreq) static void v9fs_upload_to_server(struct netfs_io_subrequest *subreq)
{ {
struct p9_fid *fid = subreq->rreq->netfs_priv; struct p9_fid *fid = subreq->rreq->netfs_priv;
int err; int err, len;
trace_netfs_sreq(subreq, netfs_sreq_trace_submit); trace_netfs_sreq(subreq, netfs_sreq_trace_submit);
p9_client_write(fid, subreq->start, &subreq->io_iter, &err); len = p9_client_write(fid, subreq->start, &subreq->io_iter, &err);
netfs_write_subrequest_terminated(subreq, err < 0 ? err : subreq->len, netfs_write_subrequest_terminated(subreq, len ?: err, false);
false);
} }
static void v9fs_upload_to_server_worker(struct work_struct *work) static void v9fs_upload_to_server_worker(struct work_struct *work)