kevin/linux
1
Fork 0
Code

clk: imx: scu: Fix memory leak in __imx_clk_gpr_scu()

Browse Source 
In cases where imx_clk_is_resource_owned() returns false, the code path
does not handle the failure gracefully, potentially leading to a memory
leak. This fix ensures proper cleanup by freeing the allocated memory
for 'clk_node' before returning.

Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/all/20231210171907.3410922-1-visitorckw@gmail.com/
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
This commit is contained in:
Kuan-Wei Chiu 2023-12-11 01:19:07 +08:00 committed by Abel Vesa
parent 144f1b70ea
commit 21c0efbcb4
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/clk/imx/clk-scu.c
View File

@ -886,8 +886,10 @@ struct clk_hw *__imx_clk_gpr_scu(const char *name, const char * const *parent_na
return ERR_PTR(-EINVAL); return ERR_PTR(-EINVAL);
} }
if (!imx_clk_is_resource_owned(rsrc_id)) if (!imx_clk_is_resource_owned(rsrc_id)) {
kfree(clk_node);
return NULL; return NULL;
}
clk = kzalloc(sizeof(*clk), GFP_KERNEL); clk = kzalloc(sizeof(*clk), GFP_KERNEL);
if (!clk) { if (!clk) {