kevin/linux
1
Fork 0
Code

hwmon: (nct7802): Simplify with scoped for each OF child loop

Browse Source 
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Message-ID: <20240822062956.3490387-6-ruanjinjie@huawei.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Jinjie Ruan 2024-08-22 14:29:53 +08:00 committed by Guenter Roeck
parent bf0b61f0aa
commit 1d20db6b54
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
drivers/hwmon/nct7802.c
View File

@ -1129,19 +1129,16 @@ static int nct7802_configure_channels(struct device *dev,
{ {
/* Enable local temperature sensor by default */ /* Enable local temperature sensor by default */
u8 mode_mask = MODE_LTD_EN, mode_val = MODE_LTD_EN; u8 mode_mask = MODE_LTD_EN, mode_val = MODE_LTD_EN;
struct device_node *node;
int err; int err;
if (dev->of_node) { if (dev->of_node) {
for_each_child_of_node(dev->of_node, node) { for_each_child_of_node_scoped(dev->of_node, node) {
err = nct7802_get_channel_config(dev, node, &mode_mask, err = nct7802_get_channel_config(dev, node, &mode_mask,
&mode_val); &mode_val);
if (err) { if (err)
of_node_put(node);
return err; return err;
} }
} }
}
return regmap_update_bits(data->regmap, REG_MODE, mode_mask, mode_val); return regmap_update_bits(data->regmap, REG_MODE, mode_mask, mode_val);
} }