kevin/linux
1
Fork 0
Code

bcachefs: Fix incorrect error handling found_btree_node_is_readable()

Browse Source 
error handling here is slightly odd, which is why we were accidently
calling evict() on an error pointer

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
This commit is contained in:
Kent Overstreet 2024-06-05 21:16:29 -04:00
parent 161f73c2c7
commit 1c8cc24eef
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
fs/bcachefs/btree_node_scan.c
View File

@ -72,10 +72,11 @@ static bool found_btree_node_is_readable(struct btree_trans *trans,
struct btree *b = bch2_btree_node_get_noiter(trans, &k.k, f->btree_id, f->level, false);
bool ret = !IS_ERR_OR_NULL(b);
if (ret) {
f->sectors_written = b->written;
six_unlock_read(&b->c.lock);
}
if (!ret)
return ret;
f->sectors_written = b->written;
six_unlock_read(&b->c.lock);
/*
* We might update this node's range; if that happens, we need the node