kevin/linux
1
Fork 0
Code

cpuidle: dt_idle_genpd: Simplify with scoped for each OF child loop

Browse Source 
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240816150931.142208-4-krzysztof.kozlowski@linaro.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
This commit is contained in:
Krzysztof Kozlowski 2024-08-16 17:09:31 +02:00 committed by Ulf Hansson
parent 7aa1204d08
commit 157519c026
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/cpuidle/dt_idle_genpd.c
View File

@ -130,11 +130,10 @@ out:
int dt_idle_pd_init_topology(struct device_node *np) int dt_idle_pd_init_topology(struct device_node *np)
{ {
struct device_node *node;
struct of_phandle_args child, parent; struct of_phandle_args child, parent;
int ret; int ret;
for_each_child_of_node(np, node) { for_each_child_of_node_scoped(np, node) {
if (of_parse_phandle_with_args(node, "power-domains", if (of_parse_phandle_with_args(node, "power-domains",
"#power-domain-cells", 0, &parent)) "#power-domain-cells", 0, &parent))
continue; continue;
@ -143,10 +142,8 @@ int dt_idle_pd_init_topology(struct device_node *np)
child.args_count = 0; child.args_count = 0;
ret = of_genpd_add_subdomain(&parent, &child); ret = of_genpd_add_subdomain(&parent, &child);
of_node_put(parent.np); of_node_put(parent.np);
if (ret) { if (ret)
of_node_put(node);
return ret; return ret;
}
} }
return 0; return 0;
@ -154,11 +151,10 @@ int dt_idle_pd_init_topology(struct device_node *np)
int dt_idle_pd_remove_topology(struct device_node *np) int dt_idle_pd_remove_topology(struct device_node *np)
{ {
struct device_node *node;
struct of_phandle_args child, parent; struct of_phandle_args child, parent;
int ret; int ret;
for_each_child_of_node(np, node) { for_each_child_of_node_scoped(np, node) {
if (of_parse_phandle_with_args(node, "power-domains", if (of_parse_phandle_with_args(node, "power-domains",
"#power-domain-cells", 0, &parent)) "#power-domain-cells", 0, &parent))
continue; continue;
@ -167,10 +163,8 @@ int dt_idle_pd_remove_topology(struct device_node *np)
child.args_count = 0; child.args_count = 0;
ret = of_genpd_remove_subdomain(&parent, &child); ret = of_genpd_remove_subdomain(&parent, &child);
of_node_put(parent.np); of_node_put(parent.np);
if (ret) { if (ret)
of_node_put(node);
return ret; return ret;
}
} }
return 0; return 0;