kevin/linux
1
Fork 0
Code

phy: hisilicon: Fix an out of bounds check in hisi_inno_phy_probe()

Browse Source 
The size of array 'priv->ports[]' is INNO_PHY_PORT_NUM.

In the for loop, 'i' is used as the index for array 'priv->ports[]'
with a check (i > INNO_PHY_PORT_NUM) which indicates that
INNO_PHY_PORT_NUM is allowed value for 'i' in the same loop.

This > comparison needs to be changed to >=, otherwise it potentially leads
to an out of bounds write on the next iteration through the loop

Fixes: ba8b0ee81f ("phy: add inno-usb2-phy driver for hi3798cv200 SoC")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20230721090558.3588613-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Harshit Mogalapalli 2023-07-21 02:05:55 -07:00 committed by Vinod Koul
parent 8932089b56
commit 13c088cf36
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/phy/hisilicon/phy-hisi-inno-usb2.c
View File

@ -184,7 +184,7 @@ static int hisi_inno_phy_probe(struct platform_device *pdev)
phy_set_drvdata(phy, &priv->ports[i]); phy_set_drvdata(phy, &priv->ports[i]);
i++; i++;
if (i > INNO_PHY_PORT_NUM) { if (i >= INNO_PHY_PORT_NUM) {
dev_warn(dev, "Support %d ports in maximum\n", i); dev_warn(dev, "Support %d ports in maximum\n", i);
of_node_put(child); of_node_put(child);
break; break;