kevin/linux
1
Fork 0
Code

Input: colibri-vf50-ts - make use of the helper function dev_err_probe()

Browse Source 
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210916153148.14045-1-caihuoqing@baidu.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
This commit is contained in:
Cai Huoqing 2021-09-16 23:31:48 +08:00 committed by Dmitry Torokhov
parent ed7687c75f
commit 105a0c76fd
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/input/touchscreen/colibri-vf50-ts.c
View File

@ -239,14 +239,10 @@ static void vf50_ts_close(struct input_dev *dev_input)
static int vf50_ts_get_gpiod(struct device *dev, struct gpio_desc **gpio_d, static int vf50_ts_get_gpiod(struct device *dev, struct gpio_desc **gpio_d,
const char *con_id, enum gpiod_flags flags) const char *con_id, enum gpiod_flags flags)
{ {
int error;
*gpio_d = devm_gpiod_get(dev, con_id, flags); *gpio_d = devm_gpiod_get(dev, con_id, flags);
if (IS_ERR(*gpio_d)) { if (IS_ERR(*gpio_d))
error = PTR_ERR(*gpio_d); return dev_err_probe(dev, PTR_ERR(*gpio_d),
dev_err(dev, "Could not get gpio_%s %d\n", con_id, error); "Could not get gpio_%s\n", con_id);
return error;
}
return 0; return 0;
} }