kevin/linux
1
Fork 0
Code

hostfs: Add const qualifier to host_root in hostfs_fill_super()

Browse Source 
After the recent conversion to the new mount API, there is a warning
when building hostfs (which may be upgraded to an error via
CONFIG_WERROR=y):

  fs/hostfs/hostfs_kern.c: In function 'hostfs_fill_super':
  fs/hostfs/hostfs_kern.c:942:27: warning: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
    942 |         char *host_root = fc->source;
        |                           ^~

Add the 'const' qualifier, as host_root will not be modified after its
assignment. Move the assignment to keep the existing reverse Christmas
tree order intact.

Fixes: cd140ce9f6 ("hostfs: convert hostfs to use the new mount API")
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Link: https://lore.kernel.org/r/20240611-hostfs-fix-mount-api-conversion-v1-1-ef75bbc77f44@kernel.org
Acked-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Christian Brauner <brauner@kernel.org>
This commit is contained in:
Nathan Chancellor 2024-06-11 12:58:41 -07:00 committed by Christian Brauner
parent cd140ce9f6
commit 104eef133f
No known key found for this signature in database
GPG Key ID: 91C61BC06578DCA2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/hostfs/hostfs_kern.c
View File

@ -938,8 +938,8 @@ static const struct inode_operations hostfs_link_iops = {
static int hostfs_fill_super(struct super_block *sb, struct fs_context *fc) static int hostfs_fill_super(struct super_block *sb, struct fs_context *fc)
{ {
struct hostfs_fs_info *fsi = sb->s_fs_info; struct hostfs_fs_info *fsi = sb->s_fs_info;
const char *host_root = fc->source;
struct inode *root_inode; struct inode *root_inode;
char *host_root = fc->source;
int err; int err;
sb->s_blocksize = 1024; sb->s_blocksize = 1024;