kevin/linux
1
Fork 0
Code

media: Use of_property_present() for testing DT property presence

Browse Source 
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
This commit is contained in:
Rob Herring 2023-03-10 08:47:11 -06:00 committed by Hans Verkuil
parent 567f97bd38
commit 0f4afd5292
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/platform/mediatek/jpeg/mtk_jpeg_core.c
View File

@ -1782,7 +1782,7 @@ static int mtk_jpeg_probe(struct platform_device *pdev)
jpeg->vdev->device_caps = V4L2_CAP_STREAMING |
V4L2_CAP_VIDEO_M2M_MPLANE;
if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL))
if (of_property_present(pdev->dev.of_node, "dma-ranges"))
dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34));
ret = video_register_device(jpeg->vdev, VFL_TYPE_VIDEO, -1);

2
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
View File

@ -321,7 +321,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
}
}
if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) {
if (of_property_present(pdev->dev.of_node, "dma-ranges")) {
ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34));
if (ret) {
mtk_v4l2_err("Failed to set mask");

2
drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
View File

@ -344,7 +344,7 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
goto err_event_workq;
}
if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL))
if (of_property_present(pdev->dev.of_node, "dma-ranges"))
dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34));
ret = video_register_device(vfd_enc, VFL_TYPE_VIDEO, -1);

2
drivers/media/platform/xilinx/xilinx-vtc.c
View File

@ -254,7 +254,7 @@ struct xvtc_device *xvtc_of_get(struct device_node *np)
struct xvtc_device *found = NULL;
struct xvtc_device *xvtc;
if (!of_find_property(np, "xlnx,vtc", NULL))
if (!of_property_present(np, "xlnx,vtc"))
return NULL;
xvtc_node = of_parse_phandle(np, "xlnx,vtc", 0);