kevin/linux
1
Fork 0
Code

net: rfkill: gpio: Do not load on Lenovo Yoga Tab 3 Pro YT3-X90

Browse Source 
The Lenovo Yoga Tab 3 Pro YT3-X90 has a non functional "BCM4752" ACPI
device, which uses GPIO resources which are actually necessary / used
for the sound (codec, speaker amplifier) on the Lenovo Yoga Tab 3 Pro.

If the rfkill-gpio driver loads before the sound drivers do the sound
drivers fail to load because the GPIOs are already claimed.

Add a DMI based deny list with the Lenovo Yoga Tab 3 Pro on there and
make rfkill_gpio_probe() exit with -ENODEV for devices on the DMI based
deny list.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patch.msgid.link/20240825131916.6388-1-hdegoede@redhat.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
This commit is contained in:
Hans de Goede 2024-08-25 15:19:16 +02:00 committed by Johannes Berg
parent ff5aabe7c2
commit 0f31a7effa
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
net/rfkill/rfkill-gpio.c
View File

@ -3,6 +3,7 @@
* Copyright (c) 2011, NVIDIA Corporation. * Copyright (c) 2011, NVIDIA Corporation.
*/ */
#include <linux/dmi.h>
#include <linux/init.h> #include <linux/init.h>
#include <linux/kernel.h> #include <linux/kernel.h>
#include <linux/module.h> #include <linux/module.h>
@ -72,6 +73,20 @@ static int rfkill_gpio_acpi_probe(struct device *dev,
return devm_acpi_dev_add_driver_gpios(dev, acpi_rfkill_default_gpios); return devm_acpi_dev_add_driver_gpios(dev, acpi_rfkill_default_gpios);
} }
/* List of DMI matches for devices on which rfkill-gpio should not load,
* to avoid firmware bugs.
*/
static const struct dmi_system_id rfkill_gpio_deny_table[] = {
{
/* Lenovo Yoga Tab 3 Pro YT3-X90, bogus "BCM4752" device in DSDT */
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Intel Corporation"),
DMI_MATCH(DMI_PRODUCT_VERSION, "Blade3-10A-001"),
},
},
{ }
};
static int rfkill_gpio_probe(struct platform_device *pdev) static int rfkill_gpio_probe(struct platform_device *pdev)
{ {
struct rfkill_gpio_data *rfkill; struct rfkill_gpio_data *rfkill;
@ -81,6 +96,9 @@ static int rfkill_gpio_probe(struct platform_device *pdev)
const char *type_name; const char *type_name;
int ret; int ret;
if (dmi_check_system(rfkill_gpio_deny_table))
return -ENODEV;
rfkill = devm_kzalloc(&pdev->dev, sizeof(*rfkill), GFP_KERNEL); rfkill = devm_kzalloc(&pdev->dev, sizeof(*rfkill), GFP_KERNEL);
if (!rfkill) if (!rfkill)
return -ENOMEM; return -ENOMEM;