kevin/linux
1
Fork 0
Code

mfd: max77620: Use for_each_child_of_node_scoped()

Browse Source 
Avoids the need for manual cleanup of_node_put() in early exits
from the loop.

Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/r/20240826092734.2899562-2-ruanjinjie@huawei.com
Signed-off-by: Lee Jones <lee@kernel.org>
This commit is contained in:
Jinjie Ruan 2024-08-26 17:27:33 +08:00 committed by Lee Jones
parent ae7eee56cd
commit 0db28e963a
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/mfd/max77620.c
View File

@ -400,7 +400,7 @@ static int max77620_config_fps(struct max77620_chip *chip,
static int max77620_initialise_fps(struct max77620_chip *chip) static int max77620_initialise_fps(struct max77620_chip *chip)
{ {
struct device *dev = chip->dev; struct device *dev = chip->dev;
struct device_node *fps_np, *fps_child; struct device_node *fps_np;
u8 config; u8 config;
int fps_id; int fps_id;
int ret; int ret;
@ -414,10 +414,9 @@ static int max77620_initialise_fps(struct max77620_chip *chip)
if (!fps_np) if (!fps_np)
goto skip_fps; goto skip_fps;
for_each_child_of_node(fps_np, fps_child) { for_each_child_of_node_scoped(fps_np, fps_child) {
ret = max77620_config_fps(chip, fps_child); ret = max77620_config_fps(chip, fps_child);
if (ret < 0) { if (ret < 0) {
of_node_put(fps_child);
of_node_put(fps_np); of_node_put(fps_np);
return ret; return ret;
} }