kevin/linux
1
Fork 0
Code

fs/super.c: improve get_tree() error message

Browse Source 
seeing an odd bug where we fail to correctly return an error from
.get_tree():

https://syzkaller.appspot.com/bug?extid=c0360e8367d6d8d04a66

we need to be able to distinguish between accidently returning a
positive error (as implied by the log) and no error.

Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
This commit is contained in:
Kent Overstreet 2024-08-21 22:06:44 -04:00
parent bdbdd4759f
commit 06f67437ab
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fs/super.c
View File

@ -1802,8 +1802,8 @@ int vfs_get_tree(struct fs_context *fc)
return error; return error;
if (!fc->root) { if (!fc->root) {
pr_err("Filesystem %s get_tree() didn't set fc->root\n", pr_err("Filesystem %s get_tree() didn't set fc->root, returned %i\n",
fc->fs_type->name); fc->fs_type->name, error);
/* We don't know what the locking state of the superblock is - /* We don't know what the locking state of the superblock is -
* if there is a superblock. * if there is a superblock.
*/ */