kevin/linux
1
Fork 0
Code

s390/iucv: Fix vargs handling in iucv_alloc_device()

Browse Source 
iucv_alloc_device() gets a format string and a varying number of
arguments. This is incorrectly forwarded by calling dev_set_name() with
the format string and a va_list, while dev_set_name() expects also a
varying number of arguments.

Symptoms:
Corrupted iucv device names, which can result in log messages like:
sysfs: cannot create duplicate filename '/devices/iucv/hvc_iucv1827699952'

Fixes: 4452e8ef8c ("s390/iucv: Provide iucv_alloc_device() / iucv_release_device()")
Link: https://bugzilla.suse.com/show_bug.cgi?id=1228425
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Reviewed-by: Thorsten Winkler <twinkler@linux.ibm.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Link: https://patch.msgid.link/20240821091337.3627068-1-wintera@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Alexandra Winter 2024-08-21 11:13:37 +02:00 committed by Jakub Kicinski
parent 57fb67783c
commit 0124fb0ebf
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/iucv/iucv.c
View File

@ -86,13 +86,15 @@ struct device *iucv_alloc_device(const struct attribute_group **attrs,
{ {
struct device *dev; struct device *dev;
va_list vargs; va_list vargs;
char buf[20];
int rc; int rc;
dev = kzalloc(sizeof(*dev), GFP_KERNEL); dev = kzalloc(sizeof(*dev), GFP_KERNEL);
if (!dev) if (!dev)
goto out_error; goto out_error;
va_start(vargs, fmt); va_start(vargs, fmt);
rc = dev_set_name(dev, fmt, vargs); vsnprintf(buf, sizeof(buf), fmt, vargs);
rc = dev_set_name(dev, "%s", buf);
va_end(vargs); va_end(vargs);
if (rc) if (rc)
goto out_error; goto out_error;