2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* INET An implementation of the TCP/IP protocol suite for the LINUX
|
|
|
|
* operating system. INET is implemented using the BSD Socket
|
|
|
|
* interface as the means of communication with the user level.
|
|
|
|
*
|
|
|
|
* Implementation of the Transmission Control Protocol(TCP).
|
|
|
|
*
|
2005-05-05 16:16:16 -07:00
|
|
|
* Authors: Ross Biro
|
2005-04-16 15:20:36 -07:00
|
|
|
* Fred N. van Kempen, <waltje@uWalt.NL.Mugnet.ORG>
|
|
|
|
* Mark Evans, <evansmp@uhura.aston.ac.uk>
|
|
|
|
* Corey Minyard <wf-rch!minyard@relay.EU.net>
|
|
|
|
* Florian La Roche, <flla@stud.uni-sb.de>
|
|
|
|
* Charles Hedrick, <hedrick@klinzhai.rutgers.edu>
|
|
|
|
* Linus Torvalds, <torvalds@cs.helsinki.fi>
|
|
|
|
* Alan Cox, <gw4pts@gw4pts.ampr.org>
|
|
|
|
* Matthew Dillon, <dillon@apollo.west.oic.com>
|
|
|
|
* Arnt Gulbrandsen, <agulbra@nvg.unit.no>
|
|
|
|
* Jorge Cwik, <jorge@laser.satlink.net>
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/mm.h>
|
|
|
|
#include <linux/module.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 01:04:11 -07:00
|
|
|
#include <linux/slab.h>
|
2005-04-16 15:20:36 -07:00
|
|
|
#include <linux/sysctl.h>
|
|
|
|
#include <linux/workqueue.h>
|
|
|
|
#include <net/tcp.h>
|
|
|
|
#include <net/inet_common.h>
|
|
|
|
#include <net/xfrm.h>
|
|
|
|
|
2009-11-21 12:22:25 -07:00
|
|
|
int sysctl_tcp_syncookies __read_mostly = 1;
|
2008-02-07 22:49:26 -07:00
|
|
|
EXPORT_SYMBOL(sysctl_tcp_syncookies);
|
|
|
|
|
2006-09-22 14:15:41 -07:00
|
|
|
int sysctl_tcp_abort_on_overflow __read_mostly;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2005-08-09 20:44:40 -07:00
|
|
|
struct inet_timewait_death_row tcp_death_row = {
|
|
|
|
.sysctl_max_tw_buckets = NR_FILE * 2,
|
|
|
|
.period = TCP_TIMEWAIT_LEN / INET_TWDR_TWKILL_SLOTS,
|
2006-07-03 00:24:34 -07:00
|
|
|
.death_lock = __SPIN_LOCK_UNLOCKED(tcp_death_row.death_lock),
|
2005-08-09 20:44:40 -07:00
|
|
|
.hashinfo = &tcp_hashinfo,
|
|
|
|
.tw_timer = TIMER_INITIALIZER(inet_twdr_hangman, 0,
|
|
|
|
(unsigned long)&tcp_death_row),
|
|
|
|
.twkill_work = __WORK_INITIALIZER(tcp_death_row.twkill_work,
|
2006-11-22 07:55:48 -07:00
|
|
|
inet_twdr_twkill_work),
|
2005-08-09 20:44:40 -07:00
|
|
|
/* Short-time timewait calendar */
|
|
|
|
|
|
|
|
.twcal_hand = -1,
|
|
|
|
.twcal_timer = TIMER_INITIALIZER(inet_twdr_twcal_tick, 0,
|
|
|
|
(unsigned long)&tcp_death_row),
|
|
|
|
};
|
|
|
|
EXPORT_SYMBOL_GPL(tcp_death_row);
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
static __inline__ int tcp_in_window(u32 seq, u32 end_seq, u32 s_win, u32 e_win)
|
|
|
|
{
|
|
|
|
if (seq == s_win)
|
|
|
|
return 1;
|
|
|
|
if (after(end_seq, s_win) && before(seq, e_win))
|
|
|
|
return 1;
|
2010-09-22 13:43:57 -07:00
|
|
|
return seq == e_win && seq == end_seq;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2007-02-09 07:24:47 -07:00
|
|
|
/*
|
2005-04-16 15:20:36 -07:00
|
|
|
* * Main purpose of TIME-WAIT state is to close connection gracefully,
|
|
|
|
* when one of ends sits in LAST-ACK or CLOSING retransmitting FIN
|
|
|
|
* (and, probably, tail of data) and one or more our ACKs are lost.
|
|
|
|
* * What is TIME-WAIT timeout? It is associated with maximal packet
|
|
|
|
* lifetime in the internet, which results in wrong conclusion, that
|
|
|
|
* it is set to catch "old duplicate segments" wandering out of their path.
|
|
|
|
* It is not quite correct. This timeout is calculated so that it exceeds
|
|
|
|
* maximal retransmission timeout enough to allow to lose one (or more)
|
|
|
|
* segments sent by peer and our ACKs. This time may be calculated from RTO.
|
|
|
|
* * When TIME-WAIT socket receives RST, it means that another end
|
|
|
|
* finally closed and we are allowed to kill TIME-WAIT too.
|
|
|
|
* * Second purpose of TIME-WAIT is catching old duplicate segments.
|
|
|
|
* Well, certainly it is pure paranoia, but if we load TIME-WAIT
|
|
|
|
* with this semantics, we MUST NOT kill TIME-WAIT state with RSTs.
|
|
|
|
* * If we invented some more clever way to catch duplicates
|
|
|
|
* (f.e. based on PAWS), we could truncate TIME-WAIT to several RTOs.
|
|
|
|
*
|
|
|
|
* The algorithm below is based on FORMAL INTERPRETATION of RFCs.
|
|
|
|
* When you compare it to RFCs, please, read section SEGMENT ARRIVES
|
|
|
|
* from the very beginning.
|
|
|
|
*
|
|
|
|
* NOTE. With recycling (and later with fin-wait-2) TW bucket
|
|
|
|
* is _not_ stateless. It means, that strictly speaking we must
|
|
|
|
* spinlock it. I do not want! Well, probability of misbehaviour
|
|
|
|
* is ridiculously low and, seems, we could use some mb() tricks
|
|
|
|
* to avoid misread sequence numbers, states etc. --ANK
|
|
|
|
*/
|
|
|
|
enum tcp_tw_status
|
2005-08-09 20:09:30 -07:00
|
|
|
tcp_timewait_state_process(struct inet_timewait_sock *tw, struct sk_buff *skb,
|
|
|
|
const struct tcphdr *th)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct tcp_options_received tmp_opt;
|
2009-12-02 11:25:27 -07:00
|
|
|
u8 *hash_location;
|
|
|
|
struct tcp_timewait_sock *tcptw = tcp_twsk((struct sock *)tw);
|
2005-04-16 15:20:36 -07:00
|
|
|
int paws_reject = 0;
|
|
|
|
|
tcp: Revert per-route SACK/DSACK/TIMESTAMP changes.
It creates a regression, triggering badness for SYN_RECV
sockets, for example:
[19148.022102] Badness at net/ipv4/inet_connection_sock.c:293
[19148.022570] NIP: c02a0914 LR: c02a0904 CTR: 00000000
[19148.023035] REGS: eeecbd30 TRAP: 0700 Not tainted (2.6.32)
[19148.023496] MSR: 00029032 <EE,ME,CE,IR,DR> CR: 24002442 XER: 00000000
[19148.024012] TASK = eee9a820[1756] 'privoxy' THREAD: eeeca000
This is likely caused by the change in the 'estab' parameter
passed to tcp_parse_options() when invoked by the functions
in net/ipv4/tcp_minisocks.c
But even if that is fixed, the ->conn_request() changes made in
this patch series is fundamentally wrong. They try to use the
listening socket's 'dst' to probe the route settings. The
listening socket doesn't even have a route, and you can't
get the right route (the child request one) until much later
after we setup all of the state, and it must be done by hand.
This stuff really isn't ready, so the best thing to do is a
full revert. This reverts the following commits:
f55017a93f1a74d50244b1254b9a2bd7ac9bbf7d
022c3f7d82f0f1c68018696f2f027b87b9bb45c2
1aba721eba1d84a2defce45b950272cee1e6c72a
cda42ebd67ee5fdf09d7057b5a4584d36fe8a335
345cda2fd695534be5a4494f1b59da9daed33663
dc343475ed062e13fc260acccaab91d7d80fd5b2
05eaade2782fb0c90d3034fd7a7d5a16266182bb
6a2a2d6bf8581216e08be15fcb563cfd6c430e1e
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-15 21:56:42 -07:00
|
|
|
tmp_opt.saw_tstamp = 0;
|
2005-08-09 20:09:30 -07:00
|
|
|
if (th->doff > (sizeof(*th) >> 2) && tcptw->tw_ts_recent_stamp) {
|
tcp: Revert per-route SACK/DSACK/TIMESTAMP changes.
It creates a regression, triggering badness for SYN_RECV
sockets, for example:
[19148.022102] Badness at net/ipv4/inet_connection_sock.c:293
[19148.022570] NIP: c02a0914 LR: c02a0904 CTR: 00000000
[19148.023035] REGS: eeecbd30 TRAP: 0700 Not tainted (2.6.32)
[19148.023496] MSR: 00029032 <EE,ME,CE,IR,DR> CR: 24002442 XER: 00000000
[19148.024012] TASK = eee9a820[1756] 'privoxy' THREAD: eeeca000
This is likely caused by the change in the 'estab' parameter
passed to tcp_parse_options() when invoked by the functions
in net/ipv4/tcp_minisocks.c
But even if that is fixed, the ->conn_request() changes made in
this patch series is fundamentally wrong. They try to use the
listening socket's 'dst' to probe the route settings. The
listening socket doesn't even have a route, and you can't
get the right route (the child request one) until much later
after we setup all of the state, and it must be done by hand.
This stuff really isn't ready, so the best thing to do is a
full revert. This reverts the following commits:
f55017a93f1a74d50244b1254b9a2bd7ac9bbf7d
022c3f7d82f0f1c68018696f2f027b87b9bb45c2
1aba721eba1d84a2defce45b950272cee1e6c72a
cda42ebd67ee5fdf09d7057b5a4584d36fe8a335
345cda2fd695534be5a4494f1b59da9daed33663
dc343475ed062e13fc260acccaab91d7d80fd5b2
05eaade2782fb0c90d3034fd7a7d5a16266182bb
6a2a2d6bf8581216e08be15fcb563cfd6c430e1e
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-15 21:56:42 -07:00
|
|
|
tcp_parse_options(skb, &tmp_opt, &hash_location, 0);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
if (tmp_opt.saw_tstamp) {
|
2005-08-09 20:09:30 -07:00
|
|
|
tmp_opt.ts_recent = tcptw->tw_ts_recent;
|
|
|
|
tmp_opt.ts_recent_stamp = tcptw->tw_ts_recent_stamp;
|
2009-03-14 07:23:03 -07:00
|
|
|
paws_reject = tcp_paws_reject(&tmp_opt, th->rst);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (tw->tw_substate == TCP_FIN_WAIT2) {
|
|
|
|
/* Just repeat all the checks of tcp_rcv_state_process() */
|
|
|
|
|
|
|
|
/* Out of window, send ACK */
|
|
|
|
if (paws_reject ||
|
|
|
|
!tcp_in_window(TCP_SKB_CB(skb)->seq, TCP_SKB_CB(skb)->end_seq,
|
2005-08-09 20:09:30 -07:00
|
|
|
tcptw->tw_rcv_nxt,
|
|
|
|
tcptw->tw_rcv_nxt + tcptw->tw_rcv_wnd))
|
2005-04-16 15:20:36 -07:00
|
|
|
return TCP_TW_ACK;
|
|
|
|
|
|
|
|
if (th->rst)
|
|
|
|
goto kill;
|
|
|
|
|
2005-08-09 20:09:30 -07:00
|
|
|
if (th->syn && !before(TCP_SKB_CB(skb)->seq, tcptw->tw_rcv_nxt))
|
2005-04-16 15:20:36 -07:00
|
|
|
goto kill_with_rst;
|
|
|
|
|
|
|
|
/* Dup ACK? */
|
2009-06-24 15:29:31 -07:00
|
|
|
if (!th->ack ||
|
|
|
|
!after(TCP_SKB_CB(skb)->end_seq, tcptw->tw_rcv_nxt) ||
|
2005-04-16 15:20:36 -07:00
|
|
|
TCP_SKB_CB(skb)->end_seq == TCP_SKB_CB(skb)->seq) {
|
2005-08-09 20:09:30 -07:00
|
|
|
inet_twsk_put(tw);
|
2005-04-16 15:20:36 -07:00
|
|
|
return TCP_TW_SUCCESS;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* New data or FIN. If new data arrive after half-duplex close,
|
|
|
|
* reset.
|
|
|
|
*/
|
|
|
|
if (!th->fin ||
|
2005-08-09 20:09:30 -07:00
|
|
|
TCP_SKB_CB(skb)->end_seq != tcptw->tw_rcv_nxt + 1) {
|
2005-04-16 15:20:36 -07:00
|
|
|
kill_with_rst:
|
2005-08-09 20:44:40 -07:00
|
|
|
inet_twsk_deschedule(tw, &tcp_death_row);
|
2005-08-09 20:09:30 -07:00
|
|
|
inet_twsk_put(tw);
|
2005-04-16 15:20:36 -07:00
|
|
|
return TCP_TW_RST;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* FIN arrived, enter true time-wait state. */
|
2005-08-09 20:09:30 -07:00
|
|
|
tw->tw_substate = TCP_TIME_WAIT;
|
|
|
|
tcptw->tw_rcv_nxt = TCP_SKB_CB(skb)->end_seq;
|
2005-04-16 15:20:36 -07:00
|
|
|
if (tmp_opt.saw_tstamp) {
|
2007-03-04 17:12:44 -07:00
|
|
|
tcptw->tw_ts_recent_stamp = get_seconds();
|
2005-08-09 20:09:30 -07:00
|
|
|
tcptw->tw_ts_recent = tmp_opt.rcv_tsval;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/* I am shamed, but failed to make it more elegant.
|
|
|
|
* Yes, it is direct reference to IP, which is impossible
|
|
|
|
* to generalize to IPv6. Taking into account that IPv6
|
2005-11-10 18:13:47 -07:00
|
|
|
* do not understand recycling in any case, it not
|
2005-04-16 15:20:36 -07:00
|
|
|
* a big problem in practice. --ANK */
|
|
|
|
if (tw->tw_family == AF_INET &&
|
2005-08-09 20:44:40 -07:00
|
|
|
tcp_death_row.sysctl_tw_recycle && tcptw->tw_ts_recent_stamp &&
|
2005-04-16 15:20:36 -07:00
|
|
|
tcp_v4_tw_remember_stamp(tw))
|
2005-08-09 20:45:03 -07:00
|
|
|
inet_twsk_schedule(tw, &tcp_death_row, tw->tw_timeout,
|
|
|
|
TCP_TIMEWAIT_LEN);
|
2005-04-16 15:20:36 -07:00
|
|
|
else
|
2005-08-09 20:45:03 -07:00
|
|
|
inet_twsk_schedule(tw, &tcp_death_row, TCP_TIMEWAIT_LEN,
|
|
|
|
TCP_TIMEWAIT_LEN);
|
2005-04-16 15:20:36 -07:00
|
|
|
return TCP_TW_ACK;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Now real TIME-WAIT state.
|
|
|
|
*
|
|
|
|
* RFC 1122:
|
|
|
|
* "When a connection is [...] on TIME-WAIT state [...]
|
|
|
|
* [a TCP] MAY accept a new SYN from the remote TCP to
|
|
|
|
* reopen the connection directly, if it:
|
2007-02-09 07:24:47 -07:00
|
|
|
*
|
2005-04-16 15:20:36 -07:00
|
|
|
* (1) assigns its initial sequence number for the new
|
|
|
|
* connection to be larger than the largest sequence
|
|
|
|
* number it used on the previous connection incarnation,
|
|
|
|
* and
|
|
|
|
*
|
2007-02-09 07:24:47 -07:00
|
|
|
* (2) returns to TIME-WAIT state if the SYN turns out
|
2005-04-16 15:20:36 -07:00
|
|
|
* to be an old duplicate".
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (!paws_reject &&
|
2005-08-09 20:09:30 -07:00
|
|
|
(TCP_SKB_CB(skb)->seq == tcptw->tw_rcv_nxt &&
|
2005-04-16 15:20:36 -07:00
|
|
|
(TCP_SKB_CB(skb)->seq == TCP_SKB_CB(skb)->end_seq || th->rst))) {
|
|
|
|
/* In window segment, it may be only reset or bare ack. */
|
|
|
|
|
|
|
|
if (th->rst) {
|
2005-11-10 18:13:47 -07:00
|
|
|
/* This is TIME_WAIT assassination, in two flavors.
|
2005-04-16 15:20:36 -07:00
|
|
|
* Oh well... nobody has a sufficient solution to this
|
|
|
|
* protocol bug yet.
|
|
|
|
*/
|
|
|
|
if (sysctl_tcp_rfc1337 == 0) {
|
|
|
|
kill:
|
2005-08-09 20:44:40 -07:00
|
|
|
inet_twsk_deschedule(tw, &tcp_death_row);
|
2005-08-09 20:09:30 -07:00
|
|
|
inet_twsk_put(tw);
|
2005-04-16 15:20:36 -07:00
|
|
|
return TCP_TW_SUCCESS;
|
|
|
|
}
|
|
|
|
}
|
2005-08-09 20:45:03 -07:00
|
|
|
inet_twsk_schedule(tw, &tcp_death_row, TCP_TIMEWAIT_LEN,
|
|
|
|
TCP_TIMEWAIT_LEN);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
if (tmp_opt.saw_tstamp) {
|
2005-08-09 20:09:30 -07:00
|
|
|
tcptw->tw_ts_recent = tmp_opt.rcv_tsval;
|
2007-03-04 17:12:44 -07:00
|
|
|
tcptw->tw_ts_recent_stamp = get_seconds();
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2005-08-09 20:09:30 -07:00
|
|
|
inet_twsk_put(tw);
|
2005-04-16 15:20:36 -07:00
|
|
|
return TCP_TW_SUCCESS;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Out of window segment.
|
|
|
|
|
|
|
|
All the segments are ACKed immediately.
|
|
|
|
|
|
|
|
The only exception is new SYN. We accept it, if it is
|
|
|
|
not old duplicate and we are not in danger to be killed
|
|
|
|
by delayed old duplicates. RFC check is that it has
|
|
|
|
newer sequence number works at rates <40Mbit/sec.
|
|
|
|
However, if paws works, it is reliable AND even more,
|
|
|
|
we even may relax silly seq space cutoff.
|
|
|
|
|
|
|
|
RED-PEN: we violate main RFC requirement, if this SYN will appear
|
|
|
|
old duplicate (i.e. we receive RST in reply to SYN-ACK),
|
|
|
|
we must return socket to time-wait state. It is not good,
|
|
|
|
but not fatal yet.
|
|
|
|
*/
|
|
|
|
|
|
|
|
if (th->syn && !th->rst && !th->ack && !paws_reject &&
|
2005-08-09 20:09:30 -07:00
|
|
|
(after(TCP_SKB_CB(skb)->seq, tcptw->tw_rcv_nxt) ||
|
|
|
|
(tmp_opt.saw_tstamp &&
|
|
|
|
(s32)(tcptw->tw_ts_recent - tmp_opt.rcv_tsval) < 0))) {
|
|
|
|
u32 isn = tcptw->tw_snd_nxt + 65535 + 2;
|
2005-04-16 15:20:36 -07:00
|
|
|
if (isn == 0)
|
|
|
|
isn++;
|
|
|
|
TCP_SKB_CB(skb)->when = isn;
|
|
|
|
return TCP_TW_SYN;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (paws_reject)
|
2008-07-16 20:31:16 -07:00
|
|
|
NET_INC_STATS_BH(twsk_net(tw), LINUX_MIB_PAWSESTABREJECTED);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2007-03-08 21:45:19 -07:00
|
|
|
if (!th->rst) {
|
2005-04-16 15:20:36 -07:00
|
|
|
/* In this case we must reset the TIMEWAIT timer.
|
|
|
|
*
|
|
|
|
* If it is ACKless SYN it may be both old duplicate
|
|
|
|
* and new good SYN with random sequence number <rcv_nxt.
|
|
|
|
* Do not reschedule in the last case.
|
|
|
|
*/
|
|
|
|
if (paws_reject || th->ack)
|
2005-08-09 20:45:03 -07:00
|
|
|
inet_twsk_schedule(tw, &tcp_death_row, TCP_TIMEWAIT_LEN,
|
|
|
|
TCP_TIMEWAIT_LEN);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/* Send ACK. Note, we do not put the bucket,
|
|
|
|
* it will be released by caller.
|
|
|
|
*/
|
|
|
|
return TCP_TW_ACK;
|
|
|
|
}
|
2005-08-09 20:09:30 -07:00
|
|
|
inet_twsk_put(tw);
|
2005-04-16 15:20:36 -07:00
|
|
|
return TCP_TW_SUCCESS;
|
|
|
|
}
|
2010-07-09 14:22:10 -07:00
|
|
|
EXPORT_SYMBOL(tcp_timewait_state_process);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2007-02-09 07:24:47 -07:00
|
|
|
/*
|
2005-04-16 15:20:36 -07:00
|
|
|
* Move a socket to time-wait or dead fin-wait-2 state.
|
2007-02-09 07:24:47 -07:00
|
|
|
*/
|
2005-04-16 15:20:36 -07:00
|
|
|
void tcp_time_wait(struct sock *sk, int state, int timeo)
|
|
|
|
{
|
2005-08-09 20:09:30 -07:00
|
|
|
struct inet_timewait_sock *tw = NULL;
|
2005-12-14 00:15:52 -07:00
|
|
|
const struct inet_connection_sock *icsk = inet_csk(sk);
|
2005-08-09 20:09:30 -07:00
|
|
|
const struct tcp_sock *tp = tcp_sk(sk);
|
2005-04-16 15:20:36 -07:00
|
|
|
int recycle_ok = 0;
|
|
|
|
|
2005-08-09 20:44:40 -07:00
|
|
|
if (tcp_death_row.sysctl_tw_recycle && tp->rx_opt.ts_recent_stamp)
|
2005-12-14 00:15:52 -07:00
|
|
|
recycle_ok = icsk->icsk_af_ops->remember_stamp(sk);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2005-08-09 20:44:40 -07:00
|
|
|
if (tcp_death_row.tw_count < tcp_death_row.sysctl_max_tw_buckets)
|
2005-08-09 20:09:59 -07:00
|
|
|
tw = inet_twsk_alloc(sk, state);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2005-08-09 20:09:30 -07:00
|
|
|
if (tw != NULL) {
|
|
|
|
struct tcp_timewait_sock *tcptw = tcp_twsk((struct sock *)tw);
|
2005-08-09 20:10:42 -07:00
|
|
|
const int rto = (icsk->icsk_rto << 2) - (icsk->icsk_rto >> 1);
|
2005-08-09 20:09:30 -07:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
tw->tw_rcv_wscale = tp->rx_opt.rcv_wscale;
|
2005-08-09 20:09:30 -07:00
|
|
|
tcptw->tw_rcv_nxt = tp->rcv_nxt;
|
|
|
|
tcptw->tw_snd_nxt = tp->snd_nxt;
|
|
|
|
tcptw->tw_rcv_wnd = tcp_receive_window(tp);
|
|
|
|
tcptw->tw_ts_recent = tp->rx_opt.ts_recent;
|
|
|
|
tcptw->tw_ts_recent_stamp = tp->rx_opt.ts_recent_stamp;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
|
|
|
|
if (tw->tw_family == PF_INET6) {
|
|
|
|
struct ipv6_pinfo *np = inet6_sk(sk);
|
2005-12-14 00:23:09 -07:00
|
|
|
struct inet6_timewait_sock *tw6;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2005-12-14 00:23:09 -07:00
|
|
|
tw->tw_ipv6_offset = inet6_tw_offset(sk->sk_prot);
|
|
|
|
tw6 = inet6_twsk((struct sock *)tw);
|
|
|
|
ipv6_addr_copy(&tw6->tw_v6_daddr, &np->daddr);
|
|
|
|
ipv6_addr_copy(&tw6->tw_v6_rcv_saddr, &np->rcv_saddr);
|
2005-08-09 20:09:30 -07:00
|
|
|
tw->tw_ipv6only = np->ipv6only;
|
2005-08-09 20:09:59 -07:00
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
#endif
|
2006-11-14 20:07:45 -07:00
|
|
|
|
|
|
|
#ifdef CONFIG_TCP_MD5SIG
|
|
|
|
/*
|
|
|
|
* The timewait bucket does not have the key DB from the
|
|
|
|
* sock structure. We just make a quick copy of the
|
|
|
|
* md5 key being used (if indeed we are using one)
|
|
|
|
* so the timewait ack generating code has the key.
|
|
|
|
*/
|
|
|
|
do {
|
|
|
|
struct tcp_md5sig_key *key;
|
|
|
|
memset(tcptw->tw_md5_key, 0, sizeof(tcptw->tw_md5_key));
|
|
|
|
tcptw->tw_md5_keylen = 0;
|
|
|
|
key = tp->af_specific->md5_lookup(sk, sk);
|
|
|
|
if (key != NULL) {
|
|
|
|
memcpy(&tcptw->tw_md5_key, key->key, key->keylen);
|
|
|
|
tcptw->tw_md5_keylen = key->keylen;
|
2009-09-02 23:45:45 -07:00
|
|
|
if (tcp_alloc_md5sig_pool(sk) == NULL)
|
2006-11-14 20:07:45 -07:00
|
|
|
BUG();
|
|
|
|
}
|
2007-03-08 21:45:19 -07:00
|
|
|
} while (0);
|
2006-11-14 20:07:45 -07:00
|
|
|
#endif
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/* Linkage updates. */
|
2005-08-09 20:09:46 -07:00
|
|
|
__inet_twsk_hashdance(tw, sk, &tcp_hashinfo);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/* Get the TIME_WAIT timeout firing. */
|
|
|
|
if (timeo < rto)
|
|
|
|
timeo = rto;
|
|
|
|
|
|
|
|
if (recycle_ok) {
|
|
|
|
tw->tw_timeout = rto;
|
|
|
|
} else {
|
|
|
|
tw->tw_timeout = TCP_TIMEWAIT_LEN;
|
|
|
|
if (state == TCP_TIME_WAIT)
|
|
|
|
timeo = TCP_TIMEWAIT_LEN;
|
|
|
|
}
|
|
|
|
|
2005-08-09 20:45:03 -07:00
|
|
|
inet_twsk_schedule(tw, &tcp_death_row, timeo,
|
|
|
|
TCP_TIMEWAIT_LEN);
|
2005-08-09 20:09:30 -07:00
|
|
|
inet_twsk_put(tw);
|
2005-04-16 15:20:36 -07:00
|
|
|
} else {
|
|
|
|
/* Sorry, if we're out of memory, just CLOSE this
|
|
|
|
* socket up. We've got bigger problems than
|
|
|
|
* non-graceful socket closings.
|
|
|
|
*/
|
2006-11-17 06:25:49 -07:00
|
|
|
LIMIT_NETDEBUG(KERN_INFO "TCP: time wait bucket table overflow\n");
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
tcp_update_metrics(sk);
|
|
|
|
tcp_done(sk);
|
|
|
|
}
|
|
|
|
|
2006-11-14 20:07:45 -07:00
|
|
|
void tcp_twsk_destructor(struct sock *sk)
|
|
|
|
{
|
|
|
|
#ifdef CONFIG_TCP_MD5SIG
|
2006-11-14 20:53:22 -07:00
|
|
|
struct tcp_timewait_sock *twsk = tcp_twsk(sk);
|
2006-11-14 20:07:45 -07:00
|
|
|
if (twsk->tw_md5_keylen)
|
2009-09-15 23:49:21 -07:00
|
|
|
tcp_free_md5sig_pool();
|
2006-11-14 20:07:45 -07:00
|
|
|
#endif
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(tcp_twsk_destructor);
|
|
|
|
|
2007-05-27 02:04:16 -07:00
|
|
|
static inline void TCP_ECN_openreq_child(struct tcp_sock *tp,
|
|
|
|
struct request_sock *req)
|
|
|
|
{
|
|
|
|
tp->ecn_flags = inet_rsk(req)->ecn_ok ? TCP_ECN_OK : 0;
|
|
|
|
}
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/* This is not only more efficient than what we used to do, it eliminates
|
|
|
|
* a lot of code duplication between IPv4/IPv6 SYN recv processing. -DaveM
|
|
|
|
*
|
|
|
|
* Actually, we could lots of memory writes here. tp of listening
|
|
|
|
* socket contains all necessary default parameters.
|
|
|
|
*/
|
2005-06-18 22:47:21 -07:00
|
|
|
struct sock *tcp_create_openreq_child(struct sock *sk, struct request_sock *req, struct sk_buff *skb)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2005-08-09 20:11:24 -07:00
|
|
|
struct sock *newsk = inet_csk_clone(sk, req, GFP_ATOMIC);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2005-08-09 20:10:12 -07:00
|
|
|
if (newsk != NULL) {
|
2005-08-09 20:11:24 -07:00
|
|
|
const struct inet_request_sock *ireq = inet_rsk(req);
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-18 22:46:52 -07:00
|
|
|
struct tcp_request_sock *treq = tcp_rsk(req);
|
2007-02-28 12:05:56 -07:00
|
|
|
struct inet_connection_sock *newicsk = inet_csk(newsk);
|
TCPCT part 1d: define TCP cookie option, extend existing struct's
Data structures are carefully composed to require minimal additions.
For example, the struct tcp_options_received cookie_plus variable fits
between existing 16-bit and 8-bit variables, requiring no additional
space (taking alignment into consideration). There are no additions to
tcp_request_sock, and only 1 pointer in tcp_sock.
This is a significantly revised implementation of an earlier (year-old)
patch that no longer applies cleanly, with permission of the original
author (Adam Langley):
http://thread.gmane.org/gmane.linux.network/102586
The principle difference is using a TCP option to carry the cookie nonce,
instead of a user configured offset in the data. This is more flexible and
less subject to user configuration error. Such a cookie option has been
suggested for many years, and is also useful without SYN data, allowing
several related concepts to use the same extension option.
"Re: SYN floods (was: does history repeat itself?)", September 9, 1996.
http://www.merit.net/mail.archives/nanog/1996-09/msg00235.html
"Re: what a new TCP header might look like", May 12, 1998.
ftp://ftp.isi.edu/end2end/end2end-interest-1998.mail
These functions will also be used in subsequent patches that implement
additional features.
Requires:
TCPCT part 1a: add request_values parameter for sending SYNACK
TCPCT part 1b: generate Responder Cookie secret
TCPCT part 1c: sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS
Signed-off-by: William.Allen.Simpson@gmail.com
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-02 11:17:05 -07:00
|
|
|
struct tcp_sock *newtp = tcp_sk(newsk);
|
|
|
|
struct tcp_sock *oldtp = tcp_sk(sk);
|
|
|
|
struct tcp_cookie_values *oldcvp = oldtp->cookie_values;
|
|
|
|
|
|
|
|
/* TCP Cookie Transactions require space for the cookie pair,
|
|
|
|
* as it differs for each connection. There is no need to
|
|
|
|
* copy any s_data_payload stored at the original socket.
|
|
|
|
* Failure will prevent resuming the connection.
|
|
|
|
*
|
|
|
|
* Presumed copied, in order of appearance:
|
|
|
|
* cookie_in_always, cookie_out_never
|
|
|
|
*/
|
|
|
|
if (oldcvp != NULL) {
|
|
|
|
struct tcp_cookie_values *newcvp =
|
|
|
|
kzalloc(sizeof(*newtp->cookie_values),
|
|
|
|
GFP_ATOMIC);
|
|
|
|
|
|
|
|
if (newcvp != NULL) {
|
|
|
|
kref_init(&newcvp->kref);
|
|
|
|
newcvp->cookie_desired =
|
|
|
|
oldcvp->cookie_desired;
|
|
|
|
newtp->cookie_values = newcvp;
|
|
|
|
} else {
|
|
|
|
/* Not Yet Implemented */
|
|
|
|
newtp->cookie_values = NULL;
|
|
|
|
}
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/* Now setup tcp_sock */
|
|
|
|
newtp->pred_flags = 0;
|
TCPCT part 1d: define TCP cookie option, extend existing struct's
Data structures are carefully composed to require minimal additions.
For example, the struct tcp_options_received cookie_plus variable fits
between existing 16-bit and 8-bit variables, requiring no additional
space (taking alignment into consideration). There are no additions to
tcp_request_sock, and only 1 pointer in tcp_sock.
This is a significantly revised implementation of an earlier (year-old)
patch that no longer applies cleanly, with permission of the original
author (Adam Langley):
http://thread.gmane.org/gmane.linux.network/102586
The principle difference is using a TCP option to carry the cookie nonce,
instead of a user configured offset in the data. This is more flexible and
less subject to user configuration error. Such a cookie option has been
suggested for many years, and is also useful without SYN data, allowing
several related concepts to use the same extension option.
"Re: SYN floods (was: does history repeat itself?)", September 9, 1996.
http://www.merit.net/mail.archives/nanog/1996-09/msg00235.html
"Re: what a new TCP header might look like", May 12, 1998.
ftp://ftp.isi.edu/end2end/end2end-interest-1998.mail
These functions will also be used in subsequent patches that implement
additional features.
Requires:
TCPCT part 1a: add request_values parameter for sending SYNACK
TCPCT part 1b: generate Responder Cookie secret
TCPCT part 1c: sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS
Signed-off-by: William.Allen.Simpson@gmail.com
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-02 11:17:05 -07:00
|
|
|
|
|
|
|
newtp->rcv_wup = newtp->copied_seq =
|
|
|
|
newtp->rcv_nxt = treq->rcv_isn + 1;
|
|
|
|
|
|
|
|
newtp->snd_sml = newtp->snd_una =
|
|
|
|
newtp->snd_nxt = newtp->snd_up =
|
|
|
|
treq->snt_isn + 1 + tcp_s_data_size(oldtp);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
tcp_prequeue_init(newtp);
|
|
|
|
|
2009-03-02 23:42:02 -07:00
|
|
|
tcp_init_wl(newtp, treq->rcv_isn);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
newtp->srtt = 0;
|
|
|
|
newtp->mdev = TCP_TIMEOUT_INIT;
|
2005-08-09 20:10:42 -07:00
|
|
|
newicsk->icsk_rto = TCP_TIMEOUT_INIT;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
newtp->packets_out = 0;
|
|
|
|
newtp->retrans_out = 0;
|
|
|
|
newtp->sacked_out = 0;
|
|
|
|
newtp->fackets_out = 0;
|
2009-09-15 01:30:10 -07:00
|
|
|
newtp->snd_ssthresh = TCP_INFINITE_SSTHRESH;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/* So many TCP implementations out there (incorrectly) count the
|
|
|
|
* initial SYN frame in their delayed-ACK and congestion control
|
|
|
|
* algorithms that we must have the following bandaid to talk
|
|
|
|
* efficiently to them. -DaveM
|
|
|
|
*/
|
|
|
|
newtp->snd_cwnd = 2;
|
|
|
|
newtp->snd_cwnd_cnt = 0;
|
2005-11-10 18:09:53 -07:00
|
|
|
newtp->bytes_acked = 0;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
newtp->frto_counter = 0;
|
|
|
|
newtp->frto_highmark = 0;
|
|
|
|
|
2005-09-21 00:19:46 -07:00
|
|
|
newicsk->icsk_ca_ops = &tcp_init_congestion_ops;
|
2005-06-23 12:19:55 -07:00
|
|
|
|
2005-08-10 00:03:31 -07:00
|
|
|
tcp_set_ca_state(newsk, TCP_CA_Open);
|
2005-04-16 15:20:36 -07:00
|
|
|
tcp_init_xmit_timers(newsk);
|
|
|
|
skb_queue_head_init(&newtp->out_of_order_queue);
|
TCPCT part 1d: define TCP cookie option, extend existing struct's
Data structures are carefully composed to require minimal additions.
For example, the struct tcp_options_received cookie_plus variable fits
between existing 16-bit and 8-bit variables, requiring no additional
space (taking alignment into consideration). There are no additions to
tcp_request_sock, and only 1 pointer in tcp_sock.
This is a significantly revised implementation of an earlier (year-old)
patch that no longer applies cleanly, with permission of the original
author (Adam Langley):
http://thread.gmane.org/gmane.linux.network/102586
The principle difference is using a TCP option to carry the cookie nonce,
instead of a user configured offset in the data. This is more flexible and
less subject to user configuration error. Such a cookie option has been
suggested for many years, and is also useful without SYN data, allowing
several related concepts to use the same extension option.
"Re: SYN floods (was: does history repeat itself?)", September 9, 1996.
http://www.merit.net/mail.archives/nanog/1996-09/msg00235.html
"Re: what a new TCP header might look like", May 12, 1998.
ftp://ftp.isi.edu/end2end/end2end-interest-1998.mail
These functions will also be used in subsequent patches that implement
additional features.
Requires:
TCPCT part 1a: add request_values parameter for sending SYNACK
TCPCT part 1b: generate Responder Cookie secret
TCPCT part 1c: sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS
Signed-off-by: William.Allen.Simpson@gmail.com
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-02 11:17:05 -07:00
|
|
|
newtp->write_seq = newtp->pushed_seq =
|
|
|
|
treq->snt_isn + 1 + tcp_s_data_size(oldtp);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
newtp->rx_opt.saw_tstamp = 0;
|
|
|
|
|
|
|
|
newtp->rx_opt.dsack = 0;
|
|
|
|
newtp->rx_opt.num_sacks = 0;
|
2009-02-27 21:44:38 -07:00
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
newtp->urg_data = 0;
|
|
|
|
|
|
|
|
if (sock_flag(newsk, SOCK_KEEPOPEN))
|
2005-08-09 20:10:42 -07:00
|
|
|
inet_csk_reset_keepalive_timer(newsk,
|
|
|
|
keepalive_time_when(newtp));
|
2005-04-16 15:20:36 -07:00
|
|
|
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-18 22:46:52 -07:00
|
|
|
newtp->rx_opt.tstamp_ok = ireq->tstamp_ok;
|
2007-03-08 21:45:19 -07:00
|
|
|
if ((newtp->rx_opt.sack_ok = ireq->sack_ok) != 0) {
|
2005-04-16 15:20:36 -07:00
|
|
|
if (sysctl_tcp_fack)
|
2007-08-09 05:14:46 -07:00
|
|
|
tcp_enable_fack(newtp);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
newtp->window_clamp = req->window_clamp;
|
|
|
|
newtp->rcv_ssthresh = req->rcv_wnd;
|
|
|
|
newtp->rcv_wnd = req->rcv_wnd;
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-18 22:46:52 -07:00
|
|
|
newtp->rx_opt.wscale_ok = ireq->wscale_ok;
|
2005-04-16 15:20:36 -07:00
|
|
|
if (newtp->rx_opt.wscale_ok) {
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-18 22:46:52 -07:00
|
|
|
newtp->rx_opt.snd_wscale = ireq->snd_wscale;
|
|
|
|
newtp->rx_opt.rcv_wscale = ireq->rcv_wscale;
|
2005-04-16 15:20:36 -07:00
|
|
|
} else {
|
|
|
|
newtp->rx_opt.snd_wscale = newtp->rx_opt.rcv_wscale = 0;
|
|
|
|
newtp->window_clamp = min(newtp->window_clamp, 65535U);
|
|
|
|
}
|
2007-04-10 21:04:22 -07:00
|
|
|
newtp->snd_wnd = (ntohs(tcp_hdr(skb)->window) <<
|
|
|
|
newtp->rx_opt.snd_wscale);
|
2005-04-16 15:20:36 -07:00
|
|
|
newtp->max_window = newtp->snd_wnd;
|
|
|
|
|
|
|
|
if (newtp->rx_opt.tstamp_ok) {
|
|
|
|
newtp->rx_opt.ts_recent = req->ts_recent;
|
2007-03-04 17:12:44 -07:00
|
|
|
newtp->rx_opt.ts_recent_stamp = get_seconds();
|
2005-04-16 15:20:36 -07:00
|
|
|
newtp->tcp_header_len = sizeof(struct tcphdr) + TCPOLEN_TSTAMP_ALIGNED;
|
|
|
|
} else {
|
|
|
|
newtp->rx_opt.ts_recent_stamp = 0;
|
|
|
|
newtp->tcp_header_len = sizeof(struct tcphdr);
|
|
|
|
}
|
2006-11-14 20:07:45 -07:00
|
|
|
#ifdef CONFIG_TCP_MD5SIG
|
|
|
|
newtp->md5sig_info = NULL; /*XXX*/
|
|
|
|
if (newtp->af_specific->md5_lookup(sk, newsk))
|
|
|
|
newtp->tcp_header_len += TCPOLEN_MD5SIG_ALIGNED;
|
|
|
|
#endif
|
2009-11-10 02:51:18 -07:00
|
|
|
if (skb->len >= TCP_MSS_DEFAULT + newtp->tcp_header_len)
|
2005-08-09 20:10:42 -07:00
|
|
|
newicsk->icsk_ack.last_seg_size = skb->len - newtp->tcp_header_len;
|
2005-04-16 15:20:36 -07:00
|
|
|
newtp->rx_opt.mss_clamp = req->mss;
|
|
|
|
TCP_ECN_openreq_child(newtp, req);
|
|
|
|
|
2008-07-16 20:22:25 -07:00
|
|
|
TCP_INC_STATS_BH(sock_net(sk), TCP_MIB_PASSIVEOPENS);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
return newsk;
|
|
|
|
}
|
2010-07-09 14:22:10 -07:00
|
|
|
EXPORT_SYMBOL(tcp_create_openreq_child);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2007-02-09 07:24:47 -07:00
|
|
|
/*
|
2005-04-16 15:20:36 -07:00
|
|
|
* Process an incoming packet for SYN_RECV sockets represented
|
2005-06-18 22:47:21 -07:00
|
|
|
* as a request_sock.
|
2005-04-16 15:20:36 -07:00
|
|
|
*/
|
|
|
|
|
2008-11-03 01:24:34 -07:00
|
|
|
struct sock *tcp_check_req(struct sock *sk, struct sk_buff *skb,
|
2005-06-18 22:47:21 -07:00
|
|
|
struct request_sock *req,
|
|
|
|
struct request_sock **prev)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
2009-12-02 11:25:27 -07:00
|
|
|
struct tcp_options_received tmp_opt;
|
|
|
|
u8 *hash_location;
|
|
|
|
struct sock *child;
|
2007-04-10 21:04:22 -07:00
|
|
|
const struct tcphdr *th = tcp_hdr(skb);
|
2006-11-14 21:51:49 -07:00
|
|
|
__be32 flg = tcp_flag_word(th) & (TCP_FLAG_RST|TCP_FLAG_SYN|TCP_FLAG_ACK);
|
2005-04-16 15:20:36 -07:00
|
|
|
int paws_reject = 0;
|
|
|
|
|
tcp: Revert per-route SACK/DSACK/TIMESTAMP changes.
It creates a regression, triggering badness for SYN_RECV
sockets, for example:
[19148.022102] Badness at net/ipv4/inet_connection_sock.c:293
[19148.022570] NIP: c02a0914 LR: c02a0904 CTR: 00000000
[19148.023035] REGS: eeecbd30 TRAP: 0700 Not tainted (2.6.32)
[19148.023496] MSR: 00029032 <EE,ME,CE,IR,DR> CR: 24002442 XER: 00000000
[19148.024012] TASK = eee9a820[1756] 'privoxy' THREAD: eeeca000
This is likely caused by the change in the 'estab' parameter
passed to tcp_parse_options() when invoked by the functions
in net/ipv4/tcp_minisocks.c
But even if that is fixed, the ->conn_request() changes made in
this patch series is fundamentally wrong. They try to use the
listening socket's 'dst' to probe the route settings. The
listening socket doesn't even have a route, and you can't
get the right route (the child request one) until much later
after we setup all of the state, and it must be done by hand.
This stuff really isn't ready, so the best thing to do is a
full revert. This reverts the following commits:
f55017a93f1a74d50244b1254b9a2bd7ac9bbf7d
022c3f7d82f0f1c68018696f2f027b87b9bb45c2
1aba721eba1d84a2defce45b950272cee1e6c72a
cda42ebd67ee5fdf09d7057b5a4584d36fe8a335
345cda2fd695534be5a4494f1b59da9daed33663
dc343475ed062e13fc260acccaab91d7d80fd5b2
05eaade2782fb0c90d3034fd7a7d5a16266182bb
6a2a2d6bf8581216e08be15fcb563cfd6c430e1e
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-15 21:56:42 -07:00
|
|
|
tmp_opt.saw_tstamp = 0;
|
|
|
|
if (th->doff > (sizeof(struct tcphdr)>>2)) {
|
|
|
|
tcp_parse_options(skb, &tmp_opt, &hash_location, 0);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
if (tmp_opt.saw_tstamp) {
|
|
|
|
tmp_opt.ts_recent = req->ts_recent;
|
|
|
|
/* We do not store true stamp, but it is not required,
|
|
|
|
* it can be estimated (approximately)
|
|
|
|
* from another data.
|
|
|
|
*/
|
2007-03-04 17:12:44 -07:00
|
|
|
tmp_opt.ts_recent_stamp = get_seconds() - ((TCP_TIMEOUT_INIT/HZ)<<req->retrans);
|
2009-03-14 07:23:03 -07:00
|
|
|
paws_reject = tcp_paws_reject(&tmp_opt, th->rst);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Check for pure retransmitted SYN. */
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-18 22:46:52 -07:00
|
|
|
if (TCP_SKB_CB(skb)->seq == tcp_rsk(req)->rcv_isn &&
|
2005-04-16 15:20:36 -07:00
|
|
|
flg == TCP_FLAG_SYN &&
|
|
|
|
!paws_reject) {
|
|
|
|
/*
|
|
|
|
* RFC793 draws (Incorrectly! It was fixed in RFC1122)
|
|
|
|
* this case on figure 6 and figure 8, but formal
|
|
|
|
* protocol description says NOTHING.
|
|
|
|
* To be more exact, it says that we should send ACK,
|
|
|
|
* because this segment (at least, if it has no data)
|
|
|
|
* is out of window.
|
|
|
|
*
|
|
|
|
* CONCLUSION: RFC793 (even with RFC1122) DOES NOT
|
|
|
|
* describe SYN-RECV state. All the description
|
|
|
|
* is wrong, we cannot believe to it and should
|
|
|
|
* rely only on common sense and implementation
|
|
|
|
* experience.
|
|
|
|
*
|
|
|
|
* Enforce "SYN-ACK" according to figure 8, figure 6
|
|
|
|
* of RFC793, fixed by RFC1122.
|
|
|
|
*/
|
2009-12-02 11:07:39 -07:00
|
|
|
req->rsk_ops->rtx_syn_ack(sk, req, NULL);
|
2005-04-16 15:20:36 -07:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Further reproduces section "SEGMENT ARRIVES"
|
|
|
|
for state SYN-RECEIVED of RFC793.
|
|
|
|
It is broken, however, it does not work only
|
|
|
|
when SYNs are crossed.
|
|
|
|
|
|
|
|
You would think that SYN crossing is impossible here, since
|
|
|
|
we should have a SYN_SENT socket (from connect()) on our end,
|
|
|
|
but this is not true if the crossed SYNs were sent to both
|
|
|
|
ends by a malicious third party. We must defend against this,
|
|
|
|
and to do that we first verify the ACK (as per RFC793, page
|
|
|
|
36) and reset if it is invalid. Is this a true full defense?
|
|
|
|
To convince ourselves, let us consider a way in which the ACK
|
|
|
|
test can still pass in this 'malicious crossed SYNs' case.
|
|
|
|
Malicious sender sends identical SYNs (and thus identical sequence
|
|
|
|
numbers) to both A and B:
|
|
|
|
|
|
|
|
A: gets SYN, seq=7
|
|
|
|
B: gets SYN, seq=7
|
|
|
|
|
|
|
|
By our good fortune, both A and B select the same initial
|
|
|
|
send sequence number of seven :-)
|
|
|
|
|
|
|
|
A: sends SYN|ACK, seq=7, ack_seq=8
|
|
|
|
B: sends SYN|ACK, seq=7, ack_seq=8
|
|
|
|
|
|
|
|
So we are now A eating this SYN|ACK, ACK test passes. So
|
|
|
|
does sequence test, SYN is truncated, and thus we consider
|
|
|
|
it a bare ACK.
|
|
|
|
|
tcp: Revert 'process defer accept as established' changes.
This reverts two changesets, ec3c0982a2dd1e671bad8e9d26c28dcba0039d87
("[TCP]: TCP_DEFER_ACCEPT updates - process as established") and
the follow-on bug fix 9ae27e0adbf471c7a6b80102e38e1d5a346b3b38
("tcp: Fix slab corruption with ipv6 and tcp6fuzz").
This change causes several problems, first reported by Ingo Molnar
as a distcc-over-loopback regression where connections were getting
stuck.
Ilpo Järvinen first spotted the locking problems. The new function
added by this code, tcp_defer_accept_check(), only has the
child socket locked, yet it is modifying state of the parent
listening socket.
Fixing that is non-trivial at best, because we can't simply just grab
the parent listening socket lock at this point, because it would
create an ABBA deadlock. The normal ordering is parent listening
socket --> child socket, but this code path would require the
reverse lock ordering.
Next is a problem noticed by Vitaliy Gusev, he noted:
----------------------------------------
>--- a/net/ipv4/tcp_timer.c
>+++ b/net/ipv4/tcp_timer.c
>@@ -481,6 +481,11 @@ static void tcp_keepalive_timer (unsigned long data)
> goto death;
> }
>
>+ if (tp->defer_tcp_accept.request && sk->sk_state == TCP_ESTABLISHED) {
>+ tcp_send_active_reset(sk, GFP_ATOMIC);
>+ goto death;
Here socket sk is not attached to listening socket's request queue. tcp_done()
will not call inet_csk_destroy_sock() (and tcp_v4_destroy_sock() which should
release this sk) as socket is not DEAD. Therefore socket sk will be lost for
freeing.
----------------------------------------
Finally, Alexey Kuznetsov argues that there might not even be any
real value or advantage to these new semantics even if we fix all
of the bugs:
----------------------------------------
Hiding from accept() sockets with only out-of-order data only
is the only thing which is impossible with old approach. Is this really
so valuable? My opinion: no, this is nothing but a new loophole
to consume memory without control.
----------------------------------------
So revert this thing for now.
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-06-12 16:31:35 -07:00
|
|
|
If icsk->icsk_accept_queue.rskq_defer_accept, we silently drop this
|
|
|
|
bare ACK. Otherwise, we create an established connection. Both
|
|
|
|
ends (listening sockets) accept the new incoming connection and try
|
|
|
|
to talk to each other. 8-)
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
Note: This case is both harmless, and rare. Possibility is about the
|
|
|
|
same as us discovering intelligent life on another plant tomorrow.
|
|
|
|
|
|
|
|
But generally, we should (RFC lies!) to accept ACK
|
|
|
|
from SYNACK both here and in tcp_rcv_state_process().
|
|
|
|
tcp_rcv_state_process() does not, hence, we do not too.
|
|
|
|
|
|
|
|
Note that the case is absolutely generic:
|
|
|
|
we cannot optimize anything here without
|
|
|
|
violating protocol. All the checks must be made
|
|
|
|
before attempt to create socket.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* RFC793 page 36: "If the connection is in any non-synchronized state ...
|
|
|
|
* and the incoming segment acknowledges something not yet
|
2005-11-10 18:13:47 -07:00
|
|
|
* sent (the segment carries an unacceptable ACK) ...
|
2005-04-16 15:20:36 -07:00
|
|
|
* a reset is sent."
|
|
|
|
*
|
|
|
|
* Invalid ACK: reset will be sent by listening socket
|
|
|
|
*/
|
|
|
|
if ((flg & TCP_FLAG_ACK) &&
|
TCPCT part 1d: define TCP cookie option, extend existing struct's
Data structures are carefully composed to require minimal additions.
For example, the struct tcp_options_received cookie_plus variable fits
between existing 16-bit and 8-bit variables, requiring no additional
space (taking alignment into consideration). There are no additions to
tcp_request_sock, and only 1 pointer in tcp_sock.
This is a significantly revised implementation of an earlier (year-old)
patch that no longer applies cleanly, with permission of the original
author (Adam Langley):
http://thread.gmane.org/gmane.linux.network/102586
The principle difference is using a TCP option to carry the cookie nonce,
instead of a user configured offset in the data. This is more flexible and
less subject to user configuration error. Such a cookie option has been
suggested for many years, and is also useful without SYN data, allowing
several related concepts to use the same extension option.
"Re: SYN floods (was: does history repeat itself?)", September 9, 1996.
http://www.merit.net/mail.archives/nanog/1996-09/msg00235.html
"Re: what a new TCP header might look like", May 12, 1998.
ftp://ftp.isi.edu/end2end/end2end-interest-1998.mail
These functions will also be used in subsequent patches that implement
additional features.
Requires:
TCPCT part 1a: add request_values parameter for sending SYNACK
TCPCT part 1b: generate Responder Cookie secret
TCPCT part 1c: sysctl_tcp_cookie_size, socket option TCP_COOKIE_TRANSACTIONS
Signed-off-by: William.Allen.Simpson@gmail.com
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-12-02 11:17:05 -07:00
|
|
|
(TCP_SKB_CB(skb)->ack_seq !=
|
|
|
|
tcp_rsk(req)->snt_isn + 1 + tcp_s_data_size(tcp_sk(sk))))
|
2005-04-16 15:20:36 -07:00
|
|
|
return sk;
|
|
|
|
|
|
|
|
/* Also, it would be not so bad idea to check rcv_tsecr, which
|
|
|
|
* is essentially ACK extension and too early or too late values
|
|
|
|
* should cause reset in unsynchronized states.
|
|
|
|
*/
|
|
|
|
|
|
|
|
/* RFC793: "first check sequence number". */
|
|
|
|
|
|
|
|
if (paws_reject || !tcp_in_window(TCP_SKB_CB(skb)->seq, TCP_SKB_CB(skb)->end_seq,
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-18 22:46:52 -07:00
|
|
|
tcp_rsk(req)->rcv_isn + 1, tcp_rsk(req)->rcv_isn + 1 + req->rcv_wnd)) {
|
2005-04-16 15:20:36 -07:00
|
|
|
/* Out of window: send ACK and drop. */
|
|
|
|
if (!(flg & TCP_FLAG_RST))
|
2008-08-06 23:50:04 -07:00
|
|
|
req->rsk_ops->send_ack(sk, skb, req);
|
2005-04-16 15:20:36 -07:00
|
|
|
if (paws_reject)
|
2008-07-16 20:31:16 -07:00
|
|
|
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_PAWSESTABREJECTED);
|
2005-04-16 15:20:36 -07:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* In sequence, PAWS is OK. */
|
|
|
|
|
[NET] Generalise TCP's struct open_request minisock infrastructure
Kept this first changeset minimal, without changing existing names to
ease peer review.
Basicaly tcp_openreq_alloc now receives the or_calltable, that in turn
has two new members:
->slab, that replaces tcp_openreq_cachep
->obj_size, to inform the size of the openreq descendant for
a specific protocol
The protocol specific fields in struct open_request were moved to a
class hierarchy, with the things that are common to all connection
oriented PF_INET protocols in struct inet_request_sock, the TCP ones
in tcp_request_sock, that is an inet_request_sock, that is an
open_request.
I.e. this uses the same approach used for the struct sock class
hierarchy, with sk_prot indicating if the protocol wants to use the
open_request infrastructure by filling in sk_prot->rsk_prot with an
or_calltable.
Results? Performance is improved and TCP v4 now uses only 64 bytes per
open request minisock, down from 96 without this patch :-)
Next changeset will rename some of the structs, fields and functions
mentioned above, struct or_calltable is way unclear, better name it
struct request_sock_ops, s/struct open_request/struct request_sock/g,
etc.
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
2005-06-18 22:46:52 -07:00
|
|
|
if (tmp_opt.saw_tstamp && !after(TCP_SKB_CB(skb)->seq, tcp_rsk(req)->rcv_isn + 1))
|
2008-08-07 20:27:45 -07:00
|
|
|
req->ts_recent = tmp_opt.rcv_tsval;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2008-08-07 20:27:45 -07:00
|
|
|
if (TCP_SKB_CB(skb)->seq == tcp_rsk(req)->rcv_isn) {
|
|
|
|
/* Truncate SYN, it is out of window starting
|
|
|
|
at tcp_rsk(req)->rcv_isn + 1. */
|
|
|
|
flg &= ~TCP_FLAG_SYN;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2008-08-07 20:27:45 -07:00
|
|
|
/* RFC793: "second check the RST bit" and
|
|
|
|
* "fourth, check the SYN bit"
|
|
|
|
*/
|
|
|
|
if (flg & (TCP_FLAG_RST|TCP_FLAG_SYN)) {
|
|
|
|
TCP_INC_STATS_BH(sock_net(sk), TCP_MIB_ATTEMPTFAILS);
|
|
|
|
goto embryonic_reset;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2008-08-07 20:27:45 -07:00
|
|
|
/* ACK sequence verified above, just make sure ACK is
|
|
|
|
* set. If ACK not set, just silently drop the packet.
|
|
|
|
*/
|
|
|
|
if (!(flg & TCP_FLAG_ACK))
|
|
|
|
return NULL;
|
tcp: Revert 'process defer accept as established' changes.
This reverts two changesets, ec3c0982a2dd1e671bad8e9d26c28dcba0039d87
("[TCP]: TCP_DEFER_ACCEPT updates - process as established") and
the follow-on bug fix 9ae27e0adbf471c7a6b80102e38e1d5a346b3b38
("tcp: Fix slab corruption with ipv6 and tcp6fuzz").
This change causes several problems, first reported by Ingo Molnar
as a distcc-over-loopback regression where connections were getting
stuck.
Ilpo Järvinen first spotted the locking problems. The new function
added by this code, tcp_defer_accept_check(), only has the
child socket locked, yet it is modifying state of the parent
listening socket.
Fixing that is non-trivial at best, because we can't simply just grab
the parent listening socket lock at this point, because it would
create an ABBA deadlock. The normal ordering is parent listening
socket --> child socket, but this code path would require the
reverse lock ordering.
Next is a problem noticed by Vitaliy Gusev, he noted:
----------------------------------------
>--- a/net/ipv4/tcp_timer.c
>+++ b/net/ipv4/tcp_timer.c
>@@ -481,6 +481,11 @@ static void tcp_keepalive_timer (unsigned long data)
> goto death;
> }
>
>+ if (tp->defer_tcp_accept.request && sk->sk_state == TCP_ESTABLISHED) {
>+ tcp_send_active_reset(sk, GFP_ATOMIC);
>+ goto death;
Here socket sk is not attached to listening socket's request queue. tcp_done()
will not call inet_csk_destroy_sock() (and tcp_v4_destroy_sock() which should
release this sk) as socket is not DEAD. Therefore socket sk will be lost for
freeing.
----------------------------------------
Finally, Alexey Kuznetsov argues that there might not even be any
real value or advantage to these new semantics even if we fix all
of the bugs:
----------------------------------------
Hiding from accept() sockets with only out-of-order data only
is the only thing which is impossible with old approach. Is this really
so valuable? My opinion: no, this is nothing but a new loophole
to consume memory without control.
----------------------------------------
So revert this thing for now.
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-06-12 16:31:35 -07:00
|
|
|
|
2009-10-19 03:01:56 -07:00
|
|
|
/* While TCP_DEFER_ACCEPT is active, drop bare ACK. */
|
|
|
|
if (req->retrans < inet_csk(sk)->icsk_accept_queue.rskq_defer_accept &&
|
2008-08-07 20:27:45 -07:00
|
|
|
TCP_SKB_CB(skb)->end_seq == tcp_rsk(req)->rcv_isn + 1) {
|
|
|
|
inet_rsk(req)->acked = 1;
|
2010-03-18 22:37:18 -07:00
|
|
|
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_TCPDEFERACCEPTDROP);
|
2008-08-07 20:27:45 -07:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* OK, ACK is valid, create big socket and
|
|
|
|
* feed this segment to it. It will repeat all
|
|
|
|
* the tests. THIS SEGMENT MUST MOVE SOCKET TO
|
|
|
|
* ESTABLISHED STATE. If it will be dropped after
|
|
|
|
* socket is created, wait for troubles.
|
|
|
|
*/
|
|
|
|
child = inet_csk(sk)->icsk_af_ops->syn_recv_sock(sk, skb, req, NULL);
|
|
|
|
if (child == NULL)
|
|
|
|
goto listen_overflow;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2008-08-07 20:27:45 -07:00
|
|
|
inet_csk_reqsk_queue_unlink(sk, req, prev);
|
|
|
|
inet_csk_reqsk_queue_removed(sk, req);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2008-08-07 20:27:45 -07:00
|
|
|
inet_csk_reqsk_queue_add(sk, req, child);
|
|
|
|
return child;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2008-08-07 20:27:45 -07:00
|
|
|
listen_overflow:
|
|
|
|
if (!sysctl_tcp_abort_on_overflow) {
|
|
|
|
inet_rsk(req)->acked = 1;
|
|
|
|
return NULL;
|
|
|
|
}
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2008-08-07 20:27:45 -07:00
|
|
|
embryonic_reset:
|
|
|
|
NET_INC_STATS_BH(sock_net(sk), LINUX_MIB_EMBRYONICRSTS);
|
|
|
|
if (!(flg & TCP_FLAG_RST))
|
|
|
|
req->rsk_ops->send_reset(sk, skb);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
2008-08-07 20:27:45 -07:00
|
|
|
inet_csk_reqsk_queue_drop(sk, req, prev);
|
|
|
|
return NULL;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
2010-07-09 14:22:10 -07:00
|
|
|
EXPORT_SYMBOL(tcp_check_req);
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Queue segment on the new socket if the new socket is active,
|
|
|
|
* otherwise we just shortcircuit this and continue with
|
|
|
|
* the new socket.
|
|
|
|
*/
|
|
|
|
|
|
|
|
int tcp_child_process(struct sock *parent, struct sock *child,
|
|
|
|
struct sk_buff *skb)
|
|
|
|
{
|
|
|
|
int ret = 0;
|
|
|
|
int state = child->sk_state;
|
|
|
|
|
|
|
|
if (!sock_owned_by_user(child)) {
|
2007-04-10 21:04:22 -07:00
|
|
|
ret = tcp_rcv_state_process(child, skb, tcp_hdr(skb),
|
|
|
|
skb->len);
|
2005-04-16 15:20:36 -07:00
|
|
|
/* Wakeup parent, send SIGIO */
|
|
|
|
if (state == TCP_SYN_RECV && child->sk_state != state)
|
|
|
|
parent->sk_data_ready(parent, 0);
|
|
|
|
} else {
|
|
|
|
/* Alas, it is possible again, because we do lookup
|
|
|
|
* in main socket hash table and lock on listening
|
|
|
|
* socket does not protect us more.
|
|
|
|
*/
|
2010-03-04 11:01:47 -07:00
|
|
|
__sk_add_backlog(child, skb);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
bh_unlock_sock(child);
|
|
|
|
sock_put(child);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(tcp_child_process);
|