2005-04-16 15:20:36 -07:00
|
|
|
/*
|
|
|
|
* user-mode-linux networking multicast transport
|
2007-10-16 01:27:29 -07:00
|
|
|
* Copyright (C) 2001 - 2007 Jeff Dike (jdike@{addtoit,linux.intel}.com)
|
2005-04-16 15:20:36 -07:00
|
|
|
* Copyright (C) 2001 by Harald Welte <laforge@gnumonks.org>
|
|
|
|
*
|
|
|
|
* based on the existing uml-networking code, which is
|
2007-10-16 01:27:29 -07:00
|
|
|
* Copyright (C) 2001 Lennert Buytenhek (buytenh@gnu.org) and
|
2005-04-16 15:20:36 -07:00
|
|
|
* James Leu (jleu@mindspring.net).
|
|
|
|
* Copyright (C) 2001 by various other people who didn't put their name here.
|
|
|
|
*
|
|
|
|
* Licensed under the GPL.
|
|
|
|
*
|
|
|
|
*/
|
|
|
|
|
|
|
|
#include <unistd.h>
|
2007-10-16 01:27:29 -07:00
|
|
|
#include <errno.h>
|
2005-04-16 15:20:36 -07:00
|
|
|
#include <netinet/in.h>
|
|
|
|
#include "mcast.h"
|
2007-10-16 01:27:29 -07:00
|
|
|
#include "net_user.h"
|
2006-10-19 23:28:20 -07:00
|
|
|
#include "um_malloc.h"
|
2007-10-16 01:27:29 -07:00
|
|
|
#include "user.h"
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
static struct sockaddr_in *new_addr(char *addr, unsigned short port)
|
|
|
|
{
|
|
|
|
struct sockaddr_in *sin;
|
|
|
|
|
2007-07-15 23:38:56 -07:00
|
|
|
sin = kmalloc(sizeof(struct sockaddr_in), UM_GFP_KERNEL);
|
2007-10-16 01:27:29 -07:00
|
|
|
if (sin == NULL) {
|
|
|
|
printk(UM_KERN_ERR "new_addr: allocation of sockaddr_in "
|
|
|
|
"failed\n");
|
2007-05-06 14:51:02 -07:00
|
|
|
return NULL;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
sin->sin_family = AF_INET;
|
|
|
|
sin->sin_addr.s_addr = in_aton(addr);
|
2005-05-20 13:59:09 -07:00
|
|
|
sin->sin_port = htons(port);
|
2007-05-06 14:51:02 -07:00
|
|
|
return sin;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
uml: network interface hotplug error handling
This fixes a number of problems associated with network interface hotplug.
The userspace initialization function can fail in some cases, but the
failure was never passed back to eth_configure, which proceeded with the
configuration. This results in a zombie device that is present, but can't
work. This is fixed by allowing the initialization routines to return an
error, which is checked, and the configuration aborted on failure.
eth_configure failed to check for many failures. Even when it did check,
it didn't undo whatever initializations has already happened, so a present,
but partially initialized and non-working device could result. It now
checks everything that can fail, and bails out, undoing whatever had been
done.
The return value of eth_configure was always ignored, so it is now just
void.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-06 14:51:04 -07:00
|
|
|
static int mcast_user_init(void *data, void *dev)
|
2005-04-16 15:20:36 -07:00
|
|
|
{
|
|
|
|
struct mcast_data *pri = data;
|
|
|
|
|
|
|
|
pri->mcast_addr = new_addr(pri->addr, pri->port);
|
|
|
|
pri->dev = dev;
|
uml: network interface hotplug error handling
This fixes a number of problems associated with network interface hotplug.
The userspace initialization function can fail in some cases, but the
failure was never passed back to eth_configure, which proceeded with the
configuration. This results in a zombie device that is present, but can't
work. This is fixed by allowing the initialization routines to return an
error, which is checked, and the configuration aborted on failure.
eth_configure failed to check for many failures. Even when it did check,
it didn't undo whatever initializations has already happened, so a present,
but partially initialized and non-working device could result. It now
checks everything that can fail, and bails out, undoing whatever had been
done.
The return value of eth_configure was always ignored, so it is now just
void.
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-05-06 14:51:04 -07:00
|
|
|
return 0;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2007-03-07 21:41:09 -07:00
|
|
|
static void mcast_remove(void *data)
|
|
|
|
{
|
|
|
|
struct mcast_data *pri = data;
|
|
|
|
|
|
|
|
kfree(pri->mcast_addr);
|
|
|
|
pri->mcast_addr = NULL;
|
|
|
|
}
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
static int mcast_open(void *data)
|
|
|
|
{
|
|
|
|
struct mcast_data *pri = data;
|
|
|
|
struct sockaddr_in *sin = pri->mcast_addr;
|
|
|
|
struct ip_mreq mreq;
|
2005-11-13 17:07:07 -07:00
|
|
|
int fd, yes = 1, err = -EINVAL;
|
2005-04-16 15:20:36 -07:00
|
|
|
|
|
|
|
|
2005-05-20 13:59:09 -07:00
|
|
|
if ((sin->sin_addr.s_addr == 0) || (sin->sin_port == 0))
|
2005-04-16 15:20:36 -07:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
fd = socket(AF_INET, SOCK_DGRAM, 0);
|
2005-05-20 13:59:09 -07:00
|
|
|
|
2007-10-16 01:27:29 -07:00
|
|
|
if (fd < 0) {
|
2005-11-13 17:07:07 -07:00
|
|
|
err = -errno;
|
2007-10-16 01:27:29 -07:00
|
|
|
printk(UM_KERN_ERR "mcast_open : data socket failed, "
|
|
|
|
"errno = %d\n", errno);
|
2005-04-16 15:20:36 -07:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (setsockopt(fd, SOL_SOCKET, SO_REUSEADDR, &yes, sizeof(yes)) < 0) {
|
2005-11-13 17:07:07 -07:00
|
|
|
err = -errno;
|
2007-10-16 01:27:29 -07:00
|
|
|
printk(UM_KERN_ERR "mcast_open: SO_REUSEADDR failed, "
|
|
|
|
"errno = %d\n", errno);
|
2005-05-20 13:59:09 -07:00
|
|
|
goto out_close;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/* set ttl according to config */
|
|
|
|
if (setsockopt(fd, SOL_IP, IP_MULTICAST_TTL, &pri->ttl,
|
|
|
|
sizeof(pri->ttl)) < 0) {
|
2005-11-13 17:07:07 -07:00
|
|
|
err = -errno;
|
2007-10-16 01:27:29 -07:00
|
|
|
printk(UM_KERN_ERR "mcast_open: IP_MULTICAST_TTL failed, "
|
|
|
|
"error = %d\n", errno);
|
2005-05-20 13:59:09 -07:00
|
|
|
goto out_close;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/* set LOOP, so data does get fed back to local sockets */
|
|
|
|
if (setsockopt(fd, SOL_IP, IP_MULTICAST_LOOP, &yes, sizeof(yes)) < 0) {
|
2005-11-13 17:07:07 -07:00
|
|
|
err = -errno;
|
2007-10-16 01:27:29 -07:00
|
|
|
printk(UM_KERN_ERR "mcast_open: IP_MULTICAST_LOOP failed, "
|
|
|
|
"error = %d\n", errno);
|
2005-05-20 13:59:09 -07:00
|
|
|
goto out_close;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/* bind socket to mcast address */
|
|
|
|
if (bind(fd, (struct sockaddr *) sin, sizeof(*sin)) < 0) {
|
[PATCH] uml: preserve errno in error paths
The poster child for this patch is the third tuntap_user hunk. When an ioctl
fails, it properly closes the opened file descriptor and returns. However,
the close resets errno to 0, and the 'return errno' that follows returns 0
rather than the value that ioctl set. This caused the caller to believe that
the device open succeeded and had opened file descriptor 0, which caused no
end of interesting behavior.
The rest of this patch is a pass through the UML sources looking for places
where errno could be reset before being passed back out. A common culprit is
printk, which could call write, being called before errno is returned.
In some cases, where the code ends up being much smaller, I just deleted the
printk.
There was another case where a caller of run_helper looked at errno after a
failure, rather than the return value of run_helper, which was the errno value
that it wanted.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-16 19:27:49 -07:00
|
|
|
err = -errno;
|
2007-10-16 01:27:29 -07:00
|
|
|
printk(UM_KERN_ERR "mcast_open : data bind failed, "
|
|
|
|
"errno = %d\n", errno);
|
2005-05-20 13:59:09 -07:00
|
|
|
goto out_close;
|
2007-05-06 14:51:02 -07:00
|
|
|
}
|
|
|
|
|
2005-04-16 15:20:36 -07:00
|
|
|
/* subscribe to the multicast group */
|
|
|
|
mreq.imr_multiaddr.s_addr = sin->sin_addr.s_addr;
|
|
|
|
mreq.imr_interface.s_addr = 0;
|
2007-10-16 01:27:29 -07:00
|
|
|
if (setsockopt(fd, SOL_IP, IP_ADD_MEMBERSHIP,
|
2005-04-16 15:20:36 -07:00
|
|
|
&mreq, sizeof(mreq)) < 0) {
|
2005-11-13 17:07:07 -07:00
|
|
|
err = -errno;
|
2007-10-16 01:27:29 -07:00
|
|
|
printk(UM_KERN_ERR "mcast_open: IP_ADD_MEMBERSHIP failed, "
|
|
|
|
"error = %d\n", errno);
|
|
|
|
printk(UM_KERN_ERR "There appears not to be a multicast-"
|
|
|
|
"capable network interface on the host.\n");
|
|
|
|
printk(UM_KERN_ERR "eth0 should be configured in order to use "
|
|
|
|
"the multicast transport.\n");
|
2005-11-13 17:07:07 -07:00
|
|
|
goto out_close;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2005-05-20 13:59:09 -07:00
|
|
|
return fd;
|
|
|
|
|
|
|
|
out_close:
|
2007-10-16 01:27:29 -07:00
|
|
|
close(fd);
|
[PATCH] uml: preserve errno in error paths
The poster child for this patch is the third tuntap_user hunk. When an ioctl
fails, it properly closes the opened file descriptor and returns. However,
the close resets errno to 0, and the 'return errno' that follows returns 0
rather than the value that ioctl set. This caused the caller to believe that
the device open succeeded and had opened file descriptor 0, which caused no
end of interesting behavior.
The rest of this patch is a pass through the UML sources looking for places
where errno could be reset before being passed back out. A common culprit is
printk, which could call write, being called before errno is returned.
In some cases, where the code ends up being much smaller, I just deleted the
printk.
There was another case where a caller of run_helper looked at errno after a
failure, rather than the return value of run_helper, which was the errno value
that it wanted.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Cc: Paolo Giarrusso <blaisorblade@yahoo.it>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
2005-09-16 19:27:49 -07:00
|
|
|
out:
|
2005-11-13 17:07:07 -07:00
|
|
|
return err;
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
static void mcast_close(int fd, void *data)
|
|
|
|
{
|
|
|
|
struct ip_mreq mreq;
|
|
|
|
struct mcast_data *pri = data;
|
|
|
|
struct sockaddr_in *sin = pri->mcast_addr;
|
|
|
|
|
|
|
|
mreq.imr_multiaddr.s_addr = sin->sin_addr.s_addr;
|
|
|
|
mreq.imr_interface.s_addr = 0;
|
|
|
|
if (setsockopt(fd, SOL_IP, IP_DROP_MEMBERSHIP,
|
|
|
|
&mreq, sizeof(mreq)) < 0) {
|
2007-10-16 01:27:29 -07:00
|
|
|
printk(UM_KERN_ERR "mcast_open: IP_DROP_MEMBERSHIP failed, "
|
|
|
|
"error = %d\n", errno);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2007-10-16 01:27:29 -07:00
|
|
|
close(fd);
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
int mcast_user_write(int fd, void *buf, int len, struct mcast_data *pri)
|
|
|
|
{
|
|
|
|
struct sockaddr_in *data_addr = pri->mcast_addr;
|
|
|
|
|
2007-05-06 14:51:02 -07:00
|
|
|
return net_sendto(fd, buf, len, data_addr, sizeof(*data_addr));
|
2005-04-16 15:20:36 -07:00
|
|
|
}
|
|
|
|
|
2006-09-27 01:50:33 -07:00
|
|
|
const struct net_user_info mcast_user_info = {
|
2005-04-16 15:20:36 -07:00
|
|
|
.init = mcast_user_init,
|
|
|
|
.open = mcast_open,
|
|
|
|
.close = mcast_close,
|
2007-03-07 21:41:09 -07:00
|
|
|
.remove = mcast_remove,
|
2005-04-16 15:20:36 -07:00
|
|
|
.add_address = NULL,
|
|
|
|
.delete_address = NULL,
|
2007-10-16 01:27:31 -07:00
|
|
|
.mtu = ETH_MAX_PACKET,
|
|
|
|
.max_packet = ETH_MAX_PACKET + ETH_HEADER_OTHER,
|
2005-04-16 15:20:36 -07:00
|
|
|
};
|