2019-05-29 16:57:47 -07:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
|
|
|
* mm/kmemleak.c
|
|
|
|
*
|
|
|
|
* Copyright (C) 2008 ARM Limited
|
|
|
|
* Written by Catalin Marinas <catalin.marinas@arm.com>
|
|
|
|
*
|
|
|
|
* For more information on the algorithm and kmemleak usage, please see
|
2016-12-12 17:42:01 -07:00
|
|
|
* Documentation/dev-tools/kmemleak.rst.
|
2009-06-11 05:22:39 -07:00
|
|
|
*
|
|
|
|
* Notes on locking
|
|
|
|
* ----------------
|
|
|
|
*
|
|
|
|
* The following locks and mutexes are used by kmemleak:
|
|
|
|
*
|
2023-01-18 21:01:11 -07:00
|
|
|
* - kmemleak_lock (raw_spinlock_t): protects the object_list as well as
|
2023-12-01 12:08:29 -07:00
|
|
|
* del_state modifications and accesses to the object trees
|
|
|
|
* (object_tree_root, object_phys_tree_root, object_percpu_tree_root). The
|
|
|
|
* object_list is the main list holding the metadata (struct
|
|
|
|
* kmemleak_object) for the allocated memory blocks. The object trees are
|
|
|
|
* red black trees used to look-up metadata based on a pointer to the
|
|
|
|
* corresponding memory block. The kmemleak_object structures are added to
|
|
|
|
* the object_list and the object tree root in the create_object() function
|
|
|
|
* called from the kmemleak_alloc{,_phys,_percpu}() callback and removed in
|
|
|
|
* delete_object() called from the kmemleak_free{,_phys,_percpu}() callback
|
2020-01-30 23:12:00 -07:00
|
|
|
* - kmemleak_object.lock (raw_spinlock_t): protects a kmemleak_object.
|
|
|
|
* Accesses to the metadata (e.g. count) are protected by this lock. Note
|
|
|
|
* that some members of this structure may be protected by other means
|
|
|
|
* (atomic or kmemleak_lock). This lock is also held when scanning the
|
|
|
|
* corresponding memory block to avoid the kernel freeing it via the
|
|
|
|
* kmemleak_free() callback. This is less heavyweight than holding a global
|
|
|
|
* lock like kmemleak_lock during scanning.
|
2009-06-11 05:22:39 -07:00
|
|
|
* - scan_mutex (mutex): ensures that only one thread may scan the memory for
|
|
|
|
* unreferenced objects at a time. The gray_list contains the objects which
|
|
|
|
* are already referenced or marked as false positives and need to be
|
|
|
|
* scanned. This list is only modified during a scanning episode when the
|
|
|
|
* scan_mutex is held. At the end of a scan, the gray_list is always empty.
|
|
|
|
* Note that the kmemleak_object.use_count is incremented when an object is
|
2009-06-26 09:38:27 -07:00
|
|
|
* added to the gray_list and therefore cannot be freed. This mutex also
|
|
|
|
* prevents multiple users of the "kmemleak" debugfs file together with
|
|
|
|
* modifications to the memory scanning parameters including the scan_thread
|
|
|
|
* pointer
|
2009-06-11 05:22:39 -07:00
|
|
|
*
|
2015-06-24 16:58:37 -07:00
|
|
|
* Locks and mutexes are acquired/nested in the following order:
|
2015-06-24 16:58:34 -07:00
|
|
|
*
|
2015-06-24 16:58:37 -07:00
|
|
|
* scan_mutex [-> object->lock] -> kmemleak_lock -> other_object->lock (SINGLE_DEPTH_NESTING)
|
|
|
|
*
|
|
|
|
* No kmemleak_lock and object->lock nesting is allowed outside scan_mutex
|
|
|
|
* regions.
|
2015-06-24 16:58:34 -07:00
|
|
|
*
|
2009-06-11 05:22:39 -07:00
|
|
|
* The kmemleak_object structures have a use_count incremented or decremented
|
|
|
|
* using the get_object()/put_object() functions. When the use_count becomes
|
|
|
|
* 0, this count can no longer be incremented and put_object() schedules the
|
|
|
|
* kmemleak_object freeing via an RCU callback. All calls to the get_object()
|
|
|
|
* function must be protected by rcu_read_lock() to avoid accessing a freed
|
|
|
|
* structure.
|
|
|
|
*/
|
|
|
|
|
2009-06-23 06:40:26 -07:00
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include <linux/list.h>
|
2017-02-08 10:51:30 -07:00
|
|
|
#include <linux/sched/signal.h>
|
2017-02-08 10:51:36 -07:00
|
|
|
#include <linux/sched/task.h>
|
2017-02-08 10:51:37 -07:00
|
|
|
#include <linux/sched/task_stack.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
#include <linux/jiffies.h>
|
|
|
|
#include <linux/delay.h>
|
2011-10-15 23:01:52 -07:00
|
|
|
#include <linux/export.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
#include <linux/kthread.h>
|
2012-10-08 16:31:27 -07:00
|
|
|
#include <linux/rbtree.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/debugfs.h>
|
|
|
|
#include <linux/seq_file.h>
|
|
|
|
#include <linux/cpumask.h>
|
|
|
|
#include <linux/spinlock.h>
|
2018-10-26 15:03:42 -07:00
|
|
|
#include <linux/module.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
#include <linux/mutex.h>
|
|
|
|
#include <linux/rcupdate.h>
|
|
|
|
#include <linux/stacktrace.h>
|
2022-10-27 02:50:24 -07:00
|
|
|
#include <linux/stackdepot.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
#include <linux/cache.h>
|
|
|
|
#include <linux/percpu.h>
|
2018-10-30 15:09:49 -07:00
|
|
|
#include <linux/memblock.h>
|
2016-10-11 13:55:11 -07:00
|
|
|
#include <linux/pfn.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
#include <linux/mmzone.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/thread_info.h>
|
|
|
|
#include <linux/err.h>
|
|
|
|
#include <linux/uaccess.h>
|
|
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/nodemask.h>
|
|
|
|
#include <linux/mm.h>
|
2009-09-07 02:14:42 -07:00
|
|
|
#include <linux/workqueue.h>
|
2009-10-28 06:33:12 -07:00
|
|
|
#include <linux/crc32.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
#include <asm/sections.h>
|
|
|
|
#include <asm/processor.h>
|
2011-07-26 16:09:06 -07:00
|
|
|
#include <linux/atomic.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2015-02-13 15:39:49 -07:00
|
|
|
#include <linux/kasan.h>
|
2021-03-24 21:37:47 -07:00
|
|
|
#include <linux/kfence.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
#include <linux/kmemleak.h>
|
2011-11-15 16:49:09 -07:00
|
|
|
#include <linux/memory_hotplug.h>
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Kmemleak configuration and common defines.
|
|
|
|
*/
|
|
|
|
#define MAX_TRACE 16 /* stack trace length */
|
|
|
|
#define MSECS_MIN_AGE 5000 /* minimum object age for reporting */
|
|
|
|
#define SECS_FIRST_SCAN 60 /* delay before the first scan */
|
|
|
|
#define SECS_SCAN_WAIT 600 /* subsequent auto scanning delay */
|
2009-08-27 06:29:12 -07:00
|
|
|
#define MAX_SCAN_SIZE 4096 /* maximum size of a scanned block */
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
#define BYTES_PER_POINTER sizeof(void *)
|
|
|
|
|
2009-06-17 10:29:02 -07:00
|
|
|
/* GFP bitmask for kmemleak internal allocations */
|
2021-09-08 18:10:17 -07:00
|
|
|
#define gfp_kmemleak_mask(gfp) (((gfp) & (GFP_KERNEL | GFP_ATOMIC | \
|
|
|
|
__GFP_NOLOCKDEP)) | \
|
2011-01-27 03:30:26 -07:00
|
|
|
__GFP_NORETRY | __GFP_NOMEMALLOC | \
|
2019-08-02 21:48:37 -07:00
|
|
|
__GFP_NOWARN)
|
2009-06-17 10:29:02 -07:00
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/* scanning area inside a memory block */
|
|
|
|
struct kmemleak_scan_area {
|
|
|
|
struct hlist_node node;
|
2009-10-28 06:33:09 -07:00
|
|
|
unsigned long start;
|
|
|
|
size_t size;
|
2009-06-11 05:22:39 -07:00
|
|
|
};
|
|
|
|
|
2009-09-04 17:44:52 -07:00
|
|
|
#define KMEMLEAK_GREY 0
|
|
|
|
#define KMEMLEAK_BLACK -1
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
|
|
|
* Structure holding the metadata for each allocated memory block.
|
|
|
|
* Modifications to such objects should be made while holding the
|
|
|
|
* object->lock. Insertions or deletions from object_list, gray_list or
|
2012-10-08 16:31:27 -07:00
|
|
|
* rb_node are already protected by the corresponding locks or mutex (see
|
2009-06-11 05:22:39 -07:00
|
|
|
* the notes on locking above). These objects are reference-counted
|
|
|
|
* (use_count) and freed using the RCU mechanism.
|
|
|
|
*/
|
|
|
|
struct kmemleak_object {
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spinlock_t lock;
|
2017-07-06 15:40:16 -07:00
|
|
|
unsigned int flags; /* object status flags */
|
2009-06-11 05:22:39 -07:00
|
|
|
struct list_head object_list;
|
|
|
|
struct list_head gray_list;
|
2012-10-08 16:31:27 -07:00
|
|
|
struct rb_node rb_node;
|
2009-06-11 05:22:39 -07:00
|
|
|
struct rcu_head rcu; /* object_list lockless traversal */
|
|
|
|
/* object usage count; object freed when use_count == 0 */
|
|
|
|
atomic_t use_count;
|
2023-01-18 21:01:11 -07:00
|
|
|
unsigned int del_state; /* deletion state */
|
2009-06-11 05:22:39 -07:00
|
|
|
unsigned long pointer;
|
|
|
|
size_t size;
|
2017-07-06 15:40:22 -07:00
|
|
|
/* pass surplus references to this pointer */
|
|
|
|
unsigned long excess_ref;
|
2009-06-11 05:22:39 -07:00
|
|
|
/* minimum number of a pointers found before it is considered leak */
|
|
|
|
int min_count;
|
|
|
|
/* the total number of pointers found pointing to this object */
|
|
|
|
int count;
|
2009-10-28 06:33:12 -07:00
|
|
|
/* checksum for detecting modified objects */
|
|
|
|
u32 checksum;
|
2024-03-07 12:05:47 -07:00
|
|
|
depot_stack_handle_t trace_handle;
|
2009-06-11 05:22:39 -07:00
|
|
|
/* memory ranges to be scanned inside an object (empty for all) */
|
|
|
|
struct hlist_head area_list;
|
|
|
|
unsigned long jiffies; /* creation timestamp */
|
|
|
|
pid_t pid; /* pid of the current task */
|
|
|
|
char comm[TASK_COMM_LEN]; /* executable name */
|
|
|
|
};
|
|
|
|
|
|
|
|
/* flag representing the memory block allocation status */
|
|
|
|
#define OBJECT_ALLOCATED (1 << 0)
|
|
|
|
/* flag set after the first reporting of an unreference object */
|
|
|
|
#define OBJECT_REPORTED (1 << 1)
|
|
|
|
/* flag set to not scan the object */
|
|
|
|
#define OBJECT_NO_SCAN (1 << 2)
|
2019-09-23 15:33:59 -07:00
|
|
|
/* flag set to fully scan the object when scan_area allocation failed */
|
|
|
|
#define OBJECT_FULL_SCAN (1 << 3)
|
2022-06-10 20:55:49 -07:00
|
|
|
/* flag set for object allocated with physical address */
|
|
|
|
#define OBJECT_PHYS (1 << 4)
|
2023-12-01 12:08:29 -07:00
|
|
|
/* flag set for per-CPU pointers */
|
|
|
|
#define OBJECT_PERCPU (1 << 5)
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2023-01-18 21:01:11 -07:00
|
|
|
/* set when __remove_object() called */
|
|
|
|
#define DELSTATE_REMOVED (1 << 0)
|
|
|
|
/* set to temporarily prevent deletion from object_list */
|
|
|
|
#define DELSTATE_NO_DELETE (1 << 1)
|
|
|
|
|
2018-10-26 15:03:42 -07:00
|
|
|
#define HEX_PREFIX " "
|
2009-08-27 06:29:18 -07:00
|
|
|
/* number of bytes to print per line; must be 16 or 32 */
|
|
|
|
#define HEX_ROW_SIZE 16
|
|
|
|
/* number of bytes to print at a time (1, 2, 4, 8) */
|
|
|
|
#define HEX_GROUP_SIZE 1
|
|
|
|
/* include ASCII after the hex output */
|
|
|
|
#define HEX_ASCII 1
|
|
|
|
/* max number of lines to be printed */
|
|
|
|
#define HEX_MAX_LINES 2
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/* the list of all allocated objects */
|
|
|
|
static LIST_HEAD(object_list);
|
|
|
|
/* the list of gray-colored objects (see color_gray comment below) */
|
|
|
|
static LIST_HEAD(gray_list);
|
2019-09-23 15:34:02 -07:00
|
|
|
/* memory pool allocation */
|
2019-09-23 15:34:05 -07:00
|
|
|
static struct kmemleak_object mem_pool[CONFIG_DEBUG_KMEMLEAK_MEM_POOL_SIZE];
|
2019-09-23 15:34:02 -07:00
|
|
|
static int mem_pool_free_count = ARRAY_SIZE(mem_pool);
|
|
|
|
static LIST_HEAD(mem_pool_free_list);
|
2012-10-08 16:31:27 -07:00
|
|
|
/* search tree for object boundaries */
|
|
|
|
static struct rb_root object_tree_root = RB_ROOT;
|
2022-06-10 20:55:50 -07:00
|
|
|
/* search tree for object (with OBJECT_PHYS flag) boundaries */
|
|
|
|
static struct rb_root object_phys_tree_root = RB_ROOT;
|
2023-12-01 12:08:29 -07:00
|
|
|
/* search tree for object (with OBJECT_PERCPU flag) boundaries */
|
|
|
|
static struct rb_root object_percpu_tree_root = RB_ROOT;
|
2022-06-10 20:55:50 -07:00
|
|
|
/* protecting the access to object_list, object_tree_root (or object_phys_tree_root) */
|
2020-01-30 23:12:00 -07:00
|
|
|
static DEFINE_RAW_SPINLOCK(kmemleak_lock);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/* allocation caches for kmemleak internal data */
|
|
|
|
static struct kmem_cache *object_cache;
|
|
|
|
static struct kmem_cache *scan_area_cache;
|
|
|
|
|
|
|
|
/* set if tracing memory operations is enabled */
|
2019-09-23 15:34:05 -07:00
|
|
|
static int kmemleak_enabled = 1;
|
2015-06-24 16:58:26 -07:00
|
|
|
/* same as above but only for the kmemleak_free() callback */
|
2019-09-23 15:34:05 -07:00
|
|
|
static int kmemleak_free_enabled = 1;
|
2009-06-11 05:22:39 -07:00
|
|
|
/* set in the late_initcall if there were no errors */
|
2023-08-15 07:41:28 -07:00
|
|
|
static int kmemleak_late_initialized;
|
2011-09-28 04:17:03 -07:00
|
|
|
/* set if a kmemleak warning was issued */
|
2014-04-03 14:46:29 -07:00
|
|
|
static int kmemleak_warning;
|
2011-09-28 04:17:03 -07:00
|
|
|
/* set if a fatal kmemleak error has occurred */
|
2014-04-03 14:46:29 -07:00
|
|
|
static int kmemleak_error;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/* minimum and maximum address that may be valid pointers */
|
|
|
|
static unsigned long min_addr = ULONG_MAX;
|
|
|
|
static unsigned long max_addr;
|
|
|
|
|
|
|
|
static struct task_struct *scan_thread;
|
2009-06-26 09:38:29 -07:00
|
|
|
/* used to avoid reporting of recently allocated objects */
|
2009-06-11 05:22:39 -07:00
|
|
|
static unsigned long jiffies_min_age;
|
2009-06-26 09:38:29 -07:00
|
|
|
static unsigned long jiffies_last_scan;
|
2009-06-11 05:22:39 -07:00
|
|
|
/* delay between automatic memory scannings */
|
2021-06-28 19:35:01 -07:00
|
|
|
static unsigned long jiffies_scan_wait;
|
2009-06-11 05:22:39 -07:00
|
|
|
/* enables or disables the task stacks scanning */
|
2009-06-26 09:38:25 -07:00
|
|
|
static int kmemleak_stack_scan = 1;
|
2009-06-26 09:38:27 -07:00
|
|
|
/* protects the memory scanning, parameters and debug/kmemleak file access */
|
2009-06-11 05:22:39 -07:00
|
|
|
static DEFINE_MUTEX(scan_mutex);
|
2010-07-19 03:54:17 -07:00
|
|
|
/* setting kmemleak=on, will set this var, skipping the disable */
|
|
|
|
static int kmemleak_skip_disable;
|
2014-04-03 14:46:26 -07:00
|
|
|
/* If there are leaks that can be reported */
|
|
|
|
static bool kmemleak_found_leaks;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2018-10-26 15:03:42 -07:00
|
|
|
static bool kmemleak_verbose;
|
|
|
|
module_param_named(verbose, kmemleak_verbose, bool, 0600);
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
static void kmemleak_disable(void);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Print a warning and dump the stack trace.
|
|
|
|
*/
|
2011-09-28 04:17:03 -07:00
|
|
|
#define kmemleak_warn(x...) do { \
|
2016-03-17 14:19:44 -07:00
|
|
|
pr_warn(x); \
|
2011-09-28 04:17:03 -07:00
|
|
|
dump_stack(); \
|
2014-04-03 14:46:29 -07:00
|
|
|
kmemleak_warning = 1; \
|
2009-06-11 05:22:39 -07:00
|
|
|
} while (0)
|
|
|
|
|
|
|
|
/*
|
2011-03-30 18:57:33 -07:00
|
|
|
* Macro invoked when a serious kmemleak condition occurred and cannot be
|
2009-06-17 10:29:04 -07:00
|
|
|
* recovered from. Kmemleak will be disabled and further allocation/freeing
|
2009-06-11 05:22:39 -07:00
|
|
|
* tracing no longer available.
|
|
|
|
*/
|
2009-06-17 10:29:03 -07:00
|
|
|
#define kmemleak_stop(x...) do { \
|
2009-06-11 05:22:39 -07:00
|
|
|
kmemleak_warn(x); \
|
|
|
|
kmemleak_disable(); \
|
|
|
|
} while (0)
|
|
|
|
|
2018-10-26 15:03:42 -07:00
|
|
|
#define warn_or_seq_printf(seq, fmt, ...) do { \
|
|
|
|
if (seq) \
|
|
|
|
seq_printf(seq, fmt, ##__VA_ARGS__); \
|
|
|
|
else \
|
|
|
|
pr_warn(fmt, ##__VA_ARGS__); \
|
|
|
|
} while (0)
|
|
|
|
|
|
|
|
static void warn_or_seq_hex_dump(struct seq_file *seq, int prefix_type,
|
|
|
|
int rowsize, int groupsize, const void *buf,
|
|
|
|
size_t len, bool ascii)
|
|
|
|
{
|
|
|
|
if (seq)
|
|
|
|
seq_hex_dump(seq, HEX_PREFIX, prefix_type, rowsize, groupsize,
|
|
|
|
buf, len, ascii);
|
|
|
|
else
|
|
|
|
print_hex_dump(KERN_WARNING, pr_fmt(HEX_PREFIX), prefix_type,
|
|
|
|
rowsize, groupsize, buf, len, ascii);
|
|
|
|
}
|
|
|
|
|
2009-08-27 06:29:18 -07:00
|
|
|
/*
|
|
|
|
* Printing of the objects hex dump to the seq file. The number of lines to be
|
|
|
|
* printed is limited to HEX_MAX_LINES to prevent seq file spamming. The
|
|
|
|
* actual number of printed bytes depends on HEX_ROW_SIZE. It must be called
|
|
|
|
* with the object->lock held.
|
|
|
|
*/
|
|
|
|
static void hex_dump_object(struct seq_file *seq,
|
|
|
|
struct kmemleak_object *object)
|
|
|
|
{
|
|
|
|
const u8 *ptr = (const u8 *)object->pointer;
|
2015-09-09 15:38:45 -07:00
|
|
|
size_t len;
|
2009-08-27 06:29:18 -07:00
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
if (WARN_ON_ONCE(object->flags & (OBJECT_PHYS | OBJECT_PERCPU)))
|
2022-06-10 20:55:50 -07:00
|
|
|
return;
|
|
|
|
|
2009-08-27 06:29:18 -07:00
|
|
|
/* limit the number of lines to HEX_MAX_LINES */
|
2015-09-09 15:38:45 -07:00
|
|
|
len = min_t(size_t, object->size, HEX_MAX_LINES * HEX_ROW_SIZE);
|
2009-08-27 06:29:18 -07:00
|
|
|
|
2018-10-26 15:03:42 -07:00
|
|
|
warn_or_seq_printf(seq, " hex dump (first %zu bytes):\n", len);
|
2016-06-24 14:50:07 -07:00
|
|
|
kasan_disable_current();
|
2018-10-26 15:03:42 -07:00
|
|
|
warn_or_seq_hex_dump(seq, DUMP_PREFIX_NONE, HEX_ROW_SIZE,
|
kasan, kmemleak: reset tags when scanning block
Patch series "kasan, slub: reset tag when printing address", v3.
With hardware tag-based kasan enabled, we reset the tag when we access
metadata to avoid from false alarm.
This patch (of 2):
Kmemleak needs to scan kernel memory to check memory leak. With hardware
tag-based kasan enabled, when it scans on the invalid slab and
dereference, the issue will occur as below.
Hardware tag-based KASAN doesn't use compiler instrumentation, we can not
use kasan_disable_current() to ignore tag check.
Based on the below report, there are 11 0xf7 granules, which amounts to
176 bytes, and the object is allocated from the kmalloc-256 cache. So
when kmemleak accesses the last 256-176 bytes, it causes faults, as those
are marked with KASAN_KMALLOC_REDZONE == KASAN_TAG_INVALID == 0xfe.
Thus, we reset tags before accessing metadata to avoid from false positives.
BUG: KASAN: out-of-bounds in scan_block+0x58/0x170
Read at addr f7ff0000c0074eb0 by task kmemleak/138
Pointer tag: [f7], memory tag: [fe]
CPU: 7 PID: 138 Comm: kmemleak Not tainted 5.14.0-rc2-00001-g8cae8cd89f05-dirty #134
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1b0
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
print_address_description+0x7c/0x2b4
kasan_report+0x138/0x38c
__do_kernel_fault+0x190/0x1c4
do_tag_check_fault+0x78/0x90
do_mem_abort+0x44/0xb4
el1_abort+0x40/0x60
el1h_64_sync_handler+0xb4/0xd0
el1h_64_sync+0x78/0x7c
scan_block+0x58/0x170
scan_gray_list+0xdc/0x1a0
kmemleak_scan+0x2ac/0x560
kmemleak_scan_thread+0xb0/0xe0
kthread+0x154/0x160
ret_from_fork+0x10/0x18
Allocated by task 0:
kasan_save_stack+0x2c/0x60
__kasan_kmalloc+0xec/0x104
__kmalloc+0x224/0x3c4
__register_sysctl_paths+0x200/0x290
register_sysctl_table+0x2c/0x40
sysctl_init+0x20/0x34
proc_sys_init+0x3c/0x48
proc_root_init+0x80/0x9c
start_kernel+0x648/0x6a4
__primary_switched+0xc0/0xc8
Freed by task 0:
kasan_save_stack+0x2c/0x60
kasan_set_track+0x2c/0x40
kasan_set_free_info+0x44/0x54
____kasan_slab_free.constprop.0+0x150/0x1b0
__kasan_slab_free+0x14/0x20
slab_free_freelist_hook+0xa4/0x1fc
kfree+0x1e8/0x30c
put_fs_context+0x124/0x220
vfs_kern_mount.part.0+0x60/0xd4
kern_mount+0x24/0x4c
bdev_cache_init+0x70/0x9c
vfs_caches_init+0xdc/0xf4
start_kernel+0x638/0x6a4
__primary_switched+0xc0/0xc8
The buggy address belongs to the object at ffff0000c0074e00
which belongs to the cache kmalloc-256 of size 256
The buggy address is located 176 bytes inside of
256-byte region [ffff0000c0074e00, ffff0000c0074f00)
The buggy address belongs to the page:
page:(____ptrval____) refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x100074
head:(____ptrval____) order:2 compound_mapcount:0 compound_pincount:0
flags: 0xbfffc0000010200(slab|head|node=0|zone=2|lastcpupid=0xffff|kasantag=0x0)
raw: 0bfffc0000010200 0000000000000000 dead000000000122 f5ff0000c0002300
raw: 0000000000000000 0000000000200020 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff0000c0074c00: f0 f0 f0 f0 f0 f0 f0 f0 f0 fe fe fe fe fe fe fe
ffff0000c0074d00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
>ffff0000c0074e00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 fe fe fe fe fe
^
ffff0000c0074f00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
ffff0000c0075000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================
Disabling lock debugging due to kernel taint
kmemleak: 181 new suspected memory leaks (see /sys/kernel/debug/kmemleak)
Link: https://lkml.kernel.org/r/20210804090957.12393-1-Kuan-Ying.Lee@mediatek.com
Link: https://lkml.kernel.org/r/20210804090957.12393-2-Kuan-Ying.Lee@mediatek.com
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Marco Elver <elver@google.com>
Cc: Nicholas Tang <nicholas.tang@mediatek.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Chinwen Chang <chinwen.chang@mediatek.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2021-08-13 16:54:24 -07:00
|
|
|
HEX_GROUP_SIZE, kasan_reset_tag((void *)ptr), len, HEX_ASCII);
|
2016-06-24 14:50:07 -07:00
|
|
|
kasan_enable_current();
|
2009-08-27 06:29:18 -07:00
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
|
|
|
* Object colors, encoded with count and min_count:
|
|
|
|
* - white - orphan object, not enough references to it (count < min_count)
|
|
|
|
* - gray - not orphan, not marked as false positive (min_count == 0) or
|
|
|
|
* sufficient references to it (count >= min_count)
|
|
|
|
* - black - ignore, it doesn't contain references (e.g. text section)
|
|
|
|
* (min_count == -1). No function defined for this color.
|
|
|
|
* Newly created objects don't have any color assigned (object->count == -1)
|
|
|
|
* before the next memory scan when they become white.
|
|
|
|
*/
|
2009-09-08 08:34:50 -07:00
|
|
|
static bool color_white(const struct kmemleak_object *object)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2009-09-04 17:44:52 -07:00
|
|
|
return object->count != KMEMLEAK_BLACK &&
|
|
|
|
object->count < object->min_count;
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
2009-09-08 08:34:50 -07:00
|
|
|
static bool color_gray(const struct kmemleak_object *object)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2009-09-04 17:44:52 -07:00
|
|
|
return object->min_count != KMEMLEAK_BLACK &&
|
|
|
|
object->count >= object->min_count;
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Objects are considered unreferenced only if their color is white, they have
|
|
|
|
* not be deleted and have a minimum age to avoid false positives caused by
|
|
|
|
* pointers temporarily stored in CPU registers.
|
|
|
|
*/
|
2009-09-08 08:34:50 -07:00
|
|
|
static bool unreferenced_object(struct kmemleak_object *object)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2009-10-28 06:33:12 -07:00
|
|
|
return (color_white(object) && object->flags & OBJECT_ALLOCATED) &&
|
2009-06-26 09:38:29 -07:00
|
|
|
time_before_eq(object->jiffies + jiffies_min_age,
|
|
|
|
jiffies_last_scan);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2009-06-26 09:38:26 -07:00
|
|
|
* Printing of the unreferenced objects information to the seq file. The
|
|
|
|
* print_unreferenced function must be called with the object->lock held.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
|
|
|
static void print_unreferenced(struct seq_file *seq,
|
|
|
|
struct kmemleak_object *object)
|
|
|
|
{
|
|
|
|
int i;
|
2022-10-27 02:50:24 -07:00
|
|
|
unsigned long *entries;
|
|
|
|
unsigned int nr_entries;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2022-10-27 02:50:24 -07:00
|
|
|
nr_entries = stack_depot_fetch(object->trace_handle, &entries);
|
2018-10-26 15:03:42 -07:00
|
|
|
warn_or_seq_printf(seq, "unreferenced object 0x%08lx (size %zu):\n",
|
2022-10-27 02:50:24 -07:00
|
|
|
object->pointer, object->size);
|
kmemleak: drop (age <increasing>) from leak record
Patch series "tweak kmemleak report format".
These 2 patches make minor changes to the report:
1st strips "age <increasing>" from output. This makes the output
idempotent; unchanging until a new leak is reported.
2nd adds the backtrace.checksum to the "backtrace:" line. This lets a
user see repeats without actually reading the whole backtrace. So now
the backtrace line looks like this:
backtrace (crc 603070071):
I surveyed for un-wanted effects upon users:
Syzkaller parses kmemleak in executor/common_linux.h:
static void check_leaks(char** frames, int nframes)
It just counts occurrences of "unreferenced object", specifically it
does not look for "age", nor would it choke on "crc" being added.
github has 3 repos with "kmemleak" mentioned, all are moribund.
gitlab has 0 hits on "kmemleak".
This patch (of 2):
Displaying age is pretty, but counter-productive; it changes with
current-time, so it surrenders idempotency of the output, which breaks
simple hash-based cataloging of the records by the user.
The trouble: sequential reads, wo new leaks, get new results:
:#> sum /sys/kernel/debug/kmemleak
53439 74 /sys/kernel/debug/kmemleak
:#> sum /sys/kernel/debug/kmemleak
59066 74 /sys/kernel/debug/kmemleak
and age is why (nothing else changes):
:#> grep -v age /sys/kernel/debug/kmemleak | sum
58894 67
:#> grep -v age /sys/kernel/debug/kmemleak | sum
58894 67
Since jiffies is already printed in the "comm" line, age adds nothing.
Notably, syzkaller reads kmemleak only for "unreferenced object", and
won't care about this reform of age-ism. A few moribund github repos
mention it, but don't compile.
Link: https://lkml.kernel.org/r/20231116224318.124209-1-jim.cromie@gmail.com
Link: https://lkml.kernel.org/r/20231116224318.124209-2-jim.cromie@gmail.com
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2023-11-16 15:43:17 -07:00
|
|
|
warn_or_seq_printf(seq, " comm \"%s\", pid %d, jiffies %lu\n",
|
|
|
|
object->comm, object->pid, object->jiffies);
|
2009-08-27 06:29:18 -07:00
|
|
|
hex_dump_object(seq, object);
|
2023-11-16 15:43:18 -07:00
|
|
|
warn_or_seq_printf(seq, " backtrace (crc %x):\n", object->checksum);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2022-10-27 02:50:24 -07:00
|
|
|
for (i = 0; i < nr_entries; i++) {
|
|
|
|
void *ptr = (void *)entries[i];
|
2022-11-08 02:43:22 -07:00
|
|
|
warn_or_seq_printf(seq, " [<%pK>] %pS\n", ptr, ptr);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Print the kmemleak_object information. This function is used mainly for
|
|
|
|
* debugging special cases when kmemleak operations. It must be called with
|
|
|
|
* the object->lock held.
|
|
|
|
*/
|
|
|
|
static void dump_object_info(struct kmemleak_object *object)
|
|
|
|
{
|
2009-06-23 06:40:26 -07:00
|
|
|
pr_notice("Object 0x%08lx (size %zu):\n",
|
2022-10-27 02:50:24 -07:00
|
|
|
object->pointer, object->size);
|
2009-06-11 05:22:39 -07:00
|
|
|
pr_notice(" comm \"%s\", pid %d, jiffies %lu\n",
|
2022-10-27 02:50:24 -07:00
|
|
|
object->comm, object->pid, object->jiffies);
|
2009-06-11 05:22:39 -07:00
|
|
|
pr_notice(" min_count = %d\n", object->min_count);
|
|
|
|
pr_notice(" count = %d\n", object->count);
|
2017-07-06 15:40:16 -07:00
|
|
|
pr_notice(" flags = 0x%x\n", object->flags);
|
2014-06-06 14:38:16 -07:00
|
|
|
pr_notice(" checksum = %u\n", object->checksum);
|
2009-06-11 05:22:39 -07:00
|
|
|
pr_notice(" backtrace:\n");
|
2022-10-27 02:50:24 -07:00
|
|
|
if (object->trace_handle)
|
|
|
|
stack_depot_print(object->trace_handle);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
static struct rb_root *object_tree(unsigned long objflags)
|
|
|
|
{
|
|
|
|
if (objflags & OBJECT_PHYS)
|
|
|
|
return &object_phys_tree_root;
|
|
|
|
if (objflags & OBJECT_PERCPU)
|
|
|
|
return &object_percpu_tree_root;
|
|
|
|
return &object_tree_root;
|
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
2012-10-08 16:31:27 -07:00
|
|
|
* Look-up a memory block metadata (kmemleak_object) in the object search
|
2009-06-11 05:22:39 -07:00
|
|
|
* tree based on a pointer value. If alias is 0, only values pointing to the
|
|
|
|
* beginning of the memory block are allowed. The kmemleak_lock must be held
|
|
|
|
* when calling this function.
|
|
|
|
*/
|
2022-06-10 20:55:50 -07:00
|
|
|
static struct kmemleak_object *__lookup_object(unsigned long ptr, int alias,
|
2023-12-01 12:08:29 -07:00
|
|
|
unsigned int objflags)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2023-12-01 12:08:29 -07:00
|
|
|
struct rb_node *rb = object_tree(objflags)->rb_node;
|
kmemleak: fix kmemleak false positive report with HW tag-based kasan enable
With HW tag-based kasan enable, We will get the warning when we free
object whose address starts with 0xFF.
It is because kmemleak rbtree stores tagged object and this freeing
object's tag does not match with rbtree object.
In the example below, kmemleak rbtree stores the tagged object in the
kmalloc(), and kfree() gets the pointer with 0xFF tag.
Call sequence:
ptr = kmalloc(size, GFP_KERNEL);
page = virt_to_page(ptr);
offset = offset_in_page(ptr);
kfree(page_address(page) + offset);
ptr = kmalloc(size, GFP_KERNEL);
A sequence like that may cause the warning as following:
1) Freeing unknown object:
In kfree(), we will get free unknown object warning in
kmemleak_free(). Because object(0xFx) in kmemleak rbtree and
pointer(0xFF) in kfree() have different tag.
2) Overlap existing:
When we allocate that object with the same hw-tag again, we will
find the overlap in the kmemleak rbtree and kmemleak thread will be
killed.
kmemleak: Freeing unknown object at 0xffff000003f88000
CPU: 5 PID: 177 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
kmemleak_free+0x6c/0x70
slab_free_freelist_hook+0x104/0x200
kmem_cache_free+0xa8/0x3d4
test_version_show+0x270/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
...
kmemleak: Cannot insert 0xf2ff000003f88000 into the object search tree (overlaps existing)
CPU: 5 PID: 178 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
create_object.isra.0+0x2d8/0x2fc
kmemleak_alloc+0x34/0x40
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
kmemleak: Kernel memory leak detector disabled
kmemleak: Object 0xf2ff000003f88000 (size 128):
kmemleak: comm "cat", pid 177, jiffies 4294921177
kmemleak: min_count = 1
kmemleak: count = 0
kmemleak: flags = 0x1
kmemleak: checksum = 0
kmemleak: backtrace:
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
kmemleak: Automatic memory scanning thread ended
[akpm@linux-foundation.org: whitespace tweak]
Link: https://lkml.kernel.org/r/20211118054426.4123-1-Kuan-Ying.Lee@mediatek.com
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-01-14 15:04:04 -07:00
|
|
|
unsigned long untagged_ptr = (unsigned long)kasan_reset_tag((void *)ptr);
|
2012-10-08 16:31:27 -07:00
|
|
|
|
|
|
|
while (rb) {
|
kmemleak: fix kmemleak false positive report with HW tag-based kasan enable
With HW tag-based kasan enable, We will get the warning when we free
object whose address starts with 0xFF.
It is because kmemleak rbtree stores tagged object and this freeing
object's tag does not match with rbtree object.
In the example below, kmemleak rbtree stores the tagged object in the
kmalloc(), and kfree() gets the pointer with 0xFF tag.
Call sequence:
ptr = kmalloc(size, GFP_KERNEL);
page = virt_to_page(ptr);
offset = offset_in_page(ptr);
kfree(page_address(page) + offset);
ptr = kmalloc(size, GFP_KERNEL);
A sequence like that may cause the warning as following:
1) Freeing unknown object:
In kfree(), we will get free unknown object warning in
kmemleak_free(). Because object(0xFx) in kmemleak rbtree and
pointer(0xFF) in kfree() have different tag.
2) Overlap existing:
When we allocate that object with the same hw-tag again, we will
find the overlap in the kmemleak rbtree and kmemleak thread will be
killed.
kmemleak: Freeing unknown object at 0xffff000003f88000
CPU: 5 PID: 177 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
kmemleak_free+0x6c/0x70
slab_free_freelist_hook+0x104/0x200
kmem_cache_free+0xa8/0x3d4
test_version_show+0x270/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
...
kmemleak: Cannot insert 0xf2ff000003f88000 into the object search tree (overlaps existing)
CPU: 5 PID: 178 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
create_object.isra.0+0x2d8/0x2fc
kmemleak_alloc+0x34/0x40
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
kmemleak: Kernel memory leak detector disabled
kmemleak: Object 0xf2ff000003f88000 (size 128):
kmemleak: comm "cat", pid 177, jiffies 4294921177
kmemleak: min_count = 1
kmemleak: count = 0
kmemleak: flags = 0x1
kmemleak: checksum = 0
kmemleak: backtrace:
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
kmemleak: Automatic memory scanning thread ended
[akpm@linux-foundation.org: whitespace tweak]
Link: https://lkml.kernel.org/r/20211118054426.4123-1-Kuan-Ying.Lee@mediatek.com
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-01-14 15:04:04 -07:00
|
|
|
struct kmemleak_object *object;
|
|
|
|
unsigned long untagged_objp;
|
|
|
|
|
|
|
|
object = rb_entry(rb, struct kmemleak_object, rb_node);
|
|
|
|
untagged_objp = (unsigned long)kasan_reset_tag((void *)object->pointer);
|
|
|
|
|
|
|
|
if (untagged_ptr < untagged_objp)
|
2012-10-08 16:31:27 -07:00
|
|
|
rb = object->rb_node.rb_left;
|
kmemleak: fix kmemleak false positive report with HW tag-based kasan enable
With HW tag-based kasan enable, We will get the warning when we free
object whose address starts with 0xFF.
It is because kmemleak rbtree stores tagged object and this freeing
object's tag does not match with rbtree object.
In the example below, kmemleak rbtree stores the tagged object in the
kmalloc(), and kfree() gets the pointer with 0xFF tag.
Call sequence:
ptr = kmalloc(size, GFP_KERNEL);
page = virt_to_page(ptr);
offset = offset_in_page(ptr);
kfree(page_address(page) + offset);
ptr = kmalloc(size, GFP_KERNEL);
A sequence like that may cause the warning as following:
1) Freeing unknown object:
In kfree(), we will get free unknown object warning in
kmemleak_free(). Because object(0xFx) in kmemleak rbtree and
pointer(0xFF) in kfree() have different tag.
2) Overlap existing:
When we allocate that object with the same hw-tag again, we will
find the overlap in the kmemleak rbtree and kmemleak thread will be
killed.
kmemleak: Freeing unknown object at 0xffff000003f88000
CPU: 5 PID: 177 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
kmemleak_free+0x6c/0x70
slab_free_freelist_hook+0x104/0x200
kmem_cache_free+0xa8/0x3d4
test_version_show+0x270/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
...
kmemleak: Cannot insert 0xf2ff000003f88000 into the object search tree (overlaps existing)
CPU: 5 PID: 178 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
create_object.isra.0+0x2d8/0x2fc
kmemleak_alloc+0x34/0x40
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
kmemleak: Kernel memory leak detector disabled
kmemleak: Object 0xf2ff000003f88000 (size 128):
kmemleak: comm "cat", pid 177, jiffies 4294921177
kmemleak: min_count = 1
kmemleak: count = 0
kmemleak: flags = 0x1
kmemleak: checksum = 0
kmemleak: backtrace:
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
kmemleak: Automatic memory scanning thread ended
[akpm@linux-foundation.org: whitespace tweak]
Link: https://lkml.kernel.org/r/20211118054426.4123-1-Kuan-Ying.Lee@mediatek.com
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-01-14 15:04:04 -07:00
|
|
|
else if (untagged_objp + object->size <= untagged_ptr)
|
2012-10-08 16:31:27 -07:00
|
|
|
rb = object->rb_node.rb_right;
|
kmemleak: fix kmemleak false positive report with HW tag-based kasan enable
With HW tag-based kasan enable, We will get the warning when we free
object whose address starts with 0xFF.
It is because kmemleak rbtree stores tagged object and this freeing
object's tag does not match with rbtree object.
In the example below, kmemleak rbtree stores the tagged object in the
kmalloc(), and kfree() gets the pointer with 0xFF tag.
Call sequence:
ptr = kmalloc(size, GFP_KERNEL);
page = virt_to_page(ptr);
offset = offset_in_page(ptr);
kfree(page_address(page) + offset);
ptr = kmalloc(size, GFP_KERNEL);
A sequence like that may cause the warning as following:
1) Freeing unknown object:
In kfree(), we will get free unknown object warning in
kmemleak_free(). Because object(0xFx) in kmemleak rbtree and
pointer(0xFF) in kfree() have different tag.
2) Overlap existing:
When we allocate that object with the same hw-tag again, we will
find the overlap in the kmemleak rbtree and kmemleak thread will be
killed.
kmemleak: Freeing unknown object at 0xffff000003f88000
CPU: 5 PID: 177 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
kmemleak_free+0x6c/0x70
slab_free_freelist_hook+0x104/0x200
kmem_cache_free+0xa8/0x3d4
test_version_show+0x270/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
...
kmemleak: Cannot insert 0xf2ff000003f88000 into the object search tree (overlaps existing)
CPU: 5 PID: 178 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
create_object.isra.0+0x2d8/0x2fc
kmemleak_alloc+0x34/0x40
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
kmemleak: Kernel memory leak detector disabled
kmemleak: Object 0xf2ff000003f88000 (size 128):
kmemleak: comm "cat", pid 177, jiffies 4294921177
kmemleak: min_count = 1
kmemleak: count = 0
kmemleak: flags = 0x1
kmemleak: checksum = 0
kmemleak: backtrace:
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
kmemleak: Automatic memory scanning thread ended
[akpm@linux-foundation.org: whitespace tweak]
Link: https://lkml.kernel.org/r/20211118054426.4123-1-Kuan-Ying.Lee@mediatek.com
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-01-14 15:04:04 -07:00
|
|
|
else if (untagged_objp == untagged_ptr || alias)
|
2012-10-08 16:31:27 -07:00
|
|
|
return object;
|
|
|
|
else {
|
2011-09-28 04:17:03 -07:00
|
|
|
kmemleak_warn("Found object by alias at 0x%08lx\n",
|
|
|
|
ptr);
|
2010-07-19 03:54:16 -07:00
|
|
|
dump_object_info(object);
|
2012-10-08 16:31:27 -07:00
|
|
|
break;
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
2012-10-08 16:31:27 -07:00
|
|
|
}
|
|
|
|
return NULL;
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
2022-06-10 20:55:50 -07:00
|
|
|
/* Look-up a kmemleak object which allocated with virtual address. */
|
|
|
|
static struct kmemleak_object *lookup_object(unsigned long ptr, int alias)
|
|
|
|
{
|
2023-12-01 12:08:29 -07:00
|
|
|
return __lookup_object(ptr, alias, 0);
|
2022-06-10 20:55:50 -07:00
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
|
|
|
* Increment the object use_count. Return 1 if successful or 0 otherwise. Note
|
|
|
|
* that once an object's use_count reached 0, the RCU freeing was already
|
|
|
|
* registered and the object should no longer be used. This function must be
|
|
|
|
* called under the protection of rcu_read_lock().
|
|
|
|
*/
|
|
|
|
static int get_object(struct kmemleak_object *object)
|
|
|
|
{
|
|
|
|
return atomic_inc_not_zero(&object->use_count);
|
|
|
|
}
|
|
|
|
|
2019-09-23 15:34:02 -07:00
|
|
|
/*
|
|
|
|
* Memory pool allocation and freeing. kmemleak_lock must not be held.
|
|
|
|
*/
|
|
|
|
static struct kmemleak_object *mem_pool_alloc(gfp_t gfp)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
|
|
|
|
/* try the slab allocator first */
|
2019-09-23 15:34:05 -07:00
|
|
|
if (object_cache) {
|
2024-04-25 13:55:23 -07:00
|
|
|
object = kmem_cache_alloc_noprof(object_cache, gfp_kmemleak_mask(gfp));
|
2019-09-23 15:34:05 -07:00
|
|
|
if (object)
|
|
|
|
return object;
|
|
|
|
}
|
2019-09-23 15:34:02 -07:00
|
|
|
|
|
|
|
/* slab allocation failed, try the memory pool */
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&kmemleak_lock, flags);
|
2019-09-23 15:34:02 -07:00
|
|
|
object = list_first_entry_or_null(&mem_pool_free_list,
|
|
|
|
typeof(*object), object_list);
|
|
|
|
if (object)
|
|
|
|
list_del(&object->object_list);
|
|
|
|
else if (mem_pool_free_count)
|
|
|
|
object = &mem_pool[--mem_pool_free_count];
|
2019-09-23 15:34:05 -07:00
|
|
|
else
|
|
|
|
pr_warn_once("Memory pool empty, consider increasing CONFIG_DEBUG_KMEMLEAK_MEM_POOL_SIZE\n");
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&kmemleak_lock, flags);
|
2019-09-23 15:34:02 -07:00
|
|
|
|
|
|
|
return object;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Return the object to either the slab allocator or the memory pool.
|
|
|
|
*/
|
|
|
|
static void mem_pool_free(struct kmemleak_object *object)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
if (object < mem_pool || object >= mem_pool + ARRAY_SIZE(mem_pool)) {
|
|
|
|
kmem_cache_free(object_cache, object);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* add the object to the memory pool free list */
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&kmemleak_lock, flags);
|
2019-09-23 15:34:02 -07:00
|
|
|
list_add(&object->object_list, &mem_pool_free_list);
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&kmemleak_lock, flags);
|
2019-09-23 15:34:02 -07:00
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
|
|
|
* RCU callback to free a kmemleak_object.
|
|
|
|
*/
|
|
|
|
static void free_object_rcu(struct rcu_head *rcu)
|
|
|
|
{
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-27 18:06:00 -07:00
|
|
|
struct hlist_node *tmp;
|
2009-06-11 05:22:39 -07:00
|
|
|
struct kmemleak_scan_area *area;
|
|
|
|
struct kmemleak_object *object =
|
|
|
|
container_of(rcu, struct kmemleak_object, rcu);
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Once use_count is 0 (guaranteed by put_object), there is no other
|
|
|
|
* code accessing this object, hence no need for locking.
|
|
|
|
*/
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-27 18:06:00 -07:00
|
|
|
hlist_for_each_entry_safe(area, tmp, &object->area_list, node) {
|
|
|
|
hlist_del(&area->node);
|
2009-06-11 05:22:39 -07:00
|
|
|
kmem_cache_free(scan_area_cache, area);
|
|
|
|
}
|
2019-09-23 15:34:02 -07:00
|
|
|
mem_pool_free(object);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Decrement the object use_count. Once the count is 0, free the object using
|
|
|
|
* an RCU callback. Since put_object() may be called via the kmemleak_free() ->
|
|
|
|
* delete_object() path, the delayed RCU freeing ensures that there is no
|
|
|
|
* recursive call to the kernel allocator. Lock-less RCU object_list traversal
|
|
|
|
* is also possible.
|
|
|
|
*/
|
|
|
|
static void put_object(struct kmemleak_object *object)
|
|
|
|
{
|
|
|
|
if (!atomic_dec_and_test(&object->use_count))
|
|
|
|
return;
|
|
|
|
|
|
|
|
/* should only get here after delete_object was called */
|
|
|
|
WARN_ON(object->flags & OBJECT_ALLOCATED);
|
|
|
|
|
2019-09-23 15:34:05 -07:00
|
|
|
/*
|
|
|
|
* It may be too early for the RCU callbacks, however, there is no
|
|
|
|
* concurrent object_list traversal when !object_cache and all objects
|
|
|
|
* came from the memory pool. Free the object directly.
|
|
|
|
*/
|
|
|
|
if (object_cache)
|
|
|
|
call_rcu(&object->rcu, free_object_rcu);
|
|
|
|
else
|
|
|
|
free_object_rcu(&object->rcu);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2012-10-08 16:31:27 -07:00
|
|
|
* Look up an object in the object search tree and increase its use_count.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2022-06-10 20:55:50 -07:00
|
|
|
static struct kmemleak_object *__find_and_get_object(unsigned long ptr, int alias,
|
2023-12-01 12:08:29 -07:00
|
|
|
unsigned int objflags)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
|
|
|
unsigned long flags;
|
2015-11-05 19:45:57 -07:00
|
|
|
struct kmemleak_object *object;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
rcu_read_lock();
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&kmemleak_lock, flags);
|
2023-12-01 12:08:29 -07:00
|
|
|
object = __lookup_object(ptr, alias, objflags);
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&kmemleak_lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/* check whether the object is still available */
|
|
|
|
if (object && !get_object(object))
|
|
|
|
object = NULL;
|
|
|
|
rcu_read_unlock();
|
|
|
|
|
|
|
|
return object;
|
|
|
|
}
|
|
|
|
|
2022-06-10 20:55:50 -07:00
|
|
|
/* Look up and get an object which allocated with virtual address. */
|
|
|
|
static struct kmemleak_object *find_and_get_object(unsigned long ptr, int alias)
|
|
|
|
{
|
2023-12-01 12:08:29 -07:00
|
|
|
return __find_and_get_object(ptr, alias, 0);
|
2022-06-10 20:55:50 -07:00
|
|
|
}
|
|
|
|
|
2019-10-04 06:46:24 -07:00
|
|
|
/*
|
2023-12-01 12:08:29 -07:00
|
|
|
* Remove an object from its object tree and object_list. Must be called with
|
|
|
|
* the kmemleak_lock held _if_ kmemleak is still enabled.
|
2019-10-04 06:46:24 -07:00
|
|
|
*/
|
|
|
|
static void __remove_object(struct kmemleak_object *object)
|
|
|
|
{
|
2023-12-01 12:08:29 -07:00
|
|
|
rb_erase(&object->rb_node, object_tree(object->flags));
|
2023-01-18 21:01:11 -07:00
|
|
|
if (!(object->del_state & DELSTATE_NO_DELETE))
|
|
|
|
list_del_rcu(&object->object_list);
|
|
|
|
object->del_state |= DELSTATE_REMOVED;
|
2019-10-04 06:46:24 -07:00
|
|
|
}
|
|
|
|
|
2023-10-18 03:29:51 -07:00
|
|
|
static struct kmemleak_object *__find_and_remove_object(unsigned long ptr,
|
|
|
|
int alias,
|
2023-12-01 12:08:29 -07:00
|
|
|
unsigned int objflags)
|
2023-10-18 03:29:51 -07:00
|
|
|
{
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
object = __lookup_object(ptr, alias, objflags);
|
2023-10-18 03:29:51 -07:00
|
|
|
if (object)
|
|
|
|
__remove_object(object);
|
|
|
|
|
|
|
|
return object;
|
|
|
|
}
|
|
|
|
|
2015-06-24 16:58:29 -07:00
|
|
|
/*
|
2023-12-01 12:08:29 -07:00
|
|
|
* Look up an object in the object search tree and remove it from both object
|
|
|
|
* tree root and object_list. The returned object's use_count should be at
|
|
|
|
* least 1, as initially set by create_object().
|
2015-06-24 16:58:29 -07:00
|
|
|
*/
|
2022-06-10 20:55:50 -07:00
|
|
|
static struct kmemleak_object *find_and_remove_object(unsigned long ptr, int alias,
|
2023-12-01 12:08:29 -07:00
|
|
|
unsigned int objflags)
|
2015-06-24 16:58:29 -07:00
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&kmemleak_lock, flags);
|
2023-12-01 12:08:29 -07:00
|
|
|
object = __find_and_remove_object(ptr, alias, objflags);
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&kmemleak_lock, flags);
|
2015-06-24 16:58:29 -07:00
|
|
|
|
|
|
|
return object;
|
|
|
|
}
|
|
|
|
|
2022-10-27 02:50:24 -07:00
|
|
|
static noinline depot_stack_handle_t set_track_prepare(void)
|
2009-08-27 06:29:17 -07:00
|
|
|
{
|
2022-10-27 02:50:24 -07:00
|
|
|
depot_stack_handle_t trace_handle;
|
|
|
|
unsigned long entries[MAX_TRACE];
|
|
|
|
unsigned int nr_entries;
|
|
|
|
|
2023-08-15 07:41:27 -07:00
|
|
|
/*
|
|
|
|
* Use object_cache to determine whether kmemleak_init() has
|
|
|
|
* been invoked. stack_depot_early_init() is called before
|
|
|
|
* kmemleak_init() in mm_core_init().
|
|
|
|
*/
|
|
|
|
if (!object_cache)
|
2022-10-27 02:50:24 -07:00
|
|
|
return 0;
|
|
|
|
nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 3);
|
|
|
|
trace_handle = stack_depot_save(entries, nr_entries, GFP_NOWAIT);
|
|
|
|
|
|
|
|
return trace_handle;
|
2009-08-27 06:29:17 -07:00
|
|
|
}
|
|
|
|
|
2023-10-18 03:29:49 -07:00
|
|
|
static struct kmemleak_object *__alloc_object(gfp_t gfp)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2023-10-18 03:29:49 -07:00
|
|
|
struct kmemleak_object *object;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2019-09-23 15:34:02 -07:00
|
|
|
object = mem_pool_alloc(gfp);
|
2009-06-11 05:22:39 -07:00
|
|
|
if (!object) {
|
2016-03-17 14:19:44 -07:00
|
|
|
pr_warn("Cannot allocate a kmemleak_object structure\n");
|
2011-01-27 03:30:26 -07:00
|
|
|
kmemleak_disable();
|
2023-11-15 01:21:37 -07:00
|
|
|
return NULL;
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&object->object_list);
|
|
|
|
INIT_LIST_HEAD(&object->gray_list);
|
|
|
|
INIT_HLIST_HEAD(&object->area_list);
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_init(&object->lock);
|
2009-06-11 05:22:39 -07:00
|
|
|
atomic_set(&object->use_count, 1);
|
2017-07-06 15:40:22 -07:00
|
|
|
object->excess_ref = 0;
|
2009-10-28 06:33:12 -07:00
|
|
|
object->count = 0; /* white color initially */
|
|
|
|
object->checksum = 0;
|
2023-01-18 21:01:11 -07:00
|
|
|
object->del_state = 0;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/* task information */
|
2021-09-07 19:56:12 -07:00
|
|
|
if (in_hardirq()) {
|
2009-06-11 05:22:39 -07:00
|
|
|
object->pid = 0;
|
|
|
|
strncpy(object->comm, "hardirq", sizeof(object->comm));
|
2019-07-11 20:53:39 -07:00
|
|
|
} else if (in_serving_softirq()) {
|
2009-06-11 05:22:39 -07:00
|
|
|
object->pid = 0;
|
|
|
|
strncpy(object->comm, "softirq", sizeof(object->comm));
|
|
|
|
} else {
|
|
|
|
object->pid = current->pid;
|
|
|
|
/*
|
|
|
|
* There is a small chance of a race with set_task_comm(),
|
|
|
|
* however using get_task_comm() here may cause locking
|
|
|
|
* dependency issues with current->alloc_lock. In the worst
|
|
|
|
* case, the command line is not correct.
|
|
|
|
*/
|
|
|
|
strncpy(object->comm, current->comm, sizeof(object->comm));
|
|
|
|
}
|
|
|
|
|
|
|
|
/* kernel backtrace */
|
2022-10-27 02:50:24 -07:00
|
|
|
object->trace_handle = set_track_prepare();
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2023-11-15 01:21:37 -07:00
|
|
|
return object;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int __link_object(struct kmemleak_object *object, unsigned long ptr,
|
2023-12-01 12:08:29 -07:00
|
|
|
size_t size, int min_count, unsigned int objflags)
|
2023-11-15 01:21:37 -07:00
|
|
|
{
|
|
|
|
|
|
|
|
struct kmemleak_object *parent;
|
|
|
|
struct rb_node **link, *rb_parent;
|
|
|
|
unsigned long untagged_ptr;
|
|
|
|
unsigned long untagged_objp;
|
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
object->flags = OBJECT_ALLOCATED | objflags;
|
2023-11-15 01:21:37 -07:00
|
|
|
object->pointer = ptr;
|
|
|
|
object->size = kfence_ksize((void *)ptr) ?: size;
|
|
|
|
object->min_count = min_count;
|
|
|
|
object->jiffies = jiffies;
|
|
|
|
|
2019-02-20 23:19:16 -07:00
|
|
|
untagged_ptr = (unsigned long)kasan_reset_tag((void *)ptr);
|
2022-06-10 20:55:50 -07:00
|
|
|
/*
|
|
|
|
* Only update min_addr and max_addr with object
|
|
|
|
* storing virtual address.
|
|
|
|
*/
|
2023-12-01 12:08:29 -07:00
|
|
|
if (!(objflags & (OBJECT_PHYS | OBJECT_PERCPU))) {
|
2022-06-10 20:55:50 -07:00
|
|
|
min_addr = min(min_addr, untagged_ptr);
|
|
|
|
max_addr = max(max_addr, untagged_ptr + size);
|
|
|
|
}
|
2023-12-01 12:08:29 -07:00
|
|
|
link = &object_tree(objflags)->rb_node;
|
2012-10-08 16:31:27 -07:00
|
|
|
rb_parent = NULL;
|
|
|
|
while (*link) {
|
|
|
|
rb_parent = *link;
|
|
|
|
parent = rb_entry(rb_parent, struct kmemleak_object, rb_node);
|
kmemleak: fix kmemleak false positive report with HW tag-based kasan enable
With HW tag-based kasan enable, We will get the warning when we free
object whose address starts with 0xFF.
It is because kmemleak rbtree stores tagged object and this freeing
object's tag does not match with rbtree object.
In the example below, kmemleak rbtree stores the tagged object in the
kmalloc(), and kfree() gets the pointer with 0xFF tag.
Call sequence:
ptr = kmalloc(size, GFP_KERNEL);
page = virt_to_page(ptr);
offset = offset_in_page(ptr);
kfree(page_address(page) + offset);
ptr = kmalloc(size, GFP_KERNEL);
A sequence like that may cause the warning as following:
1) Freeing unknown object:
In kfree(), we will get free unknown object warning in
kmemleak_free(). Because object(0xFx) in kmemleak rbtree and
pointer(0xFF) in kfree() have different tag.
2) Overlap existing:
When we allocate that object with the same hw-tag again, we will
find the overlap in the kmemleak rbtree and kmemleak thread will be
killed.
kmemleak: Freeing unknown object at 0xffff000003f88000
CPU: 5 PID: 177 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
kmemleak_free+0x6c/0x70
slab_free_freelist_hook+0x104/0x200
kmem_cache_free+0xa8/0x3d4
test_version_show+0x270/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
...
kmemleak: Cannot insert 0xf2ff000003f88000 into the object search tree (overlaps existing)
CPU: 5 PID: 178 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
create_object.isra.0+0x2d8/0x2fc
kmemleak_alloc+0x34/0x40
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
kmemleak: Kernel memory leak detector disabled
kmemleak: Object 0xf2ff000003f88000 (size 128):
kmemleak: comm "cat", pid 177, jiffies 4294921177
kmemleak: min_count = 1
kmemleak: count = 0
kmemleak: flags = 0x1
kmemleak: checksum = 0
kmemleak: backtrace:
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
kmemleak: Automatic memory scanning thread ended
[akpm@linux-foundation.org: whitespace tweak]
Link: https://lkml.kernel.org/r/20211118054426.4123-1-Kuan-Ying.Lee@mediatek.com
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-01-14 15:04:04 -07:00
|
|
|
untagged_objp = (unsigned long)kasan_reset_tag((void *)parent->pointer);
|
|
|
|
if (untagged_ptr + size <= untagged_objp)
|
2012-10-08 16:31:27 -07:00
|
|
|
link = &parent->rb_node.rb_left;
|
kmemleak: fix kmemleak false positive report with HW tag-based kasan enable
With HW tag-based kasan enable, We will get the warning when we free
object whose address starts with 0xFF.
It is because kmemleak rbtree stores tagged object and this freeing
object's tag does not match with rbtree object.
In the example below, kmemleak rbtree stores the tagged object in the
kmalloc(), and kfree() gets the pointer with 0xFF tag.
Call sequence:
ptr = kmalloc(size, GFP_KERNEL);
page = virt_to_page(ptr);
offset = offset_in_page(ptr);
kfree(page_address(page) + offset);
ptr = kmalloc(size, GFP_KERNEL);
A sequence like that may cause the warning as following:
1) Freeing unknown object:
In kfree(), we will get free unknown object warning in
kmemleak_free(). Because object(0xFx) in kmemleak rbtree and
pointer(0xFF) in kfree() have different tag.
2) Overlap existing:
When we allocate that object with the same hw-tag again, we will
find the overlap in the kmemleak rbtree and kmemleak thread will be
killed.
kmemleak: Freeing unknown object at 0xffff000003f88000
CPU: 5 PID: 177 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
kmemleak_free+0x6c/0x70
slab_free_freelist_hook+0x104/0x200
kmem_cache_free+0xa8/0x3d4
test_version_show+0x270/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
...
kmemleak: Cannot insert 0xf2ff000003f88000 into the object search tree (overlaps existing)
CPU: 5 PID: 178 Comm: cat Not tainted 5.16.0-rc1-dirty #21
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1ac
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
dump_stack+0x1c/0x38
create_object.isra.0+0x2d8/0x2fc
kmemleak_alloc+0x34/0x40
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
el0_svc+0x20/0x80
el0t_64_sync_handler+0x1a8/0x1b0
el0t_64_sync+0x1ac/0x1b0
kmemleak: Kernel memory leak detector disabled
kmemleak: Object 0xf2ff000003f88000 (size 128):
kmemleak: comm "cat", pid 177, jiffies 4294921177
kmemleak: min_count = 1
kmemleak: count = 0
kmemleak: flags = 0x1
kmemleak: checksum = 0
kmemleak: backtrace:
kmem_cache_alloc+0x23c/0x2f0
test_version_show+0x1fc/0x3a0
module_attr_show+0x28/0x40
sysfs_kf_seq_show+0xb0/0x130
kernfs_seq_show+0x30/0x40
seq_read_iter+0x1bc/0x4b0
kernfs_fop_read_iter+0x144/0x1c0
generic_file_splice_read+0xd0/0x184
do_splice_to+0x90/0xe0
splice_direct_to_actor+0xb8/0x250
do_splice_direct+0x88/0xd4
do_sendfile+0x2b0/0x344
__arm64_sys_sendfile64+0x164/0x16c
invoke_syscall+0x48/0x114
el0_svc_common.constprop.0+0x44/0xec
do_el0_svc+0x74/0x90
kmemleak: Automatic memory scanning thread ended
[akpm@linux-foundation.org: whitespace tweak]
Link: https://lkml.kernel.org/r/20211118054426.4123-1-Kuan-Ying.Lee@mediatek.com
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Doug Berger <opendmb@gmail.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-01-14 15:04:04 -07:00
|
|
|
else if (untagged_objp + parent->size <= untagged_ptr)
|
2012-10-08 16:31:27 -07:00
|
|
|
link = &parent->rb_node.rb_right;
|
|
|
|
else {
|
2016-03-17 14:19:47 -07:00
|
|
|
kmemleak_stop("Cannot insert 0x%lx into the object search tree (overlaps existing)\n",
|
2012-10-08 16:31:27 -07:00
|
|
|
ptr);
|
2015-06-24 16:58:34 -07:00
|
|
|
/*
|
|
|
|
* No need for parent->lock here since "parent" cannot
|
|
|
|
* be freed while the kmemleak_lock is held.
|
|
|
|
*/
|
|
|
|
dump_object_info(parent);
|
2023-10-18 03:29:50 -07:00
|
|
|
return -EEXIST;
|
2012-10-08 16:31:27 -07:00
|
|
|
}
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
2012-10-08 16:31:27 -07:00
|
|
|
rb_link_node(&object->rb_node, rb_parent, link);
|
2023-12-01 12:08:29 -07:00
|
|
|
rb_insert_color(&object->rb_node, object_tree(objflags));
|
2009-06-11 05:22:39 -07:00
|
|
|
list_add_tail_rcu(&object->object_list, &object_list);
|
2023-10-18 03:29:50 -07:00
|
|
|
|
|
|
|
return 0;
|
2023-10-18 03:29:49 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Create the metadata (struct kmemleak_object) corresponding to an allocated
|
2023-12-01 12:08:29 -07:00
|
|
|
* memory block and add it to the object_list and object tree.
|
2023-10-18 03:29:49 -07:00
|
|
|
*/
|
|
|
|
static void __create_object(unsigned long ptr, size_t size,
|
2023-12-01 12:08:29 -07:00
|
|
|
int min_count, gfp_t gfp, unsigned int objflags)
|
2023-10-18 03:29:49 -07:00
|
|
|
{
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
unsigned long flags;
|
2023-10-18 03:29:50 -07:00
|
|
|
int ret;
|
2023-10-18 03:29:49 -07:00
|
|
|
|
|
|
|
object = __alloc_object(gfp);
|
|
|
|
if (!object)
|
|
|
|
return;
|
|
|
|
|
|
|
|
raw_spin_lock_irqsave(&kmemleak_lock, flags);
|
2023-12-01 12:08:29 -07:00
|
|
|
ret = __link_object(object, ptr, size, min_count, objflags);
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&kmemleak_lock, flags);
|
2023-10-18 03:29:50 -07:00
|
|
|
if (ret)
|
|
|
|
mem_pool_free(object);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
2022-06-10 20:55:49 -07:00
|
|
|
/* Create kmemleak object which allocated with virtual address. */
|
2022-08-31 19:30:07 -07:00
|
|
|
static void create_object(unsigned long ptr, size_t size,
|
|
|
|
int min_count, gfp_t gfp)
|
2022-06-10 20:55:49 -07:00
|
|
|
{
|
2023-12-01 12:08:29 -07:00
|
|
|
__create_object(ptr, size, min_count, gfp, 0);
|
2022-06-10 20:55:49 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Create kmemleak object which allocated with physical address. */
|
2022-08-31 19:30:07 -07:00
|
|
|
static void create_object_phys(unsigned long ptr, size_t size,
|
|
|
|
int min_count, gfp_t gfp)
|
2022-06-10 20:55:49 -07:00
|
|
|
{
|
2023-12-01 12:08:29 -07:00
|
|
|
__create_object(ptr, size, min_count, gfp, OBJECT_PHYS);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Create kmemleak object corresponding to a per-CPU allocation. */
|
|
|
|
static void create_object_percpu(unsigned long ptr, size_t size,
|
|
|
|
int min_count, gfp_t gfp)
|
|
|
|
{
|
|
|
|
__create_object(ptr, size, min_count, gfp, OBJECT_PERCPU);
|
2022-06-10 20:55:49 -07:00
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
2015-06-24 16:58:29 -07:00
|
|
|
* Mark the object as not allocated and schedule RCU freeing via put_object().
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-07-07 02:33:00 -07:00
|
|
|
static void __delete_object(struct kmemleak_object *object)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
WARN_ON(!(object->flags & OBJECT_ALLOCATED));
|
2015-06-24 16:58:29 -07:00
|
|
|
WARN_ON(atomic_read(&object->use_count) < 1);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Locking here also ensures that the corresponding memory block
|
|
|
|
* cannot be freed when it is being scanned.
|
|
|
|
*/
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
object->flags &= ~OBJECT_ALLOCATED;
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
put_object(object);
|
|
|
|
}
|
|
|
|
|
2009-07-07 02:33:00 -07:00
|
|
|
/*
|
|
|
|
* Look up the metadata (struct kmemleak_object) corresponding to ptr and
|
|
|
|
* delete it.
|
|
|
|
*/
|
2023-12-01 12:08:29 -07:00
|
|
|
static void delete_object_full(unsigned long ptr, unsigned int objflags)
|
2009-07-07 02:33:00 -07:00
|
|
|
{
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
object = find_and_remove_object(ptr, 0, objflags);
|
2009-07-07 02:33:00 -07:00
|
|
|
if (!object) {
|
|
|
|
#ifdef DEBUG
|
|
|
|
kmemleak_warn("Freeing unknown object at 0x%08lx\n",
|
|
|
|
ptr);
|
|
|
|
#endif
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
__delete_object(object);
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Look up the metadata (struct kmemleak_object) corresponding to ptr and
|
|
|
|
* delete it. If the memory block is partially freed, the function may create
|
|
|
|
* additional metadata for the remaining parts of the block.
|
|
|
|
*/
|
2023-12-01 12:08:29 -07:00
|
|
|
static void delete_object_part(unsigned long ptr, size_t size,
|
|
|
|
unsigned int objflags)
|
2009-07-07 02:33:00 -07:00
|
|
|
{
|
2023-10-18 03:29:52 -07:00
|
|
|
struct kmemleak_object *object, *object_l, *object_r;
|
|
|
|
unsigned long start, end, flags;
|
|
|
|
|
|
|
|
object_l = __alloc_object(GFP_KERNEL);
|
|
|
|
if (!object_l)
|
|
|
|
return;
|
2009-07-07 02:33:00 -07:00
|
|
|
|
2023-10-18 03:29:52 -07:00
|
|
|
object_r = __alloc_object(GFP_KERNEL);
|
|
|
|
if (!object_r)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
raw_spin_lock_irqsave(&kmemleak_lock, flags);
|
2023-12-01 12:08:29 -07:00
|
|
|
object = __find_and_remove_object(ptr, 1, objflags);
|
2009-07-07 02:33:00 -07:00
|
|
|
if (!object) {
|
|
|
|
#ifdef DEBUG
|
2016-03-17 14:19:47 -07:00
|
|
|
kmemleak_warn("Partially freeing unknown object at 0x%08lx (size %zu)\n",
|
|
|
|
ptr, size);
|
2009-07-07 02:33:00 -07:00
|
|
|
#endif
|
2023-10-18 03:29:52 -07:00
|
|
|
goto unlock;
|
2009-07-07 02:33:00 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Create one or two objects that may result from the memory block
|
|
|
|
* split. Note that partial freeing is only done by free_bootmem() and
|
2019-09-23 15:34:05 -07:00
|
|
|
* this happens before kmemleak_init() is called.
|
2009-07-07 02:33:00 -07:00
|
|
|
*/
|
|
|
|
start = object->pointer;
|
|
|
|
end = object->pointer + object->size;
|
2023-10-18 03:29:52 -07:00
|
|
|
if ((ptr > start) &&
|
|
|
|
!__link_object(object_l, start, ptr - start,
|
2023-12-01 12:08:29 -07:00
|
|
|
object->min_count, objflags))
|
2023-10-18 03:29:52 -07:00
|
|
|
object_l = NULL;
|
|
|
|
if ((ptr + size < end) &&
|
|
|
|
!__link_object(object_r, ptr + size, end - ptr - size,
|
2023-12-01 12:08:29 -07:00
|
|
|
object->min_count, objflags))
|
2023-10-18 03:29:52 -07:00
|
|
|
object_r = NULL;
|
|
|
|
|
|
|
|
unlock:
|
|
|
|
raw_spin_unlock_irqrestore(&kmemleak_lock, flags);
|
|
|
|
if (object)
|
|
|
|
__delete_object(object);
|
2009-07-07 02:33:00 -07:00
|
|
|
|
2023-10-18 03:29:52 -07:00
|
|
|
out:
|
|
|
|
if (object_l)
|
|
|
|
mem_pool_free(object_l);
|
|
|
|
if (object_r)
|
|
|
|
mem_pool_free(object_r);
|
2009-07-07 02:33:00 -07:00
|
|
|
}
|
2009-09-04 17:44:52 -07:00
|
|
|
|
|
|
|
static void __paint_it(struct kmemleak_object *object, int color)
|
|
|
|
{
|
|
|
|
object->min_count = color;
|
|
|
|
if (color == KMEMLEAK_BLACK)
|
|
|
|
object->flags |= OBJECT_NO_SCAN;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void paint_it(struct kmemleak_object *object, int color)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
|
|
|
unsigned long flags;
|
2009-09-04 17:44:52 -07:00
|
|
|
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2009-09-04 17:44:52 -07:00
|
|
|
__paint_it(object, color);
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2009-09-04 17:44:52 -07:00
|
|
|
}
|
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
static void paint_ptr(unsigned long ptr, int color, unsigned int objflags)
|
2009-09-04 17:44:52 -07:00
|
|
|
{
|
2009-06-11 05:22:39 -07:00
|
|
|
struct kmemleak_object *object;
|
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
object = __find_and_get_object(ptr, 0, objflags);
|
2009-06-11 05:22:39 -07:00
|
|
|
if (!object) {
|
2016-03-17 14:19:47 -07:00
|
|
|
kmemleak_warn("Trying to color unknown object at 0x%08lx as %s\n",
|
|
|
|
ptr,
|
2009-09-04 17:44:52 -07:00
|
|
|
(color == KMEMLEAK_GREY) ? "Grey" :
|
|
|
|
(color == KMEMLEAK_BLACK) ? "Black" : "Unknown");
|
2009-06-11 05:22:39 -07:00
|
|
|
return;
|
|
|
|
}
|
2009-09-04 17:44:52 -07:00
|
|
|
paint_it(object, color);
|
2009-06-11 05:22:39 -07:00
|
|
|
put_object(object);
|
|
|
|
}
|
|
|
|
|
2009-09-04 17:44:52 -07:00
|
|
|
/*
|
2010-07-22 04:54:13 -07:00
|
|
|
* Mark an object permanently as gray-colored so that it can no longer be
|
2009-09-04 17:44:52 -07:00
|
|
|
* reported as a leak. This is used in general to mark a false positive.
|
|
|
|
*/
|
|
|
|
static void make_gray_object(unsigned long ptr)
|
|
|
|
{
|
2023-12-01 12:08:29 -07:00
|
|
|
paint_ptr(ptr, KMEMLEAK_GREY, 0);
|
2009-09-04 17:44:52 -07:00
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
|
|
|
* Mark the object as black-colored so that it is ignored from scans and
|
|
|
|
* reporting.
|
|
|
|
*/
|
2023-12-01 12:08:29 -07:00
|
|
|
static void make_black_object(unsigned long ptr, unsigned int objflags)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2023-12-01 12:08:29 -07:00
|
|
|
paint_ptr(ptr, KMEMLEAK_BLACK, objflags);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Add a scanning area to the object. If at least one such area is added,
|
|
|
|
* kmemleak will only scan these ranges rather than the whole memory block.
|
|
|
|
*/
|
2009-10-28 06:33:09 -07:00
|
|
|
static void add_scan_area(unsigned long ptr, size_t size, gfp_t gfp)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
struct kmemleak_object *object;
|
2019-09-23 15:34:05 -07:00
|
|
|
struct kmemleak_scan_area *area = NULL;
|
2022-04-01 11:28:54 -07:00
|
|
|
unsigned long untagged_ptr;
|
|
|
|
unsigned long untagged_objp;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2009-10-28 06:33:09 -07:00
|
|
|
object = find_and_get_object(ptr, 1);
|
2009-06-11 05:22:39 -07:00
|
|
|
if (!object) {
|
2009-06-23 06:40:26 -07:00
|
|
|
kmemleak_warn("Adding scan area to unknown object at 0x%08lx\n",
|
|
|
|
ptr);
|
2009-06-11 05:22:39 -07:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2022-04-01 11:28:54 -07:00
|
|
|
untagged_ptr = (unsigned long)kasan_reset_tag((void *)ptr);
|
|
|
|
untagged_objp = (unsigned long)kasan_reset_tag((void *)object->pointer);
|
|
|
|
|
2019-09-23 15:34:05 -07:00
|
|
|
if (scan_area_cache)
|
2024-04-25 13:55:23 -07:00
|
|
|
area = kmem_cache_alloc_noprof(scan_area_cache, gfp_kmemleak_mask(gfp));
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2019-09-23 15:33:59 -07:00
|
|
|
if (!area) {
|
|
|
|
pr_warn_once("Cannot allocate a scan area, scanning the full object\n");
|
|
|
|
/* mark the object for full scan to avoid false positives */
|
|
|
|
object->flags |= OBJECT_FULL_SCAN;
|
|
|
|
goto out_unlock;
|
|
|
|
}
|
2013-11-12 16:07:45 -07:00
|
|
|
if (size == SIZE_MAX) {
|
2022-04-01 11:28:54 -07:00
|
|
|
size = untagged_objp + object->size - untagged_ptr;
|
|
|
|
} else if (untagged_ptr + size > untagged_objp + object->size) {
|
2009-06-23 06:40:26 -07:00
|
|
|
kmemleak_warn("Scan area larger than object 0x%08lx\n", ptr);
|
2009-06-11 05:22:39 -07:00
|
|
|
dump_object_info(object);
|
|
|
|
kmem_cache_free(scan_area_cache, area);
|
|
|
|
goto out_unlock;
|
|
|
|
}
|
|
|
|
|
|
|
|
INIT_HLIST_NODE(&area->node);
|
2009-10-28 06:33:09 -07:00
|
|
|
area->start = ptr;
|
|
|
|
area->size = size;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
hlist_add_head(&area->node, &object->area_list);
|
|
|
|
out_unlock:
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
put_object(object);
|
|
|
|
}
|
|
|
|
|
2017-07-06 15:40:22 -07:00
|
|
|
/*
|
|
|
|
* Any surplus references (object already gray) to 'ptr' are passed to
|
|
|
|
* 'excess_ref'. This is used in the vmalloc() case where a pointer to
|
|
|
|
* vm_struct may be used as an alternative reference to the vmalloc'ed object
|
|
|
|
* (see free_thread_stack()).
|
|
|
|
*/
|
|
|
|
static void object_set_excess_ref(unsigned long ptr, unsigned long excess_ref)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
|
|
|
|
object = find_and_get_object(ptr, 0);
|
|
|
|
if (!object) {
|
|
|
|
kmemleak_warn("Setting excess_ref on unknown object at 0x%08lx\n",
|
|
|
|
ptr);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2017-07-06 15:40:22 -07:00
|
|
|
object->excess_ref = excess_ref;
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2017-07-06 15:40:22 -07:00
|
|
|
put_object(object);
|
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
|
|
|
* Set the OBJECT_NO_SCAN flag for the object corresponding to the give
|
|
|
|
* pointer. Such object will not be scanned by kmemleak but references to it
|
|
|
|
* are searched.
|
|
|
|
*/
|
|
|
|
static void object_no_scan(unsigned long ptr)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
|
|
|
|
object = find_and_get_object(ptr, 0);
|
|
|
|
if (!object) {
|
2009-06-23 06:40:26 -07:00
|
|
|
kmemleak_warn("Not scanning unknown object at 0x%08lx\n", ptr);
|
2009-06-11 05:22:39 -07:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
object->flags |= OBJECT_NO_SCAN;
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
put_object(object);
|
|
|
|
}
|
|
|
|
|
2010-07-19 03:54:17 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_alloc - register a newly allocated object
|
|
|
|
* @ptr: pointer to beginning of the object
|
|
|
|
* @size: size of the object
|
|
|
|
* @min_count: minimum number of references to this object. If during memory
|
|
|
|
* scanning a number of references less than @min_count is found,
|
|
|
|
* the object is reported as a memory leak. If @min_count is 0,
|
|
|
|
* the object is never reported as a leak. If @min_count is -1,
|
|
|
|
* the object is ignored (not scanned and not reported as a leak)
|
|
|
|
* @gfp: kmalloc() flags used for kmemleak internal memory allocations
|
|
|
|
*
|
|
|
|
* This function is called from the kernel allocators when a new object
|
2017-07-06 15:40:22 -07:00
|
|
|
* (memory block) is allocated (kmem_cache_alloc, kmalloc etc.).
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-08-27 06:29:16 -07:00
|
|
|
void __ref kmemleak_alloc(const void *ptr, size_t size, int min_count,
|
|
|
|
gfp_t gfp)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px, %zu, %d)\n", __func__, ptr, size, min_count);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2014-04-03 14:46:29 -07:00
|
|
|
if (kmemleak_enabled && ptr && !IS_ERR(ptr))
|
2009-06-11 05:22:39 -07:00
|
|
|
create_object((unsigned long)ptr, size, min_count, gfp);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(kmemleak_alloc);
|
|
|
|
|
2011-09-26 09:12:53 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_alloc_percpu - register a newly allocated __percpu object
|
|
|
|
* @ptr: __percpu pointer to beginning of the object
|
|
|
|
* @size: size of the object
|
2015-06-24 16:58:51 -07:00
|
|
|
* @gfp: flags used for kmemleak internal memory allocations
|
2011-09-26 09:12:53 -07:00
|
|
|
*
|
|
|
|
* This function is called from the kernel percpu allocator when a new object
|
2015-06-24 16:58:51 -07:00
|
|
|
* (memory block) is allocated (alloc_percpu).
|
2011-09-26 09:12:53 -07:00
|
|
|
*/
|
2015-06-24 16:58:51 -07:00
|
|
|
void __ref kmemleak_alloc_percpu(const void __percpu *ptr, size_t size,
|
|
|
|
gfp_t gfp)
|
2011-09-26 09:12:53 -07:00
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px, %zu)\n", __func__, ptr, size);
|
2011-09-26 09:12:53 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Percpu allocations are only scanned and not reported as leaks
|
|
|
|
* (min_count is set to 0).
|
|
|
|
*/
|
2014-04-03 14:46:29 -07:00
|
|
|
if (kmemleak_enabled && ptr && !IS_ERR(ptr))
|
2023-12-01 12:08:29 -07:00
|
|
|
create_object_percpu((unsigned long)ptr, size, 0, gfp);
|
2011-09-26 09:12:53 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(kmemleak_alloc_percpu);
|
|
|
|
|
2017-07-06 15:40:22 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_vmalloc - register a newly vmalloc'ed object
|
|
|
|
* @area: pointer to vm_struct
|
|
|
|
* @size: size of the object
|
|
|
|
* @gfp: __vmalloc() flags used for kmemleak internal memory allocations
|
|
|
|
*
|
|
|
|
* This function is called from the vmalloc() kernel allocator when a new
|
|
|
|
* object (memory block) is allocated.
|
|
|
|
*/
|
|
|
|
void __ref kmemleak_vmalloc(const struct vm_struct *area, size_t size, gfp_t gfp)
|
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px, %zu)\n", __func__, area, size);
|
2017-07-06 15:40:22 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* A min_count = 2 is needed because vm_struct contains a reference to
|
|
|
|
* the virtual address of the vmalloc'ed block.
|
|
|
|
*/
|
|
|
|
if (kmemleak_enabled) {
|
|
|
|
create_object((unsigned long)area->addr, size, 2, gfp);
|
|
|
|
object_set_excess_ref((unsigned long)area,
|
|
|
|
(unsigned long)area->addr);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(kmemleak_vmalloc);
|
|
|
|
|
2010-07-19 03:54:17 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_free - unregister a previously registered object
|
|
|
|
* @ptr: pointer to beginning of the object
|
|
|
|
*
|
|
|
|
* This function is called from the kernel allocators when an object (memory
|
|
|
|
* block) is freed (kmem_cache_free, kfree, vfree etc.).
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-08-27 06:29:16 -07:00
|
|
|
void __ref kmemleak_free(const void *ptr)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, ptr);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2015-06-24 16:58:26 -07:00
|
|
|
if (kmemleak_free_enabled && ptr && !IS_ERR(ptr))
|
2023-12-01 12:08:29 -07:00
|
|
|
delete_object_full((unsigned long)ptr, 0);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(kmemleak_free);
|
|
|
|
|
2010-07-19 03:54:17 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_free_part - partially unregister a previously registered object
|
|
|
|
* @ptr: pointer to the beginning or inside the object. This also
|
|
|
|
* represents the start of the range to be freed
|
|
|
|
* @size: size to be unregistered
|
|
|
|
*
|
|
|
|
* This function is called when only a part of a memory block is freed
|
|
|
|
* (usually from the bootmem allocator).
|
2009-07-07 02:33:00 -07:00
|
|
|
*/
|
2009-08-27 06:29:16 -07:00
|
|
|
void __ref kmemleak_free_part(const void *ptr, size_t size)
|
2009-07-07 02:33:00 -07:00
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, ptr);
|
2009-07-07 02:33:00 -07:00
|
|
|
|
2014-04-03 14:46:29 -07:00
|
|
|
if (kmemleak_enabled && ptr && !IS_ERR(ptr))
|
2023-12-01 12:08:29 -07:00
|
|
|
delete_object_part((unsigned long)ptr, size, 0);
|
2009-07-07 02:33:00 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(kmemleak_free_part);
|
|
|
|
|
2011-09-26 09:12:53 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_free_percpu - unregister a previously registered __percpu object
|
|
|
|
* @ptr: __percpu pointer to beginning of the object
|
|
|
|
*
|
|
|
|
* This function is called from the kernel percpu allocator when an object
|
|
|
|
* (memory block) is freed (free_percpu).
|
|
|
|
*/
|
|
|
|
void __ref kmemleak_free_percpu(const void __percpu *ptr)
|
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, ptr);
|
2011-09-26 09:12:53 -07:00
|
|
|
|
2015-06-24 16:58:26 -07:00
|
|
|
if (kmemleak_free_enabled && ptr && !IS_ERR(ptr))
|
2023-12-01 12:08:29 -07:00
|
|
|
delete_object_full((unsigned long)ptr, OBJECT_PERCPU);
|
2011-09-26 09:12:53 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL_GPL(kmemleak_free_percpu);
|
|
|
|
|
2014-06-06 14:38:17 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_update_trace - update object allocation stack trace
|
|
|
|
* @ptr: pointer to beginning of the object
|
|
|
|
*
|
|
|
|
* Override the object allocation stack trace for cases where the actual
|
|
|
|
* allocation place is not always useful.
|
|
|
|
*/
|
|
|
|
void __ref kmemleak_update_trace(const void *ptr)
|
|
|
|
{
|
|
|
|
struct kmemleak_object *object;
|
2023-11-15 01:21:38 -07:00
|
|
|
depot_stack_handle_t trace_handle;
|
2014-06-06 14:38:17 -07:00
|
|
|
unsigned long flags;
|
|
|
|
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, ptr);
|
2014-06-06 14:38:17 -07:00
|
|
|
|
|
|
|
if (!kmemleak_enabled || IS_ERR_OR_NULL(ptr))
|
|
|
|
return;
|
|
|
|
|
|
|
|
object = find_and_get_object((unsigned long)ptr, 1);
|
|
|
|
if (!object) {
|
|
|
|
#ifdef DEBUG
|
|
|
|
kmemleak_warn("Updating stack trace for unknown object at %p\n",
|
|
|
|
ptr);
|
|
|
|
#endif
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2023-11-15 01:21:38 -07:00
|
|
|
trace_handle = set_track_prepare();
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2023-11-15 01:21:38 -07:00
|
|
|
object->trace_handle = trace_handle;
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2014-06-06 14:38:17 -07:00
|
|
|
|
|
|
|
put_object(object);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(kmemleak_update_trace);
|
|
|
|
|
2010-07-19 03:54:17 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_not_leak - mark an allocated object as false positive
|
|
|
|
* @ptr: pointer to beginning of the object
|
|
|
|
*
|
|
|
|
* Calling this function on an object will cause the memory block to no longer
|
|
|
|
* be reported as leak and always be scanned.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-08-27 06:29:16 -07:00
|
|
|
void __ref kmemleak_not_leak(const void *ptr)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, ptr);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2014-04-03 14:46:29 -07:00
|
|
|
if (kmemleak_enabled && ptr && !IS_ERR(ptr))
|
2009-06-11 05:22:39 -07:00
|
|
|
make_gray_object((unsigned long)ptr);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(kmemleak_not_leak);
|
|
|
|
|
2010-07-19 03:54:17 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_ignore - ignore an allocated object
|
|
|
|
* @ptr: pointer to beginning of the object
|
|
|
|
*
|
|
|
|
* Calling this function on an object will cause the memory block to be
|
|
|
|
* ignored (not scanned and not reported as a leak). This is usually done when
|
|
|
|
* it is known that the corresponding block is not a leak and does not contain
|
|
|
|
* any references to other allocated memory blocks.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-08-27 06:29:16 -07:00
|
|
|
void __ref kmemleak_ignore(const void *ptr)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, ptr);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2014-04-03 14:46:29 -07:00
|
|
|
if (kmemleak_enabled && ptr && !IS_ERR(ptr))
|
2023-12-01 12:08:29 -07:00
|
|
|
make_black_object((unsigned long)ptr, 0);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(kmemleak_ignore);
|
|
|
|
|
2010-07-19 03:54:17 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_scan_area - limit the range to be scanned in an allocated object
|
|
|
|
* @ptr: pointer to beginning or inside the object. This also
|
|
|
|
* represents the start of the scan area
|
|
|
|
* @size: size of the scan area
|
|
|
|
* @gfp: kmalloc() flags used for kmemleak internal memory allocations
|
|
|
|
*
|
|
|
|
* This function is used when it is known that only certain parts of an object
|
|
|
|
* contain references to other objects. Kmemleak will only scan these areas
|
|
|
|
* reducing the number false negatives.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-10-28 06:33:09 -07:00
|
|
|
void __ref kmemleak_scan_area(const void *ptr, size_t size, gfp_t gfp)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, ptr);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2014-04-03 14:46:29 -07:00
|
|
|
if (kmemleak_enabled && ptr && size && !IS_ERR(ptr))
|
2009-10-28 06:33:09 -07:00
|
|
|
add_scan_area((unsigned long)ptr, size, gfp);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(kmemleak_scan_area);
|
|
|
|
|
2010-07-19 03:54:17 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_no_scan - do not scan an allocated object
|
|
|
|
* @ptr: pointer to beginning of the object
|
|
|
|
*
|
|
|
|
* This function notifies kmemleak not to scan the given memory block. Useful
|
|
|
|
* in situations where it is known that the given object does not contain any
|
|
|
|
* references to other objects. Kmemleak will not scan such objects reducing
|
|
|
|
* the number of false negatives.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-08-27 06:29:16 -07:00
|
|
|
void __ref kmemleak_no_scan(const void *ptr)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, ptr);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2014-04-03 14:46:29 -07:00
|
|
|
if (kmemleak_enabled && ptr && !IS_ERR(ptr))
|
2009-06-11 05:22:39 -07:00
|
|
|
object_no_scan((unsigned long)ptr);
|
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(kmemleak_no_scan);
|
|
|
|
|
2016-10-11 13:55:11 -07:00
|
|
|
/**
|
|
|
|
* kmemleak_alloc_phys - similar to kmemleak_alloc but taking a physical
|
|
|
|
* address argument
|
2018-04-05 16:24:57 -07:00
|
|
|
* @phys: physical address of the object
|
|
|
|
* @size: size of the object
|
|
|
|
* @gfp: kmalloc() flags used for kmemleak internal memory allocations
|
2016-10-11 13:55:11 -07:00
|
|
|
*/
|
2022-06-10 20:55:48 -07:00
|
|
|
void __ref kmemleak_alloc_phys(phys_addr_t phys, size_t size, gfp_t gfp)
|
2016-10-11 13:55:11 -07:00
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px, %zu)\n", __func__, &phys, size);
|
2022-06-10 20:55:49 -07:00
|
|
|
|
2022-06-10 20:55:51 -07:00
|
|
|
if (kmemleak_enabled)
|
2022-06-10 20:55:49 -07:00
|
|
|
/*
|
|
|
|
* Create object with OBJECT_PHYS flag and
|
|
|
|
* assume min_count 0.
|
|
|
|
*/
|
2022-06-10 20:55:50 -07:00
|
|
|
create_object_phys((unsigned long)phys, size, 0, gfp);
|
2016-10-11 13:55:11 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(kmemleak_alloc_phys);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* kmemleak_free_part_phys - similar to kmemleak_free_part but taking a
|
|
|
|
* physical address argument
|
2018-04-05 16:24:57 -07:00
|
|
|
* @phys: physical address if the beginning or inside an object. This
|
|
|
|
* also represents the start of the range to be freed
|
|
|
|
* @size: size to be unregistered
|
2016-10-11 13:55:11 -07:00
|
|
|
*/
|
|
|
|
void __ref kmemleak_free_part_phys(phys_addr_t phys, size_t size)
|
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, &phys);
|
2022-06-10 20:55:50 -07:00
|
|
|
|
2022-06-10 20:55:51 -07:00
|
|
|
if (kmemleak_enabled)
|
2023-12-01 12:08:29 -07:00
|
|
|
delete_object_part((unsigned long)phys, size, OBJECT_PHYS);
|
2016-10-11 13:55:11 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(kmemleak_free_part_phys);
|
|
|
|
|
|
|
|
/**
|
|
|
|
* kmemleak_ignore_phys - similar to kmemleak_ignore but taking a physical
|
|
|
|
* address argument
|
2018-04-05 16:24:57 -07:00
|
|
|
* @phys: physical address of the object
|
2016-10-11 13:55:11 -07:00
|
|
|
*/
|
|
|
|
void __ref kmemleak_ignore_phys(phys_addr_t phys)
|
|
|
|
{
|
2023-10-18 03:29:48 -07:00
|
|
|
pr_debug("%s(0x%px)\n", __func__, &phys);
|
2022-06-10 20:55:50 -07:00
|
|
|
|
2022-06-10 20:55:51 -07:00
|
|
|
if (kmemleak_enabled)
|
2023-12-01 12:08:29 -07:00
|
|
|
make_black_object((unsigned long)phys, OBJECT_PHYS);
|
2016-10-11 13:55:11 -07:00
|
|
|
}
|
|
|
|
EXPORT_SYMBOL(kmemleak_ignore_phys);
|
|
|
|
|
2009-10-28 06:33:12 -07:00
|
|
|
/*
|
|
|
|
* Update an object's checksum and return true if it was modified.
|
|
|
|
*/
|
|
|
|
static bool update_checksum(struct kmemleak_object *object)
|
|
|
|
{
|
|
|
|
u32 old_csum = object->checksum;
|
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
if (WARN_ON_ONCE(object->flags & (OBJECT_PHYS | OBJECT_PERCPU)))
|
2022-06-10 20:55:50 -07:00
|
|
|
return false;
|
|
|
|
|
2015-02-13 15:39:49 -07:00
|
|
|
kasan_disable_current();
|
2020-08-14 17:31:14 -07:00
|
|
|
kcsan_disable_current();
|
kasan, kmemleak: reset tags when scanning block
Patch series "kasan, slub: reset tag when printing address", v3.
With hardware tag-based kasan enabled, we reset the tag when we access
metadata to avoid from false alarm.
This patch (of 2):
Kmemleak needs to scan kernel memory to check memory leak. With hardware
tag-based kasan enabled, when it scans on the invalid slab and
dereference, the issue will occur as below.
Hardware tag-based KASAN doesn't use compiler instrumentation, we can not
use kasan_disable_current() to ignore tag check.
Based on the below report, there are 11 0xf7 granules, which amounts to
176 bytes, and the object is allocated from the kmalloc-256 cache. So
when kmemleak accesses the last 256-176 bytes, it causes faults, as those
are marked with KASAN_KMALLOC_REDZONE == KASAN_TAG_INVALID == 0xfe.
Thus, we reset tags before accessing metadata to avoid from false positives.
BUG: KASAN: out-of-bounds in scan_block+0x58/0x170
Read at addr f7ff0000c0074eb0 by task kmemleak/138
Pointer tag: [f7], memory tag: [fe]
CPU: 7 PID: 138 Comm: kmemleak Not tainted 5.14.0-rc2-00001-g8cae8cd89f05-dirty #134
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1b0
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
print_address_description+0x7c/0x2b4
kasan_report+0x138/0x38c
__do_kernel_fault+0x190/0x1c4
do_tag_check_fault+0x78/0x90
do_mem_abort+0x44/0xb4
el1_abort+0x40/0x60
el1h_64_sync_handler+0xb4/0xd0
el1h_64_sync+0x78/0x7c
scan_block+0x58/0x170
scan_gray_list+0xdc/0x1a0
kmemleak_scan+0x2ac/0x560
kmemleak_scan_thread+0xb0/0xe0
kthread+0x154/0x160
ret_from_fork+0x10/0x18
Allocated by task 0:
kasan_save_stack+0x2c/0x60
__kasan_kmalloc+0xec/0x104
__kmalloc+0x224/0x3c4
__register_sysctl_paths+0x200/0x290
register_sysctl_table+0x2c/0x40
sysctl_init+0x20/0x34
proc_sys_init+0x3c/0x48
proc_root_init+0x80/0x9c
start_kernel+0x648/0x6a4
__primary_switched+0xc0/0xc8
Freed by task 0:
kasan_save_stack+0x2c/0x60
kasan_set_track+0x2c/0x40
kasan_set_free_info+0x44/0x54
____kasan_slab_free.constprop.0+0x150/0x1b0
__kasan_slab_free+0x14/0x20
slab_free_freelist_hook+0xa4/0x1fc
kfree+0x1e8/0x30c
put_fs_context+0x124/0x220
vfs_kern_mount.part.0+0x60/0xd4
kern_mount+0x24/0x4c
bdev_cache_init+0x70/0x9c
vfs_caches_init+0xdc/0xf4
start_kernel+0x638/0x6a4
__primary_switched+0xc0/0xc8
The buggy address belongs to the object at ffff0000c0074e00
which belongs to the cache kmalloc-256 of size 256
The buggy address is located 176 bytes inside of
256-byte region [ffff0000c0074e00, ffff0000c0074f00)
The buggy address belongs to the page:
page:(____ptrval____) refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x100074
head:(____ptrval____) order:2 compound_mapcount:0 compound_pincount:0
flags: 0xbfffc0000010200(slab|head|node=0|zone=2|lastcpupid=0xffff|kasantag=0x0)
raw: 0bfffc0000010200 0000000000000000 dead000000000122 f5ff0000c0002300
raw: 0000000000000000 0000000000200020 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff0000c0074c00: f0 f0 f0 f0 f0 f0 f0 f0 f0 fe fe fe fe fe fe fe
ffff0000c0074d00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
>ffff0000c0074e00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 fe fe fe fe fe
^
ffff0000c0074f00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
ffff0000c0075000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================
Disabling lock debugging due to kernel taint
kmemleak: 181 new suspected memory leaks (see /sys/kernel/debug/kmemleak)
Link: https://lkml.kernel.org/r/20210804090957.12393-1-Kuan-Ying.Lee@mediatek.com
Link: https://lkml.kernel.org/r/20210804090957.12393-2-Kuan-Ying.Lee@mediatek.com
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Marco Elver <elver@google.com>
Cc: Nicholas Tang <nicholas.tang@mediatek.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Chinwen Chang <chinwen.chang@mediatek.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2021-08-13 16:54:24 -07:00
|
|
|
object->checksum = crc32(0, kasan_reset_tag((void *)object->pointer), object->size);
|
2015-02-13 15:39:49 -07:00
|
|
|
kasan_enable_current();
|
2020-08-14 17:31:14 -07:00
|
|
|
kcsan_enable_current();
|
2015-02-13 15:39:49 -07:00
|
|
|
|
2009-10-28 06:33:12 -07:00
|
|
|
return object->checksum != old_csum;
|
|
|
|
}
|
|
|
|
|
2017-07-06 15:40:19 -07:00
|
|
|
/*
|
|
|
|
* Update an object's references. object->lock must be held by the caller.
|
|
|
|
*/
|
|
|
|
static void update_refs(struct kmemleak_object *object)
|
|
|
|
{
|
|
|
|
if (!color_white(object)) {
|
|
|
|
/* non-orphan, ignored or new */
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Increase the object's reference count (number of pointers to the
|
|
|
|
* memory block). If this count reaches the required minimum, the
|
|
|
|
* object's color will become gray and it will be added to the
|
|
|
|
* gray_list.
|
|
|
|
*/
|
|
|
|
object->count++;
|
|
|
|
if (color_gray(object)) {
|
|
|
|
/* put_object() called when removing from gray_list */
|
|
|
|
WARN_ON(!get_object(object));
|
|
|
|
list_add_tail(&object->gray_list, &gray_list);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
2021-04-29 22:54:54 -07:00
|
|
|
* Memory scanning is a long process and it needs to be interruptible. This
|
2011-03-30 18:57:33 -07:00
|
|
|
* function checks whether such interrupt condition occurred.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
|
|
|
static int scan_should_stop(void)
|
|
|
|
{
|
2014-04-03 14:46:29 -07:00
|
|
|
if (!kmemleak_enabled)
|
2009-06-11 05:22:39 -07:00
|
|
|
return 1;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* This function may be called from either process or kthread context,
|
|
|
|
* hence the need to check for both stop conditions.
|
|
|
|
*/
|
|
|
|
if (current->mm)
|
|
|
|
return signal_pending(current);
|
|
|
|
else
|
|
|
|
return kthread_should_stop();
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Scan a memory block (exclusive range) for valid pointers and add those
|
|
|
|
* found to the gray list.
|
|
|
|
*/
|
|
|
|
static void scan_block(void *_start, void *_end,
|
2015-06-24 16:58:37 -07:00
|
|
|
struct kmemleak_object *scanned)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
|
|
|
unsigned long *ptr;
|
|
|
|
unsigned long *start = PTR_ALIGN(_start, BYTES_PER_POINTER);
|
|
|
|
unsigned long *end = _end - (BYTES_PER_POINTER - 1);
|
2015-06-24 16:58:37 -07:00
|
|
|
unsigned long flags;
|
2019-02-20 23:19:16 -07:00
|
|
|
unsigned long untagged_ptr;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&kmemleak_lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
for (ptr = start; ptr < end; ptr++) {
|
|
|
|
struct kmemleak_object *object;
|
2009-08-27 06:50:00 -07:00
|
|
|
unsigned long pointer;
|
2017-07-06 15:40:22 -07:00
|
|
|
unsigned long excess_ref;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
if (scan_should_stop())
|
|
|
|
break;
|
|
|
|
|
2015-02-13 15:39:49 -07:00
|
|
|
kasan_disable_current();
|
kasan, kmemleak: reset tags when scanning block
Patch series "kasan, slub: reset tag when printing address", v3.
With hardware tag-based kasan enabled, we reset the tag when we access
metadata to avoid from false alarm.
This patch (of 2):
Kmemleak needs to scan kernel memory to check memory leak. With hardware
tag-based kasan enabled, when it scans on the invalid slab and
dereference, the issue will occur as below.
Hardware tag-based KASAN doesn't use compiler instrumentation, we can not
use kasan_disable_current() to ignore tag check.
Based on the below report, there are 11 0xf7 granules, which amounts to
176 bytes, and the object is allocated from the kmalloc-256 cache. So
when kmemleak accesses the last 256-176 bytes, it causes faults, as those
are marked with KASAN_KMALLOC_REDZONE == KASAN_TAG_INVALID == 0xfe.
Thus, we reset tags before accessing metadata to avoid from false positives.
BUG: KASAN: out-of-bounds in scan_block+0x58/0x170
Read at addr f7ff0000c0074eb0 by task kmemleak/138
Pointer tag: [f7], memory tag: [fe]
CPU: 7 PID: 138 Comm: kmemleak Not tainted 5.14.0-rc2-00001-g8cae8cd89f05-dirty #134
Hardware name: linux,dummy-virt (DT)
Call trace:
dump_backtrace+0x0/0x1b0
show_stack+0x1c/0x30
dump_stack_lvl+0x68/0x84
print_address_description+0x7c/0x2b4
kasan_report+0x138/0x38c
__do_kernel_fault+0x190/0x1c4
do_tag_check_fault+0x78/0x90
do_mem_abort+0x44/0xb4
el1_abort+0x40/0x60
el1h_64_sync_handler+0xb4/0xd0
el1h_64_sync+0x78/0x7c
scan_block+0x58/0x170
scan_gray_list+0xdc/0x1a0
kmemleak_scan+0x2ac/0x560
kmemleak_scan_thread+0xb0/0xe0
kthread+0x154/0x160
ret_from_fork+0x10/0x18
Allocated by task 0:
kasan_save_stack+0x2c/0x60
__kasan_kmalloc+0xec/0x104
__kmalloc+0x224/0x3c4
__register_sysctl_paths+0x200/0x290
register_sysctl_table+0x2c/0x40
sysctl_init+0x20/0x34
proc_sys_init+0x3c/0x48
proc_root_init+0x80/0x9c
start_kernel+0x648/0x6a4
__primary_switched+0xc0/0xc8
Freed by task 0:
kasan_save_stack+0x2c/0x60
kasan_set_track+0x2c/0x40
kasan_set_free_info+0x44/0x54
____kasan_slab_free.constprop.0+0x150/0x1b0
__kasan_slab_free+0x14/0x20
slab_free_freelist_hook+0xa4/0x1fc
kfree+0x1e8/0x30c
put_fs_context+0x124/0x220
vfs_kern_mount.part.0+0x60/0xd4
kern_mount+0x24/0x4c
bdev_cache_init+0x70/0x9c
vfs_caches_init+0xdc/0xf4
start_kernel+0x638/0x6a4
__primary_switched+0xc0/0xc8
The buggy address belongs to the object at ffff0000c0074e00
which belongs to the cache kmalloc-256 of size 256
The buggy address is located 176 bytes inside of
256-byte region [ffff0000c0074e00, ffff0000c0074f00)
The buggy address belongs to the page:
page:(____ptrval____) refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x100074
head:(____ptrval____) order:2 compound_mapcount:0 compound_pincount:0
flags: 0xbfffc0000010200(slab|head|node=0|zone=2|lastcpupid=0xffff|kasantag=0x0)
raw: 0bfffc0000010200 0000000000000000 dead000000000122 f5ff0000c0002300
raw: 0000000000000000 0000000000200020 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
ffff0000c0074c00: f0 f0 f0 f0 f0 f0 f0 f0 f0 fe fe fe fe fe fe fe
ffff0000c0074d00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
>ffff0000c0074e00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 fe fe fe fe fe
^
ffff0000c0074f00: fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe fe
ffff0000c0075000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================
Disabling lock debugging due to kernel taint
kmemleak: 181 new suspected memory leaks (see /sys/kernel/debug/kmemleak)
Link: https://lkml.kernel.org/r/20210804090957.12393-1-Kuan-Ying.Lee@mediatek.com
Link: https://lkml.kernel.org/r/20210804090957.12393-2-Kuan-Ying.Lee@mediatek.com
Signed-off-by: Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Marco Elver <elver@google.com>
Cc: Nicholas Tang <nicholas.tang@mediatek.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Alexander Potapenko <glider@google.com>
Cc: Chinwen Chang <chinwen.chang@mediatek.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2021-08-13 16:54:24 -07:00
|
|
|
pointer = *(unsigned long *)kasan_reset_tag((void *)ptr);
|
2015-02-13 15:39:49 -07:00
|
|
|
kasan_enable_current();
|
2009-08-27 06:50:00 -07:00
|
|
|
|
2019-02-20 23:19:16 -07:00
|
|
|
untagged_ptr = (unsigned long)kasan_reset_tag((void *)pointer);
|
|
|
|
if (untagged_ptr < min_addr || untagged_ptr >= max_addr)
|
2015-06-24 16:58:37 -07:00
|
|
|
continue;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* No need for get_object() here since we hold kmemleak_lock.
|
|
|
|
* object->use_count cannot be dropped to 0 while the object
|
|
|
|
* is still present in object_tree_root and object_list
|
|
|
|
* (with updates protected by kmemleak_lock).
|
|
|
|
*/
|
|
|
|
object = lookup_object(pointer, 1);
|
2009-06-11 05:22:39 -07:00
|
|
|
if (!object)
|
|
|
|
continue;
|
2015-06-24 16:58:37 -07:00
|
|
|
if (object == scanned)
|
2009-06-11 05:22:39 -07:00
|
|
|
/* self referenced, ignore */
|
|
|
|
continue;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Avoid the lockdep recursive warning on object->lock being
|
|
|
|
* previously acquired in scan_object(). These locks are
|
|
|
|
* enclosed by scan_mutex.
|
|
|
|
*/
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_nested(&object->lock, SINGLE_DEPTH_NESTING);
|
2017-07-06 15:40:22 -07:00
|
|
|
/* only pass surplus references (object already gray) */
|
|
|
|
if (color_gray(object)) {
|
|
|
|
excess_ref = object->excess_ref;
|
|
|
|
/* no need for update_refs() if object already gray */
|
|
|
|
} else {
|
|
|
|
excess_ref = 0;
|
|
|
|
update_refs(object);
|
|
|
|
}
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock(&object->lock);
|
2017-07-06 15:40:22 -07:00
|
|
|
|
|
|
|
if (excess_ref) {
|
|
|
|
object = lookup_object(excess_ref, 0);
|
|
|
|
if (!object)
|
|
|
|
continue;
|
|
|
|
if (object == scanned)
|
|
|
|
/* circular reference, ignore */
|
|
|
|
continue;
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_nested(&object->lock, SINGLE_DEPTH_NESTING);
|
2017-07-06 15:40:22 -07:00
|
|
|
update_refs(object);
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock(&object->lock);
|
2017-07-06 15:40:22 -07:00
|
|
|
}
|
2015-06-24 16:58:37 -07:00
|
|
|
}
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&kmemleak_lock, flags);
|
2015-06-24 16:58:37 -07:00
|
|
|
}
|
2009-10-28 06:33:11 -07:00
|
|
|
|
2015-06-24 16:58:37 -07:00
|
|
|
/*
|
|
|
|
* Scan a large memory block in MAX_SCAN_SIZE chunks to reduce the latency.
|
|
|
|
*/
|
2019-04-18 17:50:48 -07:00
|
|
|
#ifdef CONFIG_SMP
|
2015-06-24 16:58:37 -07:00
|
|
|
static void scan_large_block(void *start, void *end)
|
|
|
|
{
|
|
|
|
void *next;
|
|
|
|
|
|
|
|
while (start < end) {
|
|
|
|
next = min(start + MAX_SCAN_SIZE, end);
|
|
|
|
scan_block(start, next, NULL);
|
|
|
|
start = next;
|
|
|
|
cond_resched();
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
}
|
2019-04-18 17:50:48 -07:00
|
|
|
#endif
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Scan a memory block corresponding to a kmemleak_object. A condition is
|
|
|
|
* that object->use_count >= 1.
|
|
|
|
*/
|
|
|
|
static void scan_object(struct kmemleak_object *object)
|
|
|
|
{
|
|
|
|
struct kmemleak_scan_area *area;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
/*
|
2009-10-07 06:21:09 -07:00
|
|
|
* Once the object->lock is acquired, the corresponding memory block
|
|
|
|
* cannot be freed (the same lock is acquired in delete_object).
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
if (object->flags & OBJECT_NO_SCAN)
|
|
|
|
goto out;
|
|
|
|
if (!(object->flags & OBJECT_ALLOCATED))
|
|
|
|
/* already freed object */
|
|
|
|
goto out;
|
2022-06-10 20:55:50 -07:00
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
if (object->flags & OBJECT_PERCPU) {
|
|
|
|
unsigned int cpu;
|
|
|
|
|
|
|
|
for_each_possible_cpu(cpu) {
|
|
|
|
void *start = per_cpu_ptr((void __percpu *)object->pointer, cpu);
|
|
|
|
void *end = start + object->size;
|
2022-06-10 20:55:50 -07:00
|
|
|
|
2023-12-01 12:08:29 -07:00
|
|
|
scan_block(start, end, object);
|
|
|
|
|
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
|
|
|
cond_resched();
|
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
|
|
|
if (!(object->flags & OBJECT_ALLOCATED))
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
} else if (hlist_empty(&object->area_list) ||
|
2019-09-23 15:33:59 -07:00
|
|
|
object->flags & OBJECT_FULL_SCAN) {
|
2023-12-01 12:08:29 -07:00
|
|
|
void *start = object->flags & OBJECT_PHYS ?
|
|
|
|
__va((phys_addr_t)object->pointer) :
|
|
|
|
(void *)object->pointer;
|
|
|
|
void *end = start + object->size;
|
2015-06-24 16:58:37 -07:00
|
|
|
void *next;
|
|
|
|
|
|
|
|
do {
|
|
|
|
next = min(start + MAX_SCAN_SIZE, end);
|
|
|
|
scan_block(start, next, object);
|
2009-08-27 06:29:12 -07:00
|
|
|
|
2015-06-24 16:58:37 -07:00
|
|
|
start = next;
|
|
|
|
if (start >= end)
|
|
|
|
break;
|
2009-08-27 06:29:12 -07:00
|
|
|
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2009-08-27 06:29:12 -07:00
|
|
|
cond_resched();
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2015-06-24 16:58:37 -07:00
|
|
|
} while (object->flags & OBJECT_ALLOCATED);
|
2023-12-01 12:08:29 -07:00
|
|
|
} else {
|
hlist: drop the node parameter from iterators
I'm not sure why, but the hlist for each entry iterators were conceived
list_for_each_entry(pos, head, member)
The hlist ones were greedy and wanted an extra parameter:
hlist_for_each_entry(tpos, pos, head, member)
Why did they need an extra pos parameter? I'm not quite sure. Not only
they don't really need it, it also prevents the iterator from looking
exactly like the list iterator, which is unfortunate.
Besides the semantic patch, there was some manual work required:
- Fix up the actual hlist iterators in linux/list.h
- Fix up the declaration of other iterators based on the hlist ones.
- A very small amount of places were using the 'node' parameter, this
was modified to use 'obj->member' instead.
- Coccinelle didn't handle the hlist_for_each_entry_safe iterator
properly, so those had to be fixed up manually.
The semantic patch which is mostly the work of Peter Senna Tschudin is here:
@@
iterator name hlist_for_each_entry, hlist_for_each_entry_continue, hlist_for_each_entry_from, hlist_for_each_entry_rcu, hlist_for_each_entry_rcu_bh, hlist_for_each_entry_continue_rcu_bh, for_each_busy_worker, ax25_uid_for_each, ax25_for_each, inet_bind_bucket_for_each, sctp_for_each_hentry, sk_for_each, sk_for_each_rcu, sk_for_each_from, sk_for_each_safe, sk_for_each_bound, hlist_for_each_entry_safe, hlist_for_each_entry_continue_rcu, nr_neigh_for_each, nr_neigh_for_each_safe, nr_node_for_each, nr_node_for_each_safe, for_each_gfn_indirect_valid_sp, for_each_gfn_sp, for_each_host;
type T;
expression a,c,d,e;
identifier b;
statement S;
@@
-T b;
<+... when != b
(
hlist_for_each_entry(a,
- b,
c, d) S
|
hlist_for_each_entry_continue(a,
- b,
c) S
|
hlist_for_each_entry_from(a,
- b,
c) S
|
hlist_for_each_entry_rcu(a,
- b,
c, d) S
|
hlist_for_each_entry_rcu_bh(a,
- b,
c, d) S
|
hlist_for_each_entry_continue_rcu_bh(a,
- b,
c) S
|
for_each_busy_worker(a, c,
- b,
d) S
|
ax25_uid_for_each(a,
- b,
c) S
|
ax25_for_each(a,
- b,
c) S
|
inet_bind_bucket_for_each(a,
- b,
c) S
|
sctp_for_each_hentry(a,
- b,
c) S
|
sk_for_each(a,
- b,
c) S
|
sk_for_each_rcu(a,
- b,
c) S
|
sk_for_each_from
-(a, b)
+(a)
S
+ sk_for_each_from(a) S
|
sk_for_each_safe(a,
- b,
c, d) S
|
sk_for_each_bound(a,
- b,
c) S
|
hlist_for_each_entry_safe(a,
- b,
c, d, e) S
|
hlist_for_each_entry_continue_rcu(a,
- b,
c) S
|
nr_neigh_for_each(a,
- b,
c) S
|
nr_neigh_for_each_safe(a,
- b,
c, d) S
|
nr_node_for_each(a,
- b,
c) S
|
nr_node_for_each_safe(a,
- b,
c, d) S
|
- for_each_gfn_sp(a, c, d, b) S
+ for_each_gfn_sp(a, c, d) S
|
- for_each_gfn_indirect_valid_sp(a, c, d, b) S
+ for_each_gfn_indirect_valid_sp(a, c, d) S
|
for_each_host(a,
- b,
c) S
|
for_each_host_safe(a,
- b,
c, d) S
|
for_each_mesh_entry(a,
- b,
c, d) S
)
...+>
[akpm@linux-foundation.org: drop bogus change from net/ipv4/raw.c]
[akpm@linux-foundation.org: drop bogus hunk from net/ipv6/raw.c]
[akpm@linux-foundation.org: checkpatch fixes]
[akpm@linux-foundation.org: fix warnings]
[akpm@linux-foudnation.org: redo intrusive kvm changes]
Tested-by: Peter Senna Tschudin <peter.senna@gmail.com>
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Gleb Natapov <gleb@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-27 18:06:00 -07:00
|
|
|
hlist_for_each_entry(area, &object->area_list, node)
|
2009-10-28 06:33:09 -07:00
|
|
|
scan_block((void *)area->start,
|
|
|
|
(void *)(area->start + area->size),
|
2015-06-24 16:58:37 -07:00
|
|
|
object);
|
2023-12-01 12:08:29 -07:00
|
|
|
}
|
2009-06-11 05:22:39 -07:00
|
|
|
out:
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
2009-10-28 06:33:12 -07:00
|
|
|
/*
|
|
|
|
* Scan the objects already referenced (gray objects). More objects will be
|
|
|
|
* referenced and, if there are no memory leaks, all the objects are scanned.
|
|
|
|
*/
|
|
|
|
static void scan_gray_list(void)
|
|
|
|
{
|
|
|
|
struct kmemleak_object *object, *tmp;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* The list traversal is safe for both tail additions and removals
|
|
|
|
* from inside the loop. The kmemleak objects cannot be freed from
|
|
|
|
* outside the loop because their use_count was incremented.
|
|
|
|
*/
|
|
|
|
object = list_entry(gray_list.next, typeof(*object), gray_list);
|
|
|
|
while (&object->gray_list != &gray_list) {
|
|
|
|
cond_resched();
|
|
|
|
|
|
|
|
/* may add new objects to the list */
|
|
|
|
if (!scan_should_stop())
|
|
|
|
scan_object(object);
|
|
|
|
|
|
|
|
tmp = list_entry(object->gray_list.next, typeof(*object),
|
|
|
|
gray_list);
|
|
|
|
|
|
|
|
/* remove the object from the list and release it */
|
|
|
|
list_del(&object->gray_list);
|
|
|
|
put_object(object);
|
|
|
|
|
|
|
|
object = tmp;
|
|
|
|
}
|
|
|
|
WARN_ON(!list_empty(&gray_list));
|
|
|
|
}
|
|
|
|
|
2022-10-20 10:56:19 -07:00
|
|
|
/*
|
2022-11-14 10:14:26 -07:00
|
|
|
* Conditionally call resched() in an object iteration loop while making sure
|
2022-10-20 10:56:19 -07:00
|
|
|
* that the given object won't go away without RCU read lock by performing a
|
2023-01-18 21:01:10 -07:00
|
|
|
* get_object() if necessaary.
|
2022-10-20 10:56:19 -07:00
|
|
|
*/
|
2023-01-18 21:01:10 -07:00
|
|
|
static void kmemleak_cond_resched(struct kmemleak_object *object)
|
2022-10-20 10:56:19 -07:00
|
|
|
{
|
2023-01-18 21:01:10 -07:00
|
|
|
if (!get_object(object))
|
|
|
|
return; /* Try next object */
|
2022-10-20 10:56:19 -07:00
|
|
|
|
2023-01-18 21:01:11 -07:00
|
|
|
raw_spin_lock_irq(&kmemleak_lock);
|
|
|
|
if (object->del_state & DELSTATE_REMOVED)
|
|
|
|
goto unlock_put; /* Object removed */
|
|
|
|
object->del_state |= DELSTATE_NO_DELETE;
|
|
|
|
raw_spin_unlock_irq(&kmemleak_lock);
|
|
|
|
|
2022-10-20 10:56:19 -07:00
|
|
|
rcu_read_unlock();
|
|
|
|
cond_resched();
|
|
|
|
rcu_read_lock();
|
2023-01-18 21:01:11 -07:00
|
|
|
|
|
|
|
raw_spin_lock_irq(&kmemleak_lock);
|
|
|
|
if (object->del_state & DELSTATE_REMOVED)
|
|
|
|
list_del_rcu(&object->object_list);
|
|
|
|
object->del_state &= ~DELSTATE_NO_DELETE;
|
|
|
|
unlock_put:
|
|
|
|
raw_spin_unlock_irq(&kmemleak_lock);
|
2023-01-18 21:01:10 -07:00
|
|
|
put_object(object);
|
2022-10-20 10:56:19 -07:00
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
|
|
|
* Scan data sections and all the referenced memory blocks allocated via the
|
|
|
|
* kernel's standard allocators. This function must be called with the
|
|
|
|
* scan_mutex held.
|
|
|
|
*/
|
|
|
|
static void kmemleak_scan(void)
|
|
|
|
{
|
2009-10-28 06:33:12 -07:00
|
|
|
struct kmemleak_object *object;
|
2022-02-03 21:49:37 -07:00
|
|
|
struct zone *zone;
|
|
|
|
int __maybe_unused i;
|
2009-06-26 09:38:27 -07:00
|
|
|
int new_leaks = 0;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2009-06-26 09:38:29 -07:00
|
|
|
jiffies_last_scan = jiffies;
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/* prepare the kmemleak_object's */
|
|
|
|
rcu_read_lock();
|
|
|
|
list_for_each_entry_rcu(object, &object_list, object_list) {
|
2022-06-14 15:03:57 -07:00
|
|
|
raw_spin_lock_irq(&object->lock);
|
2009-06-11 05:22:39 -07:00
|
|
|
#ifdef DEBUG
|
|
|
|
/*
|
|
|
|
* With a few exceptions there should be a maximum of
|
|
|
|
* 1 reference to any object at this point.
|
|
|
|
*/
|
|
|
|
if (atomic_read(&object->use_count) > 1) {
|
2009-06-23 06:40:26 -07:00
|
|
|
pr_debug("object->use_count = %d\n",
|
2009-06-11 05:22:39 -07:00
|
|
|
atomic_read(&object->use_count));
|
|
|
|
dump_object_info(object);
|
|
|
|
}
|
|
|
|
#endif
|
2022-06-10 20:55:51 -07:00
|
|
|
|
|
|
|
/* ignore objects outside lowmem (paint them black) */
|
|
|
|
if ((object->flags & OBJECT_PHYS) &&
|
|
|
|
!(object->flags & OBJECT_NO_SCAN)) {
|
|
|
|
unsigned long phys = object->pointer;
|
|
|
|
|
|
|
|
if (PHYS_PFN(phys) < min_low_pfn ||
|
|
|
|
PHYS_PFN(phys + object->size) >= max_low_pfn)
|
|
|
|
__paint_it(object, KMEMLEAK_BLACK);
|
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/* reset the reference count (whiten the object) */
|
|
|
|
object->count = 0;
|
2023-01-18 21:01:10 -07:00
|
|
|
if (color_gray(object) && get_object(object))
|
2009-06-11 05:22:39 -07:00
|
|
|
list_add_tail(&object->gray_list, &gray_list);
|
|
|
|
|
2022-06-14 15:03:57 -07:00
|
|
|
raw_spin_unlock_irq(&object->lock);
|
2022-06-14 15:03:59 -07:00
|
|
|
|
2023-01-18 21:01:10 -07:00
|
|
|
if (need_resched())
|
|
|
|
kmemleak_cond_resched(object);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
rcu_read_unlock();
|
|
|
|
|
|
|
|
#ifdef CONFIG_SMP
|
|
|
|
/* per-cpu sections scanning */
|
|
|
|
for_each_possible_cpu(i)
|
2015-06-24 16:58:37 -07:00
|
|
|
scan_large_block(__per_cpu_start + per_cpu_offset(i),
|
|
|
|
__per_cpu_end + per_cpu_offset(i));
|
2009-06-11 05:22:39 -07:00
|
|
|
#endif
|
|
|
|
|
|
|
|
/*
|
2011-11-15 16:49:09 -07:00
|
|
|
* Struct page scanning for each node.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
mem-hotplug: implement get/put_online_mems
kmem_cache_{create,destroy,shrink} need to get a stable value of
cpu/node online mask, because they init/destroy/access per-cpu/node
kmem_cache parts, which can be allocated or destroyed on cpu/mem
hotplug. To protect against cpu hotplug, these functions use
{get,put}_online_cpus. However, they do nothing to synchronize with
memory hotplug - taking the slab_mutex does not eliminate the
possibility of race as described in patch 2.
What we need there is something like get_online_cpus, but for memory.
We already have lock_memory_hotplug, which serves for the purpose, but
it's a bit of a hammer right now, because it's backed by a mutex. As a
result, it imposes some limitations to locking order, which are not
desirable, and can't be used just like get_online_cpus. That's why in
patch 1 I substitute it with get/put_online_mems, which work exactly
like get/put_online_cpus except they block not cpu, but memory hotplug.
[ v1 can be found at https://lkml.org/lkml/2014/4/6/68. I NAK'ed it by
myself, because it used an rw semaphore for get/put_online_mems,
making them dead lock prune. ]
This patch (of 2):
{un}lock_memory_hotplug, which is used to synchronize against memory
hotplug, is currently backed by a mutex, which makes it a bit of a
hammer - threads that only want to get a stable value of online nodes
mask won't be able to proceed concurrently. Also, it imposes some
strong locking ordering rules on it, which narrows down the set of its
usage scenarios.
This patch introduces get/put_online_mems, which are the same as
get/put_online_cpus, but for memory hotplug, i.e. executing a code
inside a get/put_online_mems section will guarantee a stable value of
online nodes, present pages, etc.
lock_memory_hotplug()/unlock_memory_hotplug() are removed altogether.
Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Tang Chen <tangchen@cn.fujitsu.com>
Cc: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>
Cc: Jiang Liu <liuj97@gmail.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Wen Congyang <wency@cn.fujitsu.com>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-06-04 16:07:18 -07:00
|
|
|
get_online_mems();
|
2022-02-03 21:49:37 -07:00
|
|
|
for_each_populated_zone(zone) {
|
|
|
|
unsigned long start_pfn = zone->zone_start_pfn;
|
|
|
|
unsigned long end_pfn = zone_end_pfn(zone);
|
2009-06-11 05:22:39 -07:00
|
|
|
unsigned long pfn;
|
|
|
|
|
|
|
|
for (pfn = start_pfn; pfn < end_pfn; pfn++) {
|
mm, kmemleak: little optimization while scanning
kmemleak_scan() goes through all online nodes and tries to scan all used
pages.
We can do better and use pfn_to_online_page(), so in case we have
CONFIG_MEMORY_HOTPLUG, offlined pages will be skiped automatically. For
boxes where CONFIG_MEMORY_HOTPLUG is not present, pfn_to_online_page()
will fallback to pfn_valid().
Another little optimization is to check if the page belongs to the node we
are currently checking, so in case we have nodes interleaved we will not
check the same pfn multiple times.
I ran some tests:
Add some memory to node1 and node2 making it interleaved:
(qemu) object_add memory-backend-ram,id=ram0,size=1G
(qemu) device_add pc-dimm,id=dimm0,memdev=ram0,node=1
(qemu) object_add memory-backend-ram,id=ram1,size=1G
(qemu) device_add pc-dimm,id=dimm1,memdev=ram1,node=2
(qemu) object_add memory-backend-ram,id=ram2,size=1G
(qemu) device_add pc-dimm,id=dimm2,memdev=ram2,node=1
Then, we offline that memory:
# for i in {32..39} ; do echo "offline" > /sys/devices/system/node/node1/memory$i/state;done
# for i in {48..55} ; do echo "offline" > /sys/devices/system/node/node1/memory$i/state;don
# for i in {40..47} ; do echo "offline" > /sys/devices/system/node/node2/memory$i/state;done
And we run kmemleak_scan:
# echo "scan" > /sys/kernel/debug/kmemleak
before the patch:
kmemleak: time spend: 41596 us
after the patch:
kmemleak: time spend: 34899 us
[akpm@linux-foundation.org: remove stray newline, per Oscar]
Link: http://lkml.kernel.org/r/20181206131918.25099-1-osalvador@suse.de
Signed-off-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
Suggested-by: Michal Hocko <mhocko@suse.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-12-28 01:37:57 -07:00
|
|
|
struct page *page = pfn_to_online_page(pfn);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2023-08-25 09:49:47 -07:00
|
|
|
if (!(pfn & 63))
|
|
|
|
cond_resched();
|
|
|
|
|
mm, kmemleak: little optimization while scanning
kmemleak_scan() goes through all online nodes and tries to scan all used
pages.
We can do better and use pfn_to_online_page(), so in case we have
CONFIG_MEMORY_HOTPLUG, offlined pages will be skiped automatically. For
boxes where CONFIG_MEMORY_HOTPLUG is not present, pfn_to_online_page()
will fallback to pfn_valid().
Another little optimization is to check if the page belongs to the node we
are currently checking, so in case we have nodes interleaved we will not
check the same pfn multiple times.
I ran some tests:
Add some memory to node1 and node2 making it interleaved:
(qemu) object_add memory-backend-ram,id=ram0,size=1G
(qemu) device_add pc-dimm,id=dimm0,memdev=ram0,node=1
(qemu) object_add memory-backend-ram,id=ram1,size=1G
(qemu) device_add pc-dimm,id=dimm1,memdev=ram1,node=2
(qemu) object_add memory-backend-ram,id=ram2,size=1G
(qemu) device_add pc-dimm,id=dimm2,memdev=ram2,node=1
Then, we offline that memory:
# for i in {32..39} ; do echo "offline" > /sys/devices/system/node/node1/memory$i/state;done
# for i in {48..55} ; do echo "offline" > /sys/devices/system/node/node1/memory$i/state;don
# for i in {40..47} ; do echo "offline" > /sys/devices/system/node/node2/memory$i/state;done
And we run kmemleak_scan:
# echo "scan" > /sys/kernel/debug/kmemleak
before the patch:
kmemleak: time spend: 41596 us
after the patch:
kmemleak: time spend: 34899 us
[akpm@linux-foundation.org: remove stray newline, per Oscar]
Link: http://lkml.kernel.org/r/20181206131918.25099-1-osalvador@suse.de
Signed-off-by: Oscar Salvador <osalvador@suse.de>
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
Suggested-by: Michal Hocko <mhocko@suse.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2018-12-28 01:37:57 -07:00
|
|
|
if (!page)
|
|
|
|
continue;
|
|
|
|
|
2022-02-03 21:49:37 -07:00
|
|
|
/* only scan pages belonging to this zone */
|
|
|
|
if (page_zone(page) != zone)
|
2009-06-11 05:22:39 -07:00
|
|
|
continue;
|
|
|
|
/* only scan if page is in use */
|
|
|
|
if (page_count(page) == 0)
|
|
|
|
continue;
|
2015-06-24 16:58:37 -07:00
|
|
|
scan_block(page, page + 1, NULL);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
}
|
mem-hotplug: implement get/put_online_mems
kmem_cache_{create,destroy,shrink} need to get a stable value of
cpu/node online mask, because they init/destroy/access per-cpu/node
kmem_cache parts, which can be allocated or destroyed on cpu/mem
hotplug. To protect against cpu hotplug, these functions use
{get,put}_online_cpus. However, they do nothing to synchronize with
memory hotplug - taking the slab_mutex does not eliminate the
possibility of race as described in patch 2.
What we need there is something like get_online_cpus, but for memory.
We already have lock_memory_hotplug, which serves for the purpose, but
it's a bit of a hammer right now, because it's backed by a mutex. As a
result, it imposes some limitations to locking order, which are not
desirable, and can't be used just like get_online_cpus. That's why in
patch 1 I substitute it with get/put_online_mems, which work exactly
like get/put_online_cpus except they block not cpu, but memory hotplug.
[ v1 can be found at https://lkml.org/lkml/2014/4/6/68. I NAK'ed it by
myself, because it used an rw semaphore for get/put_online_mems,
making them dead lock prune. ]
This patch (of 2):
{un}lock_memory_hotplug, which is used to synchronize against memory
hotplug, is currently backed by a mutex, which makes it a bit of a
hammer - threads that only want to get a stable value of online nodes
mask won't be able to proceed concurrently. Also, it imposes some
strong locking ordering rules on it, which narrows down the set of its
usage scenarios.
This patch introduces get/put_online_mems, which are the same as
get/put_online_cpus, but for memory hotplug, i.e. executing a code
inside a get/put_online_mems section will guarantee a stable value of
online nodes, present pages, etc.
lock_memory_hotplug()/unlock_memory_hotplug() are removed altogether.
Signed-off-by: Vladimir Davydov <vdavydov@parallels.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Tang Chen <tangchen@cn.fujitsu.com>
Cc: Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Cc: Toshi Kani <toshi.kani@hp.com>
Cc: Xishi Qiu <qiuxishi@huawei.com>
Cc: Jiang Liu <liuj97@gmail.com>
Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Wen Congyang <wency@cn.fujitsu.com>
Cc: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2014-06-04 16:07:18 -07:00
|
|
|
put_online_mems();
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/*
|
2009-09-01 03:12:44 -07:00
|
|
|
* Scanning the task stacks (may introduce false negatives).
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
|
|
|
if (kmemleak_stack_scan) {
|
2009-09-01 03:12:44 -07:00
|
|
|
struct task_struct *p, *g;
|
|
|
|
|
2020-10-13 16:48:50 -07:00
|
|
|
rcu_read_lock();
|
|
|
|
for_each_process_thread(g, p) {
|
2016-10-27 17:46:47 -07:00
|
|
|
void *stack = try_get_task_stack(p);
|
|
|
|
if (stack) {
|
|
|
|
scan_block(stack, stack + THREAD_SIZE, NULL);
|
|
|
|
put_task_stack(p);
|
|
|
|
}
|
2020-10-13 16:48:50 -07:00
|
|
|
}
|
|
|
|
rcu_read_unlock();
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Scan the objects already referenced from the sections scanned
|
2009-10-28 06:33:12 -07:00
|
|
|
* above.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-10-28 06:33:12 -07:00
|
|
|
scan_gray_list();
|
2009-07-07 02:32:58 -07:00
|
|
|
|
|
|
|
/*
|
2009-10-28 06:33:12 -07:00
|
|
|
* Check for new or unreferenced objects modified since the previous
|
|
|
|
* scan and color them gray until the next scan.
|
2009-07-07 02:32:58 -07:00
|
|
|
*/
|
|
|
|
rcu_read_lock();
|
|
|
|
list_for_each_entry_rcu(object, &object_list, object_list) {
|
2023-01-18 21:01:10 -07:00
|
|
|
if (need_resched())
|
|
|
|
kmemleak_cond_resched(object);
|
2022-10-20 10:56:19 -07:00
|
|
|
|
mm/kmemleak: skip unlikely objects in kmemleak_scan() without taking lock
There are 3 RCU-based object iteration loops in kmemleak_scan(). Because
of the need to take RCU read lock, we can't insert cond_resched() into the
loop like other parts of the function. As there can be millions of
objects to be scanned, it takes a while to iterate all of them. The
kmemleak functionality is usually enabled in a debug kernel which is much
slower than a non-debug kernel. With sufficient number of kmemleak
objects, the time to iterate them all may exceed 22s causing soft lockup.
watchdog: BUG: soft lockup - CPU#3 stuck for 22s! [kmemleak:625]
In this particular bug report, the soft lockup happen in the 2nd iteration
loop.
In the 2nd and 3rd loops, most of the objects are checked and then skipped
under the object lock. Only a selected fews are modified. Those objects
certainly need lock protection. However, the lock/unlock operation is
slow especially with interrupt disabling and enabling included.
We can actually do some basic check like color_white() without taking the
lock and skip the object accordingly. Of course, this kind of check is
racy and may miss objects that are being modified concurrently. The cost
of missed objects, however, is just that they will be discovered in the
next scan instead. The advantage of doing so is that iteration can be
done much faster especially with LOCKDEP enabled in a debug kernel.
With a debug kernel running on a 2-socket 96-thread x86-64 system
(HZ=1000), the 2nd and 3rd iteration loops speedup with this patch on the
first kmemleak_scan() call after bootup is shown in the table below.
Before patch After patch
Loop # # of objects Elapsed time # of objects Elapsed time
------ ------------ ------------ ------------ ------------
2 2,599,850 2.392s 2,596,364 0.266s
3 2,600,176 2.171s 2,597,061 0.260s
This patch reduces loop iteration times by about 88%. This will greatly
reduce the chance of a soft lockup happening in the 2nd or 3rd iteration
loops.
Even though the first loop runs a little bit faster, it can still be
problematic if many kmemleak objects are there. As the object count has
to be modified in every object, we cannot avoid taking the object lock.
So other way to prevent soft lockup will be needed.
Link: https://lkml.kernel.org/r/20220614220359.59282-3-longman@redhat.com
Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2022-06-14 15:03:58 -07:00
|
|
|
/*
|
|
|
|
* This is racy but we can save the overhead of lock/unlock
|
|
|
|
* calls. The missed objects, if any, should be caught in
|
|
|
|
* the next scan.
|
|
|
|
*/
|
|
|
|
if (!color_white(object))
|
|
|
|
continue;
|
2022-06-14 15:03:57 -07:00
|
|
|
raw_spin_lock_irq(&object->lock);
|
2009-10-28 06:33:12 -07:00
|
|
|
if (color_white(object) && (object->flags & OBJECT_ALLOCATED)
|
|
|
|
&& update_checksum(object) && get_object(object)) {
|
|
|
|
/* color it gray temporarily */
|
|
|
|
object->count = object->min_count;
|
2009-07-07 02:32:58 -07:00
|
|
|
list_add_tail(&object->gray_list, &gray_list);
|
|
|
|
}
|
2022-06-14 15:03:57 -07:00
|
|
|
raw_spin_unlock_irq(&object->lock);
|
2009-07-07 02:32:58 -07:00
|
|
|
}
|
|
|
|
rcu_read_unlock();
|
|
|
|
|
2009-10-28 06:33:12 -07:00
|
|
|
/*
|
|
|
|
* Re-scan the gray list for modified unreferenced objects.
|
|
|
|
*/
|
|
|
|
scan_gray_list();
|
2009-06-26 09:38:27 -07:00
|
|
|
|
2009-06-29 09:13:56 -07:00
|
|
|
/*
|
2009-10-28 06:33:12 -07:00
|
|
|
* If scanning was stopped do not report any new unreferenced objects.
|
2009-06-29 09:13:56 -07:00
|
|
|
*/
|
2009-10-28 06:33:12 -07:00
|
|
|
if (scan_should_stop())
|
2009-06-29 09:13:56 -07:00
|
|
|
return;
|
|
|
|
|
2009-06-26 09:38:27 -07:00
|
|
|
/*
|
|
|
|
* Scanning result reporting.
|
|
|
|
*/
|
|
|
|
rcu_read_lock();
|
|
|
|
list_for_each_entry_rcu(object, &object_list, object_list) {
|
2023-01-18 21:01:10 -07:00
|
|
|
if (need_resched())
|
|
|
|
kmemleak_cond_resched(object);
|
2022-10-20 10:56:19 -07:00
|
|
|
|
mm/kmemleak: skip unlikely objects in kmemleak_scan() without taking lock
There are 3 RCU-based object iteration loops in kmemleak_scan(). Because
of the need to take RCU read lock, we can't insert cond_resched() into the
loop like other parts of the function. As there can be millions of
objects to be scanned, it takes a while to iterate all of them. The
kmemleak functionality is usually enabled in a debug kernel which is much
slower than a non-debug kernel. With sufficient number of kmemleak
objects, the time to iterate them all may exceed 22s causing soft lockup.
watchdog: BUG: soft lockup - CPU#3 stuck for 22s! [kmemleak:625]
In this particular bug report, the soft lockup happen in the 2nd iteration
loop.
In the 2nd and 3rd loops, most of the objects are checked and then skipped
under the object lock. Only a selected fews are modified. Those objects
certainly need lock protection. However, the lock/unlock operation is
slow especially with interrupt disabling and enabling included.
We can actually do some basic check like color_white() without taking the
lock and skip the object accordingly. Of course, this kind of check is
racy and may miss objects that are being modified concurrently. The cost
of missed objects, however, is just that they will be discovered in the
next scan instead. The advantage of doing so is that iteration can be
done much faster especially with LOCKDEP enabled in a debug kernel.
With a debug kernel running on a 2-socket 96-thread x86-64 system
(HZ=1000), the 2nd and 3rd iteration loops speedup with this patch on the
first kmemleak_scan() call after bootup is shown in the table below.
Before patch After patch
Loop # # of objects Elapsed time # of objects Elapsed time
------ ------------ ------------ ------------ ------------
2 2,599,850 2.392s 2,596,364 0.266s
3 2,600,176 2.171s 2,597,061 0.260s
This patch reduces loop iteration times by about 88%. This will greatly
reduce the chance of a soft lockup happening in the 2nd or 3rd iteration
loops.
Even though the first loop runs a little bit faster, it can still be
problematic if many kmemleak objects are there. As the object count has
to be modified in every object, we cannot avoid taking the object lock.
So other way to prevent soft lockup will be needed.
Link: https://lkml.kernel.org/r/20220614220359.59282-3-longman@redhat.com
Signed-off-by: Waiman Long <longman@redhat.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2022-06-14 15:03:58 -07:00
|
|
|
/*
|
|
|
|
* This is racy but we can save the overhead of lock/unlock
|
|
|
|
* calls. The missed objects, if any, should be caught in
|
|
|
|
* the next scan.
|
|
|
|
*/
|
|
|
|
if (!color_white(object))
|
|
|
|
continue;
|
2022-06-14 15:03:57 -07:00
|
|
|
raw_spin_lock_irq(&object->lock);
|
2009-06-26 09:38:27 -07:00
|
|
|
if (unreferenced_object(object) &&
|
|
|
|
!(object->flags & OBJECT_REPORTED)) {
|
|
|
|
object->flags |= OBJECT_REPORTED;
|
2018-10-26 15:03:42 -07:00
|
|
|
|
|
|
|
if (kmemleak_verbose)
|
|
|
|
print_unreferenced(NULL, object);
|
|
|
|
|
2009-06-26 09:38:27 -07:00
|
|
|
new_leaks++;
|
|
|
|
}
|
2022-06-14 15:03:57 -07:00
|
|
|
raw_spin_unlock_irq(&object->lock);
|
2009-06-26 09:38:27 -07:00
|
|
|
}
|
|
|
|
rcu_read_unlock();
|
|
|
|
|
2014-04-03 14:46:26 -07:00
|
|
|
if (new_leaks) {
|
|
|
|
kmemleak_found_leaks = true;
|
|
|
|
|
2016-03-17 14:19:47 -07:00
|
|
|
pr_info("%d new suspected memory leaks (see /sys/kernel/debug/kmemleak)\n",
|
|
|
|
new_leaks);
|
2014-04-03 14:46:26 -07:00
|
|
|
}
|
2009-06-26 09:38:27 -07:00
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Thread function performing automatic memory scanning. Unreferenced objects
|
|
|
|
* at the end of a memory scan are reported but only the first time.
|
|
|
|
*/
|
|
|
|
static int kmemleak_scan_thread(void *arg)
|
|
|
|
{
|
2018-12-28 01:38:54 -07:00
|
|
|
static int first_run = IS_ENABLED(CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2009-06-23 06:40:26 -07:00
|
|
|
pr_info("Automatic memory scanning thread started\n");
|
2009-07-07 02:32:55 -07:00
|
|
|
set_user_nice(current, 10);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Wait before the first scan to allow the system to fully initialize.
|
|
|
|
*/
|
|
|
|
if (first_run) {
|
2016-07-28 15:48:32 -07:00
|
|
|
signed long timeout = msecs_to_jiffies(SECS_FIRST_SCAN * 1000);
|
2009-06-11 05:22:39 -07:00
|
|
|
first_run = 0;
|
2016-07-28 15:48:32 -07:00
|
|
|
while (timeout && !kthread_should_stop())
|
|
|
|
timeout = schedule_timeout_interruptible(timeout);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
while (!kthread_should_stop()) {
|
2021-06-28 19:35:01 -07:00
|
|
|
signed long timeout = READ_ONCE(jiffies_scan_wait);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
mutex_lock(&scan_mutex);
|
|
|
|
kmemleak_scan();
|
|
|
|
mutex_unlock(&scan_mutex);
|
2009-06-26 09:38:27 -07:00
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/* wait before the next scan */
|
|
|
|
while (timeout && !kthread_should_stop())
|
|
|
|
timeout = schedule_timeout_interruptible(timeout);
|
|
|
|
}
|
|
|
|
|
2009-06-23 06:40:26 -07:00
|
|
|
pr_info("Automatic memory scanning thread ended\n");
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Start the automatic memory scanning thread. This function must be called
|
2009-06-26 09:38:27 -07:00
|
|
|
* with the scan_mutex held.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-09-08 09:31:45 -07:00
|
|
|
static void start_scan_thread(void)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
|
|
|
if (scan_thread)
|
|
|
|
return;
|
|
|
|
scan_thread = kthread_run(kmemleak_scan_thread, NULL, "kmemleak");
|
|
|
|
if (IS_ERR(scan_thread)) {
|
2016-03-17 14:19:44 -07:00
|
|
|
pr_warn("Failed to create the scan thread\n");
|
2009-06-11 05:22:39 -07:00
|
|
|
scan_thread = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
2018-03-28 16:01:16 -07:00
|
|
|
* Stop the automatic memory scanning thread.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-09-08 09:31:45 -07:00
|
|
|
static void stop_scan_thread(void)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
|
|
|
if (scan_thread) {
|
|
|
|
kthread_stop(scan_thread);
|
|
|
|
scan_thread = NULL;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Iterate over the object_list and return the first valid object at or after
|
|
|
|
* the required position with its use_count incremented. The function triggers
|
|
|
|
* a memory scanning when the pos argument points to the first position.
|
|
|
|
*/
|
|
|
|
static void *kmemleak_seq_start(struct seq_file *seq, loff_t *pos)
|
|
|
|
{
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
loff_t n = *pos;
|
2009-07-07 02:32:58 -07:00
|
|
|
int err;
|
|
|
|
|
|
|
|
err = mutex_lock_interruptible(&scan_mutex);
|
|
|
|
if (err < 0)
|
|
|
|
return ERR_PTR(err);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
rcu_read_lock();
|
|
|
|
list_for_each_entry_rcu(object, &object_list, object_list) {
|
|
|
|
if (n-- > 0)
|
|
|
|
continue;
|
|
|
|
if (get_object(object))
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
object = NULL;
|
|
|
|
out:
|
|
|
|
return object;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Return the next object in the object_list. The function decrements the
|
|
|
|
* use_count of the previous object and increases that of the next one.
|
|
|
|
*/
|
|
|
|
static void *kmemleak_seq_next(struct seq_file *seq, void *v, loff_t *pos)
|
|
|
|
{
|
|
|
|
struct kmemleak_object *prev_obj = v;
|
|
|
|
struct kmemleak_object *next_obj = NULL;
|
2012-08-16 21:33:34 -07:00
|
|
|
struct kmemleak_object *obj = prev_obj;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
++(*pos);
|
|
|
|
|
2012-08-16 21:33:34 -07:00
|
|
|
list_for_each_entry_continue_rcu(obj, &object_list, object_list) {
|
2011-04-27 08:44:26 -07:00
|
|
|
if (get_object(obj)) {
|
|
|
|
next_obj = obj;
|
2009-06-11 05:22:39 -07:00
|
|
|
break;
|
2011-04-27 08:44:26 -07:00
|
|
|
}
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
2009-07-07 02:32:57 -07:00
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
put_object(prev_obj);
|
|
|
|
return next_obj;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Decrement the use_count of the last object required, if any.
|
|
|
|
*/
|
|
|
|
static void kmemleak_seq_stop(struct seq_file *seq, void *v)
|
|
|
|
{
|
2009-07-07 02:32:58 -07:00
|
|
|
if (!IS_ERR(v)) {
|
|
|
|
/*
|
|
|
|
* kmemleak_seq_start may return ERR_PTR if the scan_mutex
|
|
|
|
* waiting was interrupted, so only release it if !IS_ERR.
|
|
|
|
*/
|
2009-07-29 08:26:57 -07:00
|
|
|
rcu_read_unlock();
|
2009-07-07 02:32:58 -07:00
|
|
|
mutex_unlock(&scan_mutex);
|
|
|
|
if (v)
|
|
|
|
put_object(v);
|
|
|
|
}
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Print the information for an unreferenced object to the seq file.
|
|
|
|
*/
|
|
|
|
static int kmemleak_seq_show(struct seq_file *seq, void *v)
|
|
|
|
{
|
|
|
|
struct kmemleak_object *object = v;
|
|
|
|
unsigned long flags;
|
|
|
|
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2009-07-07 02:32:57 -07:00
|
|
|
if ((object->flags & OBJECT_REPORTED) && unreferenced_object(object))
|
2009-06-29 09:13:56 -07:00
|
|
|
print_unreferenced(seq, object);
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2009-06-11 05:22:39 -07:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct seq_operations kmemleak_seq_ops = {
|
|
|
|
.start = kmemleak_seq_start,
|
|
|
|
.next = kmemleak_seq_next,
|
|
|
|
.stop = kmemleak_seq_stop,
|
|
|
|
.show = kmemleak_seq_show,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int kmemleak_open(struct inode *inode, struct file *file)
|
|
|
|
{
|
2009-07-07 02:32:58 -07:00
|
|
|
return seq_open(file, &kmemleak_seq_ops);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
2009-08-27 06:29:15 -07:00
|
|
|
static int dump_str_object_info(const char *str)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
unsigned long addr;
|
|
|
|
|
2012-12-18 15:23:27 -07:00
|
|
|
if (kstrtoul(str, 0, &addr))
|
|
|
|
return -EINVAL;
|
2009-08-27 06:29:15 -07:00
|
|
|
object = find_and_get_object(addr, 0);
|
|
|
|
if (!object) {
|
|
|
|
pr_info("Unknown object at 0x%08lx\n", addr);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_lock_irqsave(&object->lock, flags);
|
2009-08-27 06:29:15 -07:00
|
|
|
dump_object_info(object);
|
2020-01-30 23:12:00 -07:00
|
|
|
raw_spin_unlock_irqrestore(&object->lock, flags);
|
2009-08-27 06:29:15 -07:00
|
|
|
|
|
|
|
put_object(object);
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2009-09-04 17:44:51 -07:00
|
|
|
/*
|
|
|
|
* We use grey instead of black to ensure we can do future scans on the same
|
|
|
|
* objects. If we did not do future scans these black objects could
|
|
|
|
* potentially contain references to newly allocated objects in the future and
|
|
|
|
* we'd end up with false positives.
|
|
|
|
*/
|
|
|
|
static void kmemleak_clear(void)
|
|
|
|
{
|
|
|
|
struct kmemleak_object *object;
|
|
|
|
|
|
|
|
rcu_read_lock();
|
|
|
|
list_for_each_entry_rcu(object, &object_list, object_list) {
|
2022-06-14 15:03:57 -07:00
|
|
|
raw_spin_lock_irq(&object->lock);
|
2009-09-04 17:44:51 -07:00
|
|
|
if ((object->flags & OBJECT_REPORTED) &&
|
|
|
|
unreferenced_object(object))
|
2009-09-04 17:44:52 -07:00
|
|
|
__paint_it(object, KMEMLEAK_GREY);
|
2022-06-14 15:03:57 -07:00
|
|
|
raw_spin_unlock_irq(&object->lock);
|
2009-09-04 17:44:51 -07:00
|
|
|
}
|
|
|
|
rcu_read_unlock();
|
2014-04-03 14:46:26 -07:00
|
|
|
|
|
|
|
kmemleak_found_leaks = false;
|
2009-09-04 17:44:51 -07:00
|
|
|
}
|
|
|
|
|
2014-04-03 14:46:27 -07:00
|
|
|
static void __kmemleak_do_cleanup(void);
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
|
|
|
* File write operation to configure kmemleak at run-time. The following
|
|
|
|
* commands can be written to the /sys/kernel/debug/kmemleak file:
|
|
|
|
* off - disable kmemleak (irreversible)
|
|
|
|
* stack=on - enable the task stacks scanning
|
|
|
|
* stack=off - disable the tasks stacks scanning
|
|
|
|
* scan=on - start the automatic memory scanning thread
|
|
|
|
* scan=off - stop the automatic memory scanning thread
|
|
|
|
* scan=... - set the automatic memory scanning period in seconds (0 to
|
|
|
|
* disable it)
|
2009-06-26 09:38:27 -07:00
|
|
|
* scan - trigger a memory scan
|
2009-09-04 17:44:51 -07:00
|
|
|
* clear - mark all current reported unreferenced kmemleak objects as
|
2014-04-03 14:46:27 -07:00
|
|
|
* grey to ignore printing them, or free all kmemleak objects
|
|
|
|
* if kmemleak has been disabled.
|
2009-08-27 06:29:15 -07:00
|
|
|
* dump=... - dump information about the object found at the given address
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
|
|
|
static ssize_t kmemleak_write(struct file *file, const char __user *user_buf,
|
|
|
|
size_t size, loff_t *ppos)
|
|
|
|
{
|
|
|
|
char buf[64];
|
|
|
|
int buf_size;
|
2009-07-07 02:32:58 -07:00
|
|
|
int ret;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
buf_size = min(size, (sizeof(buf) - 1));
|
|
|
|
if (strncpy_from_user(buf, user_buf, buf_size) < 0)
|
|
|
|
return -EFAULT;
|
|
|
|
buf[buf_size] = 0;
|
|
|
|
|
2009-07-07 02:32:58 -07:00
|
|
|
ret = mutex_lock_interruptible(&scan_mutex);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
|
|
|
|
2014-04-03 14:46:27 -07:00
|
|
|
if (strncmp(buf, "clear", 5) == 0) {
|
2014-04-03 14:46:29 -07:00
|
|
|
if (kmemleak_enabled)
|
2014-04-03 14:46:27 -07:00
|
|
|
kmemleak_clear();
|
|
|
|
else
|
|
|
|
__kmemleak_do_cleanup();
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2014-04-03 14:46:29 -07:00
|
|
|
if (!kmemleak_enabled) {
|
2019-07-11 20:53:43 -07:00
|
|
|
ret = -EPERM;
|
2014-04-03 14:46:27 -07:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
if (strncmp(buf, "off", 3) == 0)
|
|
|
|
kmemleak_disable();
|
|
|
|
else if (strncmp(buf, "stack=on", 8) == 0)
|
|
|
|
kmemleak_stack_scan = 1;
|
|
|
|
else if (strncmp(buf, "stack=off", 9) == 0)
|
|
|
|
kmemleak_stack_scan = 0;
|
|
|
|
else if (strncmp(buf, "scan=on", 7) == 0)
|
|
|
|
start_scan_thread();
|
|
|
|
else if (strncmp(buf, "scan=off", 8) == 0)
|
|
|
|
stop_scan_thread();
|
|
|
|
else if (strncmp(buf, "scan=", 5) == 0) {
|
2021-06-28 19:35:01 -07:00
|
|
|
unsigned secs;
|
|
|
|
unsigned long msecs;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2021-06-28 19:35:01 -07:00
|
|
|
ret = kstrtouint(buf + 5, 0, &secs);
|
2009-07-07 02:32:58 -07:00
|
|
|
if (ret < 0)
|
|
|
|
goto out;
|
2021-06-28 19:35:01 -07:00
|
|
|
|
|
|
|
msecs = secs * MSEC_PER_SEC;
|
|
|
|
if (msecs > UINT_MAX)
|
|
|
|
msecs = UINT_MAX;
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
stop_scan_thread();
|
2021-06-28 19:35:01 -07:00
|
|
|
if (msecs) {
|
|
|
|
WRITE_ONCE(jiffies_scan_wait, msecs_to_jiffies(msecs));
|
2009-06-11 05:22:39 -07:00
|
|
|
start_scan_thread();
|
|
|
|
}
|
2009-06-26 09:38:27 -07:00
|
|
|
} else if (strncmp(buf, "scan", 4) == 0)
|
|
|
|
kmemleak_scan();
|
2009-08-27 06:29:15 -07:00
|
|
|
else if (strncmp(buf, "dump=", 5) == 0)
|
|
|
|
ret = dump_str_object_info(buf + 5);
|
2009-06-26 09:38:27 -07:00
|
|
|
else
|
2009-07-07 02:32:58 -07:00
|
|
|
ret = -EINVAL;
|
|
|
|
|
|
|
|
out:
|
|
|
|
mutex_unlock(&scan_mutex);
|
|
|
|
if (ret < 0)
|
|
|
|
return ret;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/* ignore the rest of the buffer, only one command at a time */
|
|
|
|
*ppos += size;
|
|
|
|
return size;
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct file_operations kmemleak_fops = {
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.open = kmemleak_open,
|
|
|
|
.read = seq_read,
|
|
|
|
.write = kmemleak_write,
|
|
|
|
.llseek = seq_lseek,
|
2014-04-03 14:46:28 -07:00
|
|
|
.release = seq_release,
|
2009-06-11 05:22:39 -07:00
|
|
|
};
|
|
|
|
|
2014-04-03 14:46:27 -07:00
|
|
|
static void __kmemleak_do_cleanup(void)
|
|
|
|
{
|
2019-10-04 06:46:24 -07:00
|
|
|
struct kmemleak_object *object, *tmp;
|
2014-04-03 14:46:27 -07:00
|
|
|
|
2019-10-04 06:46:24 -07:00
|
|
|
/*
|
|
|
|
* Kmemleak has already been disabled, no need for RCU list traversal
|
|
|
|
* or kmemleak_lock held.
|
|
|
|
*/
|
|
|
|
list_for_each_entry_safe(object, tmp, &object_list, object_list) {
|
|
|
|
__remove_object(object);
|
|
|
|
__delete_object(object);
|
|
|
|
}
|
2014-04-03 14:46:27 -07:00
|
|
|
}
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
2011-09-29 03:50:07 -07:00
|
|
|
* Stop the memory scanning thread and free the kmemleak internal objects if
|
|
|
|
* no previous scan thread (otherwise, kmemleak may still have some useful
|
|
|
|
* information on memory leaks).
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
2009-09-07 02:14:42 -07:00
|
|
|
static void kmemleak_do_cleanup(struct work_struct *work)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
|
|
|
stop_scan_thread();
|
|
|
|
|
2018-03-28 16:01:16 -07:00
|
|
|
mutex_lock(&scan_mutex);
|
2015-06-24 16:58:26 -07:00
|
|
|
/*
|
2018-03-28 16:01:16 -07:00
|
|
|
* Once it is made sure that kmemleak_scan has stopped, it is safe to no
|
|
|
|
* longer track object freeing. Ordering of the scan thread stopping and
|
|
|
|
* the memory accesses below is guaranteed by the kthread_stop()
|
|
|
|
* function.
|
2015-06-24 16:58:26 -07:00
|
|
|
*/
|
|
|
|
kmemleak_free_enabled = 0;
|
2018-03-28 16:01:16 -07:00
|
|
|
mutex_unlock(&scan_mutex);
|
2015-06-24 16:58:26 -07:00
|
|
|
|
2014-04-03 14:46:27 -07:00
|
|
|
if (!kmemleak_found_leaks)
|
|
|
|
__kmemleak_do_cleanup();
|
|
|
|
else
|
2016-03-17 14:19:47 -07:00
|
|
|
pr_info("Kmemleak disabled without freeing internal data. Reclaim the memory with \"echo clear > /sys/kernel/debug/kmemleak\".\n");
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
2009-09-07 02:14:42 -07:00
|
|
|
static DECLARE_WORK(cleanup_work, kmemleak_do_cleanup);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Disable kmemleak. No memory allocation/freeing will be traced once this
|
|
|
|
* function is called. Disabling kmemleak is an irreversible operation.
|
|
|
|
*/
|
|
|
|
static void kmemleak_disable(void)
|
|
|
|
{
|
|
|
|
/* atomically check whether it was already invoked */
|
2014-04-03 14:46:29 -07:00
|
|
|
if (cmpxchg(&kmemleak_error, 0, 1))
|
2009-06-11 05:22:39 -07:00
|
|
|
return;
|
|
|
|
|
|
|
|
/* stop any memory operation tracing */
|
2014-04-03 14:46:29 -07:00
|
|
|
kmemleak_enabled = 0;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
/* check whether it is too early for a kernel thread */
|
2023-08-15 07:41:28 -07:00
|
|
|
if (kmemleak_late_initialized)
|
2009-09-07 02:14:42 -07:00
|
|
|
schedule_work(&cleanup_work);
|
2015-06-24 16:58:26 -07:00
|
|
|
else
|
|
|
|
kmemleak_free_enabled = 0;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
pr_info("Kernel memory leak detector disabled\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Allow boot-time kmemleak disabling (enabled by default).
|
|
|
|
*/
|
2018-04-05 16:23:46 -07:00
|
|
|
static int __init kmemleak_boot_config(char *str)
|
2009-06-11 05:22:39 -07:00
|
|
|
{
|
|
|
|
if (!str)
|
|
|
|
return -EINVAL;
|
|
|
|
if (strcmp(str, "off") == 0)
|
|
|
|
kmemleak_disable();
|
2023-01-18 18:22:25 -07:00
|
|
|
else if (strcmp(str, "on") == 0) {
|
2010-07-19 03:54:17 -07:00
|
|
|
kmemleak_skip_disable = 1;
|
2023-02-10 14:15:51 -07:00
|
|
|
stack_depot_request_early_init();
|
2023-01-18 18:22:25 -07:00
|
|
|
}
|
2010-07-19 03:54:17 -07:00
|
|
|
else
|
2009-06-11 05:22:39 -07:00
|
|
|
return -EINVAL;
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
early_param("kmemleak", kmemleak_boot_config);
|
|
|
|
|
|
|
|
/*
|
2009-06-17 10:29:04 -07:00
|
|
|
* Kmemleak initialization.
|
2009-06-11 05:22:39 -07:00
|
|
|
*/
|
|
|
|
void __init kmemleak_init(void)
|
|
|
|
{
|
2010-07-19 03:54:17 -07:00
|
|
|
#ifdef CONFIG_DEBUG_KMEMLEAK_DEFAULT_OFF
|
|
|
|
if (!kmemleak_skip_disable) {
|
|
|
|
kmemleak_disable();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
2019-09-23 15:34:05 -07:00
|
|
|
if (kmemleak_error)
|
|
|
|
return;
|
|
|
|
|
2009-06-11 05:22:39 -07:00
|
|
|
jiffies_min_age = msecs_to_jiffies(MSECS_MIN_AGE);
|
|
|
|
jiffies_scan_wait = msecs_to_jiffies(SECS_SCAN_WAIT * 1000);
|
|
|
|
|
|
|
|
object_cache = KMEM_CACHE(kmemleak_object, SLAB_NOLEAKTRACE);
|
|
|
|
scan_area_cache = KMEM_CACHE(kmemleak_scan_area, SLAB_NOLEAKTRACE);
|
|
|
|
|
2019-04-05 18:38:49 -07:00
|
|
|
/* register the data/bss sections */
|
|
|
|
create_object((unsigned long)_sdata, _edata - _sdata,
|
|
|
|
KMEMLEAK_GREY, GFP_ATOMIC);
|
|
|
|
create_object((unsigned long)__bss_start, __bss_stop - __bss_start,
|
|
|
|
KMEMLEAK_GREY, GFP_ATOMIC);
|
|
|
|
/* only register .data..ro_after_init if not within .data */
|
2020-04-01 21:04:34 -07:00
|
|
|
if (&__start_ro_after_init < &_sdata || &__end_ro_after_init > &_edata)
|
2019-04-05 18:38:49 -07:00
|
|
|
create_object((unsigned long)__start_ro_after_init,
|
|
|
|
__end_ro_after_init - __start_ro_after_init,
|
|
|
|
KMEMLEAK_GREY, GFP_ATOMIC);
|
2009-06-11 05:22:39 -07:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Late initialization function.
|
|
|
|
*/
|
|
|
|
static int __init kmemleak_late_init(void)
|
|
|
|
{
|
2023-08-15 07:41:28 -07:00
|
|
|
kmemleak_late_initialized = 1;
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2019-01-22 08:21:12 -07:00
|
|
|
debugfs_create_file("kmemleak", 0644, NULL, NULL, &kmemleak_fops);
|
2018-09-04 15:45:44 -07:00
|
|
|
|
2014-04-03 14:46:29 -07:00
|
|
|
if (kmemleak_error) {
|
2009-06-11 05:22:39 -07:00
|
|
|
/*
|
2011-03-30 18:57:33 -07:00
|
|
|
* Some error occurred and kmemleak was disabled. There is a
|
2009-06-11 05:22:39 -07:00
|
|
|
* small chance that kmemleak_disable() was called immediately
|
2023-08-15 07:41:28 -07:00
|
|
|
* after setting kmemleak_late_initialized and we may end up with
|
2009-06-11 05:22:39 -07:00
|
|
|
* two clean-up threads but serialized by scan_mutex.
|
|
|
|
*/
|
2009-09-07 02:14:42 -07:00
|
|
|
schedule_work(&cleanup_work);
|
2009-06-11 05:22:39 -07:00
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
2018-12-28 01:38:54 -07:00
|
|
|
if (IS_ENABLED(CONFIG_DEBUG_KMEMLEAK_AUTO_SCAN)) {
|
|
|
|
mutex_lock(&scan_mutex);
|
|
|
|
start_scan_thread();
|
|
|
|
mutex_unlock(&scan_mutex);
|
|
|
|
}
|
2009-06-11 05:22:39 -07:00
|
|
|
|
2019-09-23 15:34:07 -07:00
|
|
|
pr_info("Kernel memory leak detector initialized (mem pool available: %d)\n",
|
|
|
|
mem_pool_free_count);
|
2009-06-11 05:22:39 -07:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
late_initcall(kmemleak_late_init);
|