Commit Graph

31 Commits

Author SHA1 Message Date
Trevor Brown
162cb8ecee feat(golang-rewrite): get remaining shim_exec.bats tests passing
* Disable custom shim template tests
* Document another breaking change
* Enable `shim_exec.bats` tests
* Fix bug in `shims.getCustomExecutablePath` function
* Pass default relative executable path as third argument to `exec-path` callback
* Get remaining `shim_exec.bats` tests passing
2024-12-18 11:32:03 -05:00
Trevor Brown
924eecfa6a feat(golang-rewrite): introduce Version struct, get some shim_exec.bats tests passing
* Get more shim_exec.bats tests passing by adding shebang lines to test scripts
* Disable shim_exec test case for scenario that is no longer possible
* Add documentation on another breaking change
* Create toolversions.Version struct and update code to use new struct
2024-12-18 11:32:03 -05:00
Edwin Kofler
491ef2a9f2
test: rm useless echo usage in tests (#1535) 2023-04-11 03:58:58 +00:00
Edwin Kofler
bbcbddcdd4
fix: Better handling with paths that include spaces (#1485) 2023-03-24 12:37:23 +00:00
Edwin Kofler
90ead5ea0a
chore: Fix ShellCheck errors in tests (#1459)
Closes https://github.com/asdf-vm/asdf/issues/1396
2023-01-27 23:17:41 +11:00
Edwin Kofler
ffa018763c
chore: Fix ShellCheck errors in tests (#1452) 2023-01-26 00:37:21 +11:00
Edwin Kofler
f0fe961373
chore: Remove useless echos in test/ (#1455) 2023-01-25 18:40:03 +11:00
Edwin Kofler
28b348a041
chore: Fix ShellCheck errors in tests (#1450) 2023-01-23 15:29:18 +11:00
Edwin Kofler
b5e981cf1d
chore: Fix ShellCheck errors in tests (#1449) 2023-01-23 10:36:47 +11:00
Edwin Kofler
6f64aa8d84
chore: Fix ShellCheck errors in tests (#1444) 2023-01-22 23:04:46 +11:00
Edwin Kofler
998180e362
chore: Fix ShellCheck errors in tests (#1443) 2023-01-22 21:55:19 +11:00
Edwin Kofler
407a6696c0
chore: fix ShellCheck errors in tests (#1433) 2023-01-22 20:20:23 +11:00
Edwin Kofler
d81b81f9de
fix: Remove == inside [ (#1421)
* lint(checkstyle): Miscellaneous tweaks
* lint(checkstyle): Add 'no-double-equals' rule
* lint: Remove double equals from `[`
* chore: Remove final double equals

Co-authored-by: Trevor Brown <Stratus3D@users.noreply.github.com>
2023-01-14 08:18:44 -05:00
Chris Rose
41162849cf
fix: clarify the wording when no version is set (#1088)
Co-authored-by: Chris Rose <offline@offby1.net>
Co-authored-by: jthegedus <jthegedus@hey.com>
2021-11-14 14:35:42 +11:00
Jean-Paul Bonnetouche
0de6910d1f fix: shims break when POSIXLY_CORRECT=1
Process substitution isn't specified by POSIX and makes shims break when called by a script that `export POSIXLY_CORRECT=1` (like gitflow [here](https://github.com/nvie/gitflow/blob/develop/git-flow#L78)).

Here we replace `grep -f <(cmd1) <(cmd2)` with `cmd2 | grep -F "$(cmd1)"` so that we can provide a string instead of a file descriptor and get the same result as before.

(Note: We also check if the result of `cmd1` is empty before running `grep` to get the same behavior as with `-f`. This also prevent crashes if null results are piped to `xargs` and fits nicely with the `with_shim_executable` function that already check the result of `$selected_version` before going on).

Fixes: #581
2021-01-14 13:19:27 +01:00
Jochen Schalanda
0edb50547c
feat: support for "latest" in shell, local, and global (#802) 2020-09-19 15:37:52 +10:00
James Hegedus
a5c815b6d4
fix: print tool-versions file dir on shim error (#750) 2020-07-31 18:46:33 +10:00
Trevor Brown
42182f31c4 Add test for shim exec of path versions 2020-02-07 22:32:04 -05:00
Luke Bonaccorsi
c728018627 Fix issue with preset version warning assuming that the shim name and plugin name are the same 2019-12-20 17:26:00 +00:00
Teja Sophista
026aa78f35 Output different warning for empty and missing version
1. when `.tool-versions` is not set
2. when `.tool-versions` set version that is not installed
2019-12-04 14:18:58 +00:00
Daniel Perez
450660018c Revert to using exec when running a shim 2019-03-26 17:36:08 +00:00
Daniel Perez
0f0bbef50d Fix select version when multiple versions available
With the previous version, the following case would fail.
It would use python 2.7.15 when running pip
instead of version 3.7.2.

Shim for `pip`

```bash
exec /home/daniel/.asdf/bin/asdf exec "pip" "$@"
```

`.tool-versions`:

```
python 3.7.2 2.7.15 system
```
2019-03-20 17:20:01 +00:00
Daniel Perez
c06799cfca Fix legacy version and multi versions handling 2019-03-16 19:45:37 +00:00
Victor Hugo Borja
4b40e80776 Test that command being executed can see other tools shims on path 2019-01-23 22:18:18 -06:00
Victor Hugo Borja
0260c442cc Test to ensure asdf exec and asdf env use plugin custom exec-env 2019-01-21 01:33:52 -06:00
Victor Hugo Borja
ab59e5618f Move common functionality to utils.sh
- Make shim-exec, shim-env, and which use the same logic to look for commands
- Make sure shim-exec and which use a plugin exec-path hook as documented
  (the hook takes a relative path to the executable and returns also
   a relative path, possibly modified)
- Fix shellchecks
2019-01-20 14:02:22 -06:00
Victor Hugo Borja
9cac0ac50a Faster exec times. Load commands only when nedded.
When testing, use `run asdf` to actually test the command
as the user would invoke it, so that we might catch possible
errors on `bin/asdf`.
2019-01-20 02:13:20 -06:00
Victor Hugo Borja
6da747b6ce Test that asdf exec works even if asdf shims are not in PATH. 2019-01-19 20:09:53 -06:00
Victor Hugo Borja
e51f778b61 Move bin/private/asdf-tool-exec to be asdf exec command
This way the code for executing shims can also be invoked via
`asdf exec <tool> [args..]` and can be linted.
2019-01-19 20:02:14 -06:00
Victor Hugo Borja
9a79ac9526 user configurable pre-post command hooks
Suppose a `foo` plugin is installed and provides a `bar` executable.
The following hooks will be executed when set in `.asdfrc`:

```shell
post_asdf_install_foo = echo installed foo version ${1}
post_asdf_reshim_foo = echo reshimmed foo version ${1}

pre_foo_bar = echo about to execute command bar from foo with args: ${@}
post_foo_bar = echo just executed command bar from foo with args: ${@}
```
2019-01-19 13:32:07 -06:00
Victor Hugo Borja
9b27848d07 New shim metadata to allow many plugins with same executable names
Features

* New shim version meta-data allows shims to not depend on a particular plugin
  nor on its relative executable path (#431)
  Upgrading requires shim re-generation and should happen automatically
  by `asdf-exec`:
    `rm -rf ~/.asdf/shims/` followed by `asdf reshim`
* Added lots of tests for shim execution.
  We now make sure that shim execution obeys plugins hooks like
  `list-bin-paths` and `exec-path`.
* Shim exec is now performed by a new `bin/private/asdf-tool-exec` that might
  be faster for most common use case: (versions on local .tool-versions file)
  but fallbacks to slower `get_preset_version_for` which takes legacy formats
  into account.
* Shim exec recommends which plugins or versions to set when command is
  not found.

Fixed Bugs

* Allow many plugins to provide shims with same executable name (#431)
2019-01-19 13:22:12 -06:00