kevin/asdf
1
Fork 0
mirror of https://github.com/asdf-vm/asdf.git synced 2024-11-15 09:38:16 -07:00
Code Issues Packages Projects Releases Wiki Activity
1,476 Commits 19 Branches 39 Tags 20 MiB
711ad99104
Commit Graph

466 Commits

Author SHA1 Message Date
James Hegedus
456d8e36ca
fix: <plugin update all> to latest commit on default branch for each plugin (#800) 2021-03-02 17:37:05 +11:00
Trevor Brown
f633811577 Ban process substitution from asdf codebase 2021-02-05 11:28:27 -05:00
Nanda Lopes
dc776c0bc0 Fix find global options warning 
find: warning: you have specified the global option -mindepth after the argument
-type, but global options are not positional, i.e., -mindepth affects tests
specified before it as well as those specified after it.  Please specify global
options before other arguments.

find: warning: you have specified the global option -maxdepth after the argument
-type, but global options are not positional, i.e., -maxdepth affects tests
specified before it as well as those specified after it.  Please specify global
options before other arguments.
 2021-01-19 11:14:26 -03:00
Jean-Paul Bonnetouche
0de6910d1f fix: shims break when POSIXLY_CORRECT=1 
Process substitution isn't specified by POSIX and makes shims break when called by a script that `export POSIXLY_CORRECT=1` (like gitflow [here](https://github.com/nvie/gitflow/blob/develop/git-flow#L78)).

Here we replace `grep -f <(cmd1) <(cmd2)` with `cmd2 | grep -F "$(cmd1)"` so that we can provide a string instead of a file descriptor and get the same result as before.

(Note: We also check if the result of `cmd1` is empty before running `grep` to get the same behavior as with `-f`. This also prevent crashes if null results are piped to `xargs` and fits nicely with the `with_shim_executable` function that already check the result of `$selected_version` before going on).

Fixes: #581
 2021-01-14 13:19:27 +01:00
Aaron Jensen
d2b7e2fceb
Update no plugin installed error message (#818) 2020-12-21 11:00:09 +11:00
Trevor Brown
34593c1766 Fix resolution of relative symlinks 
Fixes #366, #625
 2020-10-08 10:17:01 -04:00
Trevor Brown
ebc52b150b
Merge branch 'master' into parallelize-plugin-updates 2020-09-28 12:16:06 -04:00
Trevor Brown
8bbefba072
chore: ban echo command (#806) 2020-09-22 08:27:52 +10:00
Jochen Schalanda
0edb50547c
feat: support for "latest" in shell, local, and global (#802) 2020-09-19 15:37:52 +10:00
Trevor Brown
d93a2b6fe1 Fix syntax for plugin update loop 2020-09-18 11:41:56 -04:00
Joel Parker Henderson
0efc04bca5
Fix plugin-update --all when there are no plugins 
Issue: when asdf is first installed, there are no plugins, and running `asdf plugin-update --all` crashes because the plugin directory doesn't exist; similarly, the command crashes if the plugins directory exists yet doesn't contain any subdirectories.

Solution: This patch changes the directory loop from using a wildcard `plugins/*` to a more robust approach: first verify the plugins directory exists, then use the`find` command to list subdirectories and correctly handle the corner case of no subdirectories.

Future: Consider printing an error message and/or advice message. Consider automatically creating the plugins directory as needed. Consider prompting the user to install some popular plugins.
 2020-09-16 21:00:35 -07:00
James Hegedus
b178cb07a7
fix: rm asdf current header row for now (#793) 2020-09-02 09:11:07 +10:00
Timo Sand
d27b3661a9
Fixes linter issues 2020-09-01 23:27:56 +02:00
Timo Sand
cd4c1c5748
Changes to use function to update plugin 
Enables us to add parallelization
 2020-09-01 23:27:56 +02:00
James Hegedus
e9c149ea21
fix: incorrect version output in asdf current (#746) 2020-08-29 09:09:22 +10:00
Daniel Perez
77a748d70a
fix: _where_ bug when multiple versions are selected (#790) 
Fixes #690
 2020-08-28 19:24:59 +10:00
James Hegedus
8ca2af3316
feat: cmd to print debug information (#787) 2020-08-24 10:55:41 +10:00
samontea
b6deb141b5 fix: typo causing plugin-test to erroneously fail 2020-08-17 15:38:36 -07:00
Daniel Perez
1a01356935
fix: plugin test to emit error message when latest fails (#772) 
Fix #756
 2020-08-10 13:27:35 +10:00
Trevor Brown
cc0023b022
feat: plugin documentation callback support 🎉 (#757) 2020-07-31 18:47:18 +10:00
James Hegedus
a5c815b6d4
fix: print tool-versions file dir on shim error (#750) 2020-07-31 18:46:33 +10:00
Dan Fuchs
6a1855e26f Install one tool specified in .tool-versions 
`asdf install <name>` installs that single tool at the version specified
in `.tool-versions`.  If there is no `.tool-versions` or if that tool is
not in it, an error message is shown and `asdf` exits `1`.

Implements #759
 2020-07-09 18:16:50 -05:00
James Hegedus
50feef2a77
fix: CI formatting use editorconfig (#751) 2020-06-30 09:16:35 +10:00
Thomas B Homburg
1b7b4da0a6
fix: remove column command in favor of awk (#721) 2020-06-17 08:26:46 +10:00
Alexandre ZANNI
f5c7dae331
fix: asdf shell command docs & help output (#737) 
Co-authored-by: James Hegedus <james@jthegedus.com>
 2020-06-13 10:43:52 +10:00
James Hegedus
0f80ac3567
fix: remove sort --version-sort from command-latest as list is already sorted (#700) 2020-06-09 09:24:41 +10:00
Aravinda Rao
fe26274f38 Ensure consistency in indentation for message shown when no versions installed 2020-05-18 21:48:27 +05:30
Trevor Brown
410f414529 Remove downloads when removing a plugin 2020-05-14 09:13:51 -04:00
Trevor Brown
2a058af9eb
Merge branch 'master' into tb/keep-source 2020-05-08 10:21:59 -04:00
Trevor Brown
f28c518dc7 Address shellcheck warnings 2020-05-05 08:57:42 -04:00
Trevor Brown
309a4f1a12 Don't delete the download directory if the --keep-download flag is passed or the always_keep_download config is set to yes 2020-05-04 15:05:10 -04:00
Trevor Brown
a886303065 Remove duplicate mkdir calls in install_tool_version function 2020-05-04 10:51:07 -04:00
Trevor Brown
c4c022454f Revert "Change exit code to 0 and output message to stdout" 
This reverts commit e48ed1c228.
 2020-03-31 09:09:52 -04:00
Paulo Renato
e48ed1c228 Change exit code to 0 and output message to stdout 2020-03-30 16:06:12 -03:00
Jochen Schalanda
3c3f0e67f6
Rename custom plugin-add/plugin-remove for plugins (#684) 
Rename custom scripts for `plugin-add` and `plugin-remove` phases in plugins to make clear when they are executed:

`plugin-add` -> `post-plugin-add`
`plugin-remove` -> `pre-plugin-remove`
 2020-03-22 12:57:54 +11:00
Jochen Schalanda
57186be6d9
Support customizing plugin-add and plugin-remove 
* Add support for custom `plugin-add` and `plugin-remove` in plugins
* Add configurable command hooks for plugin installation and removal

```shell
pre_asdf_plugin_remove = echo will remove plugin ${1}
pre_asdf_plugin_remove_foo = echo will remove plugin foo
post_asdf_plugin_remove = echo removed plugin ${1}
post_asdf_plugin_remove_foo = echo removed plugin foo
```

Closes #670
 2020-03-21 14:59:33 +01:00
Victor Hugo Borja
a26bed6586 Make sure extension commands are properly displayed by asdf help 2020-03-15 11:45:09 -06:00
Jochen Schalanda
609e41e276 Use different exit code if updates are disabled 
If asdf-vm was installed with a package manager and the user doesn't
have the necessary permissions to update it with `asdf update`, asdf-vm
emits an informational message and exits with exit code 1.

This makes it hard to programmatically detect whether the update failed
or wasn't even attempted because it's not possible.

With this change, asdf-vm would exit with the exit code 42 if updates are
disabled instead of exit code 1, which signals an error during update.

Refs r-darwish/topgrade#367
 2020-03-13 10:14:28 +01:00
Pablo Lalloni
4ee4c1431c Default to empty version to avoid error on strict mode bash 2020-03-07 09:26:16 -03:00
Trevor Brown
ac62c7c4d4 Invoke the plugin's download script before invoking the plugin's install script 2020-03-06 19:15:06 -05:00
Trevor Brown
91a2a1f7be Add get_download_path function 2020-03-06 18:54:33 -05:00
Trevor Brown
52cbf1165c Add .bash file extensions to files containing code executed by Bash 2020-03-02 12:48:05 -05:00
Victor Borja
543e16ef5b
Merge pull request #657 from asdf-vm/fix/consistent-use-pluginname 
fix: consistent use of plugin_name
 2020-02-14 14:36:23 -06:00
Victor Borja
62c4fdb163
Merge pull request #623 from jonmast/prevent-exec-recursion 
Ignore shim directory for executable lookups
 2020-02-14 14:26:03 -06:00
James Hegedus
c69ed91886
fix: consistent use of plugin_name 
All other instances of `check_if_plugin_exists` pass the value as `plugin_name`. Minor fix for consistency.
 2020-02-14 17:21:58 +11:00
Trevor Brown
43bd2d2cb5 Address linting errors 2020-02-07 22:51:03 -05:00
Trevor Brown
c0222b0b4e Add back in support for path versions in shim code 2020-02-07 22:50:21 -05:00
Trevor Brown
e4ddf560e8 Move function definitions out of with_shim_executable function 2020-02-07 22:32:04 -05:00
Trevor Brown
e79016add3
Merge pull request #630 from lalloni/default-to-empty-asdf-data-dir 
Defaults to empty ASDF_DATA_DIR
 2020-02-06 07:15:07 -05:00
Trevor Brown
e4a9ad6e58
Merge pull request #649 from asdf-vm/tb/misc-test-improvements 
Misc. Test Improvements
 2020-02-05 07:51:42 -05:00
Trevor Brown
1dc939bb52 Simplify asdf_data_dir function 2020-02-05 07:47:02 -05:00
Trevor Brown
f787b719ac
Merge pull request #640 from asdf-vm/improve-export-shell 
Fix asdf shell xx --unset for fish
 2020-02-04 08:17:54 -05:00
Trevor Brown
a6b8996f2a Address shellcheck warnings 2020-01-29 08:04:39 -05:00
Daniel Perez
e53de6726f Fix asdf shell xx --unset for fish 2020-01-25 20:42:43 +00:00
Pablo Lalloni
95e0f534e6 Defaults to empty ASDF_DATA_DIR 
If ASDF_DATA_DIR variable is undefined it will assign an empty value to
it so bash instances running with set -o nounset can run the script
without error.
 2019-12-31 09:58:05 -03:00
Jonathan Mast
069c74f45e
Ignore shim directory for executable lookups 
Previously, the shims directory was only excluded for system versions,
which meant that `asdf exec` would fall back to a shim if the install
didn't have the desired binary. If the shims are up to date this isn't a
problem since we check the metadata, but it causes issues if those are
out of sync for whatever reason.

I've checked all the uses of this function and I'm not seeing anywhere
we should need the old behavior.
 2019-12-21 15:24:55 -05:00
Luke Bonaccorsi
c728018627 Fix issue with preset version warning assuming that the shim name and plugin name are the same 2019-12-20 17:26:00 +00:00
Victor Borja
ff57001691
Merge pull request #609 from tejanium/clearer-warning 
Clarify instructions when <version> of a <shim_name> is missing.
 2019-12-13 12:02:16 -06:00
Teja Sophista
026aa78f35 Output different warning for empty and missing version 
1. when `.tool-versions` is not set
2. when `.tool-versions` set version that is not installed
 2019-12-04 14:18:58 +00:00
Victor Hugo Borja
5ab01f49df Allow eval only on asdf function at lib/asdf.sh. 
It's needed for `asdf shell` command.
 2019-12-03 11:04:04 -06:00
Teja Sophista
c9014666e2 Clarify instructions when <version> of a <shim_name> is missing. 2019-12-03 14:21:31 +00:00
Timo Sand
d76f639c75
Fix shell compatibility with ZSH 
`command eval` does not work in ZSH
 2019-12-01 20:41:28 +01:00
Victor Hugo Borja
04b61ae62c Support latest:<version> on plugin-test 2019-11-30 15:13:41 -06:00
Victor Hugo Borja
c986bc9726 Fix plugin update command to check for at least one arg 2019-11-30 15:03:30 -06:00
Victor Hugo Borja
3d3595c7a3 Improvements to asdf plugin commands. 2019-11-30 14:18:37 -06:00
Victor Hugo Borja
1d48d8dbfb Dont use pull on command-update 2019-11-29 10:42:22 -06:00
Victor Hugo Borja
f0bdbe1d89 fix shellcheck on command-help 2019-11-29 10:20:03 -06:00
Victor Hugo Borja
b8dc5f1604 Run shfmt on bash files 2019-11-29 10:15:38 -06:00
Victor Hugo Borja
3f0fe57db9 Let asdf help show plugin commands when available. 
Also fix `asdf list all` to work as subcommand. Fixes #602
 2019-11-29 07:42:55 -06:00
Victor Hugo Borja
1be6614aa7 Add shellcheck source comments 2019-11-27 12:29:04 -06:00
Victor Hugo Borja
e968fe6142 Subcommand-aware command line interface. 2019-11-27 12:17:17 -06:00
Victor Hugo Borja
4939e24c90 Make asdf plugin test determine plugin version with asdf latest 
Fixes #541
 2019-11-26 22:23:27 -06:00
Victor Hugo Borja
2ea3d2017f asdf --version shows git-revision when asdf_dir is a git clone. 
This will help people running on asdf master be able to report
issues and maintainers can know the precise git commit where the
error was reported.

See #589
 2019-11-26 22:08:45 -06:00
Victor Borja
4279549530
Merge pull request #583 from android10/master 
asdf_data_dir() returning incorrect path when running as root.
 2019-11-25 12:23:17 -06:00
Victor Hugo Borja
70099027c2 Move plugin extension command into it's own file. 
Add a test for calling default command with arguments.
 2019-11-25 12:07:55 -06:00
Kevin Lane
9fd7b83973
Add credit to xxenv-latest in comments 2019-11-22 10:37:53 -08:00
Kevin Lane
d2324e36e7
Fix shellcheck errors 2019-11-22 10:37:53 -08:00
Kevin Lane
301cd3db3f
Add support for installing the latest stable version of a tool 2019-11-22 10:37:53 -08:00
Kevin Lane
36ba38d921
Add asdf latest command to show latest stable version of a tool 2019-11-22 10:37:52 -08:00
Kevin Lane
292d5951bd
Add ability to show available versions that begin with a given string 2019-11-22 10:37:46 -08:00
Trevor Brown
1580310064 Fix sed command so it handles paths correctly 
Fixes #559
 2019-10-31 10:56:41 -04:00
Trevor Brown
72e876b0ae Handle dashes in executable names properly 2019-10-24 12:05:44 -04:00
Fernando Cejas
ded3a41808 Simplify whether asdf is running with privileges. 2019-10-23 14:31:43 +02:00
Fernando Cejas
598503ef74 Fix constant expression. 2019-10-23 13:36:58 +02:00
Fernando Cejas
fc1c586ca6 Add a method to detect whether asdf runs with privileges. 2019-10-23 13:26:33 +02:00
Trevor Brown
edb5839239 Rename find_version to find_versions since it can return multiple versions 2019-10-22 19:03:05 -04:00
Trevor Brown
cea9b9574f Install multiple versions when multiple versions are present in a .tool-versions file 2019-10-22 18:58:30 -04:00
Fernando Cejas
c7c053e41e Fix ASDF_DATA_DIR not being set. 2019-10-22 16:45:56 +02:00
Fernando Cejas
a888e48bd2 Fix asdf data directory. 2019-10-22 15:01:55 +02:00
OZAWA Sakuro
b26f56692d Surround mutually exclusive arguments with curly braces 2019-09-02 11:55:09 +09:00
OZAWA Sakuro
503263a68d Add --unset option to shell command 2019-08-17 22:46:00 +09:00
Trevor Brown
75bd04a464
Merge pull request #560 from asdf-vm/tb/env-path-fix 
with_plugin_env PATH fix
 2019-08-14 20:36:07 -04:00
Trevor Brown
20522bb2e2 Correct bug in path logic that added current directory to PATH 2019-08-14 20:21:57 -04:00
Kevin Lundberg
fd3faf8084 removing unneeded flag on a copy action 2019-07-31 21:42:43 -04:00
Kevin Lundberg
1862ff6eee Only copy the necessary things to the test area 2019-07-31 21:18:54 -04:00
Kevin Lundberg
c77ee57fe2 Fix for asdf plugin-test when installed with brew, and a minor logic fix to a warning 2019-07-30 23:33:07 -04:00
Spencer Carlson
8865f7a66d add quite flag to git clone 2019-07-05 16:38:33 -07:00
Trevor Brown
3516c08c6b Fix failing test 2019-06-17 20:38:17 -04:00
Leonid Shevtsov
d1f09c3fca Change asdf install to loop through available plugins 2019-05-31 08:32:12 +03:00
Trevor Brown
01cd8d6dad Address shellcheck warning and use shell globbing instead of ls 2019-05-17 21:12:41 -04:00