chore: Fix ShellCheck errors in tests (#1452)

scripts/shellcheck.bash

@@ -22,7 +22,5 @@ shellcheck --shell bash --external-sources \
   test/fixtures/dummy_legacy_plugin/bin/* \
   test/fixtures/dummy_plugin/bin/*
 
-# check .bats files
-# TODO(jthegedus): unlock this check later
-# TODO  shellcheck --shell bats --external-sources \
-# TODO  test/*.bats
+shellcheck --shell bats --external-source \
+  --severity warning test/*.bats

test/asdf_fish.bats

@@ -1,4 +1,5 @@
 #!/usr/bin/env bats
+# shellcheck disable=SC2164
 
 load test_helpers
 

test/asdf_nu.bats

@@ -1,4 +1,5 @@
 #!/usr/bin/env bats
+# shellcheck disable=SC2164
 
 load test_helpers
 

test/current_command.bats

@@ -121,7 +121,7 @@ foobar          1.0.0           $PROJECT_DIR/.tool-versions"
 
   run asdf current "y"
   [ "$status" -eq 0 ]
-  [[ "$output" =~ "2.1.0" ]]
+  [[ "$output" == *'2.1.0'* ]]
 }
 
 @test "with no plugins prints an error" {

test/get_asdf_config_value.bats

@@ -1,4 +1,5 @@
 #!/usr/bin/env bats
+# shellcheck disable=SC2164
 
 load test_helpers
 

test/plugin_list_all_command.bats

@@ -33,8 +33,8 @@ foo                           http://example.com/foo"
 
   run asdf plugin list all
   [ "$status" -eq 0 ]
-  [[ "$output" =~ "$expected_plugin_repo_sync" ]]
-  [[ "$output" =~ "$expected_plugins_list" ]]
+  [[ "$output" == *"$expected_plugin_repo_sync"* ]]
+  [[ "$output" == *"$expected_plugins_list"* ]]
 }
 
 @test "plugin_list_all no immediate repo sync expected because check_duration is greater than 0" {

test/shim_env_command.bats

@@ -1,4 +1,5 @@
 #!/usr/bin/env bats
+# shellcheck disable=SC2164
 
 load test_helpers
 
@@ -57,7 +58,7 @@ teardown() {
   run asdf env dummy
   [ "$status" -eq 0 ]
 
-  run grep 'FOO=bar' <(echo "$output")
+  run grep 'FOO=bar' <<<"$output"
   [ "$output" = "" ]
   [ "$status" -eq 1 ]
 
@@ -78,6 +79,6 @@ teardown() {
   [ "$path_line" != "" ]
 
   # Should not contain duplicate colon
-  run grep '::' <(echo "$path_line")
-  [ "$duplicate_colon" = "" ]
+  run grep -q '::' <<<"$path_line"
+  [ "$status" -ne 0 ]
 }

test/shim_exec.bats

@@ -1,4 +1,5 @@
 #!/usr/bin/env bats
+# shellcheck disable=SC2164
 
 load test_helpers
 

test/shim_versions_command.bats

@@ -1,4 +1,5 @@
 #!/usr/bin/env bats
+# shellcheck disable=SC2164
 
 load test_helpers
 

test/utils.bats

@@ -1,4 +1,5 @@
 #!/usr/bin/env bats
+# shellcheck disable=SC2164
 
 load test_helpers
 
@@ -234,7 +235,7 @@ teardown() {
 
   run find_versions "dummy" "$PROJECT_DIR"
   [ "$status" -eq 0 ]
-  [[ "$output" =~ "0.1.0|$HOME/.dummy-version" ]]
+  [[ "$output" == *"0.1.0|$HOME/.dummy-version"* ]]
 }
 
 @test "get_preset_version_for returns the current version" {

test/version_commands.bats

@@ -1,4 +1,5 @@
 #!/usr/bin/env bats
+# shellcheck disable=SC2164
 
 load test_helpers