kevin/asdf
1
Fork 0
mirror of https://github.com/asdf-vm/asdf.git synced 2024-11-15 09:38:16 -07:00
Code Issues Packages Projects Releases Wiki Activity

feat: add messages for bulk install visibility

Browse Source 
Add downloading and installing messages

Signed-off-by: Raimund Hook <rhook@gitlab.com>
This commit is contained in:
Raimund Hook 2024-05-10 16:43:39 +01:00
parent c5116dca60
commit f31c639d37
No known key found for this signature in database
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/functions/installs.bash
View File

@ -194,6 +194,7 @@ install_tool_version() {
if [ -d "$install_path" ]; then if [ -d "$install_path" ]; then
printf "%s %s is already installed\n" "$plugin_name" "$full_version" printf "%s %s is already installed\n" "$plugin_name" "$full_version"
else else
printf "%s %s is being downloaded\n" "$plugin_name" "$full_version"
if [ -f "${plugin_path}/bin/download" ]; then if [ -f "${plugin_path}/bin/download" ]; then
# Not a legacy plugin # Not a legacy plugin
@ -216,6 +217,7 @@ install_tool_version() {
local download_exit_code=$? local download_exit_code=$?
if [ $download_exit_code -eq 0 ]; then if [ $download_exit_code -eq 0 ]; then
( (
printf "%s %s is being installed\n" "$plugin_name" "$full_version"
# shellcheck disable=SC2031 # shellcheck disable=SC2031
export ASDF_INSTALL_TYPE=$install_type export ASDF_INSTALL_TYPE=$install_type
# shellcheck disable=SC2031 # shellcheck disable=SC2031

14
test/install_command.bats
View File

@ -183,7 +183,7 @@ EOM
printf 'dummy 1.0.0\nother-dummy 2.0.0' >"$PROJECT_DIR/.tool-versions" printf 'dummy 1.0.0\nother-dummy 2.0.0' >"$PROJECT_DIR/.tool-versions"
run asdf install dummy other-dummy run asdf install dummy other-dummy
[ "$status" -eq 1 ] [ "$status" -eq 1 ]
[ "$output" = "Dummy couldn't install version: other-dummy (on purpose)" ] [[ "$output" == *"Dummy couldn't install version: other-dummy (on purpose)" ]]
[ ! -f "$ASDF_DIR/installs/dummy/1.0.0/version" ] [ ! -f "$ASDF_DIR/installs/dummy/1.0.0/version" ]
[ ! -f "$ASDF_DIR/installs/other-dummy/2.0.0/version" ] [ ! -f "$ASDF_DIR/installs/other-dummy/2.0.0/version" ]
} }
@ -227,7 +227,7 @@ pre_asdf_install_dummy = echo will install dummy $1
EOM EOM
run asdf install dummy 1.0.0 run asdf install dummy 1.0.0
[ "$output" = "will install dummy 1.0.0" ] [[ "$output" == *"will install dummy 1.0.0" ]]
} }
@test "install command executes configured post plugin install hook" { @test "install command executes configured post plugin install hook" {
@ -236,7 +236,7 @@ post_asdf_install_dummy = echo HEY $version FROM $plugin_name
EOM EOM
run asdf install dummy 1.0.0 run asdf install dummy 1.0.0
[ "$output" = "HEY 1.0.0 FROM dummy" ] [[ "$output" == *"HEY 1.0.0 FROM dummy" ]]
} }
@test "install command without arguments installs versions from legacy files" { @test "install command without arguments installs versions from legacy files" {
@ -295,12 +295,18 @@ EOM
[ "$(cat "$ASDF_DIR/installs/dummy/1.1.0/version")" = "1.1.0" ] [ "$(cat "$ASDF_DIR/installs/dummy/1.1.0/version")" = "1.1.0" ]
} }
@test "install_command outputs installing and downloading messages" {
run asdf install dummy 1.0.0
[ "$status" -eq 0 ]
[[ "$output" == "dummy 1.0.0 is being downloaded"*"dummy 1.0.0 is being installed"* ]]
}
@test "install_command fails when download script exits with non-zero code" { @test "install_command fails when download script exits with non-zero code" {
run asdf install dummy-broken 1.0.0 run asdf install dummy-broken 1.0.0
[ "$status" -eq 1 ] [ "$status" -eq 1 ]
[ ! -d "$ASDF_DIR/downloads/dummy-broken/1.1.0" ] [ ! -d "$ASDF_DIR/downloads/dummy-broken/1.1.0" ]
[ ! -d "$ASDF_DIR/installs/dummy-broken/1.1.0" ] [ ! -d "$ASDF_DIR/installs/dummy-broken/1.1.0" ]
[ "$output" = "Download failed!" ] [[ "$output" == *"Download failed!" ]]
} }
@test "install_command prints info message if plugin does not support preserving download data if --keep-download flag is provided" { @test "install_command prints info message if plugin does not support preserving download data if --keep-download flag is provided" {