kevin/asdf
1
Fork 0
mirror of https://github.com/asdf-vm/asdf.git synced 2024-11-15 01:28:17 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove comments from whole file instead of line by line for performance (#1198)

Browse Source
This commit is contained in:
Bo Lopker 2022-04-08 07:44:07 -07:00 committed by GitHub
parent 7493f4099c
commit de6e22f909
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.tool-versions
View File

@ -1,3 +1,3 @@
bats v1.3.0 bats 1.3.0
shellcheck 0.7.2 shellcheck 0.7.2
shfmt 3.3.0 shfmt 3.3.0

18
lib/utils.bash
View File

@ -637,16 +637,14 @@ shim_plugins() {
strip_tool_version_comments() { strip_tool_version_comments() {
local tool_version_path="$1" local tool_version_path="$1"
# Use sed to strip comments from the tool version file
while IFS= read -r tool_line || [ -n "$tool_line" ]; do # Breakdown of sed command:
# Remove whitespace before pound sign, the pound sign, and everything after it # This command represents 3 steps, seperated by a semi-colon (;), that run on each line.
new_line="$(cut -f1 -d"#" <<<"$tool_line" | sed -e 's/[[:space:]]*$//')" # 1. Delete line if it starts with any blankspace and a #.
# 2. Find a # and delete it and everything after the #.
# Only print the line if it is not empty # 3. Remove any whitespace from the end of the line.
if [[ -n "$new_line" ]]; then # Finally, the command will print the lines that are not empty.
printf "%s\\n" "$new_line" sed '/^[[:blank:]]*#/d;s/#.*//;s/[[:blank:]]*$//' "$tool_version_path"
fi
done <"$tool_version_path"
} }
asdf_run_hook() { asdf_run_hook() {