kevin/asdf
1
Fork 0
mirror of https://github.com/asdf-vm/asdf.git synced 2024-11-15 01:28:17 -07:00
Code Issues Packages Projects Releases Wiki Activity

chore: Fix ShellCheck errors in tests (#1444)

Browse Source
This commit is contained in:
Edwin Kofler 2023-01-22 04:04:46 -08:00 committed by GitHub
parent 998180e362
commit 6f64aa8d84
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
7 changed files with 58 additions and 58 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
test/install_command.bats
View File

@ -47,8 +47,8 @@ teardown() {
@test "install_command set ASDF_CONCURRENCY" { @test "install_command set ASDF_CONCURRENCY" {
run asdf install dummy 1.0.0 run asdf install dummy 1.0.0
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/installs/dummy/1.0.0/env ] [ -f "$ASDF_DIR/installs/dummy/1.0.0/env" ]
run grep ASDF_CONCURRENCY $ASDF_DIR/installs/dummy/1.0.0/env run grep ASDF_CONCURRENCY "$ASDF_DIR/installs/dummy/1.0.0/env"
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
} }
@ -67,16 +67,16 @@ teardown() {
@test "install_command should create a shim with asdf-plugin metadata" { @test "install_command should create a shim with asdf-plugin metadata" {
run asdf install dummy 1.0.0 run asdf install dummy 1.0.0
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/installs/dummy/1.0.0/env ] [ -f "$ASDF_DIR/installs/dummy/1.0.0/env" ]
run grep "asdf-plugin: dummy 1.0.0" $ASDF_DIR/shims/dummy run grep "asdf-plugin: dummy 1.0.0" "$ASDF_DIR/shims/dummy"
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
} }
@test "install_command should create a shim with asdf-plugin metadata for plugins without download script" { @test "install_command should create a shim with asdf-plugin metadata for plugins without download script" {
run asdf install legacy-dummy 1.0.0 run asdf install legacy-dummy 1.0.0
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/installs/legacy-dummy/1.0.0/env ] [ -f "$ASDF_DIR/installs/legacy-dummy/1.0.0/env" ]
run grep "asdf-plugin: legacy-dummy 1.0.0" $ASDF_DIR/shims/dummy run grep "asdf-plugin: legacy-dummy 1.0.0" "$ASDF_DIR/shims/dummy"
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
} }
@ -130,7 +130,7 @@ teardown() {
run asdf install dummy run asdf install dummy
[ "$status" -eq 1 ] [ "$status" -eq 1 ]
[ "$output" = "No versions specified for dummy in config files or environment" ] [ "$output" = "No versions specified for dummy in config files or environment" ]
[ ! -f $ASDF_DIR/installs/dummy/1.1.0/version ] [ ! -f "$ASDF_DIR/installs/dummy/1.1.0/version" ]
} }
@test "install_command fails if the plugin is not installed" { @test "install_command fails if the plugin is not installed" {
@ -156,7 +156,7 @@ teardown() {
run asdf install other-dummy run asdf install other-dummy
[ "$status" -eq 1 ] [ "$status" -eq 1 ]
[ "$output" = "No versions specified for other-dummy in config files or environment" ] [ "$output" = "No versions specified for other-dummy in config files or environment" ]
[ ! -f $ASDF_DIR/installs/dummy/1.0.0/version ] [ ! -f "$ASDF_DIR/installs/dummy/1.0.0/version" ]
} }
@test "install_command fails when two tools are specified with no versions" { @test "install_command fails when two tools are specified with no versions" {
@ -164,8 +164,8 @@ teardown() {
run asdf install dummy other-dummy run asdf install dummy other-dummy
[ "$status" -eq 1 ] [ "$status" -eq 1 ]
[ "$output" = "Dummy couldn't install version: other-dummy (on purpose)" ] [ "$output" = "Dummy couldn't install version: other-dummy (on purpose)" ]
[ ! -f $ASDF_DIR/installs/dummy/1.0.0/version ] [ ! -f "$ASDF_DIR/installs/dummy/1.0.0/version" ]
[ ! -f $ASDF_DIR/installs/other-dummy/2.0.0/version ] [ ! -f "$ASDF_DIR/installs/other-dummy/2.0.0/version" ]
} }
@test "install_command without arguments uses a parent directory .tool-versions file if present" { @test "install_command without arguments uses a parent directory .tool-versions file if present" {
@ -199,7 +199,7 @@ teardown() {
@test "install_command doesn't install system version" { @test "install_command doesn't install system version" {
run asdf install dummy system run asdf install dummy system
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ ! -f $ASDF_DIR/installs/dummy/system/version ] [ ! -f "$ASDF_DIR/installs/dummy/system/version" ]
} }
@test "install command executes configured pre plugin install hook" { @test "install command executes configured pre plugin install hook" {
@ -226,8 +226,8 @@ EOM
cd $PROJECT_DIR cd $PROJECT_DIR
run asdf install run asdf install
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ "$output" = "" ] [ -z "$output" ]
[ -f $ASDF_DIR/installs/dummy/1.2.0/version ] [ -f "$ASDF_DIR/installs/dummy/1.2.0/version" ]
} }
@test "install command without arguments installs versions from legacy files in parent directories" { @test "install command without arguments installs versions from legacy files in parent directories" {
@ -239,8 +239,8 @@ EOM
run asdf install run asdf install
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ "$output" = "" ] [ -z "$output" ]
[ -f $ASDF_DIR/installs/dummy/1.2.0/version ] [ -f "$ASDF_DIR/installs/dummy/1.2.0/version" ]
} }
@test "install_command latest installs latest stable version" { @test "install_command latest installs latest stable version" {
@ -282,7 +282,7 @@ EOM
run asdf install dummy-broken 1.0.0 run asdf install dummy-broken 1.0.0
echo $output echo $output
[ "$status" -eq 1 ] [ "$status" -eq 1 ]
[ ! -d $ASDF_DIR/downloads/dummy-broken/1.1.0 ] [ ! -d "$ASDF_DIR/downloads/dummy-broken/1.1.0" ]
[ ! -d $ASDF_DIR/installs/dummy-broken/1.1.0 ] [ ! -d "$ASDF_DIR/installs/dummy-broken/1.1.0" ]
[ "$output" = "Download failed!" ] [ "$output" = "Download failed!" ]
} }

14
test/plugin_update_command.bats
View File

@ -86,31 +86,31 @@ teardown() {
[ "$(cat "$ASDF_DIR/installs/dummy/1.1/version")" = "1.1" ] [ "$(cat "$ASDF_DIR/installs/dummy/1.1/version")" = "1.1" ]
run asdf plugin-update dummy run asdf plugin-update dummy
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/installs/dummy/1.1/version ] [ -f "$ASDF_DIR/installs/dummy/1.1/version" ]
run asdf plugin-update --all run asdf plugin-update --all
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/installs/dummy/1.1/version ] [ -f "$ASDF_DIR/installs/dummy/1.1/version" ]
} }
@test "asdf plugin-update should not remove plugins" { @test "asdf plugin-update should not remove plugins" {
# dummy plugin is already installed # dummy plugin is already installed
run asdf plugin-update dummy run asdf plugin-update dummy
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -d $ASDF_DIR/plugins/dummy ] [ -d "$ASDF_DIR/plugins/dummy" ]
run asdf plugin-update --all run asdf plugin-update --all
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -d $ASDF_DIR/plugins/dummy ] [ -d "$ASDF_DIR/plugins/dummy" ]
} }
@test "asdf plugin-update should not remove shims" { @test "asdf plugin-update should not remove shims" {
run asdf install dummy 1.1 run asdf install dummy 1.1
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
run asdf plugin-update dummy run asdf plugin-update dummy
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
run asdf plugin-update --all run asdf plugin-update --all
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
} }
@test "asdf plugin-update done for all plugins" { @test "asdf plugin-update done for all plugins" {

10
test/remove_command.bats
View File

@ -34,22 +34,22 @@ teardown() {
install_dummy_plugin install_dummy_plugin
run asdf install dummy 1.0 run asdf install dummy 1.0
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -d $ASDF_DIR/installs/dummy ] [ -d "$ASDF_DIR/installs/dummy" ]
run asdf plugin-remove dummy run asdf plugin-remove dummy
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ ! -d $ASDF_DIR/installs/dummy ] [ ! -d "$ASDF_DIR/installs/dummy" ]
} }
@test "plugin_remove_command should also remove shims for that plugin" { @test "plugin_remove_command should also remove shims for that plugin" {
install_dummy_plugin install_dummy_plugin
run asdf install dummy 1.0 run asdf install dummy 1.0
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
run asdf plugin-remove dummy run asdf plugin-remove dummy
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ ! -f $ASDF_DIR/shims/dummy ] [ ! -f "$ASDF_DIR/shims/dummy" ]
} }
@test "plugin_remove_command should not remove unrelated shims" { @test "plugin_remove_command should not remove unrelated shims" {
@ -63,7 +63,7 @@ teardown() {
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
# unrelated shim should exist # unrelated shim should exist
[ -f $ASDF_DIR/shims/gummy ] [ -f "$ASDF_DIR/shims/gummy" ]
} }
@test "plugin_remove_command executes pre-plugin-remove script" { @test "plugin_remove_command executes pre-plugin-remove script" {

4
test/shim_exec.bats
View File

@ -60,8 +60,8 @@ teardown() {
echo "dummy 1.0" >$PROJECT_DIR/.tool-versions echo "dummy 1.0" >$PROJECT_DIR/.tool-versions
run asdf install run asdf install
echo "tr [:lower:] [:upper:]" >$ASDF_DIR/installs/dummy/1.0/bin/upper echo "tr [:lower:] [:upper:]" >"$ASDF_DIR/installs/dummy/1.0/bin/upper"
chmod +x $ASDF_DIR/installs/dummy/1.0/bin/upper chmod +x "$ASDF_DIR/installs/dummy/1.0/bin/upper"
run asdf reshim dummy 1.0 run asdf reshim dummy 1.0

26
test/uninstall_command.bats
View File

@ -25,7 +25,7 @@ teardown() {
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ "$(cat "$ASDF_DIR/installs/dummy/1.1.0/version")" = "1.1.0" ] [ "$(cat "$ASDF_DIR/installs/dummy/1.1.0/version")" = "1.1.0" ]
run asdf uninstall dummy 1.1.0 run asdf uninstall dummy 1.1.0
[ ! -f $ASDF_DIR/installs/dummy/1.1.0/version ] [ ! -f "$ASDF_DIR/installs/dummy/1.1.0/version" ]
} }
@test "uninstall_command should invoke the plugin bin/uninstall if available" { @test "uninstall_command should invoke the plugin bin/uninstall if available" {
@ -41,29 +41,29 @@ teardown() {
@test "uninstall_command should remove the plugin shims if no other version is installed" { @test "uninstall_command should remove the plugin shims if no other version is installed" {
run asdf install dummy 1.1.0 run asdf install dummy 1.1.0
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
run asdf uninstall dummy 1.1.0 run asdf uninstall dummy 1.1.0
[ ! -f $ASDF_DIR/shims/dummy ] [ ! -f "$ASDF_DIR/shims/dummy" ]
} }
@test "uninstall_command should leave the plugin shims if other version is installed" { @test "uninstall_command should leave the plugin shims if other version is installed" {
run asdf install dummy 1.0.0 run asdf install dummy 1.0.0
[ -f $ASDF_DIR/installs/dummy/1.0.0/bin/dummy ] [ -f "$ASDF_DIR/installs/dummy/1.0.0/bin/dummy" ]
run asdf install dummy 1.1.0 run asdf install dummy 1.1.0
[ -f $ASDF_DIR/installs/dummy/1.1.0/bin/dummy ] [ -f "$ASDF_DIR/installs/dummy/1.1.0/bin/dummy" ]
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
run asdf uninstall dummy 1.0.0 run asdf uninstall dummy 1.0.0
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
} }
@test "uninstall_command should remove relevant asdf-plugin metadata" { @test "uninstall_command should remove relevant asdf-plugin metadata" {
run asdf install dummy 1.0.0 run asdf install dummy 1.0.0
[ -f $ASDF_DIR/installs/dummy/1.0.0/bin/dummy ] [ -f "$ASDF_DIR/installs/dummy/1.0.0/bin/dummy" ]
run asdf install dummy 1.1.0 run asdf install dummy 1.1.0
[ -f $ASDF_DIR/installs/dummy/1.1.0/bin/dummy ] [ -f "$ASDF_DIR/installs/dummy/1.1.0/bin/dummy" ]
run asdf uninstall dummy 1.0.0 run asdf uninstall dummy 1.0.0
run grep "asdf-plugin: dummy 1.1.0" $ASDF_DIR/shims/dummy run grep "asdf-plugin: dummy 1.1.0" $ASDF_DIR/shims/dummy
@ -74,13 +74,13 @@ teardown() {
@test "uninstall_command should not remove other unrelated shims" { @test "uninstall_command should not remove other unrelated shims" {
run asdf install dummy 1.0.0 run asdf install dummy 1.0.0
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
touch $ASDF_DIR/shims/gummy touch "$ASDF_DIR/shims/gummy"
[ -f $ASDF_DIR/shims/gummy ] [ -f "$ASDF_DIR/shims/gummy" ]
run asdf uninstall dummy 1.0.0 run asdf uninstall dummy 1.0.0
[ -f $ASDF_DIR/shims/gummy ] [ -f "$ASDF_DIR/shims/gummy" ]
} }
@test "uninstall command executes configured pre hook" { @test "uninstall command executes configured pre hook" {

22
test/update_command.bats
View File

@ -39,8 +39,8 @@ teardown() {
if [ -n "$tag" ]; then if [ -n "$tag" ]; then
run asdf update run asdf update
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
cd $ASDF_DIR cd "$ASDF_DIR"
git tag | grep $tag git tag | grep "$tag"
[ "$?" -eq 0 ] [ "$?" -eq 0 ]
fi fi
} }
@ -53,8 +53,8 @@ teardown() {
echo "use_release_candidates = yes" >$ASDF_CONFIG_DEFAULT_FILE echo "use_release_candidates = yes" >$ASDF_CONFIG_DEFAULT_FILE
run asdf update run asdf update
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
cd $ASDF_DIR cd "$ASDF_DIR"
git tag | grep $tag git tag | grep "$tag"
[ "$?" -eq 0 ] [ "$?" -eq 0 ]
fi fi
} }
@ -85,29 +85,29 @@ teardown() {
[ "$(cat "$ASDF_DIR/installs/dummy/1.1.0/version")" = "1.1.0" ] [ "$(cat "$ASDF_DIR/installs/dummy/1.1.0/version")" = "1.1.0" ]
run asdf update run asdf update
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/installs/dummy/1.1.0/version ] [ -f "$ASDF_DIR/installs/dummy/1.1.0/version" ]
run asdf update --head run asdf update --head
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/installs/dummy/1.1.0/version ] [ -f "$ASDF_DIR/installs/dummy/1.1.0/version" ]
} }
@test "asdf update should not remove plugins" { @test "asdf update should not remove plugins" {
# dummy plugin is already installed # dummy plugin is already installed
run asdf update run asdf update
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -d $ASDF_DIR/plugins/dummy ] [ -d "$ASDF_DIR/plugins/dummy" ]
run asdf update --head run asdf update --head
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -d $ASDF_DIR/plugins/dummy ] [ -d "$ASDF_DIR/plugins/dummy" ]
} }
@test "asdf update should not remove shims" { @test "asdf update should not remove shims" {
run asdf install dummy 1.1.0 run asdf install dummy 1.1.0
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
run asdf update run asdf update
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
run asdf update --head run asdf update --head
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ -f $ASDF_DIR/shims/dummy ] [ -f "$ASDF_DIR/shims/dummy" ]
} }

6
test/utils.bats
View File

@ -370,7 +370,7 @@ teardown() {
run resolve_symlink bar run resolve_symlink bar
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ "$output" = $PWD/foo ] [ "$output" = "$PWD/foo" ]
rm -f foo bar rm -f foo bar
} }
@ -380,7 +380,7 @@ teardown() {
run resolve_symlink baz/bar run resolve_symlink baz/bar
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ "$output" = $PWD/baz/../foo ] [ "$output" = "$PWD/baz/../foo" ]
rm -f foo bar rm -f foo bar
} }
@ -390,7 +390,7 @@ teardown() {
run resolve_symlink bar run resolve_symlink bar
[ "$status" -eq 0 ] [ "$status" -eq 0 ]
[ "$output" = $PWD/foo ] [ "$output" = "$PWD/foo" ]
rm -f foo bar rm -f foo bar
} }