kevin/asdf
1
Fork 0
mirror of https://github.com/asdf-vm/asdf.git synced 2024-11-15 01:28:17 -07:00
Code Issues Packages Projects Releases Wiki Activity

Use different exit code if updates are disabled

Browse Source 
If asdf-vm was installed with a package manager and the user doesn't
have the necessary permissions to update it with `asdf update`, asdf-vm
emits an informational message and exits with exit code 1.

This makes it hard to programmatically detect whether the update failed
or wasn't even attempted because it's not possible.

With this change, asdf-vm would exit with the exit code 42 if updates are
disabled instead of exit code 1, which signals an error during update.

Refs r-darwish/topgrade#367
This commit is contained in:
Jochen Schalanda 2020-03-12 12:04:19 +01:00
parent 0fd36881d7
commit 609e41e276
2 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/commands/command-update.bash
View File

@ -8,7 +8,7 @@ update_command() {
if [ -f asdf_updates_disabled ] || ! git rev-parse --is-inside-work-tree &>/dev/null; then
echo "Update command disabled. Please use the package manager that you used to install asdf to upgrade asdf."
exit 1
exit 42
else
do_update "$update_to_head"
fi

15
test/update_command.bats
View File

@ -53,13 +53,26 @@ teardown() {
[ "$?" -eq 0 ]
}
@test "asdf update is a noop for when updates are disabled" {
touch $ASDF_DIR/asdf_updates_disabled
run asdf update
[ "$status" -eq 42 ]
[ "$(echo -e "Update command disabled. Please use the package manager that you used to install asdf to upgrade asdf.")" == "$output" ]
}
@test "asdf update is a noop for non-git repos" {
rm -rf $ASDF_DIR/.git/
run asdf update
[ "$status" -eq 1 ]
[ "$status" -eq 42 ]
[ "$(echo -e "Update command disabled. Please use the package manager that you used to install asdf to upgrade asdf.")" == "$output" ]
}
@test "asdf update fails with exit code 1" {
git --git-dir "$ASDF_DIR/.git" remote set-url origin https://this-host-does-not-exist.xyz
run asdf update
[ "$status" -eq 1 ]
}
@test "asdf update should not remove plugin versions" {
run asdf install dummy 1.1
[ "$status" -eq 0 ]