kevin/asdf
1
Fork 0
mirror of https://github.com/asdf-vm/asdf.git synced 2024-11-15 01:28:17 -07:00
Code Issues Packages Projects Releases Wiki Activity

fix!: 0 exit code for success when adding an existing plugin (#1598)

Browse Source
This commit is contained in:
Edwin Kofler 2023-07-26 04:42:08 -07:00 committed by GitHub
parent d1a563dcc0
commit 4dd190466a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/functions/plugins.bash
View File

@ -79,8 +79,8 @@ plugin_add_command() {
mkdir -p "$(asdf_data_dir)/plugins" mkdir -p "$(asdf_data_dir)/plugins"
if [ -d "$plugin_path" ]; then if [ -d "$plugin_path" ]; then
display_error "Plugin named $plugin_name already added" printf '%s\n' "Plugin named $plugin_name already added"
exit 2 exit 0
else else
asdf_run_hook "pre_asdf_plugin_add" "$plugin_name" asdf_run_hook "pre_asdf_plugin_add" "$plugin_name"
asdf_run_hook "pre_asdf_plugin_add_${plugin_name}" asdf_run_hook "pre_asdf_plugin_add_${plugin_name}"

4
test/plugin_add_command.bats
View File

@ -97,12 +97,12 @@ teardown() {
[ "$output" = "dummy" ] [ "$output" = "dummy" ]
} }
@test "plugin_add command with URL specified run twice returns error second time" { @test "plugin_add command with URL specified twice returns success on second time" {
install_mock_plugin_repo "dummy" install_mock_plugin_repo "dummy"
run asdf plugin add "dummy" "${BASE_DIR}/repo-dummy" run asdf plugin add "dummy" "${BASE_DIR}/repo-dummy"
run asdf plugin add "dummy" "${BASE_DIR}/repo-dummy" run asdf plugin add "dummy" "${BASE_DIR}/repo-dummy"
[ "$status" -eq 2 ] [ "$status" -eq 0 ]
[ "$output" = "Plugin named dummy already added" ] [ "$output" = "Plugin named dummy already added" ]
} }