From 4dbe88a62adeccef98d2347bbc5ff4ffc70596ee Mon Sep 17 00:00:00 2001
From: Trevor Brown <admin@stratus3d.com>
Date: Mon, 24 May 2021 17:06:17 -0400
Subject: [PATCH] Remove process substitution from command-list-all.bash file

---
 lib/commands/command-list-all.bash | 36 +++++++++++++-----------------
 1 file changed, 15 insertions(+), 21 deletions(-)

diff --git a/lib/commands/command-list-all.bash b/lib/commands/command-list-all.bash
index 06a938d6..74d7397c 100644
--- a/lib/commands/command-list-all.bash
+++ b/lib/commands/command-list-all.bash
@@ -4,48 +4,42 @@ list_all_command() {
   local plugin_name=$1
   local query=$2
   local plugin_path
-  local std_out
-  local std_err
+  local std_out_file
+  local std_err_file
+  local output
   plugin_path=$(get_plugin_path "$plugin_name")
   check_if_plugin_exists "$plugin_name"
 
   # Capture return code to allow error handling
-  return_code=0 && split_outputs std_out std_err "bash ${plugin_path}/bin/list-all" || return_code=$?
+  std_out_file="$(mktemp "/tmp/asdf-command-list-all-${plugin_name}.stdout.XXXXXX")"
+  std_err_file="$(mktemp "/tmp/asdf-command-list-all-${plugin_name}.stderr.XXXXXX")"
+  return_code=0 && $(bash ${plugin_path}/bin/list-all > "$std_out_file" 2> "$std_err_file") || return_code=$?
 
   if [[ $return_code -ne 0 ]]; then
     # Printing all output to allow plugin to handle error formatting
     printf "Plugin %s's list-all callback script failed with output:\\n" "${plugin_name}" >&2
-    printf "%s\\n" "${std_err}" >&2
-    printf "%s\\n" "${std_out}" >&2
+    printf "%s\\n" "$(cat "$std_err_file")" >&2
+    printf "%s\\n" "$(cat "$std_out_file")" >&2
+    rm "$std_out_file" "$std_err_file"
     exit 1
   fi
 
   if [[ $query ]]; then
-    std_out=$(tr ' ' '\n' <<<"$std_out" |
+    output=$(cat "$std_out_file" | tr ' ' '\n' |
       grep -E "^\\s*$query" |
       tr '\n' ' ')
+  else
+    output=$(cat "$std_out_file")
   fi
 
-  IFS=' ' read -r -a versions_list <<<"$std_out"
+  IFS=' ' read -r -a versions_list <<<"$output"
 
   for version in "${versions_list[@]}"; do
     printf "%s\\n" "${version}"
   done
-}
 
-# This function splits stdout from std error, whilst preserving the return core
-function split_outputs() {
-  {
-    IFS=$'\n' read -r -d '' "${1}"
-    IFS=$'\n' read -r -d '' "${2}"
-    (
-      IFS=$'\n' read -r -d '' _ERRNO_
-      return "${_ERRNO_}"
-    )
-  } < <((printf '\0%s\0%d\0' "$( ( ( ({
-    ${3}
-    printf "%s\n" ${?} 1>&3-
-  } | tr -d '\0' 1>&4-) 4>&2- 2>&1- | tr -d '\0' 1>&4-) 3>&1- | exit "$(cat)") 4>&1-)" "${?}" 1>&2) 2>&1)
+  # Remove temp files if they still exist
+  rm "$std_out_file" "$std_err_file" || true
 }
 
 list_all_command "$@"