From 2dd65e0e715c4c5a6773728e836b6af04da28e08 Mon Sep 17 00:00:00 2001 From: Trevor Brown Date: Thu, 13 Apr 2023 10:06:25 -0400 Subject: [PATCH] chore: only ban readlink -f (#1539) --- test/banned_commands.bats | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/banned_commands.bats b/test/banned_commands.bats index b947e189..84f8bf2a 100644 --- a/test/banned_commands.bats +++ b/test/banned_commands.bats @@ -16,8 +16,6 @@ banned_commands=( eval # realpath not available by default on OSX. realpath - # readlink on OSX behaves differently from readlink on other Unix systems - readlink # source isn't POSIX compliant. . behaves the same and is POSIX compliant # Except in fish, where . is deprecated, and will be removed in the future. source @@ -32,6 +30,8 @@ banned_commands_regex=( "grep.* -P" # Ban grep long commands as they do not work on alpine "grep[^|]+--\w{2,}" + # readlink -f on OSX behaves differently from readlink -f on other Unix systems + 'readlink.+-.*f.+["$]' # sort --sort-version isn't supported everywhere "sort.*-V" "sort.*--sort-versions"