mirror of
https://github.com/Koenkk/zigbee2mqtt.git
synced 2024-11-15 09:58:45 -07:00
30227a13ae
* chore: Implement prettier * Run prettier * fix lint * process feedback * process feedback
373 lines
16 KiB
JavaScript
373 lines
16 KiB
JavaScript
const tmp = require('tmp');
|
|
const dir = tmp.dirSync();
|
|
let settings;
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const data = require('./stub/data');
|
|
const {rimrafSync} = require('rimraf');
|
|
const Transport = require('winston-transport');
|
|
|
|
describe('Logger', () => {
|
|
let logger;
|
|
let consoleWriteSpy;
|
|
|
|
beforeAll(() => {
|
|
consoleWriteSpy = jest.spyOn(console._stdout, 'write').mockImplementation(() => {});
|
|
});
|
|
|
|
afterAll(() => {
|
|
consoleWriteSpy.mockRestore();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
data.writeDefaultConfiguration();
|
|
jest.resetModules();
|
|
settings = require('../lib/util/settings');
|
|
settings.set(['advanced', 'log_directory'], dir.name + '/%TIMESTAMP%');
|
|
settings.reRead();
|
|
logger = require('../lib/util/logger').default;
|
|
logger.init();
|
|
consoleWriteSpy.mockClear();
|
|
});
|
|
|
|
afterEach(async () => {});
|
|
|
|
it('Create log directory', () => {
|
|
const dirs = fs.readdirSync(dir.name);
|
|
expect(dirs.length).toBe(1);
|
|
});
|
|
|
|
it('Should cleanup', () => {
|
|
for (const d of fs.readdirSync(dir.name)) {
|
|
rimrafSync(path.join(dir.name, d));
|
|
}
|
|
|
|
for (let i = 0; i < 21; i++) {
|
|
fs.mkdirSync(path.join(dir.name, `log_${i}`));
|
|
}
|
|
|
|
expect(fs.readdirSync(dir.name).length).toBe(21);
|
|
logger.cleanup();
|
|
expect(fs.readdirSync(dir.name).length).toBe(10);
|
|
});
|
|
|
|
it('Should not cleanup when there is no timestamp set', () => {
|
|
for (let i = 30; i < 40; i++) {
|
|
fs.mkdirSync(path.join(dir.name, `log_${i}`));
|
|
}
|
|
|
|
settings.set(['advanced', 'log_directory'], dir.name + '/bla');
|
|
expect(fs.readdirSync(dir.name).length).toBe(21);
|
|
logger.cleanup();
|
|
expect(fs.readdirSync(dir.name).length).toBe(21);
|
|
});
|
|
|
|
it('Set and get log level', () => {
|
|
logger.setLevel('debug');
|
|
expect(logger.getLevel()).toBe('debug');
|
|
logger.setLevel('info');
|
|
expect(logger.getLevel()).toBe('info');
|
|
logger.setLevel('warning');
|
|
expect(logger.getLevel()).toBe('warning');
|
|
logger.setLevel('error');
|
|
expect(logger.getLevel()).toBe('error');
|
|
|
|
// winston level always stays at 'debug', logic handled by custom logger
|
|
expect(logger.winston.level).toStrictEqual('debug');
|
|
for (const transport of logger.winston.transports) {
|
|
expect(transport.level).toStrictEqual(undefined);
|
|
}
|
|
});
|
|
|
|
it('Add/remove transport', () => {
|
|
class DummyTransport extends Transport {
|
|
log(info, callback) {}
|
|
}
|
|
|
|
expect(logger.winston.transports.length).toBe(2);
|
|
const transport = new DummyTransport();
|
|
logger.addTransport(transport);
|
|
expect(logger.winston.transports.length).toBe(3);
|
|
logger.removeTransport(transport);
|
|
expect(logger.winston.transports.length).toBe(2);
|
|
});
|
|
|
|
it('Logger should be console and file by default', () => {
|
|
const pipes = logger.winston._readableState.pipes;
|
|
expect(pipes.length).toBe(2);
|
|
expect(pipes[0].constructor.name).toBe('Console');
|
|
expect(pipes[0].silent).toBe(false);
|
|
expect(pipes[1].constructor.name).toBe('File');
|
|
expect(pipes[1].dirname.startsWith(dir.name)).toBeTruthy();
|
|
});
|
|
|
|
it('Logger can be file only', () => {
|
|
settings.set(['advanced', 'log_output'], ['file']);
|
|
logger.init();
|
|
const pipes = logger.winston._readableState.pipes;
|
|
expect(pipes.length).toBe(2);
|
|
expect(pipes[0].constructor.name).toBe('Console');
|
|
expect(pipes[0].silent).toBe(true);
|
|
expect(pipes[1].constructor.name).toBe('File');
|
|
expect(pipes[1].dirname.startsWith(dir.name)).toBeTruthy();
|
|
});
|
|
|
|
it('Logger can be console only', () => {
|
|
settings.set(['advanced', 'log_output'], ['console']);
|
|
logger.init();
|
|
const pipes = logger.winston._readableState.pipes;
|
|
expect(pipes.constructor.name).toBe('Console');
|
|
expect(pipes.silent).toBe(false);
|
|
});
|
|
|
|
it('Logger can be nothing', () => {
|
|
settings.set(['advanced', 'log_output'], []);
|
|
logger.init();
|
|
const pipes = logger.winston._readableState.pipes;
|
|
expect(pipes.constructor.name).toBe('Console');
|
|
expect(pipes.silent).toBe(true);
|
|
});
|
|
|
|
it('Should allow to disable log rotation', () => {
|
|
settings.set(['advanced', 'log_rotation'], false);
|
|
logger.init();
|
|
const pipes = logger.winston._readableState.pipes;
|
|
expect(pipes[1].constructor.name).toBe('File');
|
|
expect(pipes[1].maxFiles).toBeNull();
|
|
expect(pipes[1].tailable).toBeFalsy();
|
|
expect(pipes[1].maxsize).toBeNull();
|
|
});
|
|
|
|
it('Should allow to symlink logs to current directory', () => {
|
|
settings.set(['advanced', 'log_symlink_current'], true);
|
|
logger.init();
|
|
expect(fs.readdirSync(dir.name).includes('current')).toBeTruthy();
|
|
|
|
jest.resetModules();
|
|
});
|
|
|
|
it.each([
|
|
['debug', {higher: ['info', 'warning', 'error'], lower: []}],
|
|
['info', {higher: ['warning', 'error'], lower: ['debug']}],
|
|
['warning', {higher: ['error'], lower: ['debug', 'info']}],
|
|
['error', {higher: [], lower: ['debug', 'info', 'warning']}],
|
|
])('Logs relevant levels for %s', (level, otherLevels) => {
|
|
logger.setLevel(level);
|
|
|
|
const logSpy = jest.spyOn(logger.winston, 'log');
|
|
consoleWriteSpy.mockClear();
|
|
let i = 1;
|
|
|
|
logger[level]('msg');
|
|
expect(logSpy).toHaveBeenLastCalledWith(level, 'z2m: msg');
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(i++);
|
|
logger[level]('msg', 'abcd');
|
|
expect(logSpy).toHaveBeenLastCalledWith(level, 'abcd: msg');
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(i++);
|
|
|
|
for (const higherLevel of otherLevels.higher) {
|
|
logger[higherLevel]('higher msg');
|
|
expect(logSpy).toHaveBeenLastCalledWith(higherLevel, 'z2m: higher msg');
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(i++);
|
|
logger[higherLevel]('higher msg', 'abcd');
|
|
expect(logSpy).toHaveBeenLastCalledWith(higherLevel, 'abcd: higher msg');
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(i++);
|
|
}
|
|
|
|
logSpy.mockClear();
|
|
consoleWriteSpy.mockClear();
|
|
|
|
for (const lowerLevel of otherLevels.lower) {
|
|
logger[lowerLevel]('lower msg');
|
|
expect(logSpy).not.toHaveBeenCalled();
|
|
expect(consoleWriteSpy).not.toHaveBeenCalled();
|
|
logger[lowerLevel]('lower msg', 'abcd');
|
|
expect(logSpy).not.toHaveBeenCalled();
|
|
expect(consoleWriteSpy).not.toHaveBeenCalled();
|
|
}
|
|
});
|
|
|
|
it('Logs Error object', () => {
|
|
const logSpy = jest.spyOn(logger.winston, 'log');
|
|
|
|
logger.error(new Error('msg')); // test for stack=true
|
|
expect(logSpy).toHaveBeenLastCalledWith('error', `z2m: ${new Error('msg')}`);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it.each([
|
|
[
|
|
'^zhc:legacy:fz:(tuya|moes)',
|
|
new RegExp(/^zhc:legacy:fz:(tuya|moes)/),
|
|
[
|
|
{ns: 'zhc:legacy:fz:tuya_device12', match: true},
|
|
{ns: 'zhc:legacy:fz:moes_dimmer', match: true},
|
|
{ns: 'zhc:legacy:fz:not_moes', match: false},
|
|
{ns: 'zhc:legacy:fz', match: false},
|
|
{ns: 'zhc:legacy:fz:', match: false},
|
|
{ns: '1zhc:legacy:fz:tuya_device12', match: false},
|
|
],
|
|
],
|
|
[
|
|
'^zhc:legacy:fz:(tuya|moes)|^zh:ember:uart:|^zh:controller',
|
|
new RegExp(/^zhc:legacy:fz:(tuya|moes)|^zh:ember:uart:|^zh:controller/),
|
|
[
|
|
{ns: 'zh:ember:uart:ash', match: true},
|
|
{ns: 'zh:ember:uart', match: false},
|
|
{ns: 'zh:controller', match: true},
|
|
{ns: 'zh:controller:', match: true},
|
|
{ns: 'azh:controller:', match: false},
|
|
],
|
|
],
|
|
[
|
|
'',
|
|
undefined,
|
|
[
|
|
{ns: 'zhc:legacy:fz:tuya_device12', match: false},
|
|
{ns: 'zhc:legacy:fz:moes_dimmer', match: false},
|
|
{ns: 'zhc:legacy:fz:not_moes', match: false},
|
|
{ns: 'zhc:legacy:fz', match: false},
|
|
{ns: 'zhc:legacy:fz:', match: false},
|
|
{ns: '1zhc:legacy:fz:tuya_device12', match: false},
|
|
{ns: 'zh:ember:uart:ash', match: false},
|
|
{ns: 'zh:ember:uart', match: false},
|
|
{ns: 'zh:controller', match: false},
|
|
{ns: 'zh:controller:', match: false},
|
|
{ns: 'azh:controller:', match: false},
|
|
],
|
|
],
|
|
])('Sets namespace ignore for debug level %s', (ignore, expected, tests) => {
|
|
logger.setLevel('debug');
|
|
const logSpy = jest.spyOn(logger.winston, 'log');
|
|
logger.setDebugNamespaceIgnore(ignore);
|
|
expect(logger.debugNamespaceIgnoreRegex).toStrictEqual(expected);
|
|
expect(logger.getDebugNamespaceIgnore()).toStrictEqual(ignore);
|
|
|
|
for (const test of tests) {
|
|
logger.debug('Test message', test.ns);
|
|
|
|
if (test.match) {
|
|
expect(logSpy).not.toHaveBeenCalled();
|
|
} else {
|
|
expect(logSpy).toHaveBeenLastCalledWith('debug', `${test.ns}: Test message`);
|
|
}
|
|
|
|
logSpy.mockClear();
|
|
}
|
|
});
|
|
|
|
it('Logs with namespaced levels or default - higher', () => {
|
|
settings.set(['advanced', 'log_namespaced_levels'], {
|
|
'z2m:mqtt': 'warning',
|
|
});
|
|
logger.init();
|
|
logger.setLevel('debug');
|
|
expect(logger.getNamespacedLevels()).toStrictEqual({'z2m:mqtt': 'warning'});
|
|
expect(logger.getLevel()).toStrictEqual('debug');
|
|
|
|
const logSpy = jest.spyOn(logger.winston, 'log');
|
|
|
|
consoleWriteSpy.mockClear();
|
|
logger.info(`MQTT publish: topic 'abcd/efgh', payload '{"my": {"payload": "injson"}}'`, 'z2m:mqtt');
|
|
expect(logSpy).toHaveBeenCalledTimes(0);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(0);
|
|
logger.error(`Not connected to MQTT server!`, 'z2m:mqtt');
|
|
expect(logSpy).toHaveBeenCalledTimes(1);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(1);
|
|
logger.info(`Just another info message`, 'z2m:notmqtt');
|
|
expect(logSpy).toHaveBeenCalledTimes(2);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(2);
|
|
});
|
|
|
|
it('Logs with namespaced levels or default - lower', () => {
|
|
expect(logger.getNamespacedLevels()).toStrictEqual({});
|
|
logger.setNamespacedLevels({'z2m:mqtt': 'info'});
|
|
logger.setLevel('warning');
|
|
expect(logger.getNamespacedLevels()).toStrictEqual({'z2m:mqtt': 'info'});
|
|
expect(logger.getLevel()).toStrictEqual('warning');
|
|
|
|
const logSpy = jest.spyOn(logger.winston, 'log');
|
|
|
|
consoleWriteSpy.mockClear();
|
|
logger.info(`MQTT publish: topic 'abcd/efgh', payload '{"my": {"payload": "injson"}}'`, 'z2m:mqtt');
|
|
expect(logSpy).toHaveBeenCalledTimes(1);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(1);
|
|
logger.error(`Not connected to MQTT server!`, 'z2m:mqtt');
|
|
expect(logSpy).toHaveBeenCalledTimes(2);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(2);
|
|
logger.info(`Just another info message`, 'z2m:notmqtt');
|
|
expect(logSpy).toHaveBeenCalledTimes(2);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(2);
|
|
logger.warning(`Just another warning message`, 'z2m:notmqtt');
|
|
expect(logSpy).toHaveBeenCalledTimes(3);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(3);
|
|
});
|
|
|
|
it('Logs with namespaced levels hierarchy', () => {
|
|
const nsLevels = {'zh:zstack': 'debug', 'zh:zstack:unpi:writer': 'error'};
|
|
let cachedNSLevels = Object.assign({}, nsLevels);
|
|
logger.setNamespacedLevels(nsLevels);
|
|
logger.setLevel('warning');
|
|
|
|
consoleWriteSpy.mockClear();
|
|
logger.debug(`--- parseNext [] debug picked from hierarchy`, 'zh:zstack:unpi:parser');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'zh:zstack:unpi:parser': 'debug'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(1);
|
|
logger.warning(`--> frame [36,15] warning explicitely supressed`, 'zh:zstack:unpi:writer');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(cachedNSLevels);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(1);
|
|
logger.warning(`Another supressed warning message in a sub namespace`, 'zh:zstack:unpi:writer:sub:ns');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'zh:zstack:unpi:writer:sub:ns': 'error'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(1);
|
|
logger.error(`but error should go through`, 'zh:zstack:unpi:writer:another:sub:ns');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'zh:zstack:unpi:writer:another:sub:ns': 'error'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(2);
|
|
logger.warning(`new unconfigured namespace warning`, 'z2m:mqtt');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'z2m:mqtt': 'warning'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(3);
|
|
logger.info(`cached unconfigured namespace info should be supressed`, 'z2m:mqtt');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(cachedNSLevels);
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(3);
|
|
|
|
logger.setLevel('info');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual((cachedNSLevels = Object.assign({}, nsLevels)));
|
|
logger.info(`unconfigured namespace info should now pass after default level change and cache reset`, 'z2m:mqtt');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'z2m:mqtt': 'info'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(4);
|
|
logger.error(`configured namespace hierachy should still work after the cache reset`, 'zh:zstack:unpi:writer:another:sub:ns');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'zh:zstack:unpi:writer:another:sub:ns': 'error'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(5);
|
|
|
|
logger.setNamespacedLevels({'zh:zstack': 'warning'});
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual((cachedNSLevels = {'zh:zstack': 'warning'}));
|
|
logger.error(`error logged`, 'zh:zstack:unpi:writer');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'zh:zstack:unpi:writer': 'warning'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(6);
|
|
logger.debug(`debug suppressed`, 'zh:zstack:unpi');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'zh:zstack:unpi': 'warning'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(6);
|
|
logger.warning(`warning logged`, 'zh:zstack');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'zh:zstack': 'warning'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(7);
|
|
logger.info(`unconfigured namespace`, 'z2m:mqtt');
|
|
expect(logger.cachedNamespacedLevels).toStrictEqual(Object.assign(cachedNSLevels, {'z2m:mqtt': 'info'}));
|
|
expect(consoleWriteSpy).toHaveBeenCalledTimes(8);
|
|
});
|
|
|
|
it('Ignores SPLAT chars', () => {
|
|
logger.setLevel('debug');
|
|
|
|
const logSpy = jest.spyOn(logger.winston, 'log');
|
|
consoleWriteSpy.mockClear();
|
|
|
|
let net_map = '%d';
|
|
logger.debug(net_map, 'z2m:mqtt');
|
|
expect(logSpy).toHaveBeenLastCalledWith('debug', `z2m:mqtt: ${net_map}`);
|
|
expect(consoleWriteSpy.mock.calls[0][0]).toMatch(new RegExp(`^.*\tz2m:mqtt: ${net_map}`));
|
|
net_map = 'anything %s goes here';
|
|
logger.debug(net_map, 'z2m:test');
|
|
expect(logSpy).toHaveBeenLastCalledWith('debug', `z2m:test: ${net_map}`);
|
|
expect(consoleWriteSpy.mock.calls[1][0]).toMatch(new RegExp(`^.*\tz2m:test: ${net_map}`));
|
|
});
|
|
});
|