Gusted 356c5055ad lib/sha256: Remove it (#9643) ... ### Purpose Remove the `lib/sha256` package, because it's no longer necessary. Go's standard library now has the same performance and is on par with `sha256-simd` since [Since Go 1.21](1a64574f42). Therefore using `sha256-simd` has no benefits anymore. ARM already has optimized sha256 assembly code since 7b8a7f8272, `sha256-simd` published their results before that optimized assembly was implemented, f941fedda8. The assembly looks very similar and the benchmarks in the Go commit match that of `sha256-simd`. This patch removes all of the related code of `lib/sha256` and makes `crypto/sha256` the 'default'. Benchmark of `sha256-simd` and `crypto/sha256`: <details> ``` cpu: AMD Ryzen 5 3600X 6-Core Processor │ simd.txt │ go.txt │ │ sec/op │ sec/op vs base │ Hash/8Bytes-12 63.25n ± 1% 73.38n ± 1% +16.02% (p=0.002 n=6) Hash/64Bytes-12 98.73n ± 1% 105.30n ± 1% +6.65% (p=0.002 n=6) Hash/1K-12 567.2n ± 1% 572.8n ± 1% +0.99% (p=0.002 n=6) Hash/8K-12 4.062µ ± 1% 4.062µ ± 1% ~ (p=0.396 n=6) Hash/1M-12 512.1µ ± 0% 510.6µ ± 1% ~ (p=0.485 n=6) Hash/5M-12 2.556m ± 1% 2.564m ± 0% ~ (p=0.093 n=6) Hash/10M-12 5.112m ± 0% 5.127m ± 0% ~ (p=0.093 n=6) geomean 13.82µ 14.27µ +3.28% │ simd.txt │ go.txt │ │ B/s │ B/s vs base │ Hash/8Bytes-12 120.6Mi ± 1% 104.0Mi ± 1% -13.81% (p=0.002 n=6) Hash/64Bytes-12 618.2Mi ± 1% 579.8Mi ± 1% -6.22% (p=0.002 n=6) Hash/1K-12 1.682Gi ± 1% 1.665Gi ± 1% -0.98% (p=0.002 n=6) Hash/8K-12 1.878Gi ± 1% 1.878Gi ± 1% ~ (p=0.310 n=6) Hash/1M-12 1.907Gi ± 0% 1.913Gi ± 1% ~ (p=0.485 n=6) Hash/5M-12 1.911Gi ± 1% 1.904Gi ± 0% ~ (p=0.093 n=6) Hash/10M-12 1.910Gi ± 0% 1.905Gi ± 0% ~ (p=0.093 n=6) geomean 1.066Gi 1.032Gi -3.18% ``` </details> ### Testing Compiled and tested on Linux. ### Documentation https://github.com/syncthing/docs/pull/874		2024-08-10 12:58:20 +01:00
..
_testdata	lib/ur: Implement crash (panic) reporting (fixes #959) (#5702)	2019-06-11 08:19:11 +02:00
diskstore.go	cmd/stcrashreceiver: Add metrics for diskstore inventory	2023-11-27 08:24:59 +01:00
main.go	lib/sha256: Remove it (#9643)	2024-08-10 12:58:20 +01:00
metrics.go	cmd/stcrashreceiver: Add metrics for diskstore inventory	2023-11-27 08:24:59 +01:00
sentry_test.go	cmd/stcrashreceiver: Ignore patterns, improve metrics	2024-06-03 19:50:28 +02:00
sentry.go	cmd/stcrashreceiver: Ignore patterns, improve metrics	2024-06-03 19:50:28 +02:00
sourcecodeloader.go	all: Remove usage of deprecated io/ioutil (#7971)	2021-11-22 08:59:47 +01:00
stcrashreceiver.go	cmd/stcrashreceiver: Ignore patterns, improve metrics	2024-06-03 19:50:28 +02:00
util.go	lib/sha256: Remove it (#9643)	2024-08-10 12:58:20 +01:00