mirror of
https://github.com/syncthing/syncthing.git
synced 2024-11-16 18:41:59 -07:00
db1dc9985a
This removes the special handling of minor versions as major when the actual major is zero, and adds the special case that upgrades from 0.x to 1.x are considered minor. 0.x to 2.x or 1.x to 2.x etc are still considered major. GitHub-Pull-Request: https://github.com/syncthing/syncthing/pull/4226
118 lines
3.8 KiB
Go
118 lines
3.8 KiB
Go
// Copyright (C) 2014 The Syncthing Authors.
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
// +build !noupgrade
|
|
|
|
package upgrade
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
var versions = []struct {
|
|
a, b string
|
|
r Relation
|
|
}{
|
|
{"0.1.2", "0.1.2", Equal},
|
|
{"0.1.3", "0.1.2", Newer},
|
|
{"0.1.1", "0.1.2", Older},
|
|
{"0.3.0", "0.1.2", Newer},
|
|
{"0.0.9", "0.1.2", Older},
|
|
{"1.3.0", "1.1.2", Newer},
|
|
{"1.0.9", "1.1.2", Older},
|
|
{"2.3.0", "1.1.2", MajorNewer},
|
|
{"1.0.9", "2.1.2", MajorOlder},
|
|
{"1.1.2", "0.1.2", Newer},
|
|
{"0.1.2", "1.1.2", Older},
|
|
{"2.1.2", "0.1.2", MajorNewer},
|
|
{"0.1.2", "2.1.2", MajorOlder},
|
|
{"0.1.10", "0.1.9", Newer},
|
|
{"0.10.0", "0.2.0", Newer},
|
|
{"30.10.0", "4.9.0", MajorNewer},
|
|
{"0.9.0-beta7", "0.9.0-beta6", Newer},
|
|
{"0.9.0-beta7", "1.0.0-alpha", Older},
|
|
{"1.0.0-alpha", "1.0.0-alpha.1", Older},
|
|
{"1.0.0-alpha.1", "1.0.0-alpha.beta", Older},
|
|
{"1.0.0-alpha.beta", "1.0.0-beta", Older},
|
|
{"1.0.0-beta", "1.0.0-beta.2", Older},
|
|
{"1.0.0-beta.2", "1.0.0-beta.11", Older},
|
|
{"1.0.0-beta.11", "1.0.0-rc.1", Older},
|
|
{"1.0.0-rc.1", "1.0.0", Older},
|
|
{"1.0.0+45", "1.0.0+23-dev-foo", Equal},
|
|
{"1.0.0-beta.23+45", "1.0.0-beta.23+23-dev-foo", Equal},
|
|
{"1.0.0-beta.3+99", "1.0.0-beta.24+0", Older},
|
|
|
|
{"v1.1.2", "1.1.2", Equal},
|
|
{"v1.1.2", "V1.1.2", Equal},
|
|
{"1.1.2", "V1.1.2", Equal},
|
|
}
|
|
|
|
func TestCompareVersions(t *testing.T) {
|
|
for _, v := range versions {
|
|
if r := CompareVersions(v.a, v.b); r != v.r {
|
|
t.Errorf("compareVersions(%q, %q): %d != %d", v.a, v.b, r, v.r)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestErrorRelease(t *testing.T) {
|
|
_, err := SelectLatestRelease(nil, "v0.11.0-beta", false)
|
|
if err == nil {
|
|
t.Error("Should return an error when no release were available")
|
|
}
|
|
}
|
|
|
|
func TestSelectedRelease(t *testing.T) {
|
|
testcases := []struct {
|
|
current string
|
|
upgradeToPre bool
|
|
candidates []string
|
|
selected string
|
|
}{
|
|
// Within the same "major" (minor, in this case) select the newest
|
|
{"v0.12.24", false, []string{"v0.12.23", "v0.12.24", "v0.12.25", "v0.12.26"}, "v0.12.26"},
|
|
{"v0.12.24", false, []string{"v0.12.23", "v0.12.24", "v0.12.25", "v0.13.0"}, "v0.13.0"},
|
|
{"v0.12.24", false, []string{"v0.12.23", "v0.12.24", "v0.12.25", "v1.0.0"}, "v1.0.0"},
|
|
// Do no select beta versions when we are not allowed to
|
|
{"v0.12.24", false, []string{"v0.12.26", "v0.12.27-beta.42"}, "v0.12.26"},
|
|
{"v0.12.24-beta.0", false, []string{"v0.12.26", "v0.12.27-beta.42"}, "v0.12.26"},
|
|
// Do select beta versions when we can
|
|
{"v0.12.24", true, []string{"v0.12.26", "v0.12.27-beta.42"}, "v0.12.27-beta.42"},
|
|
{"v0.12.24-beta.0", true, []string{"v0.12.26", "v0.12.27-beta.42"}, "v0.12.27-beta.42"},
|
|
// Select the best within the current major when there is a minor upgrade available
|
|
{"v0.12.24", false, []string{"v1.12.23", "v1.12.24", "v1.14.2", "v2.0.0"}, "v1.14.2"},
|
|
{"v1.12.24", false, []string{"v1.12.23", "v1.12.24", "v1.14.2", "v2.0.0"}, "v1.14.2"},
|
|
// Select the next major when we are at the best minor
|
|
{"v0.12.25", true, []string{"v0.12.23", "v0.12.24", "v0.12.25", "v0.13.0"}, "v0.13.0"},
|
|
{"v1.14.2", true, []string{"v0.12.23", "v0.12.24", "v1.14.2", "v2.0.0"}, "v2.0.0"},
|
|
}
|
|
|
|
for i, tc := range testcases {
|
|
// Prepare a list of candidate releases
|
|
var rels []Release
|
|
for _, c := range tc.candidates {
|
|
rels = append(rels, Release{
|
|
Tag: c,
|
|
Prerelease: strings.Contains(c, "-"),
|
|
Assets: []Asset{
|
|
// There must be a matching asset or it will not get selected
|
|
{Name: releaseName(c)},
|
|
},
|
|
})
|
|
}
|
|
|
|
// Check the selection
|
|
sel, err := SelectLatestRelease(rels, tc.current, tc.upgradeToPre)
|
|
if err != nil {
|
|
t.Fatal("Unexpected error:", err)
|
|
}
|
|
if sel.Tag != tc.selected {
|
|
t.Errorf("Test case %d: expected %s to be selected, but got %s", i, tc.selected, sel.Tag)
|
|
}
|
|
}
|
|
}
|