cotugno/syncthing
2
Fork 0
mirror of https://github.com/syncthing/syncthing.git synced 2024-11-15 09:58:57 -07:00
Code Issues Packages Projects Releases Wiki Activity
dbe7fa9155
syncthing/test
History
Gusted 356c5055ad
lib/sha256: Remove it (#9643) 
### Purpose

Remove the `lib/sha256` package, because it's no longer necessary. Go's
standard library now has the same performance and is on par with
`sha256-simd` since [Since Go
1.21](1a64574f42).
Therefore using `sha256-simd` has no benefits anymore.

ARM already has optimized sha256 assembly code since
7b8a7f8272,
`sha256-simd` published their results before that optimized assembly was
implemented,
f941fedda8.
The assembly looks very similar and the benchmarks in the Go commit
match that of `sha256-simd`.

This patch removes all of the related code of `lib/sha256` and makes
`crypto/sha256` the 'default'.

Benchmark of `sha256-simd` and `crypto/sha256`:
<details>

```
cpu: AMD Ryzen 5 3600X 6-Core Processor
                │  simd.txt   │               go.txt                │
                │   sec/op    │    sec/op     vs base               │
Hash/8Bytes-12    63.25n ± 1%    73.38n ± 1%  +16.02% (p=0.002 n=6)
Hash/64Bytes-12   98.73n ± 1%   105.30n ± 1%   +6.65% (p=0.002 n=6)
Hash/1K-12        567.2n ± 1%    572.8n ± 1%   +0.99% (p=0.002 n=6)
Hash/8K-12        4.062µ ± 1%    4.062µ ± 1%        ~ (p=0.396 n=6)
Hash/1M-12        512.1µ ± 0%    510.6µ ± 1%        ~ (p=0.485 n=6)
Hash/5M-12        2.556m ± 1%    2.564m ± 0%        ~ (p=0.093 n=6)
Hash/10M-12       5.112m ± 0%    5.127m ± 0%        ~ (p=0.093 n=6)
geomean           13.82µ         14.27µ        +3.28%

                │   simd.txt   │               go.txt                │
                │     B/s      │     B/s       vs base               │
Hash/8Bytes-12    120.6Mi ± 1%   104.0Mi ± 1%  -13.81% (p=0.002 n=6)
Hash/64Bytes-12   618.2Mi ± 1%   579.8Mi ± 1%   -6.22% (p=0.002 n=6)
Hash/1K-12        1.682Gi ± 1%   1.665Gi ± 1%   -0.98% (p=0.002 n=6)
Hash/8K-12        1.878Gi ± 1%   1.878Gi ± 1%        ~ (p=0.310 n=6)
Hash/1M-12        1.907Gi ± 0%   1.913Gi ± 1%        ~ (p=0.485 n=6)
Hash/5M-12        1.911Gi ± 1%   1.904Gi ± 0%        ~ (p=0.093 n=6)
Hash/10M-12       1.910Gi ± 0%   1.905Gi ± 0%        ~ (p=0.093 n=6)
geomean           1.066Gi        1.032Gi        -3.18%
```

</details>


### Testing

Compiled and tested on Linux.

### Documentation

https://github.com/syncthing/docs/pull/874
2024-08-10 12:58:20 +01:00
..
h1 test: Update testing configs 2023-11-13 13:51:17 +01:00
h2 test: Update testing configs 2023-11-13 13:51:17 +01:00
h3 test, lib/model: Various integration test updates & improvements (#6956) 2020-09-07 09:35:37 +02:00
h4 test, lib/model: Various integration test updates & improvements (#6956) 2020-09-07 09:35:37 +02:00
logs Improvements to integration tests 2015-01-22 00:18:08 +00:00
.gitignore lib/api: Remove remnants of CSRF tokens file mentions (ref #9284) 2024-01-23 12:07:58 +01:00
cli_test.go Normalize CLI options to always use two dashes. (#8037) 2021-11-04 08:42:55 +01:00
conflict_test.go all: Remove usage of deprecated io/ioutil (#7971) 2021-11-22 08:59:47 +01:00
delay_scan_test.go all: Remove usage of deprecated io/ioutil (#7971) 2021-11-22 08:59:47 +01:00
filetype_test.go all: Update build constraints to Go 1.17 style (#7894) 2021-08-17 10:10:41 +02:00
folders.sh lib/config, lib/model: Limit concurrent pulls (fixes #5914) (#6290) 2020-01-27 17:31:17 +01:00
http_test.go lib/api: Add cache busting for basic auth (ref #9208) (#9215) 2023-11-14 11:57:39 +01:00
ignore_test.go all: Remove usage of deprecated io/ioutil (#7971) 2021-11-22 08:59:47 +01:00
manypeers_test.go all: Update build constraints to Go 1.17 style (#7894) 2021-08-17 10:10:41 +02:00
override_test.go all: Remove usage of deprecated io/ioutil (#7971) 2021-11-22 08:59:47 +01:00
parallel_scan_test.go all: Correct various typos (#8870) 2023-05-09 08:54:02 +02:00
reconnect_test.go all: Update build constraints to Go 1.17 style (#7894) 2021-08-17 10:10:41 +02:00
reset_test.go all: Remove usage of deprecated io/ioutil (#7971) 2021-11-22 08:59:47 +01:00
scan_test.go all: Update build constraints to Go 1.17 style (#7894) 2021-08-17 10:10:41 +02:00
symlink_test.go all: Update build constraints to Go 1.17 style (#7894) 2021-08-17 10:10:41 +02:00
sync_test.go all: Update build constraints to Go 1.17 style (#7894) 2021-08-17 10:10:41 +02:00
transfer-bench_test.go all: Update build constraints to Go 1.17 style (#7894) 2021-08-17 10:10:41 +02:00
usage_unix.go all: Add build constants for runtime.GOOS comparisons (#8442) 2022-07-28 19:36:39 +02:00
usage_windows.go all: Update build constraints to Go 1.17 style (#7894) 2021-08-17 10:10:41 +02:00
util.go lib/sha256: Remove it (#9643) 2024-08-10 12:58:20 +01:00