mirror of
https://github.com/syncthing/syncthing.git
synced 2024-11-16 18:41:59 -07:00
fd0a147ae6
Request to terminate currently ongoing downloads and jump to the bumped file incoming in 3, 2, 1. Also, has a slightly strange effect where we pop a job off the queue, but the copyChannel is still busy and blocks, though it gets moved to the progress slice in the jobqueue, and looks like it's in progress which it isn't as it's waiting to be picked up from the copyChan. As a result, the progress emitter doesn't register on the task, and hence the file doesn't have a progress bar, but cannot be replaced by a bump. I guess I can fix progress bar issue by moving the progressEmiter.Register just before passing the file to the copyChan, but then we are back to the initial problem of a file with a progress bar, but no progress happening as it's stuck on write to copyChan I checked if there is a way to check for channel writeability (before popping) but got struck by lightning just for bringing the idea up in #go-nuts. My ideal scenario would be to check if copyChan is writeable, pop job from the queue and shove it down handleFile. This way jobs would stay in the queue while they cannot be handled, meaning that the `Bump` could bring your file up higher. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| common_test.go | ||
| counting.go | ||
| debug.go | ||
| deviceid_test.go | ||
| deviceid.go | ||
| doc.go | ||
| header.go | ||
| message_xdr.go | ||
| message.go | ||
| nativemodel_darwin.go | ||
| nativemodel_unix.go | ||
| nativemodel_windows.go | ||
| protocol_test.go | ||
| protocol.go | ||
| wireformat.go | ||