mirror of
https://github.com/syncthing/syncthing.git
synced 2024-11-16 10:28:49 -07:00
c71116ee94
This PR does two things, because one lead to the other: - Move the leveldb specific stuff into a small "backend" package that defines a backend interface and the leveldb implementation. This allows, potentially, in the future, switching the db implementation so another KV store should we wish to do so. - Add proper error handling all along the way. The db and backend packages are now errcheck clean. However, I drew the line at modifying the FileSet API in order to keep this manageable and not continue refactoring all of the rest of Syncthing. As such, the FileSet methods still panic on database errors, except for the "database is closed" error which is instead handled by silently returning as quickly as possible, with the assumption that we're anyway "on the way out".
54 lines
1.5 KiB
Go
54 lines
1.5 KiB
Go
// Copyright (C) 2019 The Syncthing Authors.
|
|
//
|
|
// This Source Code Form is subject to the terms of the Mozilla Public
|
|
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
|
|
// You can obtain one at https://mozilla.org/MPL/2.0/.
|
|
|
|
package backend
|
|
|
|
import "testing"
|
|
|
|
// testBackendBehavior is the generic test suite that must be fulfilled by
|
|
// every backend implementation. It should be called by each implementation
|
|
// as (part of) their test suite.
|
|
func testBackendBehavior(t *testing.T, open func() Backend) {
|
|
t.Run("WriteIsolation", func(t *testing.T) { testWriteIsolation(t, open) })
|
|
t.Run("DeleteNonexisten", func(t *testing.T) { testDeleteNonexistent(t, open) })
|
|
}
|
|
|
|
func testWriteIsolation(t *testing.T, open func() Backend) {
|
|
// Values written during a transaction should not be read back, our
|
|
// updateGlobal depends on this.
|
|
|
|
db := open()
|
|
defer db.Close()
|
|
|
|
// Sanity check
|
|
_ = db.Put([]byte("a"), []byte("a"))
|
|
v, _ := db.Get([]byte("a"))
|
|
if string(v) != "a" {
|
|
t.Fatal("read back should work")
|
|
}
|
|
|
|
// Now in a transaction we should still see the old value
|
|
tx, _ := db.NewWriteTransaction()
|
|
defer tx.Release()
|
|
_ = tx.Put([]byte("a"), []byte("b"))
|
|
v, _ = tx.Get([]byte("a"))
|
|
if string(v) != "a" {
|
|
t.Fatal("read in transaction should read the old value")
|
|
}
|
|
}
|
|
|
|
func testDeleteNonexistent(t *testing.T, open func() Backend) {
|
|
// Deleting a non-existent key is not an error
|
|
|
|
db := open()
|
|
defer db.Close()
|
|
|
|
err := db.Delete([]byte("a"))
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
}
|