mirror of
https://github.com/syncthing/syncthing.git
synced 2024-11-16 10:28:49 -07:00
b80da29b23
The problem here is that we would update the sequence index before updating the FileInfos, which would result in a high sequence number pointing to a low-sequence FileInfo. The index sender would pick up the high sequence number, send the old file, and think everything was good. On the receiving side the old file is a no-op and ignored. The file remains out of sync until another update for it happens. This fixes that by correcting the order of operations in the database update: first we remove old sequence index entries, then we update the FileInfos (which now don't have anything pointing to them) and then we add the sequence indexes (which the index sender can see). The other option is to add "proper" transactions where required at the database layer. I actually have a branch for that, but it's literally thousands of lines of diff and I'm putting that off for another day as this solves the problem... |
||
|---|---|---|
| .. | ||
| testdata | ||
| debug.go | ||
| deviceactivity_test.go | ||
| deviceactivity.go | ||
| devicedownloadstate_test.go | ||
| devicedownloadstate.go | ||
| doc.go | ||
| folder_recvonly_test.go | ||
| folder_recvonly.go | ||
| folder_sendonly.go | ||
| folder_sendrecv_test.go | ||
| folder_sendrecv.go | ||
| folder.go | ||
| folderstate.go | ||
| model_test.go | ||
| model.go | ||
| progressemitter_test.go | ||
| progressemitter.go | ||
| queue_test.go | ||
| queue.go | ||
| requests_test.go | ||
| sentdownloadstate.go | ||
| sharedpullerstate_test.go | ||
| sharedpullerstate.go | ||
| util.go | ||