568 Commits

Author	SHA1	Message	Date
Simon Frei	fae7425bbf	lib: Modify FileInfos consistently (ref #6321) (#6349)	2020-02-19 16:58:09 +01:00
Jakob Borg	bb375b1aff	lib/model: Stop summary sender faster (ref #6319) (#6341) ... One of the causes of "panic: database is closed" is that we try to send summaries after it's been closed. Calculating summaries can take a long time and if we have a lot of folders it's not unreasonable to think that we might be stopped in this loop, so prepare to bail here. * push	2020-02-14 08:11:54 +01:00
Simon Frei	ce27780a4c	lib/model: Return empty summary on paused folders (ref #6272) (#6326)	2020-02-12 11:59:12 +01:00
Jakob Borg	0df39ddc72	lib/fs, lib/model: Rewrite RecvOnly tests (#6318) ... During some other work I discovered these tests weren't great, so I've rewritten them to be a little better. The real changes here are: - Don't play games with not starting the folder and such, and don't construct a fake folder instance -- just use the one the model has. The folder starts and scans but the folder contents are empty at this point so that's fine. - Use a fakefs instead of a temp dir. - To support the above, implement a fakefs option `?content=true` to make the fakefs actually retain written content. Use sparingly, obviously, but it means the fakefs can usually be used instead of an on disk real directory.	2020-02-12 07:47:05 +01:00
Simon Frei	a596e5e2f0	lib/model: Consistent error return values for folder methods on model (#6325)	2020-02-12 07:35:24 +01:00
Jakob Borg	b61da487e4	all: Update metadata modtime on delete (ref #6284) (#6315) ... This records the time a file was marked as deleted. It will, in the future, aid in garbage collecting old files.	2020-02-10 10:48:30 +01:00
Jakob Borg	5823e7a5ce	lib/model: Sort and group model initialization better (ref #6303)	2020-02-01 08:12:25 +01:00
Jakob Borg	55937b61ca	lib/model: Add global request limiter (fixes #6302) (#6303) ... This adds a new config with the simple and concise name maxConcurrentIncomingRequestKiB. This limits how many bytes we have "in the air" in the form of response data being read and processed. After some testing I think that not having this limiter is seldom a great idea and thus I propose a default value of 256 MiB for this new setting. I also refactored the folder IO limiter to be a model/folder attribute instead of a package global.	2020-02-01 08:02:18 +01:00
Jakob Borg	d91c4b010b	lib/config, lib/model: Limit concurrent pulls (fixes #5914) (#6290) ... Adds a new folder state "Waiting to Sync" in the same vein as the existing "Waiting to Scan". This vastly improves performances in the rare cases when there are lots and lots of folders operating.	2020-01-27 17:31:17 +01:00
Jakob Borg	8fc2dfad0c	lib/db: Deduplicate block lists in database (fixes #5898) (#6283) ... * lib/db: Deduplicate block lists in database (fixes #5898) This moves the block list in the database out from being just a field on the FileInfo to being an object of its own. When putting a FileInfo we marshal the block list separately and store it keyed by the sha256 of the marshalled block list. When getting, if we are not doing a "truncated" get, we do an extra read and unmarshal for the block list. Old block lists are cleared out by a periodic GC sweep. The alternative would be to use refcounting, but: - There is a larger risk of getting that wrong and either dropping a block list in error or keeping them around forever. - It's tricky with our current database, as we don't have dirty reads. This means that if we update two FileInfos with identical block lists in the same transaction we can't just do read/modify/write for the ref counters as we wouldn't see our own first update. See above about tracking this and risks about getting it wrong. GC uses a bloom filter for keys to avoid heavy RAM usage. GC can't run concurrently with FileInfo updates so there is a new lock around those operation at the lowlevel. The end result is a much more compact database, especially for setups with many peers where files get duplicated many times. This is per-key-class stats for a large database I'm currently working with, under the current schema: ``` 0x00: 9138161 items, 870876 KB keys + 7397482 KB data, 95 B + 809 B avg, 1637651 B max 0x01: 185656 items, 10388 KB keys + 1790909 KB data, 55 B + 9646 B avg, 924525 B max 0x02: 916890 items, 84795 KB keys + 3667 KB data, 92 B + 4 B avg, 192 B max 0x03: 384 items, 27 KB keys + 5 KB data, 72 B + 15 B avg, 87 B max 0x04: 1109 items, 17 KB keys + 17 KB data, 15 B + 15 B avg, 69 B max 0x06: 383 items, 3 KB keys + 0 KB data, 9 B + 2 B avg, 18 B max 0x07: 510 items, 4 KB keys + 12 KB data, 9 B + 24 B avg, 41 B max 0x08: 1349 items, 12 KB keys + 10 KB data, 9 B + 8 B avg, 17 B max 0x09: 194 items, 0 KB keys + 123 KB data, 5 B + 634 B avg, 11484 B max 0x0a: 3 items, 0 KB keys + 0 KB data, 14 B + 7 B avg, 30 B max 0x0b: 181836 items, 2363 KB keys + 10694 KB data, 13 B + 58 B avg, 173 B max Total 10426475 items, 968490 KB keys + 9202925 KB data. ``` Note 7.4 GB of data in class 00, total size 9.2 GB. After running the migration we get this instead: ``` 0x00: 9138161 items, 870876 KB keys + 2611392 KB data, 95 B + 285 B avg, 4788 B max 0x01: 185656 items, 10388 KB keys + 1790909 KB data, 55 B + 9646 B avg, 924525 B max 0x02: 916890 items, 84795 KB keys + 3667 KB data, 92 B + 4 B avg, 192 B max 0x03: 384 items, 27 KB keys + 5 KB data, 72 B + 15 B avg, 87 B max 0x04: 1109 items, 17 KB keys + 17 KB data, 15 B + 15 B avg, 69 B max 0x06: 383 items, 3 KB keys + 0 KB data, 9 B + 2 B avg, 18 B max 0x07: 510 items, 4 KB keys + 12 KB data, 9 B + 24 B avg, 41 B max 0x09: 194 items, 0 KB keys + 123 KB data, 5 B + 634 B avg, 11484 B max 0x0a: 3 items, 0 KB keys + 0 KB data, 14 B + 17 B avg, 51 B max 0x0b: 181836 items, 2363 KB keys + 10694 KB data, 13 B + 58 B avg, 173 B max 0x0d: 44282 items, 1461 KB keys + 61081 KB data, 33 B + 1379 B avg, 1637399 B max Total 10469408 items, 969939 KB keys + 4477905 KB data. ``` Class 00 is now down to 2.6 GB, with just 61 MB added in class 0d. There will be some additional reads in some cases which theoretically hurts performance, but this will be more than compensated for by smaller writes and better compaction. On my own home setup which just has three devices and a handful of folders the difference is smaller in absolute numbers of course, but still less than half the old size: ``` 0x00: 297122 items, 20894 KB keys + 306860 KB data, 70 B + 1032 B avg, 103237 B max 0x01: 115299 items, 7738 KB keys + 17542 KB data, 67 B + 152 B avg, 419 B max 0x02: 1430537 items, 121223 KB keys + 5722 KB data, 84 B + 4 B avg, 253 B max ... Total 1947412 items, 151268 KB keys + 337485 KB data. ``` to: ``` 0x00: 297122 items, 20894 KB keys + 37038 KB data, 70 B + 124 B avg, 520 B max 0x01: 115299 items, 7738 KB keys + 17542 KB data, 67 B + 152 B avg, 419 B max 0x02: 1430537 items, 121223 KB keys + 5722 KB data, 84 B + 4 B avg, 253 B max ... 0x0d: 18041 items, 595 KB keys + 71964 KB data, 33 B + 3988 B avg, 101109 B max Total 1965447 items, 151863 KB keys + 139628 KB data. ``` * wip * wip * wip * wip	2020-01-24 08:35:44 +01:00
Simon Frei	08f0e125ef	all: Transactionalize db.FileSet (fixes #5952) (#6239)	2020-01-21 18:23:08 +01:00
Jakob Borg	d62a0cf692	lib/model: Handle progress emitter zero interval (fixes #6281) (#6282) ... Makes the logic a bit clearer and safer. This also sneakily redefines the 0 interval to also mean disabled, whereas it previously meant ... sometimes default to 1s, sometimes just spin.	2020-01-20 21:14:29 +01:00
Jakob Borg	6c8e8f0391	lib/model: Remove legacy handling of symlinks (#6276) ... This hardly seams relevant any more; 0.14.14 is dead since a long time.	2020-01-19 12:02:20 +01:00
Simon Frei	39891cdf42	lib/model: Return paused summary instead of error on paused folders (#6272)	2020-01-17 09:30:00 +01:00
Simon Frei	e782bab9fc	lib/config: Add some info to the folder marker missing (ref #5207) (#6270)	2020-01-16 15:30:29 +01:00
Simon Frei	71882765f2	lib/events, lib/model: Unflake test and prevent deadlock on event unsubscribing (#6261)	2020-01-11 08:14:05 +01:00
Simon Frei	08753ccabe	lib/model: Reset queue after all pulling is done (fixes #5867) (#6256)	2020-01-08 12:21:22 +01:00
Simon Frei	f56a5545d4	gui, lib/model: Prevent negative sync completion (fixes #4570) (#6248)	2020-01-03 14:07:57 +01:00
Jakob Borg	be0508cf26	lib/model, lib/protocol: Use error handling to avoid panic on non-started folder (fixes #6174) (#6212) ... This adds error returns to model methods called by the protocol layer. Returning an error will cause the connection to be torn down as the message couldn't be handled. Using this to signal that a folder isn't currently available will then cause a reconnection a few moments later, when it'll hopefully work better. Tested manually by running with STRECHECKDBEVERY=0 on a nontrivially sized setup. This panics reliably before this patch, but just causes a disconnect/reconnect now.	2019-12-04 10:46:55 +01:00
Simon Frei	6fd5e78740	lib: Consistently unsubscribe from config-wrapper (fixes #6133) (#6205)	2019-12-04 07:15:00 +01:00
Marcus Legendre	b3fd9a8d53	lib/ignore: Don't create empty ".stignore" files (fixes #6190) (#6197) ... This will: 1. prevent creation of a new .stignore if there are no ignore patterns 2. delete an existing .stignore if all ignore patterns are removed	2019-12-02 08:19:02 +01:00
Jakob Borg	e82a7e3dfa	all: Propagate errors from NamespacedKV (#6203) ... As foretold by the prophecy, "once the database refactor is merged, then shall appear a request to propagate errors from the store known throughout the land as the NamedspacedKV, and it shall be good".	2019-11-30 13:03:24 +01:00
Jakob Borg	928767e316	lib/model: gofmt lol :(	2019-11-29 09:29:59 +01:00
Jakob Borg	c71116ee94	Implement database abstraction, error checking (ref #5907) (#6107) ... This PR does two things, because one lead to the other: - Move the leveldb specific stuff into a small "backend" package that defines a backend interface and the leveldb implementation. This allows, potentially, in the future, switching the db implementation so another KV store should we wish to do so. - Add proper error handling all along the way. The db and backend packages are now errcheck clean. However, I drew the line at modifying the FileSet API in order to keep this manageable and not continue refactoring all of the rest of Syncthing. As such, the FileSet methods still panic on database errors, except for the "database is closed" error which is instead handled by silently returning as quickly as possible, with the assumption that we're anyway "on the way out".	2019-11-29 09:11:52 +01:00
Simon Frei	606154b183	lib/model: Also send folder summary from sync-preparing (ref #6028) (#6202)	2019-11-29 08:30:17 +01:00
Jakob Borg	4e151d380c	lib/versioner: Reduce surface area (#6186) ... * lib/versioner: Reduce surface area This is a refactor while I was anyway rooting around in the versioner. Instead of exporting every possible implementation and the factory and letting the caller do whatever, this now encapsulates all that and exposes a New() that takes a config.VersioningConfiguration. Given that and that we don't know (from the outside) how a versioner works or what state it keeps, we now just construct it once per folder and keep it around. Previously it was recreated for each restore request. * unparam * wip	2019-11-26 07:39:31 +00:00
Simon Frei	4d368a37e2	lib/model, lib/protocol: Add contexts sending indexes and download-progress (#6176)	2019-11-25 11:07:36 +01:00
Simon Frei	cf312abc72	lib: Wrap errors with errors.Wrap instead of fmt.Errorf (#6181)	2019-11-23 15:20:54 +00:00
Simon Frei	65d4dd32cb	lib/model: Also handle ServeBackground (#6173)	2019-11-22 21:30:16 +01:00
Simon Frei	57d668ed1d	lib/config: Do introductions in a single config change (#6162)	2019-11-21 08:41:41 +01:00
Simon Frei	90d85fd0a2	lib: Replace done channel with contexts in and add names to util services (#6166)	2019-11-21 08:41:15 +01:00
Simon Frei	0d14ee4142	lib/model: Don't info log repeat pull errors (#6149)	2019-11-19 09:56:53 +01:00
Simon Frei	28edf2f5bb	lib/model: Keep fmut locked while adding/starting/restarting folders (#6156)	2019-11-18 21:15:26 +01:00
Simon Frei	5edf4660e2	lib/model: Prevent cleanup-race in testing (ref #6152) (#6155)	2019-11-14 23:08:40 +01:00
Simon Frei	f80ce17497	lib/model: In tests prevent goroutine leaks and increase timeouts (#6152)	2019-11-13 10:21:54 +01:00
Simon Frei	ce72bee576	lib/model: Simplify pull error/retry logic (fixes #6139) (#6141)	2019-11-11 15:50:28 +01:00
Simon Frei	85e6a77f25	lib/model: Remove some testing deadlocks (#6138)	2019-11-08 18:53:51 +01:00
Jakob Borg	88244b0c1f	lib/model: Add test for previous commit	2019-11-08 17:03:25 +01:00
Simon Frei	cd290d2d05	lib/model: Add initial deviceStatRefs on model creation (fixes #6136) (#6137) ... This is a regression introduced in PR #6005 / commit f7b2e79fdc	2019-11-08 11:32:51 +00:00
Simon Frei	bee7cce081	lib/model: Add folders on start in model (#6135)	2019-11-08 10:56:16 +01:00
Ruslan Yevdokymov	3b5dff3f34	lib/model: Fix removal of a marker when there are still folders referencing it (#6114)	2019-10-30 15:11:07 +00:00
Simon Frei	bbdda059bd	lib/model: Check for symlinks before deleting during pull (fixes #6090) (#6100)	2019-10-22 21:55:51 +02:00
Simon Frei	7b33294955	gui, lib/model: Add new state FolderPreparingSync (fixes #6027) (#6028)	2019-10-16 09:08:54 +02:00
Lukas Lihotzki	96bb1c8e29	all, lib/logger: Refactor SetDebug calls (#6054)	2019-10-04 13:03:34 +02:00
Audrius Butkevicius	8fb576ed54	lib/model: Adjust blocks reported in usage reporting (fixes #5995) (#6037) ... * lib/model: Adjust blocks reported in usage reporting (fixes #5995) * Use variables, fix go.mod	2019-10-04 12:03:13 +01:00
Simon Frei	a2a14c8424	lib/model: Set empty version when unignoring deleted files (fixes 6038) (#6039)	2019-10-01 15:34:59 +02:00
Simon Frei	28b6e8b063	lib/db: Update db when only local flags change (fixes #6008) (#6007)	2019-09-12 08:47:39 +02:00
Simon Frei	f7b2e79fdc	lib/model: Use read-locks wherever possible (#6005)	2019-09-12 05:55:23 +01:00
Jakob Borg	ebd2e5bf30	lib/model: Correctly handle manual rescan with ignore error (fixes #5985) (#5987) ... Assume a folder error was set due to bad ignores on the latest scan. Previously, doing a manual rescan would result in: 1. Clearing the folder error, which schedules (immediately) an fs watcher restart 2. Attempting to load the ignores, which fails, so we set a folder error and bail. 3. Now the fs watcher restarts, as scheduled, so we trigger a scan. Goto 1. This change fixes this by not clearing the error until the error is actually cleared, that is, if both the health check and ignore loading succeeds.	2019-08-30 13:27:26 +01:00
Jakob Borg	24d4290d03	lib/model, lib/scanner: Pass a valid event logger (fixes #5970) (#5971)	2019-08-21 08:05:43 +02:00