cotugno/syncthing
2
Fork 0
mirror of https://github.com/syncthing/syncthing.git synced 2024-11-16 10:28:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

lib/model: Disallow reserved names, and names ending with period on Windows (fixes #7008) (#7010)

Browse Source 
Like we already do with names ending in space or containing invalid
characters.
This commit is contained in:
Jakob Borg 2020-09-28 09:25:43 +02:00 committed by GitHub
parent 8452fd2ab4
commit df99237a7f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/fs/util.go
View File

@ -56,13 +56,23 @@ var windowsDisallowedCharacters = string([]rune{
}) })
func WindowsInvalidFilename(name string) bool { func WindowsInvalidFilename(name string) bool {
// None of the path components should end in space // None of the path components should end in space or period, or be a
// reserved name.
// (https://docs.microsoft.com/en-us/windows/win32/fileio/naming-a-file)
for _, part := range strings.Split(name, `\`) { for _, part := range strings.Split(name, `\`) {
if len(part) == 0 { if len(part) == 0 {
continue continue
} }
if part[len(part)-1] == ' ' { switch part[len(part)-1] {
// Names ending in space are not valid. case ' ', '.':
// Names ending in space or period are not valid.
return true
}
switch part {
case "CON", "PRN", "AUX", "NUL",
"COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9",
"LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9":
// These reserved names are not valid.
return true return true
} }
} }