dkanada
2e9661c415
Merge pull request #5043 from senritsu/improve-episode-number-parsing-with-digits-in-names
...
adjust episode path expression to allow digits in series names
2021-02-05 11:43:32 +09:00
Bond_009
956ca0e5aa
100% branch coverage for Jellyfin.Naming
2021-01-21 15:46:10 +01:00
senritsu
4e21b49994
adjust episode path expression to allow digits in series names
...
The previous expression was too greedy to consume digits, because the hyphen was optional. This lead to incorrect episode numbers for certain series with digits in their names, in those cases each episode was recognized as the same episode number (the digit from the series name).
The rule, which matches most standard anime filenames, also had a lower priority than one of the Kodi rules, leading to incorrect recognition for absolute numbered episodes with triple digits and higher (first digit was used as season number, rest of digits as episode number). This also resolves one of the TODO test cases.
Additional test cases were added to ensure that both hyphens in different parts of the filename, as well as names without hyphens, still work correctly. All previous test cases still pass.
Unfortunately another TODO (EpisodeNumberTests.cs@L76, Uchuu Senkan Yamato 2199) with the same issue (digits in the series name) could not be trivially fixed in the same change, due to the significantly different formatting. Attempts to resolve this case did not work out for now.
2021-01-17 20:24:23 +01:00
crobibero
20251e670f
Fix tests
2020-11-22 14:39:34 -07:00
crobibero
2aefe9ed5a
Only trim file name if folder name is shorter
2020-11-22 14:17:42 -07:00
Greenback
e51ddd326c
Fixes spelling.
2020-11-18 13:23:45 +00:00
martinek-stepan
04a712ab1d
Update Emby.Naming/Video/VideoFileInfo.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2020-11-17 15:11:32 +01:00
Stepan
d481c35cad
Merge fix
2020-11-17 13:06:56 +01:00
BaronGreenback
2bbfcc264d
Merge branch 'master' into emby-namig-nullable
2020-11-16 19:47:36 +00:00
martinek-stepan
4bfcc8b0d1
Update Emby.Naming/AudioBook/AudioBookListResolver.cs
...
Use StringComparison.OrdinalIgnoreCase when comparing names
Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2020-11-12 16:51:52 +01:00
Stepan
b66239fd52
One more missed suggestions (removing commented out code)
2020-11-12 13:18:22 +01:00
Stepan
3bca1181b3
Taken suggestions from code review and created test for ExtraRuleType.Regex instead of throwing exception there.
2020-11-12 13:16:33 +01:00
martinek-stepan
496923719c
Apply suggestions from code review
...
Co-authored-by: BaronGreenback <jimcartlidge@yahoo.co.uk>
2020-11-12 12:54:55 +01:00
Stepan
158eff62d7
Xml-doc part2
2020-11-10 19:23:10 +01:00
crobibero
83629ab6f2
Update packages to net5
2020-11-10 09:52:34 -07:00
Stepan
693760e38a
Xml-doc part1
2020-11-10 17:11:48 +01:00
Stepan
c0747512d6
Merge remote-tracking branch 'jellyfin/master' into emby-namig-nullable
2020-11-10 12:42:49 +01:00
crobibero
78551d166a
Don't throw exception if name is null
2020-11-09 06:10:16 -07:00
Stepan
f22e0800e2
Episode parsing coverage
2020-11-07 11:02:12 +01:00
Stepan
e96e480f01
Add comment with match cases for weir EpisodeExpression and named group for some date EpisodeExpressions
2020-11-06 15:52:01 +01:00
Stepan
3466dc5581
Finish coverage for Emby.Naming.Video
2020-11-05 16:59:15 +01:00
Stepan
5741150367
Enable MultiVersion video tests and added support for naming based on tests 11 & 8
2020-11-05 14:51:27 +01:00
Stepan
c060ed1a18
Added resolving of alternative files and extras for audibooks.
2020-11-03 16:24:04 +01:00
Stepan
1e71775688
Add Name and Year parsing for audiobooks
2020-11-02 20:03:12 +01:00
Stepan
f39775dc3a
Written test to finish coverage for AudioBookListResolver & AudioBookResolver and corrected some logical erros / unhandled exception
2020-11-01 17:10:48 +01:00
Stepan
e7a37bedfc
Simplify AudioBookResolver since there is no option of passing directories into it (AudioResolver.cs:179) and handling directories were not implemented anyway
2020-11-01 13:42:56 +01:00
Stepan
6437cf6950
Removed Success property from AudioBookFilePathParserResult, since it was unused and consider only audiobooks that have chapter/page number in name makes no sense
2020-11-01 13:28:43 +01:00
Stepan
60b49e67ea
Re-Sharper inspection issues
2020-11-01 11:19:22 +01:00
Stepan
59619b6ea7
Enable nullable in Emby.Naming
2020-11-01 10:47:31 +01:00
Bond_009
74f4affcda
Fix AudioBookListResolver test coverage
2020-10-12 20:09:15 +02:00
Bond_009
228b33a23b
Minor improvements
2020-09-20 14:02:41 +02:00
Keridos
b9c7cce696
some testing for AudioBook
...
fix PartNumber detection
2020-09-09 02:24:17 +02:00
Bond-009
6d154041b9
Merge pull request #3880 from DirtyRacer1337/datetime
...
Fix year parsing
2020-09-05 16:09:05 +02:00
Erwin de Haan
346581bb2a
Fixes for CI Nuget package pushing and CI triggers
...
Also adds SourceLink support and symbols that are pushed to Nuget.
Add symbols to main nuget packages for unstable builds (Azure Artifacts does not support symbols outside of the main package)
SourceLink will enable stepping during debugging.
2020-09-02 22:42:00 +02:00
crobibero
b02650ec2f
use proper spdx
2020-08-26 07:39:01 -06:00
crobibero
5f60da29c7
switch to spdx
2020-08-26 07:36:57 -06:00
crobibero
670c41ee89
Properly pack project license
2020-08-25 21:33:19 -06:00
David
b92fbe4d69
Use VersionPrefix
2020-08-13 19:03:24 +02:00
David
a61f6e3308
Fix nuget ci
2020-08-13 15:22:12 +02:00
DirtyRacer1337
f5d90949cf
Replace \d to [0-9]
2020-08-12 22:02:19 +07:00
DirtyRacer1337
1259fe2d50
Add date filter
2020-08-12 09:08:09 +07:00
DirtyRacer1337
c2f901acfe
Fix year parsing
2020-08-12 07:56:01 +07:00
Bond-009
3ff110984a
Merge branch 'master' into readonlyspan
2020-07-24 09:40:44 +02:00
Bond_009
febb6bced6
Review usage of string.Substring (part 1)
...
Reduced allocations by replacing string.Substring with ReadOnlySpan<char>.Slice
2020-07-22 13:39:24 +02:00
Bond_009
e98351b912
Replace \d with [0-9] in ffmpeg detection and scan code
2020-07-20 14:14:15 +02:00
Bond-009
9af6eda0b4
Merge pull request #3343 from telans/comment-stops
...
Add full stop at end of comments (SA1629)
2020-06-16 11:54:58 +02:00
telans
247f9c61e6
fix SA1513/SA1516
2020-06-16 16:11:30 +12:00
telans
9018f8d8be
Add full stop at end of comments (SA1629)
2020-06-16 10:37:52 +12:00
Bond-009
f0d182b8fe
Merge pull request #3046 from puschie286/add-clean-name-tag
...
allow bd tag in file names
2020-06-03 15:50:32 +02:00
Vasily
ce16651dbd
Fix a check broken by https://github.com/jellyfin/jellyfin/pull/2105
2020-05-15 01:55:53 +03:00
