Commit Graph

435 Commits

Author SHA1 Message Date
Shadowghost
c760a50d59 Apply review suggestions 2023-02-27 16:03:12 +01:00
Shadowghost
9880a2b3e1 Enforce HLS codec restrictions 2023-02-27 10:38:50 +01:00
Bond_009
24a7e210c3 Optimize tryparse
* Don't check for null before
* Don't try different formats when not needed (NumberFormat.Integer is the fast path)
2023-02-19 16:52:29 +01:00
Telepathic Walrus
06b40980f4 Fix transcoded audio not playing (#9251) 2023-02-05 19:27:50 +00:00
Dmitry Lyzo
28b98cacc8 Backport pull request #9051 from jellyfin/release-10.8.z
Fix transcode reasons

Original-merge: 1dea309ae4

Merged-by: Joshua M. Boniface <joshua@boniface.me>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2023-01-22 14:05:37 -05:00
Bond-009
817996da4b
Merge pull request #7494 from Shadowghost/streambuilder-cleanup 2022-12-29 15:21:28 +01:00
Shadowghost
81a7261980
Default to no bitrate limit if no maxBitrate is set (#8850)
Fixes https://github.com/jellyfin/jellyfin/issues/3277
2022-12-14 22:04:05 +01:00
Shadowghost
0834dc58c1 Fix .Net 7 compatibility 2022-12-07 18:06:04 +01:00
Shadowghost
8e8a085b7e Prefer var in StreamBuilder 2022-12-07 18:00:44 +01:00
Shadowghost
08a5c71b90 Add xmldoc for MediaOptions 2022-12-07 18:00:03 +01:00
Shadowghost
1cd7da8889 Apply review suggestions 2022-12-07 18:00:03 +01:00
Shadowghost
697efec86e Cleanup and refactor streambuilder 2022-12-07 18:00:01 +01:00
Bond_009
b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009
52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Dmitry Lyzo
2eb00bf3c0 fix secondary audio
Browsers (Chrome, Firefox) can only play the first track,
even if the second track is the default.

Ignore default flag when testing on secondary audio.

External audio tracks are not secondary.
2022-10-31 15:49:34 +03:00
Maxr1998
bf059d5b58 Backport pull request #8411 from jellyfin/release-10.8.z
Allow direct play even if no audio stream is available

Original-merge: bf129ab9b8

Merged-by: Claus Vium <cvium@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2022-10-28 22:38:56 -04:00
Claus Vium
719e5eae16
Merge pull request #8503 from Bond-009/ThrowIfNull 2022-10-07 07:50:39 +02:00
Jan Sommer
87d460909f Fix minor warnings in MediaBrowser.Model/Configuration (#2149) 2022-10-06 21:44:12 +02:00
Bond_009
a9a5fcde81 Use ArgumentNullException.ThrowIfNull helper method
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)

```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```

```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Hannes Braun
4edeccc5e0
Remove redundant using directives 2022-09-28 16:26:03 +02:00
luz paz
9ec2870b10 Fix various typos
Found via `codespell -q 3 -S ./Emby.Server.Implementations/Localization -L allready,doesnt,inh,receivedfrom,whoknows`
2022-08-15 06:48:34 -04:00
Cody Robibero
38102499cb Merge pull request #7947 from nyanmisaka/video-range-condition
(cherry picked from commit f1d56aa5ce)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:14 -04:00
Joshua M. Boniface
47d150565d Merge pull request #7712 from jellyfin/fix-hevc-disable-option
(cherry picked from commit 5a9e5e0d5d)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:57 -04:00
Joshua M. Boniface
2d8f7b46f1 Merge pull request #7699 from Shadowghost/streambuilder-fix
(cherry picked from commit b46d61dfdf)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:57 -04:00
Cody Robibero
688553b9a8 Merge pull request #7537 from dmitrylyzo/fix-streambuilder
(cherry picked from commit 5833c70725)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:10 -04:00
Cody Robibero
1960b5bdce Merge pull request #7523 from crobibero/null-stream
Allow media without streams to playback 

(cherry picked from commit 577325b788)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
Shadowghost
4e91c3ebdc Fix DLNA DirectPlay 2022-03-25 18:02:31 +01:00
Dmitry Lyzo
e4137a6279 Fix remuxing 2022-03-20 09:11:46 +03:00
Dmitry Lyzo
1fe82d0deb Add TranscodingProfile conditions 2022-03-20 09:11:46 +03:00
Cody Robibero
b9c3a497d5 Use requested bitrate for calculations 2022-03-19 12:08:42 -06:00
Cody Robibero
d29c7c1d9e Revert using Math.Clamp 2022-03-13 12:46:13 -06:00
Cody Robibero
e6df698df1
Merge pull request #7325 from eyezak/issue/6450 2022-03-12 09:08:25 -07:00
Cody Robibero
3ea4174d12 Fix flipped Clamp args 2022-03-12 07:17:59 -07:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Cody Robibero
da41cd365c Suggestions from review 2022-03-06 18:17:49 -07:00
Cody Robibero
bbd5d11d3b Remove TranscodeReason.None, Add JsonFlagEnum tests 2022-03-06 18:13:54 -07:00
Cody Robibero
c331e11c24 Clean up EnumFlags serialization 2022-03-06 18:13:54 -07:00
Isaac Gordezky
9ebd521754 Update MediaBrowser.Model/Dlna/StreamBuilder.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-03-06 18:13:54 -07:00
Isaac Gordezky
84a3db6f84 Fix transcode video matching and add tests for Transcode and Safari 2022-03-06 18:13:54 -07:00
Isaac Gordezky
5e779f20ee Series: issue-6450
Issue: https://github.com/jellyfin/jellyfin/issues/6450

Enable DirectPlay responses
Rewrite DirectPlay and DirectStream resolution
Prefer copy transcode video codec options
Enhance condition processor
Support DirectStream and Transcode with parity
Rework audio stream selection and add tests for ExternalAudio
Update MediaInfoHelper to only call StreamBuilder once
2022-03-06 18:13:54 -07:00
Isaac Gordezky
d871dded9f Convert TranscodeReason to Flags 2022-03-06 18:13:54 -07:00
Bond_009
f50a250cd9 Optimize Guid comparisons
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Shadowghost
ca5112f45a feat(external-media): refactor external subtitle and audio provider 2022-02-18 22:19:24 +01:00
Bond_009
1c14c86b20 Fix some warnings 2022-02-14 14:46:04 +01:00
Cody Robibero
904efeaddc Add null check for audio stream 2022-01-06 08:15:37 -07:00
Cody Robibero
7bfc6b5679 Remove more warnings 2021-12-27 07:38:06 -07:00
Bond_009
cbfa355e31 Update StyleCop 2021-12-24 18:28:27 +01:00
Cody Robibero
55b429edb7
Merge pull request #6920 from marius-luca-87/subtitle_drop 2021-12-24 02:01:44 +00:00
Cody Robibero
076a13abeb
Merge pull request #7029 from cvium/allocations_maybe 2021-12-24 01:59:25 +00:00