aled
22a860a806
Fix a small number of compile warnings
2020-06-06 20:17:49 +01:00
crobibero
57d1dbfe7b
undo erroneous changes
2020-06-05 18:29:58 -06:00
crobibero
44957c5a9a
Use typed logger where possible
2020-06-05 18:15:56 -06:00
Patrick Barron
06f9cde22f
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/EntryPoints/ServerEventNotifier.cs
# Emby.Server.Implementations/Library/UserManager.cs
# Emby.Server.Implementations/Sorting/IsFavoriteOrLikeComparer.cs
# Emby.Server.Implementations/Sorting/IsPlayedComparer.cs
# Emby.Server.Implementations/Sorting/IsUnplayedComparer.cs
# Emby.Server.Implementations/TV/TVSeriesManager.cs
# Jellyfin.Server.Implementations/Users/DefaultAuthenticationProvider.cs
2020-06-04 16:52:23 -04:00
Vasily
40502a33e0
Merge pull request #3203 from Bond-009/warn18
...
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
2020-06-03 12:27:59 +03:00
Vasily
668e10ceb7
Merge pull request #2767 from Bond-009/nullable3
...
Enable nullabe reference types for MediaBrowser.Model
2020-06-03 12:26:54 +03:00
Bond_009
4748105dce
Enable TreatWarningsAsErrors for Jellyfin.Server.Implementations in Release mode
2020-05-29 11:28:19 +02:00
Bond_009
7439e095e2
Merge branch 'master' into nullable3
2020-05-27 20:49:18 +02:00
Patrick Barron
eef7cfd912
Make SonarCloud less angry
2020-05-26 22:43:03 -04:00
Patrick Barron
01ce56016a
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Library/UserManager.cs
# Jellyfin.Data/Jellyfin.Data.csproj
# MediaBrowser.Api/UserService.cs
# MediaBrowser.Controller/Library/IUserManager.cs
2020-05-26 20:29:11 -04:00
Bond_009
10e381f66f
Fix some 'bugs' flagged by sonarcloud
2020-05-25 23:52:51 +02:00
Patrick Barron
c464f700db
Remove redundant qualifiers
2020-05-20 13:07:53 -04:00
dkanada
668a7b97c7
Merge pull request #3072 from JustAMan/fix-dead-livetv
...
Re-raise the exception that caused LiveTV stream to not open
2020-05-18 23:23:47 +09:00
Vasily
c70e38288c
Apply suggestions from code review
...
Co-authored-by: dkanada <dkanada@users.noreply.github.com>
2020-05-18 17:01:29 +03:00
Patrick Barron
aca7e221d8
Merge branch 'master' into userdb-efcore
...
# Conflicts:
# Emby.Server.Implementations/Activity/ActivityLogEntryPoint.cs
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/Devices/DeviceManager.cs
# Jellyfin.Server/Jellyfin.Server.csproj
# Jellyfin.Server/Migrations/MigrationRunner.cs
# MediaBrowser.Controller/Devices/IDeviceManager.cs
2020-05-15 17:20:07 -04:00
Vasily
f08830ea00
Merge pull request #2774 from mark-monteiro/simplify-https-config
...
Simplify HTTPS Properties
2020-05-13 20:36:54 +03:00
Patrick Barron
9ad839c776
Initial migration code
2020-05-12 22:10:35 -04:00
Patrick Barron
62420a6eb1
Remove support for injecting ILogger directly
2020-05-12 16:03:15 -04:00
Mark Monteiro
43c22a5822
Add GetLoopbackHttpApiUrl() helper method to replace forceHttps functionality
...
Also refactor to use return a Uri instead of a string and use UriBuilder under the hood
2020-05-10 14:36:11 -04:00
Vasily
3401d55f41
Fixed yet another case of hanging on a bad stream
2020-05-08 23:11:43 +03:00
Vasily
a517bd2e52
Re-raise the exception that caused LiveTV stream to not open
2020-05-08 14:32:41 +03:00
Joshua M. Boniface
f502c89331
Merge pull request #2798 from JustAMan/fix-livetv-again
...
Make localhost LiveTV restreams always use plain HTTP port
2020-04-26 15:13:27 -04:00
Mark Monteiro
f815059698
Merge remote-tracking branch 'upstream/master' into register-services-correctly
2020-04-20 20:11:33 -04:00
dkanada
eda208e258
Merge pull request #2829 from Bond-009/warn19
...
Fix some warnings
2020-04-19 12:04:02 +09:00
Bond_009
fc049caba2
Merge branch 'master' into nullable3
2020-04-15 11:09:14 +02:00
Mark Monteiro
9728aa8b0a
Merge branch 'master' into register-services-correctly
2020-04-13 17:06:24 -04:00
Mark Monteiro
4113288278
Fix style issues
2020-04-11 13:46:31 -04:00
Mark Monteiro
7152b55747
Use a separate line for each property initializer
2020-04-11 13:28:21 -04:00
Bond_009
49fe5e0a21
Fix some warnings
2020-04-11 12:03:10 +02:00
Vasily
e85f9f5613
Make localhost LiveTV restreams always use plain HTTP port
2020-04-07 18:41:15 +03:00
Bond_009
30ce346f34
Enable nullabe reference types for MediaBrowser.Model
2020-04-05 18:10:56 +02:00
Mark Monteiro
658e963e93
replace 'try-finally' with 'using' where appropriate
2020-04-05 09:23:44 -04:00
Mark Monteiro
cb2d99e831
Construct LiveTvDtoService and LiveTvManager correctly
2020-04-04 14:40:04 -04:00
Mark Monteiro
3d5b4f869c
Register ILiveTvManager and IPlaylistManager correctly
2020-04-04 13:16:53 -04:00
Mark Monteiro
e0f40f57d8
Merge remote-tracking branch 'upstream/master' into remove-common-process
2020-04-03 20:22:03 -04:00
Bond_009
2be394089e
Enable Microsoft.CodeAnalysis.FxCopAnalyzers for Jellyfin.Common
2020-04-02 20:12:18 +02:00
Bond-009
f31efce52d
Merge branch 'master' into usings
2020-04-01 22:42:43 +02:00
Bond_009
3ab50f5a3f
Address comments
2020-04-01 19:05:41 +02:00
Mark Monteiro
7447ea8960
Make sure Process objects are all disposed correctly
2020-03-27 00:49:22 +01:00
Mark Monteiro
b947d98266
Delete unnecessary ProcessFactory abstraction
2020-03-27 00:45:48 +01:00
Mark Monteiro
ee2f911a2b
Remove unnecessary CommonProcess abstraction
2020-03-27 00:10:16 +01:00
Bond_009
e9d1eabd53
Remove unused usings
2020-03-24 16:12:06 +01:00
Bond-009
94fe9b8f6d
Merge branch 'master' into warn17
2020-03-11 20:26:43 +01:00
Mark Monteiro
b67e9cde8c
Replace ILogger with ILogger<T> wherever possible
...
Log entries will contain additional class context when using this interface
2020-03-03 23:07:10 +01:00
Bond_009
07cc4be6a7
Fix some warnings
...
* Add analyzers to MediaBrowser.XbmcMetadata
* Enable TreatWarningsAsErrors for MediaBrowser.XbmcMetadata
* Add analyzers to MediaBrowser.WebDashboard
* Enable TreatWarningsAsErrors for MediaBrowser.WebDashboard
* Disable SA1600 in favor of CS1591
2020-02-23 12:11:43 +01:00
Bond_009
184ad29f3f
Address comments
2020-02-19 21:04:28 +01:00
Bond_009
7060934792
Fix some warnings in Emby.Server.Implementations
2020-02-06 15:21:38 +01:00
dkanada
b7a9900556
Merge pull request #2357 from Bond-009/warn13
...
Fix warnings
2020-02-03 17:15:03 +09:00
Bond_009
87d2479b78
Fix warnings
2020-01-31 22:26:53 +01:00
dkanada
cd13f718fb
Merge pull request #2247 from Bond-009/stringhelper
...
Remove StringHelper functions
2020-02-01 03:29:16 +09:00
Bond-009
c8409d2ea1
Remove FileSystem.GetStream
2020-01-22 22:20:35 +01:00
Bond_009
e714b9930e
Merge branch 'master' into embytv
2020-01-10 21:16:46 +01:00
Bond-009
fdbb329118
Remove StringHelper functions
2020-01-09 17:07:13 +01:00
dkanada
fb61a1f882
Merge pull request #2150 from Bond-009/releaseerror
...
Enable TreatWarningsAsErrors for some projects
2020-01-02 10:13:57 +09:00
Bond-009
c824c564cd
Move Emby.XmlTv to a NuGet package ( #2042 )
...
* Move Emby.XmlTv to a NuGet package
* Update Emby.Server.Implementations/Emby.Server.Implementations.csproj
Co-Authored-By: Anthony Lavado <anthonylavado@me.com>
2019-12-14 00:45:29 -05:00
Bond_009
5a8e972952
Enable TreatWarningsAsErrors for some projects
...
Analyzers are only run in debug build, so setting TreatWarningsAsErrors
for release build will catch the compiler warnings until we resolve all
analyzer warnings.
2019-12-13 20:11:37 +01:00
Bond-009
a4ca259a64
Add improved error error for #2141
2019-12-12 17:25:58 +01:00
Bond-009
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
2019-12-06 12:06:13 +01:00
Bond_009
5cab79c839
Clean up Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
2019-12-04 21:39:27 +01:00
Joshua M. Boniface
48120d01dc
Merge pull request #1991 from Bond-009/transtemp
...
Don't append transcodes to transcoding temp path
2019-11-24 15:13:50 -05:00
Bond-009
b477b3874e
Fix some warnings
2019-11-22 16:15:31 +01:00
Bond-009
d4b438791f
Don't append transcodes to transcoding temp path
2019-11-21 16:57:49 +01:00
dkanada
f3ca37e523
minor changes to transcode cleanup scheduled task
2019-11-21 21:55:10 +09:00
Bond_009
a245f5a0d4
Rewrite hex encoder/decoder
2019-11-01 17:52:29 +01:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
Bond_009
bbc0875387
Don't shuffle some types by default
2019-10-20 16:08:40 +02:00
Bond_009
c9820d30ed
Fix multiple mistakes and warnings
2019-09-23 20:32:44 +02:00
Bond_009
8fe7b6551f
Rewrite ItemDataProvider to be more robust
...
* Stop locking 2+ times per operation
* Don't clone the list multiple times
* Keep the lock for the duration of the operation
2019-09-12 21:34:55 +02:00
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
Anthony Lavado
cb393c215a
Merge pull request #1686 from Bond-009/warn7
...
More warning fixes
2019-09-02 02:07:19 -04:00
Bond_009
e4f893a0eb
More warning fixes
2019-08-29 22:28:33 +02:00
Bond_009
0aaaaab7a0
Fix invalid arg for
2019-08-29 20:25:56 +02:00
Bond_009
dc194015c2
Remove unused args
2019-08-28 13:59:17 +02:00
Bond_009
5dd332b63d
Attempt to fix #1391
2019-08-28 13:55:36 +02:00
Bond_009
1bc9b42c57
More fixes
2019-08-16 21:18:37 +02:00
Bond-009
4b37caa63a
Update SharedHttpStream.cs
2019-08-16 21:13:18 +02:00
Bond_009
237db8ae92
Clean up livestreaming code
2019-08-16 21:13:18 +02:00
dkanada
8f8d8e3d0b
Merge pull request #1581 from Bond-009/socket1
...
Use System.Net abstractions instead of raw socket
2019-08-13 19:58:57 -07:00
dkanada
5c366e4697
Merge pull request #1612 from Bond-009/warn4
...
Fix warnings
2019-08-10 15:12:54 -07:00
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
2019-08-09 23:17:54 +02:00
Bond_009
2a58c643d2
Fix more warnings
2019-08-09 23:16:24 +02:00
Bond-009
a5cb069f26
Update HdHomerunManager.cs
2019-08-09 22:38:31 +02:00
Bond_009
1cad93c276
Use System.Net abstractions instead of raw socket
2019-08-09 22:38:31 +02:00
Bond_009
ddd1a282ea
Remove IpAddressInfo and IpEndPointInfo classes
2019-07-25 00:15:06 +02:00
Bond-009
e8028de4d7
Merge pull request #1560 from jellyfin/release-10.3.z
...
Backmerge for 10.3.7
2019-07-24 19:10:04 +02:00
Bond_009
5d9fa06675
Cleanup
2019-07-13 17:18:39 -04:00
Bond_009
b294b802a8
Try to fix XmlTvListingsProvider
2019-07-13 17:18:27 -04:00
Bond-009
82f041d050
Merge branch 'master' into release-10.3.z
2019-07-06 23:08:52 +02:00
Bond_009
d405a400aa
Fixes issues with HttpClientManager
2019-07-06 20:04:42 +02:00
Bond-009
0a5550b13d
Remove more unused stuff
2019-06-18 22:20:34 -04:00
Bond-009
d0fbd260d5
Merge branch 'master' into httpclient
2019-03-27 16:34:26 +01:00
Bond-009
b44a70ff36
Simplify/remove/clean code
...
* Remove useless runtime check (we only support one)
* Remove unused args
* Remove a global constant
And ofc fix some warnings ;)
2019-03-25 22:25:32 +01:00
Bond-009
e64aaebbac
Improvements around streams
...
* Use ArrayPool instead of allocating new buffers each time
* Remove NetworkStream copy
* Remove some dead code
2019-03-13 21:11:01 +01:00
Vasily
1fef8bf266
Merge pull request #1060 from Bond-009/assinfo
...
Remove redundant class AssemblyInfo
2019-03-12 16:34:21 +03:00
Bond-009
7f42dcc60f
Remove more unused stuff
2019-03-08 20:32:14 +01:00
Bond_009
37ea50a572
Reduce the amount of exceptions thrown
2019-03-07 21:42:56 +01:00
Bond-009
e91dd14b31
Remove redundent class AssemblyInfo
2019-03-07 18:10:55 +01:00
Claus Vium
78742b8e4c
Switch to HeaderNames instead of hardcoded strings (and other header related fixes)
2019-03-05 19:20:28 +01:00
PloughPuff
73c1cdb32a
Avoid exceptions due to folder and file not found
...
1) Use function to return path to temp transcode path which has benefit of creating temp folder if not exists, thereby avoiding the exception when GetFilePaths is used.
2) Check json files exists before attempting to read from it. Avoids having to mask FileNotFound exceptions when debugging.
2019-02-20 13:30:06 +00:00
Joshua M. Boniface
89d4ce309d
Merge pull request #848 from Bond-009/perf
...
Minor changes to reduce allocations
2019-02-19 21:24:51 -05:00
Bond-009
4811e76860
Merge branch 'master' into perf
2019-02-16 17:05:44 +01:00
Bond-009
bdfd042d70
Merge branch 'master' into fields
2019-02-16 17:03:15 +01:00
Bond-009
43cf11aa35
Change discards
2019-02-16 00:42:56 +01:00
Bond_009
8d98885cda
Less string allocations
2019-02-12 21:06:47 +01:00
Felix Ruhnow
edf5ee0cc4
combining some of the if's and adressing #820
2019-02-11 10:11:07 +01:00
Felix Ruhnow
86089ec03a
Adding support for "tvg-chno"-Tag in M3U Channel Lists
2019-02-10 22:23:47 +01:00
Bond_009
a6a4cd5667
Removed some unused fields
2019-02-09 15:57:42 +01:00
Erwin de Haan
f1ef0b0b4c
Fix namespacing so it lines up properly with file names and paths ( #715 )
...
* Fix stupid namespacing so it lines up properly with file names and paths.
2019-02-09 10:10:33 +01:00
Claus Vium
0ef2b46106
Remove custom Threading
2019-02-05 16:47:50 +01:00
Vasily
0b3e6548db
Merge pull request #797 from Bond-009/warnings
...
Fix all warnings
2019-02-04 14:08:21 +03:00
Joshua M. Boniface
c4f51e16a5
Merge pull request #736 from Bond-009/startasync
...
Start startup tasks async
2019-02-03 22:23:54 -05:00
Bond-009
78e4e2ed92
Fix all warnings
2019-02-02 21:45:29 +01:00
Andrew Rabert
42d5a48491
Merge pull request #788 from Bond-009/warnings
...
Fix more warnings
2019-02-02 14:21:03 -05:00
Bond_009
1385d89df6
Remove MoreLINQ
2019-02-02 12:27:06 +01:00
Bond_009
8b073e2ba5
Remove unused field
2019-02-02 12:19:02 +01:00
Bond_009
5ac6d0ae59
Fix more warnings
2019-02-01 21:56:50 +01:00
Bond-009
1ea219bf3f
Merge branch 'master' into culture
2019-01-30 16:57:15 +01:00
Erwin de Haan
581a7fe078
Unwrapped MoveDirectory, DirectoryExists, FileExists & removed MoveFile
2019-01-28 22:10:00 +01:00
Erwin de Haan
a430568082
Unwrapped OpenRead and CopyFile
2019-01-28 22:09:58 +01:00
Erwin de Haan
d7c6d16250
Unwrapped CreateDirectory and DeleteDirectory
2019-01-28 22:09:56 +01:00
Erwin de Haan
3a831994f6
Unwrapped GetDirectoryName and DirectorySeperatorChar
2019-01-28 22:06:34 +01:00
Bond_009
85a58fd655
Start startup tasks async
2019-01-27 15:40:37 +01:00
Bond_009
a709cbdc64
Fix more analyzer warnings
2019-01-27 12:12:44 +01:00
Bond_009
fd7f420af2
Remove remnants of system events
2019-01-25 22:41:43 +01:00
Bond_009
722120af74
Remove conditions that are always true/false
2019-01-22 23:49:51 +01:00
William Taylor
65cd3ed597
Replaced injections of ILogger with ILoggerFactory
...
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.
The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.
Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Andrew Rabert
d7da475aad
Fix User-Agent
2019-01-19 21:38:42 -05:00
Andrew Rabert
8de4eb7d19
Rename ApplicationSemanticVersion to ApplicationVersion
2019-01-19 21:35:33 -05:00
Andrew Rabert
469590c9c5
Merge pull request #508 from EraYaN/api-version-reporting
...
Update internal versioning and user agents.
2019-01-19 21:08:35 -05:00
Erwin de Haan
924ec0c191
Revert Jellyfin.Versioning, Update all versions and user agents.
2019-01-20 01:12:44 +01:00
Erwin de Haan
949393043d
Fixed missing out keyword.
2019-01-19 22:07:48 +01:00
Erwin de Haan
e63b18f17d
Reformat JustAMan review second pass changes.
2019-01-19 14:30:23 +01:00
Erwin de Haan
321c440739
Reformat JustAMan review pt1 changes
...
Refs #575
2019-01-17 20:24:01 +01:00
Erwin de Haan
a358631040
Extra formatting on the merged code.
2019-01-15 17:35:33 +01:00
Erwin de Haan
49b61f238e
Merge branch 'dev' into reformat
...
# Conflicts:
# Emby.Server.Implementations/ApplicationHost.cs
# Emby.Server.Implementations/LiveTv/EmbyTV/EmbyTV.cs
# Emby.Server.Implementations/LiveTv/LiveTvManager.cs
# Emby.Server.Implementations/Security/MBLicenseFile.cs
# Emby.Server.Implementations/Security/PluginSecurityManager.cs
# Emby.Server.Implementations/Security/RegRecord.cs
# MediaBrowser.Api/PluginService.cs
# MediaBrowser.Api/System/SystemService.cs
# MediaBrowser.Common/Security/IRequiresRegistration.cs
# MediaBrowser.Common/Security/ISecurityManager.cs
# MediaBrowser.Common/Security/PaymentRequiredException.cs
# MediaBrowser.Model/Entities/MBRegistrationRecord.cs
# MediaBrowser.Model/Entities/PluginSecurityInfo.cs
# deployment/win-generic/build-jellyfin.ps1
2019-01-15 17:34:39 +01:00
cvium
22a64f37f5
More cleaning
2019-01-15 16:48:21 +01:00
cvium
0e422a33d6
Some code style clean up
2019-01-15 16:48:21 +01:00
Claus Vium
eca3c099d9
removed a bunch of validation, security, registration, premiere, whatever bs
2019-01-15 16:48:21 +01:00
Erwin de Haan
e867446437
ReSharper format: conform inline 'out' parameters.
2019-01-13 21:46:33 +01:00
Erwin de Haan
65bd052f3e
ReSharper conform to 'var' settings
2019-01-13 21:37:13 +01:00
Erwin de Haan
e566d9a231
Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv
2019-01-13 20:54:44 +01:00
Erwin de Haan
5b3d8a6d76
EditorConfig reformat: Emby.IsoMounting, Emby.Server.Implementations
2019-01-13 20:30:03 +01:00
Erwin de Haan
39ef1106d7
Visual Studio Reformat: Emby.Server.Implementations Part Liv-P
2019-01-13 20:22:00 +01:00
Erwin de Haan
846456b41e
Reformatted the files with notes.
2019-01-12 21:41:08 +01:00
Erwin de Haan
e2751d42e8
Merge branch 'dev' into code-cleanup
2019-01-11 12:50:36 +01:00
Joshua M. Boniface
15c89d281e
Merge pull request #506 from hawken93/linting
...
Removing tabs and trailing whitespace
2019-01-10 19:54:18 -05:00
Erwin de Haan
ec1f5dc317
Mayor code cleanup
...
Add Argument*Exceptions now use proper nameof operators.
Added exception messages to quite a few Argument*Exceptions.
Fixed rethorwing to be proper syntax.
Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)
Added some TODOs to log certain exceptions.
Fix sln again.
Fixed all AssemblyInfo's and added proper copyright (where I could find them)
We live in *current year*.
Fixed the use of braces.
Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.
Made more Methods that should be static static.
You can now use static to find bad functions!
Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
hawken
bd169e4fd4
remove trailing whitespace
2019-01-07 23:27:46 +00:00
hawken
82a801c9ae
Some less obvious ones that I was told were there
2019-01-07 21:29:59 +00:00
Bond_009
c07d5a6963
Remove unused PowerManagement
...
It isn't up to the application to prevent the system from going to sleep
2019-01-06 12:55:48 +01:00
