Commit Graph

20455 Commits

Author SHA1 Message Date
Bond-009
55102973d6
Merge pull request #5596 from BaronGreenback/DLNA_Hardening
Implemented DLNA exception handling
2021-03-25 01:29:10 +01:00
Bond-009
16011d96a0
Merge pull request #5321 from Ullmie02/nfo-thumb 2021-03-25 01:10:37 +01:00
Claus Vium
e64f9f2f66
Merge pull request #5613 from accek/accek-samsung-dlna-fix 2021-03-24 23:04:28 +01:00
Szymon Acedański
b1e8a8565f
Update Jellyfin.Api/Helpers/FileStreamResponseHelpers.cs
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-24 22:46:08 +01:00
cocool97
86852178c2
Update MediaBrowser.Controller/LiveTv/ChannelInfo.cs
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-03-24 21:23:59 +01:00
Bond-009
066c19a26b
Fix possible null ref exception 2021-03-24 21:06:03 +01:00
Szymon Acedański
136136dea9 Fix incorrect responses for HEAD /audio/<id>/stream
Without this fix my Samsung Soundbar (HW-Q80R) fails to play using DLNA
and returns "Error: Resource not found (716)" instead.

I had a look on tcpdump network logs between Jellyfin and the soundbar
and noticed that the device performs a HEAD request for the media before
responding to the DLNA UPNP control request from Jellyfin (or BubbleUPNP
Android App).

Jellyfin retuns 204 No Content response, which is unusual.  Common web
servers generally return 200 OK if the GET would return content, and
this is not-very-clearly suggested [in HTTP
spec](https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.1)

The other patch is to ensure, that invalid Content-Length: 0 is not
returned with the HEAD response in the streaming case.

I think in both cases we still don't return the same headers with HEAD
as with GET (e.g. Content-Length or Accept-Ranges), but at least we
don't return anything misleading.
2021-03-24 20:43:54 +01:00
David
a4cac09d5b Use |= 2021-03-23 19:25:32 +01:00
David
c2af50c51d Add tests for IsInNetwork 2021-03-23 17:39:55 +01:00
David
19e4ef82dd Remove conversion from IPAddress to string to IPAddress 2021-03-23 17:16:10 +01:00
David
572600b38e Use conditional operator instead of if/else block 2021-03-23 15:47:55 +01:00
BaronGreenback
6765f6ab17 fix compilation 2021-03-23 00:12:14 +00:00
Bond-009
8410a9a266
Merge pull request #5586 from nyanmisaka/disable-autorotate 2021-03-22 22:59:01 +01:00
cvium
74e14b4ca5 fix isdirectstream default 2021-03-22 22:34:47 +01:00
cvium
7dedeb6c79 change HLS endpoint defaults to false 2021-03-22 20:53:55 +01:00
Kenneth SB
4637bbc723 Translated using Weblate (Danish)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/da/
2021-03-22 13:34:36 -04:00
BaronGreenback
4bd345fbab DLNA Exception catching 2021-03-22 17:21:12 +00:00
BaronGreenback
5d16d1f66d
Merge branch 'master' into RemoteAccessFix 2021-03-22 17:05:44 +00:00
BaronGreenback
7fa525c83b Added more tests 2021-03-22 17:04:09 +00:00
Nyanmisaka
0853d1265c
Disable auto rotation for some HWA methods (#5586)
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-22 17:59:57 +01:00
Bond-009
f6671e05fd
Merge pull request #5580 from Bond-009/integrationtests2 2021-03-22 17:57:14 +01:00
Bond_009
5253483ce4 Improve naming 2021-03-22 13:49:00 +01:00
Nyanmisaka
fab4bf184e
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-22 19:47:05 +08:00
Nyanmisaka
a6bc191607
Apply suggestions from code review
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-03-22 19:25:41 +08:00
nyanmisaka
fcb070abf7 disable auto rotation for some HWA methods 2021-03-22 18:36:04 +08:00
Joshua M. Boniface
fe8cf29cad
Merge pull request from GHSA-wg4c-c9g9-rxhx
Fix issues 1 through 5 from GHSL-2021-050
2021-03-21 19:12:14 -04:00
Joshua M. Boniface
890a490776
Merge pull request #5532 from cvium/fix_episode_extras_questionmark 2021-03-21 15:13:56 -04:00
Bond_009
c5079ebed5 Add tests for GetFirstUser, UpdateStartupUser and CompleteWizard 2021-03-21 03:59:31 +01:00
Bond_009
849ced470a Add StartupControllerTests 2021-03-21 03:26:51 +01:00
LIAUD
72db3df605 Changed CONTRIBUTORS.md 2021-03-20 20:31:38 +01:00
LIAUD
32853ca244 Add 'group-title' channel parsing 2021-03-20 20:15:19 +01:00
Bill Thornton
9fe3ca7a92
Merge pull request #5476 from jellyfin/EraYaN-nuget-ci
Remove BuildPackage dependency for PublishNuget in CI
2021-03-19 20:50:42 -04:00
Erwin de Haan
1f3aa3fe6f Apply review suggestions 2021-03-20 01:28:14 +01:00
Erwin de Haan
470305f75e Authenticated arbitrary file overwrite in SubtitleController -> SubtitleManager
GHSL-2021-050: Issue 5 Arbitrary file overwrite.
2021-03-20 01:14:59 +01:00
Erwin de Haan
239a7156cc Fix arbitrary image file reads in ImageByNameController
GHSL-2021-050: Issue 4 Arbitrary image file read and directory traversal.
2021-03-20 01:14:59 +01:00
Erwin de Haan
f61d18612b Fix directory traversal in the HlsSegmentController in a fairly rudimentary but working way.
GHSL-2021-050: Issue 1,2,3 Arbitrary file read and directory traversal.
The segment id's can probably just be verified to be an actual ID or to not contain any forward or backward slashes
2021-03-20 01:14:59 +01:00
Bond-009
1a0ce16f4d
Merge pull request #5504 from crobibero/json-string-converter 2021-03-20 00:48:41 +01:00
David
7685569480 Rollback char.IsDigit 2021-03-19 12:34:21 +01:00
Claus Vium
9360fecb31
Merge pull request #5559 from cvium/fix-tmdb-search-clean
Clean the entity name for non-words before searching
2021-03-19 09:24:20 +01:00
Claus Vium
e1c6bb0482
Merge pull request #5561 from barronpm/permissions-fix 2021-03-19 09:23:32 +01:00
andrewthemeow
9857c21717 Translated using Weblate (Lithuanian)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/lt/
2021-03-19 02:50:08 -04:00
David
59641e5c76 Use ReadOnlySpan<char> and char.IsDigit 2021-03-18 20:52:56 +01:00
David
840eeff2af Apply suggestions from code review 2021-03-18 11:25:58 +01:00
Patrick Barron
85da0b50e2 Fix user mocking 2021-03-17 21:24:14 -04:00
Patrick Barron
12b8e29aef Fix duplicate permissions 2021-03-17 17:42:45 -04:00
cvium
151156f227 Clean the entity name for non-words before searching 2021-03-17 10:29:45 +01:00
Vitorvlv
37aa3e8735 Translated using Weblate (Portuguese (Brazil))
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/pt_BR/
2021-03-16 23:19:43 -04:00
David
14cbd22fbe Use Helper Methods for provider url parsing 2021-03-16 21:45:12 +01:00
Alyssa Ross
e14311ca8b Translated using Weblate (Esperanto)
Translation: Jellyfin/Jellyfin
Translate-URL: https://translate.jellyfin.org/projects/jellyfin/jellyfin-core/eo/
2021-03-16 15:19:34 -04:00
Bond-009
f42cee4790
Merge pull request #5550 from cvium/revert_underscore_multiversion 2021-03-16 14:38:29 +01:00