Bond_009
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Cody Robibero
38102499cb
Merge pull request #7947 from nyanmisaka/video-range-condition
...
(cherry picked from commit f1d56aa5ce
)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-06-29 01:26:14 -04:00
Joshua M. Boniface
47d150565d
Merge pull request #7712 from jellyfin/fix-hevc-disable-option
...
(cherry picked from commit 5a9e5e0d5d
)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:57 -04:00
Joshua M. Boniface
2d8f7b46f1
Merge pull request #7699 from Shadowghost/streambuilder-fix
...
(cherry picked from commit b46d61dfdf
)
Signed-off-by: crobibero <cody@robibe.ro>
2022-05-20 18:30:57 -04:00
Cody Robibero
688553b9a8
Merge pull request #7537 from dmitrylyzo/fix-streambuilder
...
(cherry picked from commit 5833c70725
)
Signed-off-by: Joshua Boniface <joshua@boniface.me>
2022-04-17 15:45:10 -04:00
Cody Robibero
1960b5bdce
Merge pull request #7523 from crobibero/null-stream
...
Allow media without streams to playback
(cherry picked from commit 577325b788
)
Signed-off-by: crobibero <cody@robibe.ro>
2022-04-07 12:54:58 -04:00
Shadowghost
4e91c3ebdc
Fix DLNA DirectPlay
2022-03-25 18:02:31 +01:00
Dmitry Lyzo
e4137a6279
Fix remuxing
2022-03-20 09:11:46 +03:00
Dmitry Lyzo
1fe82d0deb
Add TranscodingProfile conditions
2022-03-20 09:11:46 +03:00
Cody Robibero
b9c3a497d5
Use requested bitrate for calculations
2022-03-19 12:08:42 -06:00
Cody Robibero
d29c7c1d9e
Revert using Math.Clamp
2022-03-13 12:46:13 -06:00
Cody Robibero
e6df698df1
Merge pull request #7325 from eyezak/issue/6450
2022-03-12 09:08:25 -07:00
Cody Robibero
3ea4174d12
Fix flipped Clamp args
2022-03-12 07:17:59 -07:00
Cody Robibero
da41cd365c
Suggestions from review
2022-03-06 18:17:49 -07:00
Cody Robibero
bbd5d11d3b
Remove TranscodeReason.None, Add JsonFlagEnum tests
2022-03-06 18:13:54 -07:00
Cody Robibero
c331e11c24
Clean up EnumFlags serialization
2022-03-06 18:13:54 -07:00
Isaac Gordezky
9ebd521754
Update MediaBrowser.Model/Dlna/StreamBuilder.cs
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-03-06 18:13:54 -07:00
Isaac Gordezky
84a3db6f84
Fix transcode video matching and add tests for Transcode and Safari
2022-03-06 18:13:54 -07:00
Isaac Gordezky
5e779f20ee
Series: issue-6450
...
Issue: https://github.com/jellyfin/jellyfin/issues/6450
Enable DirectPlay responses
Rewrite DirectPlay and DirectStream resolution
Prefer copy transcode video codec options
Enhance condition processor
Support DirectStream and Transcode with parity
Rework audio stream selection and add tests for ExternalAudio
Update MediaInfoHelper to only call StreamBuilder once
2022-03-06 18:13:54 -07:00
Isaac Gordezky
d871dded9f
Convert TranscodeReason to Flags
2022-03-06 18:13:54 -07:00
Bond_009
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Cody Robibero
904efeaddc
Add null check for audio stream
2022-01-06 08:15:37 -07:00
Cody Robibero
7bfc6b5679
Remove more warnings
2021-12-27 07:38:06 -07:00
Bond_009
cbfa355e31
Update StyleCop
2021-12-24 18:28:27 +01:00
Cody Robibero
55b429edb7
Merge pull request #6920 from marius-luca-87/subtitle_drop
2021-12-24 02:01:44 +00:00
cvium
a7a7173cd5
Force a remux/transcode with external audio files
2021-12-21 14:35:58 +01:00
Marius Luca
7d86ef6f22
- add an option for dropping specific subtitle formats using the DLNA SubtitleProfile
2021-12-09 17:52:51 +02:00
zehner
bbf40d6be2
Update StreamBuilder.cs
...
LogLevel INFO => DEBUG
2021-11-02 09:35:09 +01:00
KonH
6cbfdea4c0
Fix warning: Type cast is redundant ( #2149 )
2021-10-03 11:05:18 +07:00
Cody Robibero
cba07b1ca6
Remove more and more warnings
2021-08-28 16:32:50 -06:00
BaronGreenback
bb6fddde9a
Group Methods
2021-04-17 11:19:09 +01:00
Bond-009
fa64d8e4f2
Merge pull request #5637 from dmitrylyzo/check-media-type
2021-04-04 01:25:09 +02:00
Dmitry Lyzo
36da7a06d7
Less negation
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-04-04 02:09:57 +03:00
Max Rumpf
21e7ceae8e
StreamBuilder tweaks ( #5668 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2021-04-01 19:18:14 +02:00
Dmitry Lyzo
364e8931af
Check appropriate profile type
2021-03-27 11:53:57 +03:00
Bond_009
141efafd3d
Enable TreatWarningsAsErrors for MediaBrowser.Model
2021-02-20 23:29:33 +01:00
Bond_009
65bab55ca0
Minor improvements
2021-02-13 00:39:18 +01:00
crobibero
c8a95e0926
Fix null reference when logging
2020-12-24 10:05:06 -07:00
nyanmisaka
b4598bd71b
Merge remote-tracking branch 'upstream/master' into fmp4-hls
2020-11-20 10:01:17 +08:00
Nyanmisaka
5ff08338d5
Apply suggestions from code review
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2020-11-19 15:02:36 +00:00
Joshua M. Boniface
e0f60847c0
Merge pull request #4361 from ssenart/feature/4360-transcoding_flac_downsampling
...
Add FLAC and define the corresponding target sample rate
2020-11-17 10:29:29 -05:00
nyanmisaka
488dbdb31d
Merge remote-tracking branch 'upstream/master' into fmp4-hls
2020-11-16 12:36:55 +08:00
Bond_009
ff49a3bb61
Missed some stuff
2020-11-14 20:28:15 +01:00
nyanmisaka
57e5b59b93
adjust bitrate limit for HLS audio codecs
2020-11-11 17:10:08 +08:00
Stéphane Senart
28ee4f0a7f
[AudioTranscoding] Add FLAC as supported target audio format and be able to define the corresponding target sample rate
2020-10-22 11:09:59 +02:00
Jan-Pieter Baert
ec91d3893d
Fix SA 1116 warnings
2020-10-12 20:05:11 +02:00
Maxr1998
e01209a6f5
Log stream type and codec for missing direct play profile
2020-10-03 17:14:09 +02:00
Matt Montgomery
53d5f64e03
Fix SA1513, SA1514, SA1507, and SA1508
2020-09-28 15:04:31 -05:00
telans
98db8f72e0
fix SA1503 for one line if statements
2020-06-20 20:35:29 +12:00
telans
247f9c61e6
fix SA1513/SA1516
2020-06-16 16:11:30 +12:00