Patrick Barron
62420a6eb1
Remove support for injecting ILogger directly
2020-05-12 16:03:15 -04:00
Bond_009
a73e1f18b6
Minor improvements
2020-04-19 11:16:09 +02:00
Bond-009
14674d4469
Merge pull request #2772 from barronpm/codecleanup
...
MediaBrowser.Api code cleanup
2020-04-11 19:30:23 +02:00
Vasily
5b59cd2eb2
Merge pull request #2696 from mark-monteiro/fix-extras
...
Display Extras With Unknown Types
2020-04-07 23:39:31 +03:00
Patrick Barron
555651aae2
Fixed indentation and corrected typo
2020-04-06 23:17:49 -04:00
Patrick Barron
c9da49ebaa
Implemented more suggestions
2020-04-05 23:12:25 -04:00
Patrick Barron
81b4a4c54c
Implement various suggestions
2020-04-05 17:58:39 -04:00
Patrick Barron
e1958e3902
Miscellaneous code cleanup
2020-04-05 15:56:08 -04:00
Patrick Barron
add0a2088d
Simplified Conditionals and returns
2020-04-05 14:44:14 -04:00
Patrick Barron
5966ee6d87
Convert type checks and null checks into pattern matching
2020-04-05 12:07:43 -04:00
PrplHaz4
46453549b5
Start line with Boolean
2020-04-05 07:26:21 -04:00
PrplHaz4
b05e04c0cb
Collapse IsInEnabledFolder to single expression
...
Co-Authored-By: Vasily <JustAMan@users.noreply.github.com>
2020-04-05 06:42:15 -04:00
Mark Monteiro
377f9896ce
Small fixes
2020-04-01 19:04:00 +02:00
Mark Monteiro
cc8294842a
Add ExtraType.Unknown enum value and use it instead of null
2020-04-01 18:10:29 +02:00
PrplHaz4
025888204d
Fix permission setting on Channels
...
Currently, permission settings on Channels are not taken into account prior to returning `{UserName} is not permitted to access Library {ItemName}.`. Whether or not a user can see items within the Channel is solely dependent on `EnableAllFolders`, so you cannot view a plugin's Channels unless you can also see ALL libraries.
This PR enables does two things for Channel-providing Plugins:
1. Fixes functionality of "EnableAllChannels"
2. Allows users with Channel permissions to access all folders within that Channel
I'm not 100% sure on 2 but I wasn't able to see an obvious way to propagate permissions downward into specific Folders inside a Channel.
I tested on a fairly simple library with two channel-providing plugins (ServerWMC, LazyMan) and it seems to work, but this behavior should also be tested by someone with more content/collections.
2020-03-30 17:14:59 -04:00
Mark Monteiro
e266ad51c5
Simplify logic; remove unnecessary methods
2020-03-28 14:17:33 +01:00
Mark Monteiro
5fcbedc194
Display extras with an unknown type
2020-03-28 13:40:56 +01:00
Anthony Lavado
00073c162a
Merge pull request #2363 from dkanada/view
...
Add session view endpoint
2020-02-11 23:56:47 -05:00
dkanada
6341d986a9
fix a few warnings
2020-02-02 00:07:46 +09:00
Bond_009
87d2479b78
Fix warnings
2020-01-31 22:26:53 +01:00
Joshua M. Boniface
9744f5aee3
Merge pull request #2118 from chaosinnovator/master
...
Add StartIndex result to /Items API query
2019-12-11 23:42:02 -05:00
chaosinnovator
b98e25a07e
Add StartIndex result to /Items API query
2019-12-10 09:30:44 -08:00
dkanada
dee3076eaf
Merge pull request #1923 from Bond-009/random
...
Don't shuffle some types by default
2019-12-10 22:28:44 +09:00
Bond-009
a2c35e6dba
Merge remote-tracking branch 'upstream/master' into random
2019-12-06 12:06:13 +01:00
Bond_009
3221e837f9
* Add support for multi segment base urls
...
* Make baseurl case-insensitive
2019-11-25 11:55:24 +01:00
dkanada
47ad21b6e3
Merge pull request #2039 from Bond-009/fixcondition
...
Fix always false condition
2019-11-24 21:41:19 +09:00
dkanada
51cdc6ea16
Merge pull request #1926 from Bond-009/auth
...
Add clearer exceptions, warnings and docs
2019-11-23 01:14:32 +09:00
Bond_009
d884ed353f
Fix always false condition
2019-11-22 16:19:19 +01:00
dkanada
89a21c96c0
Merge pull request #1852 from Bond-009/warn9
...
Fix some more warnings
2019-11-02 01:24:44 +09:00
Bond_009
d9a03c9bb1
Fix more warnings
2019-10-29 17:55:16 +01:00
grafixeyehero
752cf08e5c
update persons service
2019-10-23 01:54:32 +03:00
Bond_009
fef35d0505
Add clearer exceptions, warnings and docs
2019-10-20 21:12:03 +02:00
Bond_009
bbc0875387
Don't shuffle some types by default
2019-10-20 16:08:40 +02:00
Bond_009
c9820d30ed
Fix multiple mistakes and warnings
2019-09-23 20:32:44 +02:00
Bond-009
ee637e8fec
Fix warnings, improve performance ( #1665 )
...
* Fix warnings, improve performance
`QueryResult.Items` is now a `IReadOnlyList` so we don't need to
allocate a new `Array` when we have a `List` (and `Items` shouldn't need to
be mutable anyway)
* Update Providers .csproj to latest C#
* Remove extra newline from DtoService.cs
* Remove extra newline from UserLibraryService.cs
2019-09-02 02:19:29 -04:00
SL1288
fdc24ec2ee
Fix LocalTrailers playback.
2019-08-19 18:56:41 +02:00
Bond_009
9b2cf8501f
Add last one
2019-08-09 23:24:04 +02:00
Bond-009
6032f31aa6
Use CultureInvariant string conversion for Guids
2019-08-09 23:17:54 +02:00
Jörn
1fd8164756
fix issue #1347 introduced in pr #930
2019-06-26 01:13:54 -07:00
pjeanjean
7919dd81da
Skip user permission checking for UserRootFolder
...
Fix #1436
UserRootFolders are used to represent virtual folders that exist outside
of libraries. As such, it doesn't make sense to check if a user has the
right to access their library (named `Media Folders`).
2019-06-06 08:30:56 +02:00
Bond-009
bf43dc00bb
More warning fixes
2019-03-13 22:32:52 +01:00
Bond-009
1731bf7372
Remove ordering items
2019-02-26 20:47:23 +01:00
Vasily
60df855b26
Merge pull request #930 from fruhnow/AuthorizationCheck
...
checking user-permission in GetQueryResult
2019-02-20 14:42:35 +03:00
Felix Ruhnow
53beebc774
switching logging to serilog convention according to pr comments
2019-02-19 12:17:28 +01:00
Felix Ruhnow
ba003e06ef
adressing pr comments
2019-02-19 12:09:39 +01:00
Felix Ruhnow
1d631540ac
adressing pr comments
2019-02-19 12:06:50 +01:00
Felix Ruhnow
967d5deeb7
checking user-permission in GetQueryResult to prevent accessing the library without permission but having a link. (+added myself as contributor. forgot last time bout that)
2019-02-18 18:29:58 +01:00
Bond_009
8d98885cda
Less string allocations
2019-02-12 21:06:47 +01:00
Bond_009
7722cb3ffa
Some Lists -> IEnumerable
2019-02-12 21:06:47 +01:00
Bond_009
41fb1e5106
Tuple -> ValueTuple
2019-02-12 21:06:47 +01:00
