Commit Graph

22 Commits

Author SHA1 Message Date
LogicalPhallacy
9f3aa2cead
Apply suggestions from code review
Adding minor stylistic suggestions from Bond-009

Co-Authored-By: LogicalPhallacy <44458166+LogicalPhallacy@users.noreply.github.com>
2019-02-18 00:31:03 -08:00
Phallacy
77602aff88 Minor fixes re:PR870, added null checks from PR876 2019-02-13 00:33:00 -08:00
William Taylor
65cd3ed597 Replaced injections of ILogger with ILoggerFactory
This makes resolving dependencies from the container much easier as
you cannot resolve with primitives parameters in a way that is any
more readable.

The aim of this commit is to change as little as possible with the end
result, loggers that were newed up for the parent object were given the same
name. Objects that used the base or app loggers, were given a new logger with
an appropriate name.

Also removed some unused dependencies.
2019-01-20 21:05:12 +00:00
Erwin de Haan
65bd052f3e ReSharper conform to 'var' settings 2019-01-13 21:37:13 +01:00
Erwin de Haan
e566d9a231 Find+Sed BOM removal *.cs: BDInfo-Emby.XmlTv 2019-01-13 20:54:44 +01:00
Erwin de Haan
a5288115a8 Visual Studio Reformat: Emby.Server.Implementations Part A-Da 2019-01-13 20:20:16 +01:00
Erwin de Haan
ec1f5dc317 Mayor code cleanup
Add Argument*Exceptions now use proper nameof operators.

Added exception messages to quite a few Argument*Exceptions.

Fixed rethorwing to be proper syntax.

Added a ton of null checkes. (This is only a start, there are about 500 places that need proper null handling)

Added some TODOs to log certain exceptions.

Fix sln again.

Fixed all AssemblyInfo's and added proper copyright (where I could find them)

We live in *current year*.

Fixed the use of braces.

Fixed a ton of properties, and made a fair amount of functions static that should be and can be static.

Made more Methods that should be static static.

You can now use static to find bad functions!

Removed unused variable. And added one more proper XML comment.
2019-01-10 20:38:53 +01:00
Bond_009
ea4c914123 Fix exception logging 2018-12-30 22:44:39 +01:00
Bond_009
0f8b3c6347 Use Microsoft.Extensions.Logging abstraction 2018-12-30 22:44:38 +01:00
stefan
48facb797e Update to 3.5.2 and .net core 2.1 2018-09-12 19:26:21 +02:00
Luke Pulverenti
7e5036a587 update image aspect ratio detection 2017-10-22 02:22:43 -04:00
Luke Pulverenti
e287e3a50d remove async when there's nothing to await 2017-08-26 20:32:33 -04:00
Luke Pulverenti
1dab9a60f4 rename methods 2017-05-07 16:02:32 -04:00
Luke Pulverenti
a9a808a9c4 fix db locking errors 2016-12-11 00:12:00 -05:00
Luke Pulverenti
61e195c096 update repositories 2016-11-29 14:12:37 -05:00
Luke Pulverenti
1c52e4f51b update transaction modes 2016-11-28 14:26:48 -05:00
Luke Pulverenti
f275d7f3d2 reduce library queries 2016-11-21 03:54:53 -05:00
Luke Pulverenti
1dc080df8b update connections 2016-11-20 22:52:58 -05:00
Luke Pulverenti
7f62a99ab5 update extensions 2016-11-20 02:10:07 -05:00
Luke Pulverenti
64d15be839 update queries 2016-11-20 00:59:36 -05:00
Luke Pulverenti
52227ce00d update save methods 2016-11-19 03:40:13 -05:00
Luke Pulverenti
13abfbc3b8 rework users repository 2016-11-18 13:28:45 -05:00