gnattu
56a98a3bb0
Make internal value separator a constant
...
Signed-off-by: gnattu <gnattuoc@me.com>
2024-07-29 06:23:16 +08:00
gnattu
1d658a5a4d
Remove redundant check
...
Signed-off-by: gnattu <gnattuoc@me.com>
2024-07-29 06:23:13 +08:00
gnattu
939e02ccee
Apply suggestions from code review
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
2024-07-29 06:21:51 +08:00
gnattu
ac9322370b
Check if the metadata is supported for title fallback
...
Signed-off-by: gnattu <gnattuoc@me.com>
2024-07-29 06:21:51 +08:00
gnattu
172feab084
Migrate to z440.atl instead of TagLib-Sharp
...
The ATL lib provides a lot of advantages to the TagLib we are currently using.
Notably:
- auto-detect the format of the audio data, even if the file extension has the wrong label, and provides unified API for different file types.
- supports more audio formats than TagLib
- supports lyrics natively
- supports playlists and cuesheets
- srovides relatively simple and controllable way for non-standard fields, enable us to implement compatibility features instead of waiting for lib updates
- is actually maintained
Signed-off-by: gnattu <gnattuoc@me.com>
2024-07-29 06:21:47 +08:00
Bond-009
095d4d4d15
Merge pull request #12295 from Bond-009/trysetproviderid
...
Add TrySetProviderId extension
2024-07-29 00:13:40 +02:00
Cody Robibero
b026772764
Move external url listing to provider for plugin use ( #12279 )
2024-07-17 09:48:31 -04:00
Bond_009
ecd2dab0a2
Add TrySetProviderId extension
2024-07-17 15:48:21 +02:00
Bond_009
2e338f74ec
Fix (another) ArgumentNullException while scanning music
...
```
[2024-07-17 14:31:18.202 +02:00] [ERR] [19] MediaBrowser.Providers.Music.AudioMetadataService: Error in "Probe Provider"
System.ArgumentNullException: Value cannot be null. (Parameter 'value')
at System.ArgumentNullException.Throw(String paramName)
at System.ArgumentNullException.ThrowIfNull(Object argument, String paramName)
at System.ArgumentException.ThrowNullOrEmptyException(String argument, String paramName)
at MediaBrowser.Model.Entities.ProviderIdsExtensions.SetProviderId(IHasProviderIds instance, String name, String value) in /home/loma/dev/jellyfin/MediaBrowser.Model/Entities/ProviderIdsExtensions.cs:line 121
at MediaBrowser.Model.Entities.ProviderIdsExtensions.SetProviderId(IHasProviderIds instance, MetadataProvider provider, String value) in /home/loma/dev/jellyfin/MediaBrowser.Model/Entities/ProviderIdsExtensions.cs:line 151
at MediaBrowser.Providers.MediaInfo.AudioFileProber.FetchDataFromTags(Audio audio, MediaInfo mediaInfo, MetadataRefreshOptions options, Boolean tryExtractEmbeddedLyrics) in /home/loma/dev/jellyfin/MediaBrowser.Providers/MediaInfo/AudioFileProber.cs:line 330
at MediaBrowser.Providers.MediaInfo.AudioFileProber.FetchAsync(Audio audio, MediaInfo mediaInfo, MetadataRefreshOptions options, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/MediaInfo/AudioFileProber.cs:line 139
at MediaBrowser.Providers.MediaInfo.AudioFileProber.Probe[T](T item, MetadataRefreshOptions options, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/MediaInfo/AudioFileProber.cs:line 105
at MediaBrowser.Providers.Manager.MetadataService`2.RunCustomProvider(ICustomMetadataProvider`1 provider, TItemType item, String logName, MetadataRefreshOptions options, RefreshResult refreshResult, CancellationToken cancellationToken) in /home/loma/dev/jellyfin/MediaBrowser.Providers/Manager/MetadataService.cs:line 800
```
2024-07-17 14:36:47 +02:00
Bond_009
60c45d6273
Use complete paths in BD info
...
This way we don't need to find the complete path later
2024-07-01 00:21:06 +02:00
Bond-009
e063fcb036
Backport pull request #12166 from jellyfin/release-10.9.z
...
Fix HDR detection for 4K Blu-Ray BDMVs
Original-merge: 30fc089dd5
Merged-by: Bond-009 <bond.009@outlook.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-24 20:29:06 -04:00
gnattu
ea7e834ae1
Backport pull request #12126 from jellyfin/release-10.9.z
...
Try to add extracted lyrics during scanning
Original-merge: 25f02658f0
Merged-by: Bond-009 <bond.009@outlook.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-24 20:29:05 -04:00
Shadowghost
bd3645cbb0
Backport pull request #12055 from jellyfin/release-10.9.z
...
Fix season backdrops
Original-merge: 2266a00337
Merged-by: Bond-009 <bond.009@outlook.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-24 20:29:03 -04:00
Shadowghost
e2ca6e92e4
Backport pull request #12053 from jellyfin/release-10.9.z
...
Rewrite PlaylistItemsProvider as ILocalMetadataProvider
Original-merge: cbbe5db813
Merged-by: Bond-009 <bond.009@outlook.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-24 20:29:01 -04:00
Shadowghost
9eab2bfe41
Backport pull request #12050 from jellyfin/release-10.9.z
...
Fix season handling
Original-merge: 4601097d3e
Merged-by: Bond-009 <bond.009@outlook.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-24 20:29:00 -04:00
Shadowghost
6734450d40
Backport pull request #12025 from jellyfin/release-10.9.z
...
Fix empty image folder removal for legacy locations
Original-merge: 476dc01f4d
Merged-by: Bond-009 <bond.009@outlook.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-24 20:28:58 -04:00
Shadowghost
034c13c48f
Backport pull request #12073 from jellyfin/release-10.9.z
...
Fix Music Brainz release group query
Original-merge: 23a660e917
Merged-by: Bond-009 <bond.009@outlook.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-23 11:40:52 -04:00
Shadowghost
1c106e8323
Backport pull request #12028 from jellyfin/release-10.9.z
...
Fix replace all and respect metadata settings
Original-merge: 08b64c5502
Merged-by: Bond-009 <bond.009@outlook.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-23 11:40:42 -04:00
Zero King
8caefc2a55
Improve empty list check
2024-06-08 01:06:47 +08:00
Shadowghost
4015ac78cd
Backport pull request #11984 from jellyfin/release-10.9.z
...
Set ProductionLocations instead of Tags
Original-merge: 279cba008b
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-06 14:30:39 -04:00
Shadowghost
0c1c41aeaf
Backport pull request #11978 from jellyfin/release-10.9.z
...
Fallback to local dir when saving to media dir fails
Original-merge: f41efb3b2c
Merged-by: joshuaboniface <joshua@boniface.me>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-06 14:30:37 -04:00
Shadowghost
18dd6b2875
Backport pull request #11934 from jellyfin/release-10.9.z
...
Fix local image saving
Original-merge: b0bb22b650
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-06 14:30:30 -04:00
Shadowghost
f67e327b29
Backport pull request #11921 from jellyfin/release-10.9.z
...
Fix identify over NFO and replace all when NFO saving enabled
Original-merge: bfcc09db8a
Merged-by: joshuaboniface <joshua@boniface.me>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-06 14:30:29 -04:00
Shadowghost
02678253b9
Backport pull request #11954 from jellyfin/release-10.9.z
...
Do not delete file locations for virtual episodes and seasons
Original-merge: 23b1251393
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-05 17:02:59 -04:00
Shadowghost
c554321495
Backport pull request #11935 from jellyfin/release-10.9.z
...
Fix dateadded and movie NFO recognition
Original-merge: 0c039145e5
Merged-by: joshuaboniface <joshua@boniface.me>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-05 17:02:56 -04:00
Shadowghost
a705e56acc
Backport pull request #11933 from jellyfin/release-10.9.z
...
Check trailer distinction by URL
Original-merge: b1a5fe2f55
Merged-by: nielsvanvelzen <nielsvanvelzen@users.noreply.github.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-05 17:02:55 -04:00
gnattu
2599babe31
Backport pull request #11859 from jellyfin/release-10.9.z
...
Use music metadata from ffprobe when TagLib fails
Original-merge: b8a0cf6a9e
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-01 18:41:07 -04:00
Shadowghost
1a94976752
Backport pull request #11806 from jellyfin/release-10.9.z
...
Return missing episodes for series when no user defined
Original-merge: ae584beaac
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-01 18:40:59 -04:00
Shadowghost
5d4880c497
Backport pull request #11743 from jellyfin/release-10.9.z
...
Fix replace logic
Original-merge: 2ddb15c784
Merged-by: joshuaboniface <joshua@boniface.me>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-01 18:40:56 -04:00
Shadowghost
c0364fc766
Backport pull request #11719 from jellyfin/release-10.9.z
...
Move NFO series season name parsing to own local provider
Original-merge: a53ea029fa
Merged-by: joshuaboniface <joshua@boniface.me>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-06-01 18:40:55 -04:00
Shadowghost
39ae56db0a
Backport pull request #11804 from jellyfin/release-10.9.z
...
Exclude virtual items from DateLastMediaAdded calculation
Original-merge: d89e5a0074
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-25 11:46:27 -04:00
Shadowghost
2af1ae5d8a
Backport pull request #11792 from jellyfin/release-10.9.z
...
Improve reliability of HasChanged check
Original-merge: b2d54b82fa
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-25 11:46:21 -04:00
Shadowghost
c3091b75a3
Backport pull request #11739 from jellyfin/release-10.9.z
...
Do not run trickplay on scan if disabled
Original-merge: 86f5c93434
Merged-by: Bond-009 <bond.009@outlook.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-25 11:46:11 -04:00
Shadowghost
45400ac301
Backport pull request #11700 from jellyfin/release-10.9.z
...
Prevent double iterating over all seasons
Original-merge: 5200633574
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-25 11:46:07 -04:00
Shadowghost
a2eb4c5e60
Backport pull request #11680 from jellyfin/release-10.9.z
...
Secure local playlist path handling
Original-merge: 832e27a8fb
Merged-by: joshuaboniface <joshua@boniface.me>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-17 13:51:53 -04:00
Shadowghost
8b938e2696
Backport pull request #11673 from jellyfin/release-10.9.z
...
Fix local playlist scanning
Original-merge: 26714e2c62
Merged-by: nielsvanvelzen <nielsvanvelzen@users.noreply.github.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-17 13:51:50 -04:00
Shadowghost
b063dfd2e3
Backport pull request #11648 from jellyfin/release-10.9.z
...
Fix series status parsing
Original-merge: c6c48a2b47
Merged-by: nielsvanvelzen <nielsvanvelzen@users.noreply.github.com>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-17 13:51:42 -04:00
Shadowghost
29a293f9e7
Backport pull request #11647 from jellyfin/release-10.9.z
...
Fix season names
Original-merge: 2da06bc0b1
Merged-by: joshuaboniface <joshua@boniface.me>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-17 13:51:40 -04:00
nfmccrina
4385430f05
Backport pull request #11621 from jellyfin/release-10.9.z
...
Handle exception for unexpected audio file YEAR tag values
Original-merge: d5dc4435d9
Merged-by: crobibero <cody@robibe.ro>
Backported-by: Joshua M. Boniface <joshua@boniface.me>
2024-05-17 13:51:37 -04:00
Tim Eisele
c9cd17220a
Playlist fixes ( #11487 )
2024-05-05 19:22:21 -06:00
gnattu
cf483203f5
Fix external LRC files being incorrectly overwritten during the initial scan ( #11480 )
2024-05-05 08:22:48 -06:00
Tim Eisele
4aad655fa8
Fix subtitle saving if file already exists ( #11310 )
2024-05-05 08:22:34 -06:00
gnattu
77a101cc98
Fix missing season Index ( #11472 )
2024-05-05 08:21:00 -06:00
Bond_009
88a38a61b5
Improve audio normalization
...
* Move calculation of LUFS to a scheduled task as it's pretty slow
* Correctly calculate album LUFS
* Don't try to convert replaygain tags to LUFS values
2024-04-28 15:18:53 +02:00
Bond-009
d29b85a134
Fix multiple intro providers and remove unneeded ToLists ( #11431 )
2024-04-25 07:02:01 -06:00
Bond-009
ac108690a8
Use StringSplitOptions.TrimEntries where possible ( #11421 )
2024-04-24 08:35:15 -06:00
Bond-009
428283f787
Always scan ReplayGain tag ( #11418 )
2024-04-24 08:09:01 -06:00
Bond-009
3936fc9f25
Don't run ffprobe a second time for music file ( #11419 )
2024-04-23 07:08:49 -06:00
Bond-009
37d301ebd4
Merge pull request #11352 from jellyfin/fix-library-removal
...
fix: explicitly allow remove root when performing library removal
2024-04-18 12:16:04 +02:00
gnattu
e4d66f35fd
chore: use proper way to override remove root
...
This is an alternate approach which is more proper, but changes all parts that uses/overrides the original ValidateChildren method
Signed-off-by: gnattu <gnattuoc@me.com>
2024-04-17 14:41:19 +08:00