Commit Graph

1733 Commits

Author SHA1 Message Date
Claus Vium
956e3dab43
fix: accessing Standard* of a Process requires manually disposing them afterwards (#10125) 2023-08-20 20:06:57 +02:00
Nick
65b269c151 Minor code formatting (cvium) 2023-08-16 21:31:34 -07:00
Bond-009
07727e1d63
Merge pull request #9875 from Shadowghost/fixes 2023-08-01 20:26:21 +02:00
Jan Müller
79cff704ff Allow flac inside mp4 for all HLS audio streams
The -strict -2 setting was only added if the encoder was set to 'copy'.
If 'flac' is explicitly requested, we also need to set it, so that
ffmpeg doesn't abort the conversion.

Fixes: #10066
2023-08-01 19:12:52 +02:00
Jan Müller
19fb061381 Correct the HLS Opus codec string
Apple doesn't support Opus via HLS yet, but if they ever do, they will
definitely expect "Opus" instead of "opus".

See https://mp4ra.org/#/codecs

Fixes: #10066
2023-08-01 19:06:30 +02:00
Jan Müller
e9f23c61c9 Fix the fLaC/flac HLS issue also for audio-only
I moved the first application of the workaround out of the if block
so that it also applies to audio-only streams. The workaround was
extended likewise.

We should first and foremost adhere to the specifications and apply
workarounds afterwards for software that doesn't follow them. So I
turned around the workaround to first output the fLaC variant and then
the alternative flac variant.

Fixes: #10066
2023-08-01 17:11:32 +02:00
Jan Müller
dd75f35a1a Fix the is-local check when resetting the password
This fixes the check whether a warning should be logged when resetting
the password from outside the local network.

Fixes: #10059
2023-07-31 21:49:51 +02:00
MBR-0001
9564248b10
Add ability to upload (and save) SDH subtitles (#10036) 2023-07-29 06:52:35 -06:00
Shadowghost
368f9202ce Apply review suggestions 2023-07-15 20:15:11 +02:00
Shadowghost
05d98fe24c Enforce permissions on websocket connections 2023-07-07 08:50:37 +02:00
Joshua M. Boniface
93b400343e
Merge pull request #8147 from Shadowghost/network-rewrite 2023-07-03 13:16:21 -04:00
Nick
6d9e43cfe0 Merge branch 'master' into trickplay 2023-06-28 21:43:23 -07:00
Bond-009
e53e53eb29
Merge pull request #9907 from nyanmisaka/av1e 2023-06-28 17:34:20 +02:00
Bond-009
4ac07f6c76
Merge pull request #9890 from Shadowghost/videorange-rework 2023-06-28 17:30:26 +02:00
Shadowghost
20a4509991 Migrate VideoRange and VideoRangeType to Enum 2023-06-28 12:02:20 +02:00
Bond-009
1e38bc80de
Merge pull request #9909 from Bond-009/playlist 2023-06-27 16:22:08 +02:00
Shadowghost
a6e9824e8a Merge branch 'master' into network-rewrite 2023-06-27 16:15:57 +02:00
Nick
ab20ceaad6 Migrate to trickplay table to EF. Rename vars/methods/members to have consistent use of tile and thumbnail 2023-06-26 17:40:10 -07:00
nyanmisaka
df880ff785 Apply suggestions from code review
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-06-25 21:39:25 +08:00
Nick
619d1d47f2 Move GetHlsPlaylist to ITrickplayManager 2023-06-23 14:22:00 -07:00
Nick
049361b66c TrickplayController return 404 if playlist doesn't exist. Minor code style/format changes (crobibero) 2023-06-22 16:23:52 -07:00
Nick
d338253242 Fix styling for string builder 2023-06-22 16:23:52 -07:00
Nick
98e41d5a14 Styling, format, minor code changes (crobibero) 2023-06-22 16:23:52 -07:00
Nick
fe1c9d43ce Fix using order 2023-06-22 16:23:52 -07:00
nicknsy
d448cc18ea update 2023-06-22 16:19:59 -07:00
nicknsy
b18d6bd356 Trickplay playlist and image controller 2023-06-22 16:19:59 -07:00
nicknsy
515ee90fb9 Hls playlist 2023-06-22 16:19:59 -07:00
Bond-009
a1eb2f6ea8
Merge pull request #9915 from Bond-009/stylecop 2023-06-22 13:26:18 +02:00
Bond-009
3982b0e057
Reduce bottlenecks scan code (#9863) 2023-06-21 21:01:47 -06:00
Bond_009
b84eedd0b9 Update stylecop.analyzers to v1.2.0-beta.507 2023-06-22 00:39:32 +02:00
Shadowghost
67a58df1a3 Merge branch 'master' into network-rewrite 2023-06-21 07:57:00 +02:00
Bond_009
f04cfd6ef4 Don't ignore parentId for playlists 2023-06-20 18:06:30 +02:00
Nyanmisaka
f8d7f4acdb
Apply suggestions from code review
Co-authored-by: Shadowghost <Shadowghost@users.noreply.github.com>
2023-06-20 05:09:22 +08:00
Nyanmisaka
3b12dc6d7a
Apply suggestions from code review
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-06-20 04:18:55 +08:00
nyanmisaka
0df6fd9cf2 Add AV1 support in HLS streaming
Signed-off-by: nyanmisaka <nst799610810@gmail.com>
2023-06-20 03:50:02 +08:00
Dominik
0dffe64489 Add baseUrlParam back in and fix indentation 2023-06-15 19:55:11 +02:00
Dominik
17f1e8d19b
Merge branch 'master' into segment-deletion 2023-06-15 19:38:42 +02:00
Shadowghost
006b04dc0b Merge branch 'master' into network-rewrite 2023-06-07 08:25:32 +02:00
Bond-009
6dca53047f
Merge pull request #9818 from Shadowghost/fixes 2023-05-30 10:00:53 +02:00
Cody Robibero
d8f0933f33
Merge pull request #9821 from cvium/admin_must_have_pw 2023-05-29 18:38:01 -06:00
cvium
29ef02af9a do not allow empty admin password during wizard 2023-05-26 21:50:51 +02:00
cvium
b33f46560d use 403 instead to avoid compat issues with swagger spec 2023-05-26 19:45:40 +02:00
cvium
716bcc6410 chore: deprecate EasyPassword as it isn't very secure 2023-05-26 19:40:40 +02:00
Shadowghost
81746666de Fix TotalRecordCount calculation 2023-05-26 11:06:04 +02:00
Shadowghost
d8d5c86d49 Merge branch 'master' into network-rewrite 2023-05-25 17:07:43 +02:00
Claus Vium
d1e52b6ee3
Merge pull request #9771 from Shadowghost/recursive-tags 2023-05-18 10:05:50 +02:00
Bill Thornton
155f3856c0 Use default files to remove index.html from url 2023-05-15 15:28:33 -04:00
Shadowghost
eb52af4e6a
Fix playlists library and migration (#9770) 2023-05-15 06:45:33 -06:00
Shadowghost
ec32c56d3f Set removed and added tags recursively 2023-05-14 21:45:46 +02:00
Shadowghost
a8cdf4434b
Fix access to playlists not created by a user (#9746) 2023-05-12 07:11:59 -06:00
Shadowghost
c042f20224 Merge branch 'master' into network-rewrite 2023-05-11 15:41:39 +02:00
Shadowghost
d5fec4963e
Fix FirstTimeSetupHandler not failing on invalid user if not in setup mode (#9747) 2023-05-10 14:05:27 -06:00
Shadowghost
6cc1203c1b Merge branch 'master' into network-rewrite 2023-05-09 15:25:41 +02:00
Stepan Goremykin
910617bbc3 Remove redundant 'else' keywords 2023-04-06 19:38:34 +02:00
Stepan Goremykin
26958162d0 Remove unused using directives 2023-04-06 19:17:28 +02:00
Stepan Goremykin
e74630a613 Use MinBy and MaxBy 2023-04-01 23:00:51 +02:00
Bond-009
a1eddbb330
Merge pull request #9541 from Bond-009/apikeydelete 2023-03-29 12:20:34 +02:00
Bond-009
9c500bdca3
Merge pull request #9466 from Shadowghost/playlist-fix 2023-03-28 10:58:48 +02:00
Bond_009
8316bd590e Fix #7610 2023-03-27 15:22:21 +02:00
knackebrot
e0a7e9baa0 Fix audio VBR calculation
Pass encoder, not codec
2023-03-21 15:01:32 +01:00
Bond-009
2ce08eb184
Merge pull request #9388 from Shadowghost/output-bitrate-channels-master 2023-03-20 17:46:11 +01:00
Shadowghost
82080bd1ef Apply review suggestions 2023-03-17 11:43:53 +01:00
Shadowghost
520c07e8ca Merge branch 'master' into network-rewrite 2023-03-16 11:07:22 +01:00
Bond_009
d8ec3a5470 Reduce usage of GetAwaiter().GetResult() 2023-03-14 12:05:49 +01:00
Shadowghost
76ae599bd3 Fix playlist creation and removal 2023-03-10 19:16:35 +01:00
SenorSmartyPants
369c7f1451
Save TVChannel Height if set (#8777)
Co-authored-by: Cody Robibero <cody@robibe.ro>
2023-03-10 10:03:11 -07:00
Bond-009
6351d1022b
Merge pull request #9254 from Shadowghost/dvdbdfix 2023-03-10 15:48:35 +01:00
Shadowghost
0da5255f12 Apply review suggestions 2023-03-10 15:27:17 +01:00
Shadowghost
47aa07c342 Fix DLNA playback of DVD and BD folders 2023-03-10 15:27:17 +01:00
Shadowghost
2403a0a367 Apply review suggestions 2023-03-10 15:27:05 +01:00
nyanmisaka
f21ab50a81 Backport pull request #9422 from jellyfin/release-10.8.z
Fix stream map when using filter_complex with unlabeled output

Original-merge: 6821a2ab35

Merged-by: Bond-009 <bond.009@outlook.com>

Backported-by: crobibero <cody@robibe.ro>
2023-03-09 19:38:15 -05:00
Róbert Örn Ketilsson
ef3868ff50 Backport pull request #9178 from jellyfin/release-10.8.z
Escape the path to pass as a command line argument

Original-merge: 09f1c7f535

Merged-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>

Backported-by: crobibero <cody@robibe.ro>
2023-03-09 19:29:39 -05:00
Shadowghost
80b8661008 Merge branch 'master' into network-rewrite 2023-03-03 10:42:24 +01:00
Shadowghost
1f15724398 Use source audio bitrate if requested codec is lossless 2023-03-02 20:57:59 +01:00
Shadowghost
16f2cca882 Apply review suggestions 2023-02-28 15:12:43 +01:00
Cody Robibero
4873d2a54d
Fix auth endpoints using api key (#9408) 2023-02-27 05:48:37 -07:00
knackebrot
aa99aaebc4 Add audio vbr calculation 2023-02-26 22:37:01 +01:00
knackebrot
3e74377036 Calculate output bitrate from output channel count 2023-02-26 22:37:01 +01:00
Bond_009
ab24c0e2cf Enable nullable for more files 2023-02-23 19:09:16 +01:00
Shadowghost
c5a363a007 Merge branch 'master' into network-rewrite 2023-02-20 11:58:14 +01:00
Shadowghost
4ed97a4593 Properly check for item visibility in UserLibraryController 2023-02-20 11:53:20 +01:00
Shadowghost
2e315b7f08 Properly build where clause for rating checks 2023-02-20 11:53:20 +01:00
Shadowghost
c8d80450e0 Recursively update rating 2023-02-20 11:53:20 +01:00
Bond_009
24a7e210c3 Optimize tryparse
* Don't check for null before
* Don't try different formats when not needed (NumberFormat.Integer is the fast path)
2023-02-19 16:52:29 +01:00
Cody Robibero
a527034ebe
Validate requested user id (#8812) 2023-02-17 23:16:08 +01:00
Shadowghost
20fd05b050 Consistently write IP in upercase 2023-02-17 19:27:36 +01:00
Bond_009
60f41b80f6 Verify ContentType of uploaded images 2023-02-16 15:08:01 +01:00
Shadowghost
87b2bc5dc4
Fix LocalAccessOrRequiresElevationHandler (#9315) 2023-02-14 12:22:07 -07:00
Shadowghost
b8ed1f81cd Add back LocalAccessOrRequiresElevationPolicy 2023-02-14 19:06:43 +01:00
Shadowghost
eeb0f7af6c Add permissions for LiveTV access and management 2023-02-14 18:48:31 +01:00
Shadowghost
b7418d6e9e Add permission for collection management 2023-02-13 15:42:04 +01:00
cvium
a5e2ae4979 fix merge conflict 2023-02-12 23:01:30 +01:00
cvium
52e2776d8e Merge branch 'master' into simplify_authz
# Conflicts:
#	Jellyfin.Api/Auth/SyncPlayAccessPolicy/SyncPlayAccessHandler.cs
2023-02-12 22:59:48 +01:00
cvium
ac118e10f0 remove unnecessary init 2023-02-09 15:01:04 +01:00
cvium
f4a7583c46 fix empty user id check for api keys 2023-02-09 13:51:37 +01:00
cvium
f984f31896 admins shouldn't be able to circumvent remote access policies 2023-02-09 13:51:37 +01:00
cvium
209edd38a4 refactor: simplify authz 2023-02-09 13:51:37 +01:00
Bond_009
eb7fee9590 Add more tests 2023-02-04 21:08:30 +01:00
Shadowghost
f2b7f664aa Apply review suggestions 2023-02-04 20:16:45 +01:00
Bond_009
52230d1c30 Return NotFound when itemId isn't found 2023-02-04 20:11:08 +01:00
Shadowghost
edf3909157 Use FFmpeg concat for DVD and BD folder playback 2023-02-04 18:39:45 +01:00
Shadowghost
ddfdec7f46 Fix BD and DVD folder probing and playback 2023-02-04 18:37:57 +01:00
Cody Robibero
d1af317d98
Merge pull request #9215 from Shadowghost/api-scoped-namespace 2023-02-04 10:21:49 -07:00
Zoltan Csizmadia
e0519189b2
Use Directory.Packages.props (#9135)
Co-authored-by: Zoltan Csizmadia <CsizmadiaZ@valassis.com>
2023-02-04 10:15:08 -07:00
Shadowghost
dfea1229e1 Cleanup imports 2023-02-02 18:50:35 +01:00
Shadowghost
f5f890e685 Migrate to file-scoped namespaces 2023-02-02 18:50:33 +01:00
Claus Vium
e79f5d8226
fix: require current password when admin changes their own password (#9238)
Fixes https://github.com/jellyfin/jellyfin/issues/9208
2023-02-02 07:25:48 -07:00
Chris Blake
ad5b83781a
Add 404 response to MarkPlayedItem/MarkUnplayedItem (#9211)
Fixes https://github.com/jellyfin/jellyfin/issues/9120
2023-02-01 11:17:18 -07:00
Patrick Barron
fec23de427
Remove Emby.Notifications (#9147) 2023-01-28 07:43:55 -07:00
Cody Robibero
abffd160c3
Remove ability to add a played indicator to images (#9186) 2023-01-28 07:43:13 -07:00
Bond-009
232453014f
Minor improvements (#9156) 2023-01-23 19:39:10 +01:00
Bond_009
4261f15d41 Fix debug builds 2023-01-22 21:38:53 +01:00
Dmitry Lyzo
71a708cdb8 Backport pull request #9092 from jellyfin/release-10.8.z
Don't add additional entries if HEVC encoding is disabled

Original-merge: 2a5efeb3bb

Merged-by: Dmitry Lyzo <56478732+dmitrylyzo@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2023-01-22 14:06:19 -05:00
Shadowghost
ab96d1b7ad Backport pull request #9049 from jellyfin/release-10.8.z
Add more codecs requiring ffmpeg strict -2

Original-merge: 2a6e292153

Merged-by: Cody Robibero <cody@robibe.ro>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
2023-01-22 14:03:54 -05:00
renovate[bot]
e408da4651
chore(deps): update dependency microsoft.codeanalysis.bannedapianalyzers to v3.3.4 (#9117)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-18 04:16:59 -07:00
Patrick Barron
7186b343bd Move Formatters to Jellyfin.Api 2023-01-15 15:46:50 -05:00
Patrick Barron
74a07f6d1c Move Middleware to Jellyfin.Api 2023-01-15 15:46:50 -05:00
Teo Baranga
56ef45ebf0
Fix client supported image formats (#9071) 2023-01-14 13:15:50 -07:00
Cody Robibero
0f17e72efd
Revert "chore(deps): update swashbuckle-aspnetcore monorepo to v6.5.0 (#8591)" (#9088)
This reverts commit 3d51d79715.
2023-01-13 16:31:36 -07:00
renovate[bot]
3d51d79715
chore(deps): update swashbuckle-aspnetcore monorepo to v6.5.0 (#8591)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2023-01-13 08:09:21 -07:00
Bond-009
3a7a781ed9
Merge pull request #9001 from Shadowghost/stereo-downmix
Fixes https://github.com/jellyfin/jellyfin/issues/1986
2023-01-12 09:49:29 +01:00
renovate[bot]
7516e61c5b
chore(deps): update dotnet monorepo to v7.0.2 2023-01-10 14:50:35 +00:00
Shadowghost
407c716f82 Add stereo downmix algorithm selection. 2023-01-10 15:29:39 +01:00
David Fairbrother
4eeb522144 Add dts to list of audio codecs which require strict -2
Adds dts to the list of audio codecs where ffmpeg will throw asking us
to opt into experimental support. This is seen when the original content
is based on dts and we don't acopy using ffmpeg.
2023-01-07 19:37:32 +00:00
Bond-009
69a51c425a
Fix all warnings in Jellyfin.Api (#9003) 2023-01-04 08:01:31 -07:00
Bond-009
817996da4b
Merge pull request #7494 from Shadowghost/streambuilder-cleanup 2022-12-29 15:21:28 +01:00
Niels van Velzen
f2200c97cb
Remove unused notification endpoints (#8952) 2022-12-27 14:24:34 +01:00
Claus Vium
b015679267
Merge pull request #8927 from nielsvanvelzen/auth-depr 2022-12-20 07:47:50 +01:00
Niels van Velzen
180d17c991
Remove unused ImageByName API (#8928) 2022-12-19 18:44:13 -07:00
Niels van Velzen
479d477e01 Deprecate user id based authentication endpoint 2022-12-19 21:46:12 +01:00
Niels van Velzen
7a3a9fb7e4 Remove deprecated Password field from AuthenticateUserByName 2022-12-19 21:44:54 +01:00
Claus Vium
760b7f8fca
Merge pull request #8922 from Bond-009/distinctby
Use DistinctBy introduced in .NET 6
2022-12-19 20:13:48 +01:00
Bond-009
497d8c4957
Use Order() introduced in .NET 7 (#8923) 2022-12-19 09:30:00 -07:00
Bond_009
6481376b81 Use DistinctBy introduced in .NET 6 2022-12-19 15:21:42 +01:00
renovate[bot]
02f9e60e7c
chore(deps): update dotnet monorepo to v7.0.1 (#8900)
* chore(deps): update dotnet monorepo to v7.0.1

* Update docker sdk

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Cody Robibero <cody@robibe.ro>
2022-12-15 20:13:11 -07:00
Bond-009
8258d884f3
Merge pull request #8734 from nielsvanvelzen/qc-revoke 2022-12-07 18:14:16 +01:00
Shadowghost
697efec86e Cleanup and refactor streambuilder 2022-12-07 18:00:01 +01:00
Bond_009
fd9dc1e308 Update deps 2022-12-07 16:56:32 +01:00
Bond_009
e21f4adc16 Fix wrong usage of ArgumentNullException.ThrowIfNull 2022-12-07 16:44:00 +01:00
Bond_009
cf67381e31 Fix release build 2022-12-07 16:44:00 +01:00
Bond_009
b366dc2e6e Use ArgumentException.ThrowIfNullOrEmpty 2022-12-07 16:43:59 +01:00
Bond_009
71982c7297 Fix build errors 2022-12-07 16:42:28 +01:00
Bond_009
236dd650d0 Update projects to .net7 2022-12-07 16:42:05 +01:00
Bond_009
52194f56b5 Replace != null with is not null 2022-12-05 15:01:13 +01:00
Bond_009
c7d50d640e Replace == null with is null 2022-12-05 15:00:20 +01:00
Bond-009
210a4921f2
Fix some warnings and only disable TreatWarningsAsErrors for CodeAnalysis (#8709) 2022-12-05 13:54:28 +01:00
Cody Robibero
bf3ff15843
Merge pull request #8546 from nyanmisaka/fix-fmp4-flac-opus 2022-12-03 08:51:04 -07:00
Justin
df66816178
Allow non-ASCII in downloaded filenames (#8825)
Fixes https://github.com/jellyfin/jellyfin/issues/8657
2022-12-03 08:47:59 -07:00
Niels van Velzen
722ad3fe97 Change InitiateQuickConnect to use POST request
Keep the GET request for compatibility
2022-12-03 12:38:06 +01:00
Niels van Velzen
fd73f346dc Add userId parameter to AuthorizeQuickConnect 2022-12-03 12:31:42 +01:00