Bond_009
224bb355dd
Rewrite BaseItem.ModifySortChunks
2022-10-12 17:43:01 +02:00
Bond_009
a9a5fcde81
Use ArgumentNullException.ThrowIfNull helper method
...
Did a simple search/replace on the whole repo (except the RSSDP project)
This reduces LOC and should improve performance (methods containing a throw statement don't get inlined)
```
if \((\w+) == null\)
\s+\{
\s+throw new ArgumentNullException\((.*)\);
\s+\}
```
```
ArgumentNullException.ThrowIfNull($1);
```
2022-10-06 20:21:23 +02:00
Zach Phelan
8857edb66c
Add function back for compatibility, add sorting
2022-09-13 17:13:02 -06:00
Zach Phelan
c71d6f2358
Sort special features same as other spots, removing unnecssary function
...
Added to contributors
2022-09-13 16:56:23 -06:00
Bond-009
2b1a915ead
Merge pull request #7604 from Jellifi007/fixes-diactritics
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
(cherry picked from commit 8d1d973438
2022-05-20 18:30:56 -04:00
Bond_009
7fdc0e3c3d
BaseItem: remove unused function
2022-03-11 16:21:32 +01:00
Claus Vium
53209830e7
Merge pull request #7346 from Bond-009/guid
...
Optimize Guid comparisons
2022-03-11 08:15:12 +01:00
Cody Robibero
fc5c6c0404
Use IFileSystem
2022-02-28 17:14:33 -07:00
Joe Rogers
15053516f8
Rewrite tests for coverage and less duplication
...
Address minor warnings
Revert making GetInternalMetadataPath mockable
2022-02-21 22:25:58 +01:00
Bond_009
f50a250cd9
Optimize Guid comparisons
...
* Use Guid.Equals(Guid) instead of the == override
* Ban the usage of Guid.Equals(Object) to prevent accidental boxing
* Compare to default(Guid) instead of Guid.Empty
2022-02-21 14:15:09 +01:00
Shadowghost
719b707281
feat(external-media): refactor to generic provider, extend tests and file recognition, consolidate and extend NamingOptions
2022-02-18 22:19:33 +01:00
Claus Vium
488ce51032
Remove some allocations ( #7246 )
2022-01-28 12:21:40 +01:00
Cody Robibero
7bfc6b5679
Remove more warnings
2021-12-27 07:38:06 -07:00
Bond_009
cbfa355e31
Update StyleCop
2021-12-24 18:28:27 +01:00
Cody Robibero
a8a8ce4e7b
Fix build from PR merging
2021-12-23 19:27:51 -07:00
Cody Robibero
076a13abeb
Merge pull request #7029 from cvium/allocations_maybe
2021-12-24 01:59:25 +00:00
Cody Robibero
00211ca056
Merge pull request #7028 from cvium/everything_went_wrong
2021-12-22 17:57:00 +00:00
cvium
9158511017
Don't skip extras refresh when replacing metadata or doing a full refresh
2021-12-20 23:58:09 +01:00
cvium
b880dc8a4a
Use our own Contains extension
2021-12-20 13:31:07 +01:00
cvium
83a94aa612
Fix extras folders
2021-12-20 12:15:20 +01:00
cvium
91f3ce3109
Use == instead of Object.Equals to avoid closure allocation
2021-12-19 18:24:05 +01:00
Claus Vium
9a0618552b
Merge branch 'master' into what_could_go_wrong
2021-12-15 08:38:39 +01:00
Cody Robibero
0edf77994a
Cache BaseItemKind
2021-12-14 07:41:29 -07:00
cvium
c5569c701c
Folder can't have extras
2021-12-12 19:04:22 +01:00
cvium
fde84a1e00
Refactor extras parsing
2021-12-07 15:24:57 +01:00
Bond_009
257e1be95f
Fix some warnings
2021-11-16 16:31:57 +01:00
Bond_009
5726535a26
Fix some warnings
...
609 left
2021-11-09 13:14:31 +01:00
Joe Rogers
b4bf5af7c8
Remove ImageType.Screenshot and ItemFields.Screenshot
2021-11-06 20:43:20 +01:00
Bond_009
416894008e
Minor improvements
...
* Removed some allocations
* Removed some useless abstractions
2021-11-03 14:02:57 +01:00
Joe Rogers
7fcf01235c
Change RemoveImages to array, improve download test
2021-11-02 16:16:06 +01:00
Joe Rogers
b478b115e3
Refactor to validate all images up front
2021-11-01 11:53:31 +01:00
KonH
e3fccd5ae6
Fix warning: Qualifier is redundant ( #2149 )
2021-10-03 11:01:40 +07:00
Dixin
27e32083a1
Update LINQ query according to code review feedback.
...
Co-authored-by: Claus Vium <cvium@users.noreply.github.com>
2021-09-20 00:27:51 -07:00
Dixin
dc8420c7a2
Fix extra folder type resolving.
2021-09-19 16:54:00 -07:00
dkanada
b8eb8940c7
Merge pull request #6257 from MrTimscampi/music-library-backdrop
...
Use artist backdrop for generated library image
2021-09-06 02:30:49 +09:00
Cody Robibero
cba07b1ca6
Remove more and more warnings
2021-08-28 16:32:50 -06:00
Rich Lander
e3df4dcaae
Fix warnings in MediaBrowser.Controller
2021-08-13 20:34:36 -07:00
Bond_009
915141f196
Fix some warnings
2021-07-11 22:51:36 +02:00
MrTimscampi
8a65a6dfc3
Use artist backdrop for generated library image
2021-07-03 02:50:28 +02:00
Bond_009
981cf4cfa0
Remove our own RemoveDiacritcs string extension in favor of Diacritics.Net
2021-06-22 09:48:40 +02:00
Bond_009
6f8ccab788
Move non-jellyfin extensions to separate project
2021-06-19 18:04:46 +02:00
Bond-009
cfad97ff28
Merge pull request #6096 from cvium/saving_private_ram
2021-06-12 00:20:54 +02:00
Claus Vium
b8f5a14384
Merge pull request #6117 from LinFor/pr_originaltitle_in_lookupinfo
...
Add OriginalTitle to ItemLookupInfo
2021-06-07 09:37:49 +02:00
Cody Robibero
d461e3912a
Remove warninigs from MediaBrowser.Controller (Part 3) ( #6078 )
...
Co-authored-by: Bond-009 <bond.009@outlook.com>
2021-06-06 17:16:41 +02:00
PingWin
05c241da78
Add OriginalTitle to ItemLookupInfo
2021-05-27 10:36:56 +00:00
cvium
42a2cc1747
Remove some unnecessary allocations
2021-05-24 00:30:41 +02:00
crobibero
6bcbc2b88a
Reduce warnings in MediaBrowser.Controller
2021-05-13 07:33:11 -06:00
Cody Robibero
e3f55a0c54
Reduce warnings in MediaBrowser.Controller ( #6006 )
...
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-11 13:55:46 +02:00
Bond_009
fb090df0b5
Enable nullable reference types for MediaBrowser.Controller
2021-05-07 00:39:20 +02:00
BaronGreenback
2e98de9062
Code Clean up: Convert to null-coalescing operator ?? ( #5845 )
...
Co-authored-by: Cody Robibero <cody@robibe.ro>
Co-authored-by: Patrick Barron <18354464+barronpm@users.noreply.github.com>
2021-05-05 13:51:14 +02:00
