Apply suggestions from code review

Co-Authored-By: dkanada <dkanada@users.noreply.github.com>
This commit is contained in:
Bond-009 2019-12-10 16:22:03 +01:00 committed by GitHub
parent 42ffddc269
commit affb58ef9e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
16 changed files with 26 additions and 26 deletions

View File

@ -351,7 +351,7 @@ namespace Emby.Server.Implementations.AppBase
} }
/// <summary> /// <summary>
/// Event handler for when a named configuration got updates. /// Event handler for when a named configuration has been updated.
/// </summary> /// </summary>
/// <param name="key">The key of the configuration.</param> /// <param name="key">The key of the configuration.</param>
/// <param name="configuration">The old configuration.</param> /// <param name="configuration">The old configuration.</param>

View File

@ -150,7 +150,7 @@ namespace Emby.Server.Implementations.Configuration
} }
/// <summary> /// <summary>
/// Sets all config values to the optimal value. /// Sets all configuration values to their optimal values.
/// </summary> /// </summary>
/// <returns>If the configuration changed.</returns> /// <returns>If the configuration changed.</returns>
public bool SetOptimalValues() public bool SetOptimalValues()

View File

@ -16,7 +16,7 @@ namespace Emby.Server.Implementations.Data
/// <summary> /// <summary>
/// Initializes a new instance of the <see cref="BaseSqliteRepository"/> class. /// Initializes a new instance of the <see cref="BaseSqliteRepository"/> class.
/// </summary> /// </summary>
/// <param name="logger">The ogger.</param> /// <param name="logger">The logger.</param>
protected BaseSqliteRepository(ILogger logger) protected BaseSqliteRepository(ILogger logger)
{ {
Logger = logger; Logger = logger;

View File

@ -18,7 +18,7 @@ namespace Emby.Server.Implementations.EntryPoints
private readonly ILogger _logger; private readonly ILogger _logger;
/// <summary> /// <summary>
/// The _user manager. /// The user manager.
/// </summary> /// </summary>
private readonly IUserManager _userManager; private readonly IUserManager _userManager;

View File

@ -21,22 +21,22 @@ namespace Emby.Server.Implementations.EntryPoints
public class ServerEventNotifier : IServerEntryPoint public class ServerEventNotifier : IServerEntryPoint
{ {
/// <summary> /// <summary>
/// The _user manager. /// The user manager.
/// </summary> /// </summary>
private readonly IUserManager _userManager; private readonly IUserManager _userManager;
/// <summary> /// <summary>
/// The _installation manager. /// The installation manager.
/// </summary> /// </summary>
private readonly IInstallationManager _installationManager; private readonly IInstallationManager _installationManager;
/// <summary> /// <summary>
/// The _kernel. /// The kernel.
/// </summary> /// </summary>
private readonly IServerApplicationHost _appHost; private readonly IServerApplicationHost _appHost;
/// <summary> /// <summary>
/// The _task manager. /// The task manager.
/// </summary> /// </summary>
private readonly ITaskManager _taskManager; private readonly ITaskManager _taskManager;

View File

@ -13,12 +13,12 @@ namespace Emby.Server.Implementations.EntryPoints
public class StartupWizard : IServerEntryPoint public class StartupWizard : IServerEntryPoint
{ {
/// <summary> /// <summary>
/// The _app host. /// The app host.
/// </summary> /// </summary>
private readonly IServerApplicationHost _appHost; private readonly IServerApplicationHost _appHost;
/// <summary> /// <summary>
/// The _user manager. /// The user manager.
/// </summary> /// </summary>
private readonly ILogger _logger; private readonly ILogger _logger;

View File

@ -20,7 +20,7 @@ namespace Emby.Server.Implementations.EntryPoints
public const int PortNumber = 7359; public const int PortNumber = 7359;
/// <summary> /// <summary>
/// The _logger. /// The logger.
/// </summary> /// </summary>
private readonly ILogger _logger; private readonly ILogger _logger;
private readonly ISocketFactory _socketFactory; private readonly ISocketFactory _socketFactory;

View File

@ -29,7 +29,7 @@ namespace Emby.Server.Implementations.HttpServer
public class HttpResultFactory : IHttpResultFactory public class HttpResultFactory : IHttpResultFactory
{ {
/// <summary> /// <summary>
/// The _logger. /// The logger.
/// </summary> /// </summary>
private readonly ILogger _logger; private readonly ILogger _logger;
private readonly IFileSystem _fileSystem; private readonly IFileSystem _fileSystem;

View File

@ -15,7 +15,7 @@ namespace Emby.Server.Implementations.HttpServer
public class StreamWriter : IAsyncStreamWriter, IHasHeaders public class StreamWriter : IAsyncStreamWriter, IHasHeaders
{ {
/// <summary> /// <summary>
/// The _options. /// The options.
/// </summary> /// </summary>
private readonly IDictionary<string, string> _options = new Dictionary<string, string>(); private readonly IDictionary<string, string> _options = new Dictionary<string, string>();

View File

@ -24,12 +24,12 @@ namespace Emby.Server.Implementations.HttpServer
private readonly ILogger _logger; private readonly ILogger _logger;
/// <summary> /// <summary>
/// The _json serializer. /// The json serializer.
/// </summary> /// </summary>
private readonly IJsonSerializer _jsonSerializer; private readonly IJsonSerializer _jsonSerializer;
/// <summary> /// <summary>
/// The _socket. /// The socket.
/// </summary> /// </summary>
private readonly IWebSocket _socket; private readonly IWebSocket _socket;
@ -78,7 +78,7 @@ namespace Emby.Server.Implementations.HttpServer
public event EventHandler<EventArgs> Closed; public event EventHandler<EventArgs> Closed;
/// <summary> /// <summary>
/// Gets or sets the _remote end point. /// Gets or sets the remote end point.
/// </summary> /// </summary>
public string RemoteEndPoint { get; private set; } public string RemoteEndPoint { get; private set; }

View File

@ -43,7 +43,7 @@ namespace Emby.Server.Implementations.Library
public class UserManager : IUserManager public class UserManager : IUserManager
{ {
/// <summary> /// <summary>
/// The _logger. /// The logger.
/// </summary> /// </summary>
private readonly ILogger _logger; private readonly ILogger _logger;

View File

@ -17,12 +17,12 @@ namespace Emby.Server.Implementations.Library.Validators
public class ArtistsValidator public class ArtistsValidator
{ {
/// <summary> /// <summary>
/// The _library manager. /// The library manager.
/// </summary> /// </summary>
private readonly ILibraryManager _libraryManager; private readonly ILibraryManager _libraryManager;
/// <summary> /// <summary>
/// The _logger. /// The logger.
/// </summary> /// </summary>
private readonly ILogger _logger; private readonly ILogger _logger;
private readonly IItemRepository _itemRepo; private readonly IItemRepository _itemRepo;

View File

@ -13,13 +13,13 @@ namespace Emby.Server.Implementations.Library.Validators
public class GenresValidator public class GenresValidator
{ {
/// <summary> /// <summary>
/// The _library manager. /// The library manager.
/// </summary> /// </summary>
private readonly ILibraryManager _libraryManager; private readonly ILibraryManager _libraryManager;
private readonly IItemRepository _itemRepo; private readonly IItemRepository _itemRepo;
/// <summary> /// <summary>
/// The _logger. /// The logger.
/// </summary> /// </summary>
private readonly ILogger _logger; private readonly ILogger _logger;

View File

@ -13,7 +13,7 @@ namespace Emby.Server.Implementations.Library.Validators
public class MusicGenresPostScanTask : ILibraryPostScanTask public class MusicGenresPostScanTask : ILibraryPostScanTask
{ {
/// <summary> /// <summary>
/// The _library manager. /// The library manager.
/// </summary> /// </summary>
private readonly ILibraryManager _libraryManager; private readonly ILibraryManager _libraryManager;
private readonly ILogger _logger; private readonly ILogger _logger;

View File

@ -13,12 +13,12 @@ namespace Emby.Server.Implementations.Library.Validators
public class MusicGenresValidator public class MusicGenresValidator
{ {
/// <summary> /// <summary>
/// The _library manager. /// The library manager.
/// </summary> /// </summary>
private readonly ILibraryManager _libraryManager; private readonly ILibraryManager _libraryManager;
/// <summary> /// <summary>
/// The _logger. /// The logger.
/// </summary> /// </summary>
private readonly ILogger _logger; private readonly ILogger _logger;
private readonly IItemRepository _itemRepo; private readonly IItemRepository _itemRepo;

View File

@ -15,14 +15,14 @@ namespace Emby.Server.Implementations.Library.Validators
public class StudiosValidator public class StudiosValidator
{ {
/// <summary> /// <summary>
/// The _library manager. /// The library manager.
/// </summary> /// </summary>
private readonly ILibraryManager _libraryManager; private readonly ILibraryManager _libraryManager;
private readonly IItemRepository _itemRepo; private readonly IItemRepository _itemRepo;
/// <summary> /// <summary>
/// The _logger. /// The logger.
/// </summary> /// </summary>
private readonly ILogger _logger; private readonly ILogger _logger;