suggestions from review

Emby.Server.Implementations/Library/SplashscreenPostScanTask.cs

@@ -69,9 +69,9 @@ public class SplashscreenPostScanTask : ILibraryPostScanTask
             Limit = 30,
             // TODO max parental rating configurable
             MaxParentalRating = 10,
-            OrderBy = new ValueTuple<string, SortOrder>[]
+            OrderBy = new[]
             {
-                new(ItemSortBy.Random, SortOrder.Ascending)
+                (ItemSortBy.Random, SortOrder.Ascending)
             },
             IncludeItemTypes = new[] { BaseItemKind.Movie, BaseItemKind.Series }
         });

Jellyfin.Api/Controllers/ImageController.cs

@@ -1793,7 +1793,7 @@ namespace Jellyfin.Api.Controllers
         /// Uploads a custom splashscreen.
         /// </summary>
         /// <returns>A <see cref="NoContentResult"/> indicating success.</returns>
-        /// <response code="204">Sucessfully uploaded new splashscreen.</response>
+        /// <response code="204">Successfully uploaded new splashscreen.</response>
         /// <response code="400">Error reading MimeType from uploaded image.</response>
         /// <response code="403">User does not have permission to upload splashscreen..</response>
         /// <exception cref="ArgumentException">Error reading the image format.</exception>

Jellyfin.Drawing.Skia/SplashscreenBuilder.cs

@@ -52,8 +52,6 @@ namespace Jellyfin.Drawing.Skia
         /// <returns>The created collage as a bitmap.</returns>
         private SKBitmap GenerateCollage(IReadOnlyList<string> posters, IReadOnlyList<string> backdrops)
         {
-            var random = new Random();
-
             var posterIndex = 0;
             var backdropIndex = 0;
 
@@ -65,7 +63,7 @@ namespace Jellyfin.Drawing.Skia
 
             for (int i = 0; i < Rows; i++)
             {
-                int imageCounter = random.Next(0, 5);
+                int imageCounter = Random.Shared.Next(0, 5);
                 int currentWidthPos = i * 75;
                 int currentHeight = i * (posterHeight + Spacing);
 

MediaBrowser.Model/Branding/BrandingOptions.cs

@@ -29,10 +29,4 @@ public class BrandingOptions
     /// </remarks>
     [JsonIgnore]
     public string? SplashscreenLocation { get; set; }
-
-    /// <summary>
-    /// Gets the splashscreen url.
-    /// </summary>
-    [XmlIgnore]
-    public string SplashscreenUrl => "/Branding/Splashscreen";
 }