Merge pull request #5459 from thornbill/missing-persons

Fix missing person types

CONTRIBUTORS.md

@@ -86,6 +86,7 @@
 - [GeorgeH005](https://github.com/GeorgeH005)
 - [JPUC1143](https://github.com/Jpuc1143)
 - [David Angel](https://github.com/davidangel)
+- [Pithaya](https://github.com/Pithaya)
 
 ## Emby Contributors
 

src/components/metadataEditor/metadataEditor.js

@@ -591,8 +591,7 @@ function setFieldVisibilities(context, item) {
             || item.Type === 'Genre'
             || item.Type === 'Studio'
             || item.Type === 'MusicGenre'
-            || item.Type === 'TvChannel'
-            || item.Type === 'Book') {
+            || item.Type === 'TvChannel') {
         hideElement('#peopleCollapsible', context);
     } else {
         showElement('#peopleCollapsible', context);

src/components/metadataEditor/personEditor.template.html

@@ -28,6 +28,16 @@
                 <option value="Remixer">${Remixer}</option>
                 <option value="AlbumArtist">${AlbumArtist}</option>
                 <option value="Artist">${Artist}</option>
+                <option value="Creator">${Creator}</option>
+                <option value="Author">${Author}</option>
+                <option value="Illustrator">${Illustrator}</option>
+                <option value="Penciller">${Penciller}</option>
+                <option value="Inker">${Inker}</option>
+                <option value="Colorist">${Colorist}</option>
+                <option value="Letterer">${Letterer}</option>
+                <option value="CoverArtist">${CoverArtist}</option>
+                <option value="Editor">${Editor}</option>
+                <option value="Translator">${Translator}</option>
             </select>
         </div>
 

src/strings/en-us.json

@@ -57,6 +57,7 @@
     "AsManyAsPossible": "As many as possible",
     "AspectRatio": "Aspect Ratio",
     "Audio": "Audio",
+    "Author": "Author",
     "Authorize": "Authorize",
     "AuthProviderHelp": "Select an authentication provider to be used to authenticate this user's password.",
     "Auto": "Auto",
@@ -151,6 +152,7 @@
     "ClearQueue": "Clear queue",
     "ClientSettings": "Client Settings",
     "Collections": "Collections",
+    "Colorist": "Colorist",
     "ColorPrimaries": "Color primaries",
     "ColorSpace": "Color space",
     "ColorTransfer": "Color transfer",
@@ -174,6 +176,8 @@
     "CopyFailed": "Could not copy",
     "CopyStreamURL": "Copy Stream URL",
     "CopyStreamURLSuccess": "URL copied successfully.",
+    "CoverArtist": "Cover artist",
+    "Creator": "Creator",
     "CriticRating": "Critics rating",
     "Cursive": "Cursive",
     "DailyAt": "Daily at {0}",
@@ -232,6 +236,7 @@
     "DrmChannelsNotImported": "Channels with DRM will not be imported.",
     "DropShadow": "Drop Shadow",
     "Edit": "Edit",
+    "Editor": "Editor",
     "EditImages": "Edit images",
     "EditMetadata": "Edit metadata",
     "EditSubtitles": "Edit subtitles",
@@ -522,9 +527,11 @@
     "Identify": "Identify",
     "IgnoreDts": "Ignore DTS (decoding timestamp)",
     "IgnoreDtsHelp": "Disabling this option may resolve some issues, e.g. missing audio on channels with separate audio and video streams.",
+    "Illustrator": "Illustrator",
     "Image": "Image",
     "Images": "Images",
     "ImportFavoriteChannelsHelp": "Only channels that are marked as favorite on the tuner device will be imported.",
+    "Inker": "Inker",
     "InstallingPackage": "Installing {0} (version {1})",
     "InstantMix": "Instant mix",
     "ItemCount": "{0} items",
@@ -950,6 +957,7 @@
     "LatestFromLibrary": "Recently Added in {0}",
     "LearnHowYouCanContribute": "Learn how you can contribute.",
     "LeaveBlankToNotSetAPassword": "You can leave this field blank to set no password.",
+    "Letterer": "Letterer",
     "LibraryAccessHelp": "Select the libraries to share with this user. Administrators will be able to edit all folders using the metadata manager.",
     "LimitSupportedVideoResolution": "Limit maximum supported video resolution",
     "LimitSupportedVideoResolutionHelp": "Use 'Maximum Allowed Video Transcoding Resolution' as maximum supported video resolution.",
@@ -1236,6 +1244,7 @@
     "PasswordResetProviderHelp": "Pick a password reset provider to be used when this user requests a password reset.",
     "PasswordSaved": "Password saved.",
     "PathNotFound": "The path could not be found. Please ensure the path is valid and try again.",
+    "Penciller": "Penciler",
     "People": "People",
     "PerfectMatch": "Perfect match",
     "Person": "Person",
@@ -1485,6 +1494,7 @@
     "TrackCount": "{0} tracks",
     "Trailers": "Trailers",
     "Transcoding": "Transcoding",
+    "Translator": "Translator",
     "Tuesday": "Tuesday",
     "TV": "TV",
     "TvLibraryHelp": "Review the {0}TV naming guide{1}.",